microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-14 14:03:58 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Remove 'New' Badge from Extensions page (#19637)

Browse Source 
It's no longer "new".
This commit is contained in:
Carlos Zamora 2025-12-10 12:05:49 -08:00 committed by GitHub
parent 297703d783
commit 96d35daeec
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cascadia/TerminalSettingsEditor/Extensions.cpp
View File

@ -37,7 +37,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
auto vmImpl = get_self<ExtensionsViewModel>(_ViewModel); auto vmImpl = get_self<ExtensionsViewModel>(_ViewModel);
vmImpl->ExtensionPackageIdentifierTemplateSelector(_extensionPackageIdentifierTemplateSelector); vmImpl->ExtensionPackageIdentifierTemplateSelector(_extensionPackageIdentifierTemplateSelector);
vmImpl->LazyLoadExtensions(); vmImpl->LazyLoadExtensions();
vmImpl->MarkAsVisited();
if (vmImpl->IsExtensionView()) if (vmImpl->IsExtensionView())
{ {
@ -363,11 +362,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
return _ExtensionPackageIdentifierTemplateSelector.SelectTemplate(CurrentExtensionPackage()); return _ExtensionPackageIdentifierTemplateSelector.SelectTemplate(CurrentExtensionPackage());
} }
bool ExtensionsViewModel::DisplayBadge() const noexcept
{
return !Model::ApplicationState::SharedInstance().BadgeDismissed(L"page.extensions");
}
// Returns true if the extension is enabled, false otherwise // Returns true if the extension is enabled, false otherwise
bool ExtensionsViewModel::GetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings) bool ExtensionsViewModel::GetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings)
{ {
@ -436,12 +430,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
NavigateToColorSchemeRequested.raise(*this, nullptr); NavigateToColorSchemeRequested.raise(*this, nullptr);
} }
void ExtensionsViewModel::MarkAsVisited()
{
Model::ApplicationState::SharedInstance().DismissBadge(L"page.extensions");
_NotifyChanges(L"DisplayBadge");
}
bool ExtensionPackageViewModel::SortAscending(const Editor::ExtensionPackageViewModel& lhs, const Editor::ExtensionPackageViewModel& rhs) bool ExtensionPackageViewModel::SortAscending(const Editor::ExtensionPackageViewModel& lhs, const Editor::ExtensionPackageViewModel& rhs)
{ {
auto getKey = [&](const Editor::ExtensionPackageViewModel& pkgVM) { auto getKey = [&](const Editor::ExtensionPackageViewModel& pkgVM) {

2
src/cascadia/TerminalSettingsEditor/Extensions.h
View File

@ -46,7 +46,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
bool NoProfilesModified() const noexcept { return _profilesModifiedView.Size() == 0; } bool NoProfilesModified() const noexcept { return _profilesModifiedView.Size() == 0; }
bool NoProfilesAdded() const noexcept { return _profilesAddedView.Size() == 0; } bool NoProfilesAdded() const noexcept { return _profilesAddedView.Size() == 0; }
bool NoSchemesAdded() const noexcept { return _colorSchemesAddedView.Size() == 0; } bool NoSchemesAdded() const noexcept { return _colorSchemesAddedView.Size() == 0; }
bool DisplayBadge() const noexcept;
// Views // Views
Windows::Foundation::Collections::IObservableVector<Editor::ExtensionPackageViewModel> ExtensionPackages() const noexcept { return _extensionPackages; } Windows::Foundation::Collections::IObservableVector<Editor::ExtensionPackageViewModel> ExtensionPackages() const noexcept { return _extensionPackages; }
@ -59,7 +58,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
void UpdateSettings(const Model::CascadiaSettings& settings, const Editor::ColorSchemesPageViewModel& colorSchemesPageVM); void UpdateSettings(const Model::CascadiaSettings& settings, const Editor::ColorSchemesPageViewModel& colorSchemesPageVM);
void NavigateToProfile(const guid profileGuid); void NavigateToProfile(const guid profileGuid);
void NavigateToColorScheme(const Editor::ColorSchemeViewModel& schemeVM); void NavigateToColorScheme(const Editor::ColorSchemeViewModel& schemeVM);
void MarkAsVisited();
static bool GetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings); static bool GetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings);
static void SetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings, bool enableExt); static void SetExtensionState(hstring extensionSource, const Model::CascadiaSettings& settings, bool enableExt);

1
src/cascadia/TerminalSettingsEditor/Extensions.idl
View File

@ -23,7 +23,6 @@ namespace Microsoft.Terminal.Settings.Editor
Boolean NoProfilesModified { get; }; Boolean NoProfilesModified { get; };
Boolean NoProfilesAdded { get; }; Boolean NoProfilesAdded { get; };
Boolean NoSchemesAdded { get; }; Boolean NoSchemesAdded { get; };
Boolean DisplayBadge { get; };
// Views // Views
IVector<ExtensionPackageViewModel> ExtensionPackages { get; }; IVector<ExtensionPackageViewModel> ExtensionPackages { get; };

4
src/cascadia/TerminalSettingsEditor/MainPage.xaml
View File

@ -167,10 +167,6 @@
<muxc:NavigationViewItem.Icon> <muxc:NavigationViewItem.Icon>
<FontIcon Glyph="&#xEA86;" /> <FontIcon Glyph="&#xEA86;" />
</muxc:NavigationViewItem.Icon> </muxc:NavigationViewItem.Icon>
<muxc:NavigationViewItem.InfoBadge>
<muxc:InfoBadge Style="{StaticResource NewInfoBadge}"
Visibility="{x:Bind ExtensionsVM.DisplayBadge, Mode=OneWay}" />
</muxc:NavigationViewItem.InfoBadge>
</muxc:NavigationViewItem> </muxc:NavigationViewItem>
<muxc:NavigationViewItemHeader x:Uid="Nav_Profiles" /> <muxc:NavigationViewItemHeader x:Uid="Nav_Profiles" />