microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-11 13:56:33 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Fix hot reload for icon, bell, close on exit; regressed in #16172 (#19217)

Browse Source 
In #16172, we removed the propagation of the profile down into the
Terminal Pane Content.

It was holding on to the profile from the _old_ settings model (😱).

This also broke background image hot reload.

(cherry picked from commit 666a75bc7027e5dec4f33e395340741cfc30c4bb)
Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgdVVHA
Service-Version: 1.23
This commit is contained in:
Dustin L. Howett 2025-08-05 16:18:43 -05:00 committed by Dustin L. Howett
parent 34cd29a0ce
commit 9449d0b29e
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cascadia/TerminalApp/TerminalPaneContent.cpp
View File

@ -339,8 +339,12 @@ namespace winrt::TerminalApp::implementation
RestartTerminalRequested.raise(*this, nullptr); RestartTerminalRequested.raise(*this, nullptr);
} }
void TerminalPaneContent::UpdateSettings(const CascadiaSettings& /*settings*/) void TerminalPaneContent::UpdateSettings(const CascadiaSettings& settings)
{ {
// Reload our profile from the settings model to propagate bell mode, icon, and close on exit mode (anything that uses _profile).
const auto profile{ settings.FindProfile(_profile.Guid()) };
_profile = profile ? profile : settings.ProfileDefaults();
if (const auto& settings{ _cache.TryLookup(_profile) }) if (const auto& settings{ _cache.TryLookup(_profile) })
{ {
_control.UpdateControlSettings(settings.DefaultSettings(), settings.UnfocusedSettings()); _control.UpdateControlSettings(settings.DefaultSettings(), settings.UnfocusedSettings());