split code format check into its own job (#1270)

* split code format check into its own job

* Update build/pipelines/templates/check-formatting.yml

Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>

* fix result check

build/pipelines/ci.yml

@@ -34,3 +34,5 @@ jobs:
   - template: ./templates/build-console-ci.yml
     parameters:
       platform: ARM64
+
+  - template: ./templates/check-formatting.yml

build/pipelines/release.yml

@@ -35,4 +35,6 @@ jobs:
       platform: arm64
       additionalBuildArguments: /p:WindowsTerminalReleaseBuild=true
 
+  - template: ./templates/check-formatting.yml
+
   - template: ./templates/release-sign-and-bundle.yml

build/pipelines/templates/build-console-audit-job.yml

@@ -41,12 +41,6 @@ jobs:
       nugetConfigPath: build/config/NuGet.config
       restoreDirectory: '$(Build.SourcesDirectory)/packages'
 
-  - task: PowerShell@2
-    displayName: 'Code Formattting Check'
-    inputs:
-      targetType: filePath
-      filePath: '.\build\scripts\Invoke-FormattingCheck.ps1'
-
   - task: VSBuild@1
     displayName: 'Build solution **\OpenConsole.sln'
     inputs:

build/pipelines/templates/check-formatting.yml

@@ -0,0 +1,16 @@
+
+jobs:
+- job: CodeFormatCheck
+  displayName: Proper Code Formatting Check
+  pool: { vmImage: vs2017-win2016 }
+
+  steps:
+  - checkout: self
+    submodules: false
+    clean: true
+
+  - task: PowerShell@2
+    displayName: 'Code Formattting Check'
+    inputs:
+      targetType: filePath
+      filePath: '.\build\scripts\Invoke-FormattingCheck.ps1'

build/pipelines/templates/release-sign-and-bundle.yml

@@ -10,13 +10,15 @@ jobs:
     - Buildx64Release
     - Buildx86Release
     - Buildarm64Release
+    - CodeFormatCheck
   condition: |
     and
     (
       in(dependencies.Buildx64AuditMode.result, 'Succeeded', 'SucceededWithIssues', 'Skipped'),
       in(dependencies.Buildx64Release.result,   'Succeeded', 'SucceededWithIssues', 'Skipped'),
       in(dependencies.Buildx86Release.result,   'Succeeded', 'SucceededWithIssues', 'Skipped'),
-      in(dependencies.Buildarm64Release.result, 'Succeeded', 'SucceededWithIssues', 'Skipped')
+      in(dependencies.Buildarm64Release.result, 'Succeeded', 'SucceededWithIssues', 'Skipped'),
+      in(dependencies.CodeFormatCheck.result,   'Succeeded', 'SucceededWithIssues', 'Skipped')
     )
 
   variables: