From 8905ac11641834ab8238c0928465faaa589ae83c Mon Sep 17 00:00:00 2001 From: Carlos Zamora Date: Thu, 22 May 2025 16:57:04 -0700 Subject: [PATCH] Fix some build errors from updated VS build agents (#18927) Looks like there's a new VS version on the build agents. This just goes through and fixes any issues they found. There's still a COMPILER CRASH though. (cherry picked from commit 2d64a3a4ab0d0d1c5b9085a022f5319460ef68d7) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgakG1s Service-Version: 1.23 --- src/cascadia/TerminalApp/TerminalPage.cpp | 6 +++--- .../TerminalControl/InteractivityAutomationPeer.cpp | 2 +- src/host/ut_host/Host.UnitTests.vcxproj | 2 +- src/host/ut_host/Host.UnitTests.vcxproj.filters | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/cascadia/TerminalApp/TerminalPage.cpp b/src/cascadia/TerminalApp/TerminalPage.cpp index 581b0ddcf3..9a73591556 100644 --- a/src/cascadia/TerminalApp/TerminalPage.cpp +++ b/src/cascadia/TerminalApp/TerminalPage.cpp @@ -2303,7 +2303,7 @@ namespace winrt::TerminalApp::implementation // for it. The Title change will be propagated upwards through the tab's // PropertyChanged event handler. void TerminalPage::_activePaneChanged(winrt::TerminalApp::TerminalTab sender, - Windows::Foundation::IInspectable args) + Windows::Foundation::IInspectable /*args*/) { if (const auto tab{ _GetTerminalTabImpl(sender) }) { @@ -5255,8 +5255,8 @@ namespace winrt::TerminalApp::implementation _sendDraggedTabToWindow(winrt::to_hstring(args.TargetWindow()), args.TabIndex(), std::nullopt); } - void TerminalPage::_onTabDroppedOutside(winrt::IInspectable sender, - winrt::MUX::Controls::TabViewTabDroppedOutsideEventArgs e) + void TerminalPage::_onTabDroppedOutside(winrt::IInspectable /*sender*/, + winrt::MUX::Controls::TabViewTabDroppedOutsideEventArgs /*e*/) { // Get the current pointer point from the CoreWindow const auto& pointerPoint{ CoreWindow::GetForCurrentThread().PointerPosition() }; diff --git a/src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp b/src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp index 757796e76c..77780108c8 100644 --- a/src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp +++ b/src/cascadia/TerminalControl/InteractivityAutomationPeer.cpp @@ -118,7 +118,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation return WrapArrayOfTextRangeProviders(pReturnVal); } - XamlAutomation::ITextRangeProvider InteractivityAutomationPeer::RangeFromChild(XamlAutomation::IRawElementProviderSimple childElement) + XamlAutomation::ITextRangeProvider InteractivityAutomationPeer::RangeFromChild(XamlAutomation::IRawElementProviderSimple /*childElement*/) { UIA::ITextRangeProvider* returnVal; // ScreenInfoUiaProvider doesn't actually use parameter, so just pass in nullptr diff --git a/src/host/ut_host/Host.UnitTests.vcxproj b/src/host/ut_host/Host.UnitTests.vcxproj index 1fbaaaff14..c914e48adf 100644 --- a/src/host/ut_host/Host.UnitTests.vcxproj +++ b/src/host/ut_host/Host.UnitTests.vcxproj @@ -78,7 +78,7 @@ - + diff --git a/src/host/ut_host/Host.UnitTests.vcxproj.filters b/src/host/ut_host/Host.UnitTests.vcxproj.filters index ebf93cbf27..dd573753e3 100644 --- a/src/host/ut_host/Host.UnitTests.vcxproj.filters +++ b/src/host/ut_host/Host.UnitTests.vcxproj.filters @@ -83,7 +83,7 @@ Header Files - + Header Files