microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 18:17:40 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Delete the KeyChordViewModel if we leave edit mode with no keys (#19778)

Browse Source 
There was an issue where if the user adds a new keybinding and then hits
"cancel changes", the KeyChordViewModel is left in the keybinding list
with an empty value. Nothing gets saved to the json, but visually there
was an empty keychord box left behind. This commit fixes that.

## Validation Steps Performed
Adding a new keybinding and cancelling changes deletes the keybinding.
This commit is contained in:
PankajBhojwani 2026-01-23 16:25:43 -08:00 committed by GitHub
parent c8549bebed
commit 6723ca2239
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cascadia/TerminalSettingsEditor/ActionsViewModel.cpp
View File

@ -220,7 +220,10 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
break; break;
} }
} }
actionsPageVM.DeleteKeyChord(args); if (args)
{
actionsPageVM.DeleteKeyChord(args);
}
} }
}); });
kcVM.PropertyChanged([weakThis{ get_weak() }](const IInspectable& sender, const Windows::UI::Xaml::Data::PropertyChangedEventArgs& args) { kcVM.PropertyChanged([weakThis{ get_weak() }](const IInspectable& sender, const Windows::UI::Xaml::Data::PropertyChangedEventArgs& args) {
@ -1032,6 +1035,11 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
// if we're in edit mode, populate the text box with the current keys // if we're in edit mode, populate the text box with the current keys
ProposedKeys(_currentKeys); ProposedKeys(_currentKeys);
} }
else if (!_currentKeys)
{
// we have left edit mode but don't have any current keys - delete this view model
DeleteKeyChord();
}
} }
void KeyChordViewModel::AcceptChanges() void KeyChordViewModel::AcceptChanges()