microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-10 00:48:23 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Make til/rand noexcept-correct (#17571)

Browse Source 
This simply adds the missing `noexcept` attributes.
It also removes the unnecessary `pcg_random` import.
This commit is contained in:
Leonard Hecker 2024-07-17 02:59:31 +02:00 committed by GitHub
parent 49a294328f
commit 5826a84628
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/cascadia/UnitTests_SettingsModel/TerminalSettingsTests.cpp
View File

@ -4,6 +4,7 @@
#include "pch.h"
#include <til/rand.h>
#include <pcg_random.hpp>
#include "../TerminalSettingsModel/CascadiaSettings.h"
#include "../TerminalSettingsModel/TerminalSettings.h"

9
src/inc/til/rand.h
View File

@ -1,7 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.
#include <pcg_random.hpp>
#pragma once
namespace til
{
@ -23,12 +23,13 @@ namespace til
// cryptbase, instead it was using LoadLibrary()/GetProcAddress() on every call.
// * advapi32.dll doesn't exist on MinWin, cryptbase.dll however does.
module{ LoadLibraryExW(L"cryptbase.dll", nullptr, LOAD_LIBRARY_SEARCH_SYSTEM32) },
#pragma warning(suppress : 26490) // Don't use reinterpret_cast (type.1).
proc{ reinterpret_cast<decltype(proc)>(GetProcAddress(module.get(), "SystemFunction036")) }
{
FAIL_FAST_LAST_ERROR_IF(!proc);
}
inline void operator()(PVOID RandomBuffer, ULONG RandomBufferLength)
void operator()(PVOID RandomBuffer, ULONG RandomBufferLength) const noexcept
{
proc(RandomBuffer, RandomBufferLength);
}
@ -39,14 +40,14 @@ namespace til
};
}
inline void gen_random(void* data, uint32_t length)
inline void gen_random(void* data, uint32_t length) noexcept
{
static details::RtlGenRandomLoader loader;
loader(data, length);
}
template<typename T, typename = std::enable_if_t<std::is_standard_layout_v<T>>>
T gen_random()
T gen_random() noexcept
{
T value;
gen_random(&value, sizeof(T));

1
src/terminal/parser/ut_parser/Base64Test.cpp
View File

@ -5,6 +5,7 @@
#include "WexTestClass.h"
#include <til/rand.h>
#include <pcg_random.hpp>
#include <wincrypt.h>
#include "base64.hpp"