From 3ae6bbf2df7919071fe8477676d6b7f5d838d558 Mon Sep 17 00:00:00 2001
From: Carlos Zamora <carlos.zamora@microsoft.com>
Date: Sat, 31 May 2025 12:50:18 -0700
Subject: [PATCH] Enable SSH Generator Feature Flag and polish UI (#18814)

---
 ...d500-50ad-8a1a-c400c3262db3}.scale-100.png | Bin 647 -> 0 bytes
 ...d500-50ad-8a1a-c400c3262db3}.scale-200.png | Bin 787 -> 0 bytes
 .../TerminalSettingsEditor/Extensions.cpp     |   6 ++
 .../TerminalSettingsEditor/Extensions.h       |   1 +
 .../TerminalSettingsEditor/Extensions.idl     |   1 +
 .../TerminalSettingsEditor/Extensions.xaml    |  55 ++++++++++++++++++
 .../SshHostGenerator.cpp                      |   4 +-
 src/features.xml                              |   5 ++
 8 files changed, 70 insertions(+), 2 deletions(-)
 delete mode 100644 src/cascadia/CascadiaPackage/ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.scale-100.png
 delete mode 100644 src/cascadia/CascadiaPackage/ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.scale-200.png

diff --git a/src/cascadia/CascadiaPackage/ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.scale-100.png b/src/cascadia/CascadiaPackage/ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.scale-100.png
deleted file mode 100644
index 6d57b166f20df38330a9dc881ac4334922b64b00..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 647
zcmV;20(kw2P)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV0004lX+uL$Nkc;*
zaB^>EX>4Tx04R}tkv&MmKpe$iQ%j3f9Lyl%kfAzR5EXHhDi*;)X)CnqU~=gfG%+M8
zE{=k0!NHHks)LKOt`4q(Aou~|;_9U6A|?JWDYS_3;J6>}?mh0_0YbCJG^=ME&~)3(
zBok7;up)(D5k&|hB8bV%GE&)v9DK*uJpz2ai}Ni1bAOILwP-OQAQ8_p!?cOliKjPh
zgY!PI$SSf*d`>)O(glehxvqHp#<}dWz%xZNmzg6LiKTKED_zVgrbawP98)!&@`b#|
zD(5ZETCL97_v9~(7WL&U*J%zTiAAK4h6Dw5R8fPCIITJ<7BaM-@bM41{xrE1a#g{|
zF^>&skX=9cAN=mtDosv!NznuldU2eO5g@z^v>J}{ee5``6Cn5uT<IPEMiZF%B)!qm
zVn;y#HgIv>(Ud*lat9cEGGtSBr65hAR07`5=$i__z%9_b>h;#%$LRx*qpp^2fP+I|
zv`pD+KJSin_xA6Zc7H!o6mptvbX6w+000JJOGiWi{{a60|De66lK=n!32;bRa{vG?
zBLDy{BLR4&KXw2B00(qQO+^Re3<VSnAR^wn*8l(jg-Jv~R5;7cQ$Y^EAP6gq53fJN
zmvxu97;%%`)&xTcErt|Bgs_JJ07;aY?C!5jcLzyzkx@X>e)v3~guj`k$pCPyTlEmg
z3gq!a0ZEXsjJY-Vpw_ybND?G_uHD*0kd!1{WR<LeMzq$Vk;dW|H<pC&m*lH%*0=cu
hoqRvZ6AtGL04McaUBzB#X+Hn}002ovPDHLkV1jjr83F(R

diff --git a/src/cascadia/CascadiaPackage/ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.scale-200.png b/src/cascadia/CascadiaPackage/ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.scale-200.png
deleted file mode 100644
index ebba22951f06c03cecb41d51a2ba69ad237eb47a..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 787
zcmV+u1MK{XP)<h;3K|Lk000e1NJLTq001BW001Be1^@s6b9#F80004lX+uL$Nkc;*
zaB^>EX>4Tx04R}tkv&MmKpe$iQ%j3f9Lyl%kfAzR5EXHhDi*;)X)CnqU~=gfG%+M8
zE{=k0!NHHks)LKOt`4q(Aou~|;_9U6A|?JWDYS_3;J6>}?mh0_0YbCJG^=ME&~)3(
zBok7;up)(D5k&|hB8bV%GE&)v9DK*uJpz2ai}Ni1bAOILwP-OQAQ8_p!?cOliKjPh
zgY!PI$SSf*d`>)O(glehxvqHp#<}dWz%xZNmzg6LiKTKED_zVgrbawP98)!&@`b#|
zD(5ZETCL97_v9~(7WL&U*J%zTiAAK4h6Dw5R8fPCIITJ<7BaM-@bM41{xrE1a#g{|
zF^>&skX=9cAN=mtDosv!NznuldU2eO5g@z^v>J}{ee5``6Cn5uT<IPEMiZF%B)!qm
zVn;y#HgIv>(Ud*lat9cEGGtSBr65hAR07`5=$i__z%9_b>h;#%$LRx*qpp^2fP+I|
zv`pD+KJSin_xA6Zc7H!o6mptvbX6w+000JJOGiWi{{a60|De66lK=n!32;bRa{vG?
zBLDy{BLR4&KXw2B00(qQO+^Re3<VSk7v~h~od5s<5lKWrR9M69S3wTLAPjRV{xyC^
z_*r;ac4^SobsYhwN?VaQv?8^efE@^PhIYmg%>Wk>caVsHnX#M&ZX=9<tNJsabAEar
zA%IfKaQzmXJpPveGoMF*nd?ay+Jrqv(7>k<NGZ8vVvN&tpz9bK__YTtmS(t{N0Lh^
zPh|+B1|uRMqULOD*M$*-*&0jF2>V?EeWm_RDb^43GNX&YFB4EzsN!($xm=8KNC&h>
zT$mZmjFb{`&M$Tg0JoJ`d3e9NA%#czjWJf6^bj!cxB9;!WZ;&8D!)B_{$5|uPzqWz
zUNbP%<L}6F%axA+=;8sfjb>90Qrn={YL`>>*8SiFw1U^Qo`9wgZvXI8&>c(YvIFh*
RdH4VT002ovPDHLkV1ff0TR{K-

diff --git a/src/cascadia/TerminalSettingsEditor/Extensions.cpp b/src/cascadia/TerminalSettingsEditor/Extensions.cpp
index ffaff9a33d..a3aec0ad7c 100644
--- a/src/cascadia/TerminalSettingsEditor/Extensions.cpp
+++ b/src/cascadia/TerminalSettingsEditor/Extensions.cpp
@@ -500,6 +500,12 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         {
             if (!extPkgVM.Package().DisplayName().empty())
             {
+                // Check if the first char of the icon is in the Segoe MDL2 Icons list
+                const auto ch = til::at(extPkgVM.Package().Icon(), 0);
+                if (ch >= L'\uE700' && ch <= L'\uF8FF')
+                {
+                    return ComplexTemplateWithFontIcon();
+                }
                 return ComplexTemplate();
             }
             return DefaultTemplate();
diff --git a/src/cascadia/TerminalSettingsEditor/Extensions.h b/src/cascadia/TerminalSettingsEditor/Extensions.h
index 6b7eafad57..a9379829d2 100644
--- a/src/cascadia/TerminalSettingsEditor/Extensions.h
+++ b/src/cascadia/TerminalSettingsEditor/Extensions.h
@@ -183,6 +183,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
         WINRT_PROPERTY(Windows::UI::Xaml::DataTemplate, DefaultTemplate, nullptr);
         WINRT_PROPERTY(Windows::UI::Xaml::DataTemplate, ComplexTemplate, nullptr);
+        WINRT_PROPERTY(Windows::UI::Xaml::DataTemplate, ComplexTemplateWithFontIcon, nullptr);
     };
 };
 
diff --git a/src/cascadia/TerminalSettingsEditor/Extensions.idl b/src/cascadia/TerminalSettingsEditor/Extensions.idl
index 4dc3018c36..6093471014 100644
--- a/src/cascadia/TerminalSettingsEditor/Extensions.idl
+++ b/src/cascadia/TerminalSettingsEditor/Extensions.idl
@@ -77,5 +77,6 @@ namespace Microsoft.Terminal.Settings.Editor
 
         Windows.UI.Xaml.DataTemplate DefaultTemplate;
         Windows.UI.Xaml.DataTemplate ComplexTemplate;
+        Windows.UI.Xaml.DataTemplate ComplexTemplateWithFontIcon;
     }
 }
diff --git a/src/cascadia/TerminalSettingsEditor/Extensions.xaml b/src/cascadia/TerminalSettingsEditor/Extensions.xaml
index eec3e69290..a3f80cb2e7 100644
--- a/src/cascadia/TerminalSettingsEditor/Extensions.xaml
+++ b/src/cascadia/TerminalSettingsEditor/Extensions.xaml
@@ -42,6 +42,7 @@
 
             <local:ExtensionPackageTemplateSelector x:Key="ExtensionPackageIdentifierTemplateSelector"
                                                     ComplexTemplate="{StaticResource ComplexExtensionIdentifierTemplate}"
+                                                    ComplexTemplateWithFontIcon="{StaticResource ComplexExtensionIdentifierTemplateWithFontIcon}"
                                                     DefaultTemplate="{StaticResource DefaultExtensionIdentifierTemplate}" />
 
             <DataTemplate x:Key="DefaultExtensionIdentifierTemplate"
@@ -91,8 +92,37 @@
                 </Grid>
             </DataTemplate>
 
+            <DataTemplate x:Key="ComplexExtensionIdentifierTemplateWithFontIcon"
+                          x:DataType="local:ExtensionPackageViewModel">
+                <Grid>
+                    <Grid.ColumnDefinitions>
+                        <ColumnDefinition Width="Auto" />
+                        <ColumnDefinition Width="*" />
+                    </Grid.ColumnDefinitions>
+                    <Grid.RowDefinitions>
+                        <RowDefinition Height="Auto" />
+                        <RowDefinition Height="Auto" />
+                    </Grid.RowDefinitions>
+
+                    <FontIcon Grid.Row="0"
+                              Grid.RowSpan="2"
+                              Grid.Column="0"
+                              Margin="0,0,8,0"
+                              FontSize="32"
+                              Glyph="{x:Bind Package.Icon}" />
+                    <TextBlock Grid.Row="0"
+                               Grid.Column="1"
+                               Text="{x:Bind Package.DisplayName}" />
+                    <TextBlock Grid.Row="1"
+                               Grid.Column="1"
+                               Style="{StaticResource SettingsPageItemDescriptionStyle}"
+                               Text="{x:Bind Package.Source}" />
+                </Grid>
+            </DataTemplate>
+
             <local:ExtensionPackageTemplateSelector x:Key="ExtensionPackageNavigatorTemplateSelector"
                                                     ComplexTemplate="{StaticResource ComplexExtensionNavigatorTemplate}"
+                                                    ComplexTemplateWithFontIcon="{StaticResource ComplexExtensionNavigatorTemplateWithFontIcon}"
                                                     DefaultTemplate="{StaticResource DefaultExtensionNavigatorTemplate}" />
 
             <DataTemplate x:Key="DefaultExtensionNavigatorTemplate"
@@ -146,6 +176,31 @@
                 </Button>
             </DataTemplate>
 
+            <DataTemplate x:Key="ComplexExtensionNavigatorTemplateWithFontIcon"
+                          x:DataType="local:ExtensionPackageViewModel">
+                <Button AutomationProperties.Name="{x:Bind AccessibleName}"
+                        Click="ExtensionNavigator_Click"
+                        Style="{StaticResource NavigatorButtonStyle}"
+                        Tag="{x:Bind}">
+                    <Grid>
+                        <Grid.ColumnDefinitions>
+                            <ColumnDefinition Width="*" />
+                            <ColumnDefinition Width="Auto" />
+                        </Grid.ColumnDefinitions>
+
+                        <ContentPresenter Content="{x:Bind}"
+                                          ContentTemplate="{StaticResource ComplexExtensionIdentifierTemplateWithFontIcon}" />
+
+                        <ToggleSwitch Grid.Column="1"
+                                      HorizontalAlignment="Right"
+                                      VerticalAlignment="Center"
+                                      AutomationProperties.Name="{x:Bind AccessibleName}"
+                                      IsOn="{x:Bind Enabled, Mode=TwoWay}"
+                                      Style="{StaticResource ToggleSwitchInExpanderStyle}" />
+                    </Grid>
+                </Button>
+            </DataTemplate>
+
             <DataTemplate x:Key="FragmentProfileViewModelTemplate"
                           x:DataType="local:FragmentProfileViewModel">
                 <muxc:Expander AutomationProperties.Name="{x:Bind AccessibleName}"
diff --git a/src/cascadia/TerminalSettingsModel/SshHostGenerator.cpp b/src/cascadia/TerminalSettingsModel/SshHostGenerator.cpp
index 45711c711e..e3c7ebbcb3 100644
--- a/src/cascadia/TerminalSettingsModel/SshHostGenerator.cpp
+++ b/src/cascadia/TerminalSettingsModel/SshHostGenerator.cpp
@@ -12,8 +12,8 @@
 static constexpr std::wstring_view SshHostGeneratorNamespace{ L"Windows.Terminal.SSH" };
 
 static constexpr std::wstring_view PROFILE_TITLE_PREFIX = L"SSH - ";
-static constexpr std::wstring_view PROFILE_ICON_PATH = L"ms-appx:///ProfileIcons/{550ce7b8-d500-50ad-8a1a-c400c3262db3}.png";
-static constexpr std::wstring_view GENERATOR_ICON_PATH = L"ms-appx:///ProfileGeneratorIcons/SSH.png";
+static constexpr std::wstring_view PROFILE_ICON_PATH = L"\uE977"; // PC1
+static constexpr std::wstring_view GENERATOR_ICON_PATH = L"\uE969"; // StorageNetworkWireless
 
 // OpenSSH is installed under System32 when installed via Optional Features
 static constexpr std::wstring_view SSH_EXE_PATH1 = L"%SystemRoot%\\System32\\OpenSSH\\ssh.exe";
diff --git a/src/features.xml b/src/features.xml
index 569acb9d6e..894875ecd5 100644
--- a/src/features.xml
+++ b/src/features.xml
@@ -100,6 +100,11 @@
         <description>Enables the dynamic profile generator for OpenSSH config files</description>
         <id>9031</id>
         <stage>AlwaysDisabled</stage>
+        <alwaysEnabledBrandingTokens>
+            <brandingToken>Dev</brandingToken>
+            <brandingToken>Canary</brandingToken>
+            <brandingToken>Preview</brandingToken>
+        </alwaysEnabledBrandingTokens>
     </feature>
 
     <feature>