microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-13 04:08:47 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

clean up more TODOs

Browse Source
This commit is contained in:
Carlos Zamora 2025-11-17 17:42:43 -08:00
parent a4c69cfc6a
commit 20bdc21c79
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cascadia/TerminalSettingsEditor/MainPage.cpp
View File

@ -212,8 +212,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
else if (const auto stringNavArg = navigationArg.try_as<hstring>()) else if (const auto stringNavArg = navigationArg.try_as<hstring>())
{ {
// The hstring navArg can be... // The hstring navArg can be...
// - a color scheme name // - color scheme name
// - an hstring tag (all defined at the top of the file) // - hstring tag (all defined at the top of the file)
// Regardless, we'll use the font icon used by the navigation view item // Regardless, we'll use the font icon used by the navigation view item
WUX::Controls::FontIcon icon{}; WUX::Controls::FontIcon icon{};
icon.FontFamily(Media::FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" }); icon.FontFamily(Media::FontFamily{ L"Segoe Fluent Icons, Segoe MDL2 Assets" });
@ -1439,7 +1439,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
filteredIndex.clear(); filteredIndex.clear();
for (const auto& entry : searchIndex) for (const auto& entry : searchIndex)
{ {
// TODO CARLOS: replace with fuzzy search
// Check for a match with DisplayText (i.e. "Globals_DefaultProfile/Header") and HelpText (i.e. "Globals_DefaultProfile/HelpText") // Check for a match with DisplayText (i.e. "Globals_DefaultProfile/Header") and HelpText (i.e. "Globals_DefaultProfile/HelpText")
// in language neutral and current language // in language neutral and current language
if (til::contains_linguistic_insensitive(entry.Entry->DisplayTextLocalized, queryText) || if (til::contains_linguistic_insensitive(entry.Entry->DisplayTextLocalized, queryText) ||

2
src/cascadia/TerminalSettingsEditor/Utils.h
View File

@ -137,8 +137,6 @@ struct HasScrollViewer
// or else the call to StartBringIntoView() // or else the call to StartBringIntoView()
// will end up doing nothing // will end up doing nothing
controlToFocus.StartBringIntoView(); controlToFocus.StartBringIntoView();
// TODO CARLOS: ensure this works in all scenarios (easiest to test when navigating to page by keyboard)
controlToFocus.Focus(winrt::Windows::UI::Xaml::FocusState::Programmatic); controlToFocus.Focus(winrt::Windows::UI::Xaml::FocusState::Programmatic);
} }
page->_loadedRevoker.revoke(); page->_loadedRevoker.revoke();