microsoft/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2025-12-10 18:43:54 -06:00
Code Issues Packages Projects Releases 138 Wiki Activity

Fix lock warning during ReturnResponse (#17266)

Browse Source 
As reported here:
https://github.com/microsoft/terminal/pull/16224#discussion_r1594849244

The underlying `WriteFile` call may block indefinitely and
we shouldn't hold the terminal lock during that period.
This commit is contained in:
Leonard Hecker 2024-05-16 00:03:28 +02:00 committed by GitHub
parent 9054c81934
commit 183a8956f6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cascadia/TerminalCore/TerminalApi.cpp
View File

@ -22,8 +22,9 @@ TRACELOGGING_DEFINE_PROVIDER(g_hCTerminalCoreProvider,
void Terminal::ReturnResponse(const std::wstring_view response) void Terminal::ReturnResponse(const std::wstring_view response)
{ {
if (_pfnWriteInput) if (_pfnWriteInput && !response.empty())
{ {
const auto suspension = _readWriteLock.suspend();
_pfnWriteInput(response); _pfnWriteInput(response);
} }
} }