mirror of
https://github.com/microsoft/WSL.git
synced 2025-12-11 04:35:57 -06:00
Prepare for review
This commit is contained in:
parent
708a6ce3ac
commit
6c55fcb7c5
@ -87,7 +87,6 @@ Microsoft::WRL::ComPtr<WSLAContainer> WSLAContainer::Create(const WSLA_CONTAINER
|
|||||||
std::vector<std::string> inputOptions;
|
std::vector<std::string> inputOptions;
|
||||||
if (hasStdin)
|
if (hasStdin)
|
||||||
{
|
{
|
||||||
// For now return a proper error if the caller tries to pass stdin without a TTY to prevent hangs.
|
|
||||||
inputOptions.push_back("-i");
|
inputOptions.push_back("-i");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -1238,8 +1238,8 @@ class WSLATests
|
|||||||
// For now, validate that trying to use stdin without a tty returns the appropriate error.
|
// For now, validate that trying to use stdin without a tty returns the appropriate error.
|
||||||
auto container = launcher.Launch(*session);
|
auto container = launcher.Launch(*session);
|
||||||
|
|
||||||
// TODO: nerdctl hangs if stdin is closed without writting to it.
|
// TODO: nerdctl hangs if stdin is closed without writing to it.
|
||||||
// Add test coverage for that usecase once that the hang is fixed.
|
// Add test coverage for that usecase once the hang is fixed.
|
||||||
auto process = container.GetInitProcess();
|
auto process = container.GetInitProcess();
|
||||||
auto input = process.GetStdHandle(0);
|
auto input = process.GetStdHandle(0);
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user