14629 Commits

Author SHA1 Message Date
uniqueiniquity
f962aba24a Indent all lines of single JsxText node 2017-10-31 14:09:36 -07:00
Andy
ce25dc9807
reduceRight is never used (#19605) 2017-10-31 13:29:28 -07:00
Nathan Shively-Sanders
98e9a561af
Merge pull request #19219 from Microsoft/abstract-property-access-error-in-own-constructor-only
Abstract property access error in own constructor only
2017-10-31 13:27:24 -07:00
Wesley Wigham
7e1e7a711a
Cache some LS calls in fourslash (#19517)
* Cache some LS calls in fourslash

* Add comment
2017-10-31 13:26:58 -07:00
uniqueiniquity
3ebb2e8a34 Merge branch 'master' into jsxFragment 2017-10-31 10:53:57 -07:00
Andy
f4236ec5c8
Rename "isPartOfExpression" (#18469) 2017-10-31 08:05:39 -07:00
csigs
d22d489407 LEGO: check in for master to temporary branch. 2017-10-31 04:10:09 +00:00
Wesley Wigham
c2aa13dac5
Parenthesize export assignments if needed (#19590)
* parenthesize export assignments if needed

* Add default-specific parenthesization to handle lookahead

* New parenthesization logic for export default

* Handle commalist and comma cases
2017-10-30 18:23:32 -07:00
Andrew Casey
a89c055a48
Merge pull request #19578 from amcasey/GH19395
Don't pass synthesized node to typeToTypeNode
2017-10-30 16:35:20 -07:00
Andy
5e0c71e6ba
The global "JSON" object should always exist (#19583) 2017-10-30 16:20:55 -07:00
Nathan Shively-Sanders
f26ac9f414
Merge pull request #19589 from Microsoft/reorder-jsdoctag-kinds
Fix the order of JSDocTag kinds
2017-10-30 16:07:28 -07:00
csigs
48457eafad
LEGO: Merge pull request 19591
LEGO: Merge pull request 19591
2017-10-30 15:11:19 -07:00
csigs
5294c4190b LEGO: check in for master to temporary branch. 2017-10-30 22:10:50 +00:00
Andy
277e3189c2 Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional (#19507)
* Make getCompletionEntryDetails and getCompletionEntrySymbol parameters non-optional

* Increment servicesVersion

* Update api baselines
2017-10-30 15:10:34 -07:00
Nathan Shively-Sanders
aea2ee5726 Fix the order of JSDocTag kinds
JSDocTypeLiteral should not be grouped with the JSDocTag kinds, so move
it just before they start, instead of just after. This updates the
LastJSDocNode and LastJSDocTagNode.
2017-10-30 15:00:34 -07:00
Mohamed Hegazy
6c71ca84e7
Add utility function to check for strict option flags (#19427)
* Add utility function to check for strict option flags
- Correctelly check for noImplicitAny in checker
- Correctelly check for noImplicitAny in installTypesForPackage refactor

* Respond to code review comments

* Accept baselines

* Revert "Accept baselines"

This reverts commit cf4ef62830b4ee5555125ce214d824e16c244488.

* Move type alias to core
2017-10-30 13:05:54 -07:00
Anders Hejlsberg
7f4a132af9
Merge pull request #19564 from Microsoft/fixGenericMappedTypeRelationships
Fix generic mapped type relationships
2017-10-30 12:42:24 -07:00
Matt
6de69df9c1 Fix #102: More accurate error message for module in type reference (#19324)
* Add: Logical OR of "SymbolFlags.ValueModule" into the "meaning" argument of the
"resolveName" call, in the "checkAndReportErrorForUsingNamespaceModuleAsValue"
function, when checking if a namespace is being used as a type.

* Fix: test "privacyImportParseErrors" error messages.

* Fix: test "typeofInternalModules" error message.

* Fix: test "moduleWithValuesAsType" error message.

* Fix: test "moduleAssignmentCompat2" error messages.

* Fix: test "moduleVisibilityTest3" error message.

* Fix: test "getAccessorWithImpliedReturnTypeAndFunctionClassMerge" error messages.

* Fix: test "staticInstanceResolution5" error messages.

* Fix: test "noCrashOnImportShadowing" error message.

* Fix: test "moduleAssignmentCompat3" error messages.

* Fix: test "primaryExpressionMods" error message.

* Fix: test "moduleInTypePosition1" error message.

* Fix: test "moduleAssignmentCompat1" error messages.

* Fix: test "moduleAssignmentCompat4" error messages.

* Fix: test "moduleCrashBug1" error message.
2017-10-30 12:38:18 -07:00
Ron Buckton
91c37f72d3
Merge pull request #19401 from Microsoft/fix19349
Remove escaped names of well known symbols from string completions
2017-10-30 12:37:13 -07:00
Andy
f0da3d7336
Fix declaration emit for typeof default export (#19471)
* Fix declaration emit for `typeof` default export

* Add comment
2017-10-30 11:40:32 -07:00
Andrew Casey
1f93526fd9 Assert that enclosing declaration is not synthesized 2017-10-30 11:22:07 -07:00
Andrew Casey
aa59a69e14 Correct typo - pass correct argument
All of the other calls in extractSymbol are already correct.
2017-10-30 11:21:22 -07:00
Nathan Shively-Sanders
505ffab745
Merge pull request #19511 from Microsoft/add-tsconfig-after-running-rwc
Generate tsconfig.json for RWC projects that lack them.
2017-10-30 10:54:27 -07:00
Andy
212efd5c7b
In quick info, show all jsdoc tags (#19357) 2017-10-30 10:27:19 -07:00
Nathan Shively-Sanders
c5b199014c Use Harness.isDefaultLibraryFile to detect lib.d.ts 2017-10-30 10:20:11 -07:00
Mohamed Hegazy
5d469cf0e8
Merge pull request #19552 from ajafff/parse-negative-numbers
convertToObject: handle negative numbers in JSON
2017-10-30 09:58:30 -07:00
Anders Hejlsberg
b3a24322d3 Make generic mapped type relationship more inclusive 2017-10-29 16:49:28 -07:00
Anders Hejlsberg
7798f69558
Merge pull request #19513 from Microsoft/strictObjectLiterals
Improved type inference for object literals
2017-10-28 17:13:21 -07:00
Anders Hejlsberg
fd0d40cc2b Undo unnecessary change 2017-10-28 15:31:39 -07:00
Anders Hejlsberg
90d20f260a Redo subtype reduction with correct --noImplicitAny error reporting 2017-10-28 15:28:11 -07:00
Klaus Meinhardt
4895d16645 convertToObject: handle negative numbers in JSON
Fixes: #19551
2017-10-28 20:06:33 +02:00
Anders Hejlsberg
73802be004 Undo extra subtype reduction in getWidenedType 2017-10-27 17:18:49 -07:00
csigs
8ce740dad6 LEGO: check in for master to temporary branch. 2017-10-27 22:10:18 +00:00
Nathan Shively-Sanders
d2771a8e76 Improve regex for tsconfig test 2017-10-27 14:34:40 -07:00
Nathan Shively-Sanders
3ac91d109b Generate tsconfig in tsc-instrumented instead 2017-10-27 14:31:48 -07:00
Anders Hejlsberg
9c27c56779 Perform subtype reduction when widened union type contains {} 2017-10-27 10:05:44 -07:00
csigs
8f4184370c LEGO: check in for master to temporary branch. 2017-10-27 16:10:13 +00:00
csigs
530881cb4b LEGO: check in for master to temporary branch. 2017-10-27 10:10:14 +00:00
csigs
268ee02a44 LEGO: check in for master to temporary branch. 2017-10-27 04:10:03 +00:00
Andrew Casey
bc2a048a39 Handle --debug-brk and --inspect-brk when launching TypingsInstaller 2017-10-26 16:42:47 -07:00
Wesley Wigham
6f2d0472e6 Only construct two rules providers in textChanges (#19502) 2017-10-26 15:46:30 -07:00
Wesley Wigham
cb0d230c98 Overwrite assert.isFalse (#19506) 2017-10-26 15:43:51 -07:00
csigs
2de28aac75 LEGO: check in for master to temporary branch. 2017-10-26 22:10:34 +00:00
Nathan Shively-Sanders
8ccf0af3ac Add tsconfig.json for RWC projects that lack them.
This should make all RWC projects browseable with an editor on Windows
(except two, see below). On Linux it still works pretty well if you
are willing to lowercase the imports of the file you're interested in.

Many RWC projects already have tsconfig.json files, but this change
creates one for projects that don't -- *after* running their respective RWC
test. That's because all the information is most easily available at
that time, and you probably won't need it until then anyway.

Note that two RWC projects use relative paths in their list of stored files
and don't work with this simple scheme. I'll look at that next, but if I
can't figure it out in the next hour or two, I'd prefer to merge this
since it's immediately useful for all the other projects.
2017-10-26 15:05:56 -07:00
Anders Hejlsberg
fd0ac155b9 Add missing semicolon 2017-10-26 14:58:06 -07:00
Anders Hejlsberg
aa6b438eba Ensure void return in forEachType 2017-10-26 14:56:43 -07:00
Wesley Wigham
45684a8175 Disable sourcemaps during cancellationToken test (#19505) 2017-10-26 14:21:18 -07:00
Wesley Wigham
6671485596 Disable error sourcemaps during session test (#19504)
* Disable error sourcemaps during session test

* Also disable during the exceptions-specific test
2017-10-26 13:48:59 -07:00
Anders Hejlsberg
0fbe98331f Merge branch 'master' into strictObjectLiterals 2017-10-26 13:15:36 -07:00
Wesley Wigham
940175e23f Memoize rule provider (#19501) 2017-10-26 13:01:48 -07:00