Commit Graph

1204 Commits

Author SHA1 Message Date
Cyrus Najmabadi
f06dddcf1e Simplify helper function. 2015-02-16 18:05:29 -08:00
Cyrus Najmabadi
f4da5d724f Move the smart indenter over to zero based math. 2015-02-16 18:00:43 -08:00
Cyrus Najmabadi
edbedc7d5d Make code more clearly state that it is one based. 2015-02-16 17:47:32 -08:00
Cyrus Najmabadi
1098e80f4b Remove one-based helper function. 2015-02-16 17:41:07 -08:00
Cyrus Najmabadi
8ef4df8acb Move the emitter over to using zero based indexing. 2015-02-16 17:34:11 -08:00
Cyrus Najmabadi
b3366ec8b4 name more line/char functions more clearly. Use zero based indexing in breakpoints. 2015-02-16 16:18:53 -08:00
Cyrus Najmabadi
11a9df2cc9 Expose zero-based helpers that code will be able to call. 2015-02-16 15:30:21 -08:00
Cyrus Najmabadi
35b489d7d1 Rename our one-based methods to more clearly indicate that that's what base they use. 2015-02-16 15:20:05 -08:00
Daniel Rosenwasser
fee50a6dbc Made the actual implementation of the lexical classifier be non-optional. 2015-02-16 14:59:22 -08:00
Daniel Rosenwasser
1dca5620f5 Addressed CR feedback. 2015-02-13 12:56:21 -08:00
Daniel Rosenwasser
15b333e102 Added comment for 'syntacticClassifierAbsent'. 2015-02-12 16:29:03 -08:00
Daniel Rosenwasser
1838800b6c Fixed assertion 2015-02-12 16:29:01 -08:00
Daniel Rosenwasser
ab79faef85 Added tests, fixed order of emptying templateStack, unconditionally perform template classification. 2015-02-12 16:28:45 -08:00
Daniel Rosenwasser
3fea0aefbe classifyKeywordsInGenerics -> syntacticClassifierAbsent 2015-02-12 15:48:32 -08:00
Daniel Rosenwasser
f1f085eda6 Addressed CR feedback. 2015-02-12 15:48:30 -08:00
Daniel Rosenwasser
3429fab6fb Fixed issue with the kinds we check. 2015-02-12 15:48:27 -08:00
Daniel Rosenwasser
ea30c68128 Rudimentary, but imperfect, lexical classification for templates. 2015-02-12 15:48:21 -08:00
Daniel Rosenwasser
3e8babedcf Merge pull request #1271 from Microsoft/taggedSigHelpAtEnd
Fixed bug where tagged templates with a literal adjacent to EOF showed sig help past the end.
2015-02-12 11:37:32 -08:00
togru
d94cbed413 Merge remote-tracking branch 'upstream/master' 2015-02-11 10:12:22 +01:00
Cyrus Najmabadi
11d19e3019 Fix issue with cancellation corrupting LS state.
The problem here was as follows:
1) Host calls into the LS to do some sort of operation.
2) LS tries to synchronize with the host.
3) During synchronization we attempt to create a new program.
4) Creating the new program causes us to incrementally update some source files.
5) Incrementally updating a source file produces a new source file, and invalidates the old one.
6) *Then* the host asks to cancel this operation.
7) THe synchronization process cancels itself, leaving the LS in an inconsistent state where some
   of its source files have had their trees updated, but the information about the source file still
   thinks that we have the previous version.

The fix is to not allow cancellation during host synchronization.  Once we start, we have to go
all the way to completion.
2015-02-09 17:15:29 -08:00
Mohamed Hegazy
9207d9dd22 Merge remote-tracking branch 'origin/master' into fourslashCleanup
Conflicts:
	src/harness/harnessLanguageService.ts
2015-02-09 09:31:19 -08:00
Cyrus Najmabadi
1a17fd1daf Move assertions into the parsing layer. 2015-02-08 17:30:27 -08:00
Cyrus Najmabadi
f1cb97b692 Add additional aggressive checks during incremental parsing. 2015-02-08 16:10:16 -08:00
Mohamed Hegazy
55aa240ade Merge branch 'master' into LSAPICleanup
Conflicts:
	src/services/services.ts
2015-02-06 17:17:23 -08:00
Mohamed Hegazy
0f3f2bcb56 add comment 2015-02-06 14:22:32 -08:00
Mohamed Hegazy
68fd9f8d40 Shim API changes to enable existing installations of VS to use the latest master builds 2015-02-06 14:20:29 -08:00
Cyrus Najmabadi
5c0b38b203 Remove getEnumMemberValue, it is now subsumed into getConstantValue. 2015-02-05 18:26:56 -08:00
Cyrus Najmabadi
acbcd6c77f Merge branch 'master' into diagnosticsOrganization 2015-02-05 17:30:27 -08:00
jramsay
dc06b2f6de Merge pull request #1952 from Microsoft/jasonra-disallowRenameForStandardTSLib
Disallow rename for elements that are defined in the standard TypeScript...
2015-02-05 17:21:22 -08:00
Jason Ramsay
987dab9c9e addressing CR comments 2015-02-05 16:05:54 -08:00
Cyrus Najmabadi
66a363f449 Simplify the API for emitting and reporting exit statuses to callers. 2015-02-05 15:50:18 -08:00
Cyrus Najmabadi
ea4e3de91c Remove unnecessary diagnostics split on SourceFile. 2015-02-05 13:38:11 -08:00
Jason Ramsay
953e568d9e Disallow rename for elements that are defined in the standard TypeScript library. 2015-02-05 13:32:33 -08:00
togru
9974526101 updated code style, added tests, fixed regex bug, merged to latest branch 2015-02-05 12:07:00 +01:00
Cyrus Najmabadi
493327af34 Fix language service handling of diagnostics. 2015-02-05 02:10:36 -08:00
Cyrus Najmabadi
337a99f62a Change the API for getting diagnostics so that all calls go through a Program instance. 2015-02-05 01:47:29 -08:00
Cyrus Najmabadi
b12be3db19 Remove dependency from the typechecker to the compiler host.
This also lets us not expose the compiler host from the Program instance.
The compiler host was only needed by the type checker to get the host newline.
The host newline was used for concatenating diagnostic message chains.  Now
we don't concatenate them up front.  Instead, we just store the message chain
in the diagnostic itself.  Then when we pass it to the host, it can then decide
what newline to use.
2015-02-04 23:20:26 -08:00
Mohamed Hegazy
40a01a81b3 Merge branch 'master' into fourslashCleanup
Conflicts:
	src/harness/fourslash.ts
	src/harness/harnessLanguageService.ts
2015-02-04 20:22:00 -08:00
Cyrus Najmabadi
bb307f8163 Simplify the API for emitting code from the Program instance. 2015-02-04 16:53:14 -08:00
Paul van Brenk
40824ed8a5 Added templates, assignement and arrays + tests. 2015-02-04 16:40:22 -08:00
Cyrus Najmabadi
b6d083fa40 Do not publicly expose a way on a Program instance to get typecheckers with differing behavior.
Now, you can only get the non-diagnostics, pull-type-checker from the Program instance.
If you want diagnostics, you simply ask the Program instance for the diagnostics you want.
2015-02-04 16:11:38 -08:00
Cyrus Najmabadi
5b049feb36 Hide the diagnostic producing methods from TypeChecker.
Instead, consumers should get these diagnostics through the Program instance.
2015-02-04 14:29:25 -08:00
Paul van Brenk
ece874fde3 Merge branch 'master' into LessAggresiveCompletionList 2015-02-04 14:03:49 -08:00
Paul van Brenk
6e35f79412 Add builder support for variable declarations + test cases. 2015-02-04 14:03:26 -08:00
Cyrus Najmabadi
c7160ddb31 Rename semanticDiagnostics to bindDiagnotics. 2015-02-04 13:31:36 -08:00
Mohamed Hegazy
784dda5229 Merge pull request #1904 from Microsoft/changeLSDefaultTarget
Change the default LS target to ES5 from ES6
2015-02-04 09:25:24 -08:00
Paul van Brenk
e233da0fd6 Parameter destructuring + tests 2015-02-03 18:03:40 -08:00
Paul van Brenk
d9f678fd6d Rename the isBuilder property to something more meaningful. 2015-02-03 16:31:53 -08:00
Cyrus Najmabadi
95702a89a7 Fix spelling of 'Filename' to be 'FileName'. 2015-02-03 16:08:46 -08:00
Paul van Brenk
62bc9df899 Support for destructuring + test case. 2015-02-03 14:26:32 -08:00