Commit Graph

993 Commits

Author SHA1 Message Date
Andy
eefe5c9706 Fix acquiring format options for getEditsForRefactor (#18848)
* Fix acquiring format options for getEditsForRefactor

* Add test

* Fix test description

* Use `executeCommandSeq`
2017-10-02 13:26:35 -07:00
Ryan Cavanaugh
141cd574c7 Merge pull request #18603 from RyanCavanaugh/pluginWork
Report external files in initial case for project load
2017-10-02 10:32:04 -07:00
Andy
25ad0b5581 Apply "array-type" lint rule (#18699) 2017-09-22 16:14:41 -07:00
Ryan Cavanaugh
54070786e4 Report external files in initial case 2017-09-20 10:52:56 -07:00
Ryan Cavanaugh
b9b112738c Merge pull request #18456 from RyanCavanaugh/pluginWork
Properly report external filenames
2017-09-20 10:51:54 -07:00
Andrew Casey
0ac8406cd7 Merge pull request #18501 from Microsoft/formatOptions
Make formatOptions optional in GetEditsForRefactorRequestArgs
2017-09-15 17:11:08 -07:00
Andrew Casey
965a4d5aeb Restructure handling to TI messages to enforce exhaustiveness 2017-09-15 11:33:05 -07:00
Andy Hanson
0b76e43977 Make formatOptions optional in GetEditsForRefactorRequestArgs 2017-09-15 07:21:38 -07:00
Andrew Casey
f3411d4361 Only decrement activeRequestCount on SetTypings responses
InvalidateCache responses are triggered by file watchers, rather than by
requests.
2017-09-14 15:45:26 -07:00
Andy
0de1b2301e Cleanup getDiagnosticsForProject (#18151) 2017-09-14 12:38:48 -07:00
Andy
d96dfeb708 Don't normalize whitespace in fourslash tests (#18447)
* Don't normalize whitespace in fourslash tests

* Only render whitespace when the diff is text-only
2017-09-14 08:23:50 -07:00
Ryan Cavanaugh
9046fcb658 Add files as one batch to preserve errors 2017-09-13 16:09:18 -07:00
Ryan Cavanaugh
3bd4c4f847 Properly report external filenames 2017-09-13 15:19:07 -07:00
Andy
2a70bf5158 Don't count a write-only reference as a use (#17752)
* Don't count a write-only reference as a use

* Split isWriteAccess to isWriteOnlyAccess and isReadOnlyAccess

* Update "unusedParameterUsedInTypeOf" to use "b"

* Update diagnostic messages: "is never used" -> "its value is never read"

* Use a WriteKind enum

* Rename enum and move documentation to enum members
2017-09-13 09:02:33 -07:00
Andy
c3199c7772 extractMethod: Support renameLocation (#18050)
* extractMethod: Support renameLocation

* Add tslint disable

* Properly analyze list of changes to always get a correct rename location

* Update test

* Ensure name is really unique

* Improvements to test code

* Respond to PR comments
2017-09-13 09:02:10 -07:00
Ryan Cavanaugh
1f0e7b02ea Merge pull request #18093 from RyanCavanaugh/detectBadPlugins
Detect bad plugins and work around them
2017-09-11 12:49:10 -07:00
Andrew Casey
097b094082 Don't get typings for projects with disabled language services 2017-09-07 11:10:12 -07:00
Andrew Casey
8d1eb29fb1 Merge pull request #18265 from amcasey/ThrottledOperations
Limit the number of unanswered Typings Installer requests
2017-09-07 11:01:27 -07:00
Adrian Leonhard
7b12b79558 ts.server.ProjectService.closeConfiguredProject returns true on success. (#18180)
Fixes #17892
The if condition around the return value of that method in closeExternalProject indicates that this was the expected behavior.
2017-09-07 09:17:47 -07:00
Andy
193f4be355 Enable interface-over-type-literal lint rule (#17733) 2017-09-07 09:14:59 -07:00
Andrew Casey
9692ce86db Add explanatory comment 2017-09-06 15:46:59 -07:00
Andrew Casey
0b1bad8421 Fix lint issues 2017-09-06 15:44:00 -07:00
Andrew Casey
482e802e83 Limit the number of unanswered typings installer requests
If we send them all at once, we (apparently) hit a buffer limit in the
node IPC channel and both TS Server and the typings installer become
unresponsive.
2017-09-05 18:08:50 -07:00
Andrew Casey
9c6765d5cf Document ThrottledOperations.schedule 2017-09-05 15:47:54 -07:00
Ryan Cavanaugh
0e2d399c49 Don't crash when a JS file appears in an inferred context 2017-08-29 13:29:56 -07:00
Ryan Cavanaugh
67f2716156 Detect bad plugins and work around them 2017-08-28 13:32:20 -07:00
Paul van Brenk
6f6c3c2464 Merge branch 'master' into dynamicFiles
# Conflicts:
#	src/server/utilities.ts
2017-08-25 13:25:46 -07:00
Andy
e2141ad469 Mark some arrays as readonly (#17725)
* Mark some arrays as readonly

* Avoid unnecessary allocations and style changes

* Fix lint
2017-08-24 09:55:01 -07:00
Mohamed Hegazy
deaddb5595 Ports #17983 (#17986)
* Bind logger function before using

* Use lambda isntead of bind
2017-08-23 13:01:14 -07:00
Ryan Cavanaugh
43b8ce664c Merge 2017-08-22 14:31:49 -07:00
Ryan Cavanaugh
b217d96cc1 Merge pull request #17839 from RyanCavanaugh/ignoreScripts
Ignore scripts for types packages
2017-08-22 11:24:18 -07:00
Mohamed Hegazy
07e1d3b13d Ensure string enums are generated in protocol.d.ts (#17914) 2017-08-21 09:44:03 -07:00
Arthur Ozga
a3d113bed3 Merge pull request #16385 from aozgaa/isInMultiLineComment
multi-line comment formatting fix and handler
2017-08-18 12:43:37 -07:00
Andy
ade3b565ae Revert public API changes to logger (#17899) 2017-08-18 11:20:07 -07:00
Arthur Ozga
19e2fa6fc5 Merge branch 'master' into isInMultiLineComment 2017-08-16 17:57:04 -07:00
Ryan Cavanaugh
af68a61ba7 Ignore scripts for types packages 2017-08-16 11:53:44 -07:00
Paul van Brenk
b07fd3e180 Fix linter issues 2017-08-15 12:27:02 -07:00
Paul van Brenk
5665c098da Introduce the concept of a Dynamic File
Dynamic files are generally created by the debugger when while debugging
it can't find a matching file on disk. Since these files don't exist on
disk, we shouldn't check if the file exists on disk, and allow the content
to be controlled by the host.
2017-08-14 16:55:37 -07:00
Andy
80a7ed9a42 Fixes to session's handling of empty results (#17728)
* Fixes to session's handling of empty results

* Fix emptyArray -> undefined
2017-08-14 13:42:15 -07:00
Ron Buckton
360dc914c3 Merge pull request #17602 from Microsoft/multiInferredProjects
Adds support for inferred project isolation by projectRootPath
2017-08-11 16:06:49 -07:00
Ron Buckton
c272c3c5cd Comment update 2017-08-11 16:06:24 -07:00
Andy
f64b8ad902 Add "preserveSymlinks" option (#16661)
* Add "preserveSymlinks" option

* Respond to PR comments
2017-08-11 10:03:21 -07:00
Ron Buckton
b031777566 PR Feedback 2017-08-10 17:43:22 -07:00
Andy
08fbcd8b80 Fix many no-object-literal-type-assertion lint errors (#17278)
* Fix many no-object-literal-type-assertion lint errors

* Simple fixes

* Use a union for FlowNode

* PR feedback and remove remaining `id()` uses

* Use a union for CodeBlock

* Discriminate CodeBlock by CodeBlockKind
2017-08-10 12:52:15 -07:00
Andy
f124e19971 Session: don't return undefined if a response is required (#17165)
* Session: don't return undefined if a response is required

* Use ReadonlyArray and emptyArray

* Remove inferred return type
2017-08-09 13:46:47 -07:00
Andy
b8c37bb50c Inline childFromLineNumber and childFromCharOffset (#17018)
* Inline childFromLineNumber and childFromCharOffset

* Handle empty document -- root node with 0 children

* Fix test
2017-08-09 13:43:25 -07:00
Andy
bd68122821 scriptVersionCache: Export less (#17202)
* scriptVersionCache: Export less

* Remove LineIndexForTest, use LineIndex

* Add /* @internal */ to class LineIndex

* Make CharRangeSelection a const enum
2017-08-09 10:59:10 -07:00
Arthur Ozga
7c402d509d Merge branch 'master' into isInMultiLineComment 2017-08-09 10:49:12 -07:00
Ron Buckton
37b9b7089c PR Feedback 2017-08-08 17:23:50 -07:00
Andy
d99a492ddd Simplify server logger (#17271)
* Simplify server logger

* Move function printProjects out of inner closure
2017-08-08 11:22:22 -07:00