16544 Commits

Author SHA1 Message Date
Joscha Feth
ee429ef2ea use state 2018-04-13 11:39:29 +10:00
Joscha Feth
4da2e5eda3 fix: do not match MySymbol.import("mod") 2018-04-12 19:31:07 +10:00
Andy
edcf087145
Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment (#23314)
* Fix bug: isSymbolReferencedInFile should return true for shorthand property assignment

* Also test for export specifier
2018-04-11 19:01:30 -07:00
Andy
b0552b089d
Don't include "/index" in import from @types even with classic resolution (#23347) 2018-04-11 16:22:10 -07:00
Andy
28455c65b3
patternMatcher: Return single best match instead of list (#23166) 2018-04-11 15:35:22 -07:00
Andy
f6b206a75a
When testing references, also test documentHighlights respects filesToSearch (#23306)
* When testing references, also test documentHighlights respects filesToSearch

* Fix handling for redirects and move assertion inside getDocumentHighlights

* Add another assert
2018-04-11 14:07:22 -07:00
Andy
fef28665f7
generateGetAccessorAndSetAccessor: Fix typos and use type predicate (#23310) 2018-04-11 13:21:47 -07:00
Andy
a004571d3e
Update outdated comments (#23320) 2018-04-11 07:56:42 -07:00
Nathan Shively-Sanders
9ceb113ec5
Allow exports assignments (#23319)
1. Allow assignment to `exports`.
2. The type of the rhs is not checked against the type of `exports`
since they are aliased declarations.

To support more complex patterns like `exports = c.name = c`, we may
have to treat `c.name` as a declaration. That will be more complicated
than this PR.
2018-04-11 06:49:58 -07:00
Daniel Rosenwasser
01b22ff37e
Merge pull request #23331 from aboveyou00/master
Fix typeo: rename udpateReportDiagnostic to updateReportDiagnostic
2018-04-11 01:40:49 -07:00
csigs
f458e9007d LEGO: check in for master to temporary branch. 2018-04-11 04:10:41 +00:00
Brandon Slade
82e8bcf3b2 Fix typeo: rename udpateReportDiagnostic to updateReportDiagnostic 2018-04-10 21:58:18 -06:00
Wesley Wigham
8a2b4646f0
Include guards on comment kind in pragma extraction (#23313) 2018-04-10 20:50:31 -07:00
Wesley Wigham
b2e0c4bea6
Add support for destructuring well-known and late-bound names (#23297)
* Add support for destructuring well-known and late-bound names

* Add test of not present late bound prop
2018-04-10 18:21:24 -07:00
Wesley Wigham
1243d1a9ba
handle any'd method signature types (ie, from special property declarations) (#23316) 2018-04-10 18:17:57 -07:00
csigs
cb6d4d1ff6 LEGO: check in for master to temporary branch. 2018-04-10 22:10:52 +00:00
Andy
dcc4b8854b
In getWidenedTypeFromJSSpecialPropertyDeclarations, parent of PropertyAccessExpression must be a BinaryExpression (#22727) 2018-04-10 14:46:26 -07:00
Andy
f479de6d02
patternMatcher: Just return 'undefined' for an invalid pattern (#23237)
* patternMatcher: Just return 'undefined' for an invalid pattern

* Fix tests
2018-04-10 14:38:16 -07:00
Nathan Shively-Sanders
22919d57fe
JSDoc:positional matching of destructured params (#23307)
* JSDoc:positional matching of destructured params

1. When looking up tags for a parameter whose name is a binding pattern, use
the index of the parameter to get the type.
2. When reporting errors for `@param` tags with no matching parameter
name, do not report the error for tags whose index in the `@param` tag list
matches the index of a parameter whose name is a binding pattern.

* Change to an assert

* Improve comment text
2018-04-10 12:48:35 -07:00
Andy
4b706fc479
Add 'disableSuggestions' to UserPreferences (#23283)
* Add 'disableSuggestions' to UserPreferences

* Make mergeMapLikes return a new object

* Avoid additional clone

* mergeMapLikes -> object spread
2018-04-10 11:53:24 -07:00
Wenlu Wang
9c0671d661 add refactor of convert private field to getter and setter (#22143)
* add refactor of convert private field to getter and setter

* fix refactor

* stash

* refactor accessor generate

* revert merge union type

* refeactor and accept baseline

* add support of PropertyAssignment and StringLiteral

* add support for js file

* allow static modifier in js file
2018-04-10 11:51:41 -07:00
Andy
556a8010b9
Fix bug: ensure 'reportsUnnecessary' is actually sent by tsserver (#23293) 2018-04-10 10:15:15 -07:00
csigs
651412c887 LEGO: check in for master to temporary branch. 2018-04-10 10:10:29 +00:00
csigs
3f0dad831d LEGO: check in for master to temporary branch. 2018-04-10 04:10:24 +00:00
csigs
fe6142a2da LEGO: check in for master to temporary branch. 2018-04-09 22:10:41 +00:00
Andy
ce5d22fef0
Fix bug: don't insert a semicolon when inserting a FunctionDeclaration (#23240) 2018-04-09 15:03:24 -07:00
Wesley Wigham
83ab341531
Allow variable statements used as declaration sites to be marked visible (#22798)
* Allow variable statements used as declaration sites to be marked visible and included in declaration emit by alias marking

* Dont forget to transform statements

* Accept baselines

* Accept updated baselines for new test

* Emit scope fix markers

* Add partial private variable declaration emit test
2018-04-09 14:30:40 -07:00
Andy
71b39014eb
Fix bug: Include comment for @param tag with nested tag (#23276)
* Fix bug: Include comment for @param tag with nested tag

* Add another comment to test
2018-04-09 14:09:59 -07:00
Andy
542184a05a
Rename infoCheck to suggestionCheck (#23286) 2018-04-09 14:09:07 -07:00
Andy
e858de9520
Simplify handling of parameter properties in forEachRelatedSymbol (#23213)
* Simplify handling of parameter properties in forEachRelatedSymbol

* Add assert for other paramProps symbol
2018-04-09 13:26:10 -07:00
Andy
98a5e5cc0d
Prioritize spelling fix over add-missing-member fix (#23268) 2018-04-09 13:23:11 -07:00
Andy
998beadba2
Support goto-definition for index signatures (#23220)
* Support goto-definition for index signatures

* Use checker.getIndexInfoOfType

* Handle undefined info.declaration
2018-04-09 12:48:41 -07:00
csigs
bcbaac92e5 LEGO: check in for master to temporary branch. 2018-04-09 16:10:36 +00:00
csigs
678bab2eca LEGO: check in for master to temporary branch. 2018-04-08 10:10:24 +00:00
Sheetal Nandi
4170f35abc
Merge pull request #23239 from Microsoft/skipWatchingTypeCacheInfos
Skip watching script infos in the global type cache location
2018-04-06 17:06:37 -07:00
Andy
9762598775
findAllReferences: forEachRelatedSymbol can always include shorthand destructuring (#23223)
* findAllReferences: forEachRelatedSymbol can always include shorthand destructuring

* Update rename tests
2018-04-06 16:30:55 -07:00
Andy
e0dbdad22a
IndexInfo#declaration is always an IndexSignatureDeclaration (#23232) 2018-04-06 16:20:45 -07:00
Sheetal Nandi
7a0a1f6a28 Do not watch script infos that are part of global typings location 2018-04-06 15:52:39 -07:00
Sheetal Nandi
c9f39951b6 Do not send project update in background if there was no ensureUpdate pending on the project structure 2018-04-06 14:58:13 -07:00
Sheetal Nandi
62c6fe2ccc There is no need to ensure project structure when tryiong to get inferred project
The project operations will validate if its valid anyways
2018-04-06 14:22:08 -07:00
Sheetal Nandi
e304178c65 Add time stamp into the ti log. 2018-04-06 14:22:04 -07:00
Nathan Shively-Sanders
a7a01eadba
Allow both module.exports= and module.exports property assignments (#23228)
* Combining symbol and removing error done but messy

* Small fix + add new test baselines

All other tests are unchanged

* Union conflicting assignment types+better names

* Add tests and update baselines

* Check commonjs export= from resolveExternalModuleSymbol
2018-04-06 13:04:39 -07:00
Andy
70682b7799
Clean up code for nonrelative path completions (#23150)
* Clean up code for nonrelative path completions

* Remove unnecessary test and simplify based on that

* More code review

* Call getCompletionEntriesFromTypings unconditionally
2018-04-06 12:19:08 -07:00
Mohamed Hegazy
724b74615b
Merge pull request #23218 from TravCav/master
Bit more code cleanup
2018-04-06 11:23:33 -07:00
TravCav
9861569ae9 found another place to fall through in the checker 2018-04-06 13:40:58 -04:00
Andy
2b59c9a0d7
Don't add import completion for re-export with different name (#23211) 2018-04-06 10:05:38 -07:00
Mohamed Hegazy
61d9fc65ed
Merge pull request #23203 from HolgerJeromin/patch-1
refactor: use union type in `DateConstructor`
2018-04-06 09:42:47 -07:00
Mohamed Hegazy
da312398f5
Merge pull request #23050 from gagoman/fix/22923
Fix issue #22923
2018-04-06 09:31:43 -07:00
TravCav
60bd7e861c removed always true condition 2018-04-06 12:23:41 -04:00
Holger Jeromin
c3d8ec0ee2
refactor: use union type in DateConstructor 2018-04-06 11:27:20 +02:00