Commit Graph

33 Commits

Author SHA1 Message Date
Andy
e2141ad469 Mark some arrays as readonly (#17725)
* Mark some arrays as readonly

* Avoid unnecessary allocations and style changes

* Fix lint
2017-08-24 09:55:01 -07:00
Yui
d352e3b03f [Master] fix 16407 - LS in binding element of object binding pattern (#16534)
* wip-try get symbol of bindingelement in objectBindingPattern first

* Add fourslash tests

* Update .types baselines

* Update .symbols baselines

* Revert checker changes

* Actually lookup type for binding property name definition

* More succinct check, clarify yui's comment
2017-08-11 11:14:59 -07:00
Andy
eadd084c82 Add 'name' property to Identifier (#17329)
* Add 'name' property to Identifier

* Rename to unescapedText

* Rename 'id.text' to 'id.escapedText'

* Rename 'id.unescapedText' to 'id.text'

* Make escapeIdentifier and unescapeIdentifier do nothing
2017-07-25 13:16:34 -07:00
Andy
194c2bc2ca Make NodeArray readonly (#17213)
* Make NodeArray readonly

* Fix bug: use emptyArray instead of undefined

* Fix bug: Don't expose MutableNodeArray

* Undo trailing whitespace changes
2017-07-18 10:38:21 -07:00
Andy
e7dc2a67ca Enable "object-literal-shorthand" lint rule (#16987) 2017-07-07 07:26:58 -07:00
Wesley Wigham
4e6b2f3c93 Created a branded type for identifier-escaped strings (#16915)
* Created a branded type for escaped strings

Then flowed it throughout the compiler, finding and fixing a handful of
bugs relating to underscore-prefixed identifiers in the process.
Includes a test for two cases noticed - diagnostics from conflicting
symbols from export *'s, and enum with underscore prefixed member emit.

* Correctly double underscores WRT mapped types

* Add fourslash tests for other fixed issues

* use function call over cast

* Update forEachEntry type accuracy

* Just use escaped names for ActiveLabel

* Remove casts from getPropertyNameForPropertyNameNode

* This pattern has occurred a few times, could use a helper function.

* Remove duplicated helper

* Remove unneeded check, use helper

* Identifiers list is no longer escaped strings

* Extract repeated string-getting code into helper

* Rename type and associated functions

* Make getName() return UnderscoreEscapedString, add getUnescapedName()

* Add list of internal symbol names to escaped string type to cut back on casting

* Remove outdated comments

* Reassign interned values to nodes, just in case

* Swap to string enum

* Add deprecated aliases to escapeIdentifier and unescapeIdentifier

* Add temp var

* Remove unsafe casts

* Rename escaped string type as per @sandersn's suggestion, fix string enum usages

* Reorganize double underscore tests

* Remove jfreeman from TODO

* Remove unneeded parenthesis
2017-07-06 14:45:50 -07:00
Andy
3cd9f3d2d4 Support services for @typedef (#16087)
* Support services for @typedef

* Ensure JSDocTypeReference has SemanticMeaning.Type

* Get SemanticMeaning right
2017-05-26 09:52:46 -07:00
Andy Hanson
b1e100e494 Merge branch 'master' into kind 2017-05-23 07:02:30 -07:00
andy-ms
b162097c3c Make ScriptElementKind and HighlightSpanKind string enums 2017-05-20 07:56:24 -07:00
Andy Hanson
d646c727e7 Merge branch 'master' into jsdoc 2017-05-19 08:18:18 -07:00
Andy
38ece3b703 Merge pull request #15737 from Microsoft/findAllRefs_module
Support find-all-references for a module specifier
2017-05-19 08:11:56 -07:00
Andy Hanson
dc40f5d6b9 Merge branch 'master' into jsdoc 2017-05-17 07:17:32 -07:00
Andy Hanson
38784b761a Support for JSDoc in services 2017-05-15 14:45:30 -07:00
Andy Hanson
aaf6b83cb5 Don't goto aliased symbol with no declarations; and update tests 2017-05-12 10:26:39 -07:00
Andy Hanson
d6fa91edcd goToDefinition: Skip default and = imports 2017-05-11 15:49:30 -07:00
Andy Hanson
f05a85d56f Fix bug for goto-definition on a TSX constructor using an alias declaration 2017-05-10 15:49:40 -07:00
Andy Hanson
71fb02c099 Support find-all-references for a module specifier 2017-05-10 11:02:17 -07:00
Nathan Shively-Sanders
d35f6c3581 getNameOfDeclaration uniformly, including JS decls
JS-style assignment declarations have a name, but it's not stored on the
name property of the BinaryExpression. This commit adds
`getNameOfDeclaration` to uniformly get the name of a declaration.

It also reworks the declaration of `Declaration` so that accessing
`name` is an error unless the type does *not* include
BinaryExpression.
2017-05-04 16:12:54 -07:00
Andy Hanson
8371eb6401 Update tslint to latest (next is still on 4.3) and lint for BOM 2017-03-01 10:37:13 -08:00
Andy Hanson
7afee8c3ab Fix formatting 2017-02-28 07:55:25 -08:00
Andy Hanson
cc4a3a830f Add check for undefined declarations 2017-02-27 14:18:46 -08:00
Kanchalai Tanglertsampan
2e8f16b96b Fix comments 2017-02-08 17:19:59 -08:00
Kanchalai Tanglertsampan
aea551c3b8 Address code review 2017-02-02 15:00:35 -08:00
Kanchalai Tanglertsampan
989f9d82fd Merge branch 'master' into wip-master-statelessOverload 2017-01-26 12:53:04 -08:00
Andy Hanson
916e67a92c For goToDefinition, verify that tryGetSignatureDeclaration returns a signature declaration and not a FunctionType. 2017-01-25 13:02:02 -08:00
Kanchalai Tanglertsampan
ab2e14f24e Addressing code review in previous PR. Combining below commits
Address comment: fix spelling mistakes

Address comment: calling `checkApplicableSignatureForJsxOpeningLikeElement` from inside `checkApplicableSignature`

Address comment: fix spelling, rename function to be more consistent

Address comment: minor fix indentation, fix function name isObjectLiteralPropertyDeclaration => isObjectLiteralElement

Address PR: gotoDefinition return the last signature when there is an error in statelss function component

Address PR: convert Foreach to for...of

Address comment: fix type, inline code, clarify name of variables
2017-01-19 10:10:03 -08:00
Kanchalai Tanglertsampan
16d1b5dc50 Add language service support for JSXAttributes
Add language service support for JSXAttributes

Add completion support

Add find-all-references support

Add goto-definition support
2017-01-18 15:15:26 -08:00
Andy Hanson
f0e1fd93f7 Merge branch 'master' into map5 2017-01-11 07:17:37 -08:00
Andy Hanson
2124fcf588 goToDefinition: Use the name of a declaration (if possible) when creating DefinitionInfo. 2017-01-09 11:05:53 -08:00
Andy Hanson
6b1cc8972d Use native maps when they're available 2016-12-08 06:40:31 -08:00
Andy Hanson
12f6dcefa1 Revert "Merge pull request #11354 from Microsoft/map4"
This reverts commit adfdae0dc4, reversing
changes made to aad663cebf.
2016-10-27 15:50:21 -07:00
Andy Hanson
aadcbcc083 Use native maps when they're available 2016-10-06 13:29:18 -07:00
Andy Hanson
4d6bd9df72 Break many functions out of services.ts and into their own modules. 2016-09-07 09:22:11 -07:00