10679 Commits

Author SHA1 Message Date
Andy
ec37651308
Use packageId for suggestion to install @types/packageName (#21241) 2018-01-17 14:22:58 -08:00
Ron Buckton
3c988e8f5a
Merge pull request #21215 from Microsoft/fix20461
Fixes var declaration shadowing in async functions
2018-01-17 13:08:18 -08:00
Benjamin Lichtman
8f6c516ef9
Merge pull request #21205 from uniqueiniquity/resolveTripleSlashReferencePaths
Fix Windows-style absolute paths in triple-slash directives
2018-01-17 12:31:46 -08:00
Andy
8ed885db3e
Add completions from the 'this' type (#21231)
* Add completions from the 'this' type

* Code review
2018-01-17 12:05:31 -08:00
Ron Buckton
5b45db7907 PR Feedback 2018-01-17 11:55:43 -08:00
Andy
b363f4f9cd
Log packageId in --traceResolution (#21233) 2018-01-17 11:41:23 -08:00
Ron Buckton
afaa139475 Namespaces do not have the same 'var' scope 2018-01-17 11:30:48 -08:00
Andy
c549bb5737
Fix bug: getNonNullableType before getting signatures of method (#21212) 2018-01-17 11:27:21 -08:00
Ron Buckton
2ba29d8d9d Support labeled statement 2018-01-17 11:24:28 -08:00
Ron Buckton
004f18ff0c
Merge pull request #21219 from Microsoft/fix19020
Fix destructuring assignment when assignment target is RHS
2018-01-17 11:22:30 -08:00
Andy
61fb845b87
Get packageId for relative import within a package (#21130)
* Get packageId for relative import within a package

* Code review

* Rename things and add comments

* Improve documentation

* Test for scoped packages
2018-01-17 11:14:03 -08:00
Daniel
2ca688a87d Remove the colon from the message in tsconfig.json (#21174)
* Add additional diagnostic message for tsconfig.json

* Add a way to override description for tsconfig.json

* Modify reference tsconfig.json in tests

* Don't have to differentiate cmdline and tsconfig.json description

This reverts commit efe57733cac305533c61c7bea3d51b302bbb4d19 and 94f9e67a247f2d73ddff6935083f76812efd2a21.

* Remove colon from diagnostic message code 6079

* Remove colon from localized messages code 6079

* Revert "Remove colon from localized messages code 6079"

Not changing files on src/loc because they are managed using automated tools.

This reverts commit e91f52348e17bf829db2418020c4281203d03e05.
2018-01-17 09:42:40 -08:00
Ron Buckton
c4fddba0a9 Remove duplicate implementations 2018-01-16 17:11:32 -08:00
uniqueiniquity
5320ce2552 Revert path normalization in favor of checking for backslash 2018-01-16 17:04:14 -08:00
Ron Buckton
7a89c963b0
Merge pull request #21217 from Microsoft/fix20146
Symbol-named properties do not need to align with string indexer type
2018-01-16 17:01:27 -08:00
Ron Buckton
dcc5c32abf
Merge pull request #21216 from Microsoft/fix19103
Fix incorrect parenthesization logic for conditional expression branches
2018-01-16 17:00:55 -08:00
Ron Buckton
4aca0c8121 Fix destructuring assignment when assignment target is RHS 2018-01-16 16:58:56 -08:00
Ron Buckton
cd525fb6de
Merge pull request #21206 from Microsoft/fix20744
Fix temp variable emit for names used in nested classes
2018-01-16 16:00:24 -08:00
Ron Buckton
6c9827725c Fix symbol-named properties incorrectly requiring alignment with string indexer type 2018-01-16 15:45:10 -08:00
Ron Buckton
16b13fe449 Fix incorrect parenthesization logic for conditional expression branches 2018-01-16 15:17:04 -08:00
Ron Buckton
136c4d0dda Fixes var declaration shadowing in async functions 2018-01-16 15:02:23 -08:00
Anders Hejlsberg
64b3086f5e
Merge pull request #21157 from Microsoft/fixEmptyArrayInference
Fix empty array inference
2018-01-16 12:42:26 -08:00
Wesley Wigham
154c6141f1
Allow functions to be printed structurally in declaration emit even when they have symbols (#21203)
* Allow functions to be printed structurally in declaration emit even when they have symbols

* Implement CR feedback and fix lint
2018-01-16 12:37:15 -08:00
Ron Buckton
1785d87fda Fix temp variable emit for names used in nested classes 2018-01-16 12:33:55 -08:00
Klaus Meinhardt
7c7651d617 Add overloads for forEach{Leading,Trailing}CommentRange (#21190)
Avoids runtime errors when passing callback with state parameter but not passing a state.
2018-01-16 12:11:05 -08:00
uniqueiniquity
68aad1b85e Normalize triple slash reference paths at resolve time 2018-01-16 11:27:20 -08:00
Wesley Wigham
76d9524866
Fully deprecate the symbol display builder, reimplement in terms of node builder (#18860)
* Remove SymbolWriter, give methods to EmitTextWriter

* Unification of writers is done-ish

* Make node builder support more flags

* Write out mixins like we used to

* Accept prototype-free baselines

* Use instantiated constraint when building mapped type nodes

* Accept better mapped type baselines

* Report inaccessible this in node builder

* Turns out there was a bug in our codefix, too

* Symbol display builder usage falling

* Replace signatureToString with a nodeBuilder solution

* Replace the last internal usages of the symbol writer

* Accept semicolon additions

* Accept updated symbol baseline output

* Start using node builder for some LS operations

* Remove those pesky trailing semicolons on signatures

* Get signature printing much closer to old output

* Parameter lists should not be indented by default, especially when single-line

* Signatures up to snuff

* Type quickinfo emit is up to snuff

* Start of symbol writer replacement, needs a bit more for full compat

* Slightly mor accurate to old behavior

* Replicate qualified name type argument output correctly

* Bring back the old symbol baselines

* Mostly identical to old symbol emit now

* Perfectly matches old behavior thus far

* Replace another usage of the symbol builder

* Another usage removed

* Another usage removed

* Remove final uses of symbol display builder

* Remove implementation and types for unused symbol display builder

* Cleanup in the checker

* monomorphize new emitter code

* Replace emitWithSuffix

* Push space character to interface with writer

* List emit

* Fix lack of usage of emitExpression

* writeList, not printList

* Remove listy writes and replace with new printer calls

* Move ListFormat into types.ts

* Remove most new XToString functions in favor of node builder functions

* Accept API breaks

* Add getSymbolDisplayBuilder polyfill

* Accept updated API baseline

* Move definition to make diff easier to read

* Reinternalize some things

* Remove trailign whitespace

* Reorder for zero diff

* Remove newline

* Make shim mor eperfectly imitate old behavior

* Style feedback

* Rename reset to clear to maintain backcompat with SymbolWriter

* Fix quickfix

* Keep EmitTextWriter internal

* Remove EmitTextWriter from public API

* Mimic default name declaration emit fix

* Fix tests broken by merge

* use isFunctionLike

* Cleanup, sync TypeFormat and NodeBuilder flags

* Reorder Node initialization so pos and end are first, so a TextRange hidden class is made first to reduce future polymorphism

* Use variable instead of ternary

* Write helper for emitNodeWithWriter

* Emitter cleanup

* Cleanup whitespace, comment

* Reuse printer

* Raise error if display parts writer uses rawWrite

* Hide writer parameter through different function instead of overload, rename function in emitter

* Make less printer

* fix lint
2018-01-16 09:53:42 -08:00
Wesley Wigham
2e1738bffa
Enable substitution for object literal shorthand property assignments in the system transform (#21106) 2018-01-12 18:24:41 -08:00
Wesley Wigham
64305edbce
Skip outer expressions when checking for super keyword in binder (#20164)
* Skip outter expressions when checking for super keyword in binder

* use TransformFlags to optimize and correct super call transforms

* Lint
2018-01-12 18:24:02 -08:00
Nathan Shively-Sanders
6f28b0ac25
Merge pull request #21156 from Microsoft/fix-diff-omit
Fix Diff and Omit
2018-01-12 16:10:37 -08:00
Nathan Shively-Sanders
fd1bb9bde2 Group intersection code in getSimplifiedIndexedAccessType 2018-01-12 15:07:46 -08:00
Nathan Shively-Sanders
f1622f0dc6 Use filter instead of unnecessary laziness 2018-01-12 14:56:50 -08:00
Nathan Shively-Sanders
d74820d519 Remove mapped types to never from intersections
when transforming an indexed access type in order to get its constraint.
2018-01-12 14:43:31 -08:00
Nathan Shively-Sanders
12b80f3183 Keep string index from intersections in base constraint of index type 2018-01-11 16:26:38 -08:00
Sheetal Nandi
b529d5ba1f
Merge pull request #21149 from Microsoft/tweakRecompileConditions
Do not trigger resolution cache invalidation if watch is triggered by program file emit
2018-01-11 16:17:09 -08:00
Anders Hejlsberg
1ae0b461f8 Use contra-variant inferences when co-variant inferences yield 'never' 2018-01-11 16:14:19 -08:00
Sheetal Nandi
69bb5ea8f0 Do not trigger the failed lookup location invalidation for creation of program emit files
Handles #20934
2018-01-11 12:34:58 -08:00
Sheetal Nandi
c5ed8646e1 Add test where emit of the file results in invalidating resolution and hence invoking recompile 2018-01-11 12:33:38 -08:00
Andrew Casey
e3da8fb526
Merge pull request #21131 from amcasey/GH15533
Unmangle scoped package names in import completions
2018-01-11 11:03:34 -08:00
Andy
a77c6014b3
Parse comment on @property tag and use as documentation comment (#21119)
* Parse comment on @property tag and use as documentation comment

* Fix comment parsing bug -- back up after seeing `@` character

* Add test for indent

* Don't default comment to ""
2018-01-11 10:49:39 -08:00
Nathan Shively-Sanders
16a8003011 push/popTypeResolution for circular base constraints
Instead of a custom cache `typeStack`.
2018-01-11 10:07:59 -08:00
Nathan Shively-Sanders
7f8ec15edd Merge branch 'master' into fix-recursive-mapped-type-infinite-recursion 2018-01-10 15:44:42 -08:00
Nathan Shively-Sanders
f0ef9a08d8 getConstraintOfTypeParameter:check circularity in base constraint 2018-01-10 15:40:25 -08:00
Andrew Casey
9a4fe8eb7e Rename getPackageNameFromAtTypesDirectoryWithoutPrefix to getUnmangledNameForScopedPackage 2018-01-10 15:17:27 -08:00
Nathan Shively-Sanders
40b896a73c
Merge pull request #17912 from Microsoft/fix2-getConstraintOfIndexedAccess
Fix2 get constraint of indexed access
2018-01-10 15:17:02 -08:00
Nathan Shively-Sanders
8f45373e44 Rename simplifyIndexedAccessType->getSimplifiedIndexedAccessType 2018-01-10 14:43:55 -08:00
Nathan Shively-Sanders
0b23811a56 Handle indexed mapped types in transformIndexedAccessType
Also rename transformIndexedAccessType to simplifyIndexedAccessType
2018-01-10 14:00:52 -08:00
Andy
7a1deae6aa
AsteriskToken should always have length 1 (#21126) 2018-01-10 12:52:35 -08:00
Nathan Shively-Sanders
7dbea0e82d Merge branch 'master' into fix2-getConstraintOfIndexedAccess 2018-01-10 12:40:35 -08:00
Wesley Wigham
ee87cf409b
Print the correct type in the top level chain as the message indicates (#21127) 2018-01-10 11:41:14 -08:00