Arthur Ozga
e4e969a210
respond to comments
2017-08-17 20:06:46 -07:00
Arthur Ozga
6029b5cce8
cleanup
2017-08-16 18:12:28 -07:00
Arthur Ozga
19e2fa6fc5
Merge branch 'master' into isInMultiLineComment
2017-08-16 17:57:04 -07:00
Arthur Ozga
b7bc7d889e
clarify JsxText handling
2017-08-16 17:56:20 -07:00
Arthur Ozga
23ca368020
Use simpler indentation for comments
...
* When in a multi-line comment, we would have liked to use the start of
the comment as a reference point for the indentation inside the comment,
but determining the number of columns shifted for the comment start
woudl require determining the length w/r/t graphemes, which we do not
currently implement. We would like to avoid taking on a runtime
dependency on a grapheme-parsing library.
Instead, we look at the indentation level on the previoud line or start
of the comment as a reference point, and correct shift for lines
starting with an asterisk.
2017-08-16 17:51:29 -07:00
Arthur Ozga
a08d18af57
consolidate isInComment and getRangeOfEnclosingComment
2017-08-15 12:09:43 -07:00
Arthur Ozga
a209db7bb6
dont compute preceding token twice
2017-08-15 12:09:02 -07:00
Arthur Ozga
f3e0cbbd52
findPrecedingToken handles EOF child more gracefully
2017-08-15 12:09:02 -07:00
Arthur Ozga
472ad9d313
findPrevious changes
2017-08-15 12:08:00 -07:00
Arthur Ozga
b2188ad66c
cleanup
2017-08-15 12:08:00 -07:00
Ryan Cavanaugh
eb8f7bddc2
Merge pull request #17796 from basarat/patch-1
...
Fix build 🌹
2017-08-15 11:06:33 -07:00
Andy
10c8d5effa
In services, show the aliasSymbol for a type even if it's not accessible in the current scope ( #17433 )
...
* In services, show the aliasSymbol for a type even if it's not accessible in the current scope
* Rename flag
2017-08-15 10:23:45 -07:00
Basarat Ali Syed
c4dd820564
export interfaces used by exported functions 🌹
2017-08-15 15:19:40 +10:00
Basarat Ali Syed
e7ddaa7d49
export ScopeUsages 🌹
2017-08-15 15:17:19 +10:00
Ron Buckton
09487b8a1d
Added tests, pr feedback
2017-08-11 15:31:09 -07:00
Ron Buckton
e3b6df64b3
Add support to infer the quote style for import quick fixes
2017-08-11 14:26:25 -07:00
Yui
d352e3b03f
[Master] fix 16407 - LS in binding element of object binding pattern ( #16534 )
...
* wip-try get symbol of bindingelement in objectBindingPattern first
* Add fourslash tests
* Update .types baselines
* Update .symbols baselines
* Revert checker changes
* Actually lookup type for binding property name definition
* More succinct check, clarify yui's comment
2017-08-11 11:14:59 -07:00
Ryan Cavanaugh
c27ee81341
Merge branch 'master' into extract-method-2
2017-08-10 17:02:14 -07:00
Ryan Cavanaugh
24de14a9be
Use isReadonlyArray
2017-08-10 16:40:08 -07:00
Ryan Cavanaugh
db37cea0b6
Use the function stack!
2017-08-10 16:38:24 -07:00
Ryan Cavanaugh
a04633c22c
Style fixes
2017-08-10 16:35:32 -07:00
Ryan Cavanaugh
f957429efd
Style fixups
2017-08-10 16:23:17 -07:00
Ryan Cavanaugh
12403d9f70
Various fixes
2017-08-10 13:07:42 -07:00
Arthur Ozga
de92e98770
fix end-of-file assert failure
2017-08-10 10:01:42 -07:00
Andy
17a6f7b56a
Remove unused internal utilities ( #17380 )
...
* Remove unused internal utilities
* Handle undefined input to `mapDefined`
2017-08-09 14:37:59 -07:00
Wesley Wigham
6221d7089e
Fix import addition location ( #17327 )
...
* Add test with bug
* Fix for import placement
* Consolidate comment recognition functions into utilities
* Add another test with all 3 kinds
* Recognize path directives as part of triple slash directives
* Also handle no-default-lib triple-slash comments
* Test for all the triple-slash kinds
* Keep import-placement logic in the quickfix, since its not really a node start; accept new baselines
* Work in not-ES6, use a real no-lib comment
* Remove no default lib triple slash comment, it disables checking and thereby quick fixes
* Copy regex rather than have a regex copy
2017-08-09 14:03:37 -07:00
Andy
e73d58e21c
findAllReferences: Type parameter is not globally visible ( #16419 )
...
* findAllReferences: Type parameter is not globally visible
* Add test for merged interface
* Clean up comment
2017-08-09 13:53:54 -07:00
Arthur Ozga
7c402d509d
Merge branch 'master' into isInMultiLineComment
2017-08-09 10:49:12 -07:00
Ron Buckton
83ae8afef8
Merge pull request #17394 from vvakame/openParentFormatting
...
Add SpaceBetweenOpenParens formatting rule
2017-08-08 13:04:13 -07:00
Andy
5141ce751d
Deduplicate unresolvedImports ( #17248 )
...
* Deduplicate unresolvedImports
* Add `isNonDuplicateInSortedArray` helper
2017-08-08 11:02:10 -07:00
Andy
ceae613e4c
Add lint rule to check that Debug.assert calls do not eagerly interpolate strings ( #17125 )
...
* And lint rule to check that `Debug.assert` calls do not eagerly interpolate strings
* Use more specific 'assert' functions to avoid callbacks
* Respond to PR feedback
2017-08-08 07:56:14 -07:00
Arthur Ozga
2f5b1d3e18
Merge branch 'master' into isInMultiLineComment
2017-08-07 15:58:46 -07:00
Arthur Ozga
091376f46f
supressFormatOnKeyInComments
2017-08-07 15:45:56 -07:00
Ron Buckton
31230b9176
Merge pull request #16953 from charlespierce/destructure_completion_nonpublic
...
Remove nonpublic members from destructuring completion lists
2017-08-07 14:24:47 -07:00
Ryan Cavanaugh
c7f665faa1
Extract Method (squash)
2017-08-04 16:10:33 -07:00
Arthur Ozga
777bc575ac
implementation comment
2017-08-04 15:51:06 -07:00
Arthur Ozga
efdbebaebb
Merge branch 'master' into isInMultiLineComment
2017-08-04 14:26:24 -07:00
Andy
4f13bcfac1
Fix find-all-references for destructured getter ( #17483 )
...
* Fix find-all-references for destructured getter
* Handle setter too
* Use SymbolFlags.Accessor
2017-08-02 06:51:26 -07:00
Mine Starks
84c579586c
Merge pull request #17536 from minestarks/fix15223
...
Missing import codefix: Take scoped packages (@foo/bar) into consideration
2017-07-31 14:09:37 -07:00
Mine Starks
16112c358d
Missing import codefix: Take scoped packages (@foo/bar) into consideration
2017-07-31 13:28:55 -07:00
Andy
476157fab8
jsTyping: Better logging for addInferredTypings ( #17249 )
...
* jsTyping: Better logging for addInferredTypings
* Fix tests
* Indent other log under "Searching for typing names"
2017-07-28 12:43:50 -07:00
Daniel Rosenwasser
afdbf00d53
Add check to ensure that property access suggestions are only performed on the accessed property.
2017-07-27 18:12:20 -07:00
Daniel Rosenwasser
65650253cf
Merge pull request #17462 from Microsoft/codeFixForErrorForPropertyOfTypeAsType
...
Quick fix to correct qualified names to indexed access types
2017-07-27 15:32:49 -07:00
Daniel Rosenwasser
0dc74245e2
Added codefix for replacing qualified names with indexed access types.
2017-07-27 12:42:11 -07:00
Andy
3330f2a33b
JsTyping: Remove "safeList" global variable ( #17304 )
2017-07-27 10:54:47 -07:00
Mine Starks
89994111bd
Missing import code fix - include export assignment properties when looking for module exports ( #17376 )
...
* Include export assignment properties when looking for module exports
* Create new API function for tryGetMemberInModuleExportsAndProperties
* Cleanup based on review feedback
2017-07-26 16:17:01 -07:00
Nathan Shively-Sanders
9fd90e7e02
Merge branch 'master' into jsdoc-param-type-literals
2017-07-26 11:09:24 -07:00
Nathan Shively-Sanders
fde4c188ac
Address more PR comments
2017-07-26 10:57:29 -07:00
Andy
30d973bdcb
Rename symbol.name to escapedName and make name unescaped ( #17412 )
2017-07-25 14:22:26 -07:00
Nathan Shively-Sanders
c55a043767
Address PR comments from Andy
...
I'll take a look at Wesley's next and see if those require any changes.
2017-07-25 14:14:12 -07:00
