63 Commits

Author SHA1 Message Date
Sheetal Nandi
e31aa9e12a Added more comments and todos as per code review feedback 2014-08-06 11:26:34 -07:00
Sheetal Nandi
0e76a82072 Fix the incorrect error reporting and declaration file emit for the type parameter constraint of private methods
Also incorporates code review feedback
2014-08-04 12:06:07 -07:00
Sheetal Nandi
9fd95fcb95 Report errors if the type parameter uses constraint that is using private type/module
Fixes #86
2014-07-18 18:11:04 -07:00
Sheetal Nandi
09ec1bb9ae Report error on Class/Interface heritage clause if it cant be accessed
Fixes #78 and #83
2014-07-18 18:07:38 -07:00
Sheetal Nandi
999b7fed92 Checker and emitter changes to report errors on inaccessibility of symbols when writing types in declaration file 2014-07-18 18:06:37 -07:00
Sheetal Nandi
bbb36dc933 Make the symbol writing api on the text writer 2014-07-18 17:50:12 -07:00
Daniel Rosenwasser
1ec29c6557 Addressed code review feedback. 2014-07-18 16:55:20 -07:00
Daniel Rosenwasser
819ea95953 Better error recovery for when an arrow function is missing a curly brace.
Also better identification of arrow function expressions.
2014-07-18 16:55:18 -07:00
Sheetal Nandi
1abedc30c4 Merge pull request #142 from Microsoft/declFileErrorReporting
Compile the generated decl files and report those errors in the baseline so we can verify the result of dts file for correctness
2014-07-18 12:42:07 -07:00
Sheetal Nandi
e0ce0e97d5 Updating with code review feedback 2014-07-18 12:32:27 -07:00
Mohamed Hegazy
91b8a4531f Merge pull request #145 from Microsoft/restConstructorParam
Issue #144: Do not emit the name of the rest paramter in constructors
2014-07-18 09:57:49 -07:00
Mohamed Hegazy
c9c0166b04 fix typo in function name 2014-07-18 09:56:18 -07:00
Sheetal Nandi
2c7946ee00 Pulled out the d.ts compilation into separate it block 2014-07-17 22:43:59 -07:00
Sheetal Nandi
3665e45d19 Merge pull request #141 from Microsoft/typoInDeclFileEmit
Fixed the typo in declaration emitter of implements clause
2014-07-17 22:21:51 -07:00
Mohamed Hegazy
b744633656 Issue# 144: Do not emit the name of the rest paramter in constructors 2014-07-17 19:54:21 -07:00
Sheetal Nandi
d09e5508e2 Report global errors and re-enable assert for the number of errors reported 2014-07-17 18:16:40 -07:00
Sheetal Nandi
8936662090 Enable compiler runner to report the errors from compiling generated declaration files 2014-07-17 18:16:32 -07:00
Sheetal Nandi
586b773fbe Fixed the typo in declaration emitter of implements clause 2014-07-17 18:16:24 -07:00
Vladimir Matveev
4068404cd4 emit prologue directives as first lines in file 2014-07-17 17:43:48 -07:00
Vladimir Matveev
b9372a1aa2 Merge pull request #137 from Microsoft/referencecomments
relax the restrictions to reference comment shape, fixes #50
2014-07-17 15:46:58 -07:00
Vladimir Matveev
cd9a4347ed relax the restrictions to reference comment shape 2014-07-17 14:44:19 -07:00
Vladimir Matveev
f1ce09caa3 do not propagate function name in property accessors 2014-07-17 14:18:24 -07:00
Sheetal Nandi
43ce1511b7 Merge pull request #35 from Microsoft/emitRefactor
Moved the emit functionality into emitFiles so emitJavascript and emitDeclarations can share the data and methods without having to pass around data
2014-07-17 12:55:54 -07:00
Sheetal Nandi
96700069fc renamed isEmitToOwnFile to shouldEmitToOwnFile as per feedback 2014-07-17 12:53:07 -07:00
Daniel Rosenwasser
df5c2547fa Support automatic semicolon insertion in class member declarations. 2014-07-17 11:03:12 -07:00
Sheetal Nandi
b7feb1555b Renamed emitToOwnOutputFile to isEmitToOwnOutputFile 2014-07-17 09:27:28 -07:00
Vladimir Matveev
2b8f04af0c do not check inherited properties if interface has one item in heritage list 2014-07-16 22:53:53 -07:00
Anders Hejlsberg
6b112b1a46 Merge branch 'master' into MergingErrors
Conflicts:
	src/compiler/checker.ts
2014-07-16 16:31:08 -07:00
Anders Hejlsberg
70f8057dc7 Addressing code review feedback. 2014-07-16 16:14:29 -07:00
Sheetal Nandi
d9196d66b6 Moved the emit functionality into emitFiles 2014-07-16 15:39:14 -07:00
Jason Freeman
b8c96a2bcd Remove assert 2014-07-16 15:22:14 -07:00
Sheetal Nandi
fe1fea3710 Merge pull request #30 from Microsoft/declarations
Changes to determine when to qualify the symbol in given enclosing declaration
2014-07-16 15:20:00 -07:00
Daniel Rosenwasser
5ae265b755 Removed unnecessary check for commas in 'parseDelimitedList'. 2014-07-16 15:06:05 -07:00
Daniel Rosenwasser
cece68098a Better error recovery when errant semicolon found in a class. 2014-07-16 15:06:03 -07:00
Sheetal Nandi
1bb219a3dd Incorporating code review feedback 2014-07-16 14:50:37 -07:00
Anders Hejlsberg
e4ea5ef1f9 Fix for 954635: Clodule declaration ordering
Fix for 955714: Fundule declaration ordering
2014-07-16 14:23:39 -07:00
Daniel Rosenwasser
9ecf01b57a When importing, only check for reserved type names when importing a type. 2014-07-16 14:08:15 -07:00
Jason Freeman
2af62a9912 Error for more than one enum omitting an initial initializer 2014-07-16 13:50:08 -07:00
Jason Freeman
17563f3c5d Remove SymbolLinks.typeChecked 2014-07-16 13:34:27 -07:00
Anders Hejlsberg
f3f5993770 Incorporating code review feedback. 2014-07-16 11:46:25 -07:00
Sheetal Nandi
148abea09d Use the isDeclarationVisible in checker to determine if the declaration needs to be emitted
This would help in unifying logic of when to check if the type is visible
2014-07-16 11:37:49 -07:00
Sheetal Nandi
5a23dd0684 Check if accessible symbol needs futher qualification 2014-07-16 11:30:38 -07:00
Sheetal Nandi
d8f3481d38 Check if there is alias symbol in the scope corresponding to the symbol whose name we are trying to get in the symbol table 2014-07-16 11:30:34 -07:00
Sheetal Nandi
2273355df4 Start emitting qualified path if the current symbol is not visible in enclosing declaration
Note that this doesnt handle aliases yet.
2014-07-16 11:30:14 -07:00
Anders Hejlsberg
c1d0fd979d More I/O fixes
Support for --charset command line option
File read and write errors are propagated into compiler diagnostics
emitFiles returns diagnostics in EmitResult
2014-07-16 10:57:05 -07:00
Sheetal Nandi
6a68b3744c Do not emit arrow style call signatures when writing T of T[] 2014-07-15 13:08:13 -07:00
Sheetal Nandi
574c075dba Emit the types in declaration file 2014-07-15 13:08:10 -07:00
Daniel Rosenwasser
c777d5c68a Report error on unclosed multiline comment.
Fixes #22
2014-07-15 12:21:16 -07:00
Sheetal Nandi
455364cf5a Do not emit the signature for implementation of overload in the declaration file 2014-07-15 08:58:02 -07:00
Sheetal Nandi
d1cdf03d53 Correct the external module check to determine if declaration is part of export assignment 2014-07-15 08:57:48 -07:00