Commit Graph

15228 Commits

Author SHA1 Message Date
Wesley Wigham
dd933f4413 Fix get symbol at location to behave correctly for parameter assignments and jsx attributes (#20706)
* Fix get symbol at location to behave correctly got parameter assignments and jsx attributes

* Handle all those edge cases that weren;t explicitly handled

* Fix part of bug WRT getTypeAtLocation and for loops

* Baseline corrections pursuant to #20710

* Restore jsdoc tag interpretation

* Clean up some code, revert fourslash tests

* Cleanup types used by PR feedback
2017-12-15 15:50:22 -08:00
Andrew Casey
a3ab1ffcff Merge pull request #20713 from amcasey/GH19165
Stop assuming code fix test changes are in the originating file
2017-12-15 14:21:57 -08:00
Wesley Wigham
d89d68f426 make jsx attributes mutable locations (#20710) 2017-12-15 10:02:56 -08:00
csigs
ed4bd2e5ab LEGO: check in for master to temporary branch. 2017-12-15 11:10:31 +00:00
Andrew Casey
8b0988543b Stop assuming code fix test changes are in the originating file
Triggering a fix in one file can result in changes in another file.
Instead of passing around the originating file, retrieve an appropriate
`ScriptInfo` for each `FileTextChanges`.

Fixes #19165
2017-12-14 16:50:28 -08:00
csigs
be1d6da123 LEGO: check in for master to temporary branch. 2017-12-14 23:10:37 +00:00
Benjamin Lichtman
26c1a49d59 Merge pull request #20640 from uniqueiniquity/revertToJsDocInclusionList
Revert to inclusion list for JsDoc comment completion
2017-12-14 14:37:31 -05:00
csigs
f6a383e3e4 LEGO: check in for master to temporary branch. 2017-12-14 17:10:08 +00:00
csigs
309468396d LEGO: check in for master to temporary branch. 2017-12-14 11:10:40 +00:00
csigs
064d9345e1 LEGO: check in for master to temporary branch. 2017-12-14 05:10:09 +00:00
csigs
5299e91be3 LEGO: check in for master to temporary branch. 2017-12-13 23:10:50 +00:00
Wesley Wigham
e1278f091c Get resolved module exports in symbol chain and not raw exports (#20661)
* Actually get module exports and not module exports sans export stars

* style update

* Trim test a bit
2017-12-13 14:01:23 -08:00
Wesley Wigham
2c6501db52 Allow multiple star-star globs in one pattern (#20639)
* Allow multiple starglobs in one pattern

* Add extra test case
2017-12-13 12:57:16 -08:00
Ryan Cavanaugh
f6603cd9f2 Merge pull request #20545 from RyanCavanaugh/codefixOmnibus
Omnibus fixes for telemetry-sourced crashes
2017-12-13 12:49:58 -08:00
Ryan Cavanaugh
8f8e6a36a7 Merge pull request #20679 from RyanCavanaugh/removeLibTodo
Remove TODO from lib.d.ts
2017-12-13 12:49:40 -08:00
Andy
84eb25c561 Handle arrays with properties in assert.deepEqual (#20674)
* Handle arrays with properties in assert.deepEqual

* Fix tests
2017-12-13 11:50:53 -08:00
Ryan Cavanaugh
100262537a Remove TODO 2017-12-13 10:58:04 -08:00
Ryan Cavanaugh
65e92c624b Merge pull request #20664 from RyanCavanaugh/clearResolutionCache
Clear the module resolution cache when new @types appear
2017-12-13 09:40:16 -08:00
Wesley Wigham
79a1240a19 Revert merge pull request #20429 (removing chai) (#20654)
* Revert "Merge pull request #20429 from Microsoft/unchai"

This reverts commit 66ec938164, reversing
changes made to 37a40561ac.

* Update lockfile
2017-12-13 06:49:50 -08:00
csigs
7125cad406 LEGO: check in for master to temporary branch. 2017-12-13 11:10:32 +00:00
csigs
dbceefd05a LEGO: check in for master to temporary branch. 2017-12-13 05:10:08 +00:00
Ryan Cavanaugh
9e122d0305 Fix test 2017-12-12 17:22:41 -08:00
Wesley Wigham
40029a0523 Use TypeFlags.UnionOrIntersection not TypeFlags.Union (#20662) 2017-12-12 16:32:55 -08:00
Ryan Cavanaugh
bd3a27ed52 Clear the module resolution cache when new @types appear 2017-12-12 16:11:37 -08:00
csigs
ef23eb71be LEGO: check in for master to temporary branch. 2017-12-12 23:11:33 +00:00
Andy
8ad4aeece1 Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter (#20574)
* Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter

* Don't require newLineCharacter as input to ChangeTracker methods, and make it private again
2017-12-12 12:23:13 -08:00
Andy
21ff2cd501 Remove unnecessary getFirstChildOfKind helper function (#20647) 2017-12-12 11:25:58 -08:00
Nathan Shively-Sanders
e58d80ad83 Merge pull request #20648 from Microsoft/nonprimitive-spreads-to-empty-object
Non-primitive spreads to empty object
2017-12-12 10:56:21 -08:00
csigs
ea1e4102f5 LEGO: check in for master to temporary branch. 2017-12-12 17:10:08 +00:00
Nathan Shively-Sanders
43a5a271ee object spreads to {}
Specifically, when spreading `object` on the right, spread now returns the
left of the spread; previously it returned `object`, which loses
everything to the left.
2017-12-12 08:34:36 -08:00
Andy
d53af092c7 Always check a return expression in a generator (#20621) 2017-12-12 07:50:11 -08:00
uniqueiniquity
97a573984f Add type alias declarations to inclusion list docs 2017-12-11 16:15:32 -08:00
uniqueiniquity
03b036b630 Revert "Loosen restrictions on jsdoc completion locations"
This reverts commit 612616a105.
2017-12-11 15:56:31 -08:00
csigs
72f2136080 LEGO: check in for master to temporary branch. 2017-12-11 23:11:30 +00:00
Yuichi Nukiyama
792b8bb78e Fix error messeage (#20601)
* Fix error messeage

* delete extra lint
2017-12-11 18:05:49 -05:00
Wesley Wigham
eba15b5990 Preserve literal types in contextual unions (#19966)
* Cherrypick non-comparability related changes from prolific literals PR

* Renames and other style changes

* Accept changes to new tests

* Exclude the domain root from contextual typing literals except for type variables

* Readd simple preservation fix

* Add huge map test

* Revert changes to widening on destructuring initalizers

* Use tristate for subtype-reduction type

* Rename type and argument

* Move longer-running test to user suite
2017-12-11 18:03:38 -05:00
Wesley Wigham
d01f4d140a Reimplement #20320 differently to handle multiple check orders better (#20588)
* Reimplement #20320 less elegantly but handle odd check orders better

* Consolidate 2 of 3 conditions
2017-12-11 13:32:16 -05:00
Andy
484758a3d3 Handle ! following a keyword in isClassMemberStart (#20617)
* Handle `!` following a keyword in isClassMemberStart

* Fix test
2017-12-11 09:45:36 -08:00
Andy
b629ff4204 Fix bug: FunctionDeclaration may have missing name (#20618) 2017-12-11 09:45:20 -08:00
csigs
73d7de6b8f LEGO: check in for master to temporary branch. 2017-12-11 17:10:08 +00:00
Wesley Wigham
9e51882d9c Numeric separators (#20324)
* Add support into octal and binary literals

* Add hex support

* And finally support all numeric literals and fix spelling

* Update error message

* Refactor error in scanner to take a position

* Scan no separators in escape sequences, add escape sequence tests

* More decimal tests from the spec presentation examples

* Permissive scanning of excess separators

* Remove unnecessary assignment

* Make code easier to follow
2017-12-08 20:20:18 -05:00
csigs
2343cbb43c LEGO: check in for master to temporary branch. 2017-12-08 23:10:14 +00:00
Andy
47c1fc4022 Remove unused internal function (#20582) 2017-12-08 14:06:23 -08:00
csigs
de304f537e LEGO: check in for master to temporary branch. 2017-12-08 17:10:26 +00:00
Daniel Rosenwasser
8d209a3672 Merge pull request #20467 from Kovensky/array-from-union-fix
Accept Iterable|ArrayLike union in Array.from, add tests
2017-12-07 17:22:05 -08:00
Daniel Rosenwasser
53657069bc Merge pull request #20517 from gagoman/16900
fix docs for Math.ceil and Math.floor (#16900)
2017-12-07 16:56:27 -08:00
Nathan Shively-Sanders
f90943d0d0 Merge pull request #20543 from Microsoft/in-keyword-narrow-string-indexer
Narrowing of `in` handles string index signatures
2017-12-07 15:45:00 -08:00
csigs
158970497e LEGO: check in for master to temporary branch. 2017-12-07 23:10:20 +00:00
Ryan Cavanaugh
92c3b23a32 Bail at the correct point when containingFunction is undefined 2017-12-07 14:27:46 -08:00
Ryan Cavanaugh
fa988eacbd Fixes #20475 (no repro found yet) 2017-12-07 12:39:17 -08:00