6185 Commits

Author SHA1 Message Date
Mine Starks
fd2dd2edc0 Merge pull request #17078 from minestarks/removeimportfix
Code fix to remove unused named import should preserve default import
2017-07-13 10:53:35 -07:00
Andy
69d3ca774a When adding completions for a module, don't get the type of the module if not necessary. (#16768)
* When adding completions for a module, don't get the type of the module if not necessary.

* Use SymbolFlags.Module alias
2017-07-13 09:20:40 -07:00
Yui
1c93531f0f Merge pull request #17025 from Microsoft/master-16763
[Master] Fix 16763
2017-07-12 16:36:04 -07:00
Mine Starks
abb229e91b Add a bit more validation around comments 2017-07-12 11:14:48 -07:00
Nathan Shively-Sanders
50f39102aa Merge pull request #17096 from Microsoft/improve-return-type-parse-error
Improve return type parse error
2017-07-12 07:18:23 -07:00
Yui
25f4e46638 Merge pull request #17082 from Microsoft/master-16201
[Master] Fix 16201: fix cannot find "object"
2017-07-11 17:13:01 -07:00
Mine Starks
80b64de1e4 Fix comment behavior in remove unused named bindings 2017-07-11 14:53:08 -07:00
Mine Starks
003c28f1ef Fix caret update logic in fourslash tests 2017-07-11 14:52:41 -07:00
Nathan Shively-Sanders
3638ff19b3 Test:better error for wrong return token (: vs =>) 2017-07-11 10:16:35 -07:00
Andy
f45ccf541d In getDeclarationSpaces, treat a type alias as a SymbolFlags.Type, not a SymbolFlags.Value (#16624) 2017-07-11 09:54:42 -07:00
Andy
af147d15d6 Fix typo (#17064) 2017-07-11 07:24:40 -07:00
Andy
aa2d1008bf Completion for default export should be '.default' (#16742)
* Completion for default export should be '.default'

* Don't include empty string in name table

* getSymbolsInScope() should return local symbols, not exported symbols

* Fix bug: getSymbolAtLocation should work for local symbol too
2017-07-11 07:23:32 -07:00
Kanchalai Tanglertsampan
7ae4ff3b3d Add tests and update baselines 2017-07-10 15:24:03 -07:00
Mine Starks
39e4b1f9e3 Code fix to remove unused import should preserve default import 2017-07-10 14:23:18 -07:00
Kanchalai Tanglertsampan
f15909bfe0 Merge branch 'master' into master-16763 2017-07-10 13:13:35 -07:00
Andy
12163cc02e Allow to narrow the type of an import (#16658)
* Allow to narrow the type of an import

* Assume alias is initialized
2017-07-10 09:18:35 -07:00
Kanchalai Tanglertsampan
1ac95c29e4 Add tests and update baselines 2017-07-07 15:53:55 -07:00
Andy
ba8e5a7e24 Never return undefined from getExportsOfModule (#17013) 2017-07-07 10:06:12 -07:00
Wesley Wigham
4e6b2f3c93 Created a branded type for identifier-escaped strings (#16915)
* Created a branded type for escaped strings

Then flowed it throughout the compiler, finding and fixing a handful of
bugs relating to underscore-prefixed identifiers in the process.
Includes a test for two cases noticed - diagnostics from conflicting
symbols from export *'s, and enum with underscore prefixed member emit.

* Correctly double underscores WRT mapped types

* Add fourslash tests for other fixed issues

* use function call over cast

* Update forEachEntry type accuracy

* Just use escaped names for ActiveLabel

* Remove casts from getPropertyNameForPropertyNameNode

* This pattern has occurred a few times, could use a helper function.

* Remove duplicated helper

* Remove unneeded check, use helper

* Identifiers list is no longer escaped strings

* Extract repeated string-getting code into helper

* Rename type and associated functions

* Make getName() return UnderscoreEscapedString, add getUnescapedName()

* Add list of internal symbol names to escaped string type to cut back on casting

* Remove outdated comments

* Reassign interned values to nodes, just in case

* Swap to string enum

* Add deprecated aliases to escapeIdentifier and unescapeIdentifier

* Add temp var

* Remove unsafe casts

* Rename escaped string type as per @sandersn's suggestion, fix string enum usages

* Reorganize double underscore tests

* Remove jfreeman from TODO

* Remove unneeded parenthesis
2017-07-06 14:45:50 -07:00
Arthur Ozga
ad291d924d Merge pull request #16748 from aozgaa/implementOptionCrash
visit question token
2017-07-06 13:51:15 -07:00
Arthur Ozga
dc08c5f241 Merge branch 'master' into caretPositionInFourslash 2017-07-06 10:44:59 -07:00
Arthur Ozga
d661622e19 update tests 2017-06-30 19:41:09 -07:00
Nathan Shively-Sanders
9048c0ae47 Merge pull request #16844 from Microsoft/codefix-spelling-correction-for-typeparameters
Spelling code fix: suggestions from apparent type
2017-06-30 12:56:18 -07:00
Nathan Shively-Sanders
abec46ce48 Test:spelling suggestions for more types
Test spelling suggestions for primitives, unions/intersections and type
parameters with constraints.
2017-06-30 10:12:02 -07:00
Nathan Shively-Sanders
e0bf267029 spelling:getPropertiesOfType instead of objectType
This provides suggestions for more types based on their apparent type:
unions, type parameters with constraints, primitives.
2017-06-30 10:11:00 -07:00
Arthur Ozga
4e6e1d1b8b Merge pull request #16657 from aozgaa/formatOnOpenCurly
Format on open curly
2017-06-30 10:04:57 -07:00
Nathan Shively-Sanders
f45df8fb69 Spelling code fix:suggestions from apparent type
The code fix for spelling correction needs to provide suggestions based
on the apparent type since sometimes the type at a location will be a type
parameter. One such example is `this`.

Fixes #16744
2017-06-29 16:21:00 -07:00
Ryan Cavanaugh
ec00bb9b72 Merge pull request #16697 from RyanCavanaugh/preserveMethodComments
Preserve method comments in JS->ES6 conversion.
2017-06-29 15:40:16 -07:00
Ryan Cavanaugh
277f4592c1 Add tests 2017-06-29 15:14:09 -07:00
Daniel Rosenwasser
22f38b720c Merge pull request #16704 from charlespierce/namespace_export_default
Diagnostics for default class / function export in namespace
2017-06-28 17:10:45 -07:00
Andy
2ccfe502f7 Fix scope of @typedef references (#16718)
* Fix scope of @typedef references

* Remove unused variables
2017-06-28 13:30:23 -07:00
Arthur Ozga
eae234cab2 disable spaceBeforeOpenCurly if newline rule is enabled 2017-06-28 13:13:53 -07:00
Andy
42e08f5578 findAllRefs: Find string references inside of template strings (#16723) 2017-06-28 12:53:12 -07:00
Nathan Shively-Sanders
c51c2aecca Merge pull request #16736 from DickvdBrink/issue/15208
Also check TypeAlias for unused type parameters
2017-06-28 12:37:04 -07:00
Nathan Shively-Sanders
2f5ecf00a1 Merge pull request #16698 from Microsoft/master-16017
[Master]  Fix 16017 - ordering of promise all method
2017-06-28 10:46:53 -07:00
Andy
18357543c6 Provide better services for incomplete generic calls (#16535)
* Provide better services for incomplete generic calls

* Use clearer name

* Remove `inferredAnyDefaultTypeArgument` and `getBestGuessSignature`; have `resolveSignature` always get the best signature if !produceDiagnostics

* Update names and comments
2017-06-27 09:14:23 -07:00
Arthur Ozga
45a77c0a2c visit question token 2017-06-26 12:33:29 -07:00
Arthur Ozga
61af315778 respond to comments 2017-06-26 10:55:04 -07:00
Ryan Cavanaugh
b52747e12c Add property comments as well 2017-06-26 10:54:18 -07:00
Charles Pierce
386454a255 #16300 #16301 Diagnostics for default export in namespace 2017-06-22 20:20:41 -07:00
Nathan Shively-Sanders
6a111928b4 Merge pull request #16375 from Microsoft/skip-block-scope-for-global-symbol
Skip block scope check for global symbol
2017-06-22 15:29:35 -07:00
Kanchalai Tanglertsampan
77d69c8c1d Add tests and update baselines 2017-06-22 11:56:49 -07:00
Ryan Cavanaugh
04d750f9f8 Preserve method comments in JS->ES6 conversion. Fixes #16622 2017-06-22 11:45:34 -07:00
Yui
3ade89ca0e Merge pull request #16178 from Microsoft/master-fix13306
[Master] Fix #13306 recognize @type on property assignment
2017-06-22 11:25:22 -07:00
Arthur Ozga
f9592b6479 fix and add test 2017-06-22 11:17:38 -07:00
Dick van den Brink
33224747b3 Added test for unused typeparameters in a typealias declaration 2017-06-22 16:45:09 +02:00
Arthur Ozga
28fce55e1f add and update tests 2017-06-20 11:52:05 -07:00
Yui
47c1563649 Merge pull request #16544 from Microsoft/master-fixIncrementalParsingWithDynamicImport
[Master] wip - fix incremental parsing with dynamic import
2017-06-19 16:44:47 -07:00
Kanchalai Tanglertsampan
8038300380 Add tests 2017-06-19 16:18:42 -07:00
Sheetal Nandi
31653de3c3 Merge pull request #16566 from Microsoft/keywordFilters
Fix the completion for parameters
2017-06-15 15:44:33 -07:00