Commit Graph

1852 Commits

Author SHA1 Message Date
Andy
2a70bf5158 Don't count a write-only reference as a use (#17752)
* Don't count a write-only reference as a use

* Split isWriteAccess to isWriteOnlyAccess and isReadOnlyAccess

* Update "unusedParameterUsedInTypeOf" to use "b"

* Update diagnostic messages: "is never used" -> "its value is never read"

* Use a WriteKind enum

* Rename enum and move documentation to enum members
2017-09-13 09:02:33 -07:00
Andy
c3199c7772 extractMethod: Support renameLocation (#18050)
* extractMethod: Support renameLocation

* Add tslint disable

* Properly analyze list of changes to always get a correct rename location

* Update test

* Ensure name is really unique

* Improvements to test code

* Respond to PR comments
2017-09-13 09:02:10 -07:00
Andrew Casey
62899d10cd Add simple baseline tests for insertion positions 2017-09-08 16:45:47 -07:00
Andrew Casey
73bc0c9796 Correct copied comment 2017-09-07 16:22:09 -07:00
Andrew Casey
e3808b65d4 Simplify and correct PermittedJumps computation
1. It was looking at the parent which wasn't guaranteed to be in the
extracted range.
2. It was checking direct, rather than indirect containment - apparently
to avoid applying the rules to certain expressions (which can't contain
jumps anyway, unless they're in anonymous functions, in which case
they're fine).

Fixes #18144
2017-09-07 16:21:20 -07:00
Andrew Casey
0e50da62c4 Handle the combination of a write and a void return
When the return type is void, there's no `returnValueProperty`, but that
doesn't mean we don't need a `return` at the call site.

Fixes #18140.
2017-09-07 14:43:02 -07:00
Andy
2e02778960 When loading a module from node_modules, get packageId even in the loadModuleFromFile case (#18185)
* When loading a module from node_modules, get packageId even in the `loadModuleFromFile` case

* Support packageId for <reference types> too
2017-09-07 14:31:20 -07:00
Wesley Wigham
6695255d86 Allow trailing newline to have fake position (#18298)
* Actually support baselining pretty in the harness

* Test case from 18216

* Use host newline in formatDiagnosticsWithColorAndContext

* Merge statements
2017-09-07 12:26:23 -07:00
Wesley Wigham
39d0590869 Adds comment 2017-09-07 09:54:50 -07:00
Andy
193f4be355 Enable interface-over-type-literal lint rule (#17733) 2017-09-07 09:14:59 -07:00
Andy
8c714c3651 Support special JS property assignments in doc comment templates (#18193) 2017-09-07 07:21:47 -07:00
Wesley Wigham
72cbc12c9a Allow undefined/null to override all parameters (#18058) 2017-09-06 22:08:42 -07:00
Wesley Wigham
ed61d2d803 Emit updated export declarations when transformed from export * (#18017)
* Failing test for missing transform output

* dont elide all export stars

* Remove comment from test

* Refuse to perform ellision on transformed nodes
2017-09-06 21:58:04 -07:00
Wesley Wigham
5c779b1edb Allow singleline string writer to be recursively used (#18297)
* Allow singleline string writer to be recursively used

* Add unit test exposing issue

* Fix lints
2017-09-06 21:56:16 -07:00
Andy
36607e1bde Allow quoted names in completions (#18162)
* Allow quoted names in completions

* Don't allow string literal completions if not in an object literal; and use string literals for number keys

* Add TODO
2017-09-06 14:39:53 -07:00
Matt Bierner
c7b4ed3a91 Fix extract method for anon class expressions (#18168)
Check `scope.name` when trying to extract from an anon class
2017-08-31 13:21:08 -07:00
Ryan Cavanaugh
d7b3b6c77d Merge pull request #18120 from RyanCavanaugh/fix457864
Don't crash when a JS file appears in an inferred context
2017-08-29 14:18:47 -07:00
Ryan Cavanaugh
0e2d399c49 Don't crash when a JS file appears in an inferred context 2017-08-29 13:29:56 -07:00
Andrew Casey
c9f6bc60e2 Test coupling of type parameters 2017-08-29 11:24:07 -07:00
Andrew Casey
e08dce2c21 Test different parameters on classes and methods 2017-08-29 11:24:06 -07:00
Andrew Casey
01d7f0b699 Test that the return type of the extracted method counts as usage 2017-08-29 11:24:05 -07:00
Andrew Casey
0c8d85fbc4 Test that type parameters used in constraints are passed along 2017-08-29 11:24:04 -07:00
Andrew Casey
fe015ef30f Document failure to handle type parameter shadowing 2017-08-29 11:24:04 -07:00
Andrew Casey
b09d2277b8 Test that in-scope type parameters are not passed explicitly 2017-08-29 11:24:03 -07:00
Andrew Casey
ee80019d16 Switch from .js to .ts so that baselines are syntactically valid 2017-08-29 11:15:58 -07:00
Andrew Casey
b2cc722483 Comment out headers in Extract Method baselines 2017-08-29 11:15:54 -07:00
Wesley Wigham
3ea031cf1c Fix RWC - use replayLog, not recordLog (#18095) 2017-08-28 15:45:21 -07:00
Daniel Rosenwasser
a60b1037f8 Merge pull request #18077 from fwouts/regex-bug
Fix #18071: Printer failure when encountering RegularExpressionLiteral
2017-08-28 14:10:29 -07:00
Wesley Wigham
117ef21bfc Always use case-insensitive fs operartions for RWC (#18046)
* Always use case-insensitive fs operartions for RWC

* wrappedIO handles case sensitivity checks
2017-08-28 10:23:41 -07:00
Francois Wouts
170bc6f519 Add test for #18071 2017-08-28 08:14:08 +10:00
Ron Buckton
eb75619cda Merge pull request #18051 from Microsoft/fix17551
Fix crash in name resolution with custom transforms and emitDecoratorMetadata
2017-08-25 15:14:21 -07:00
Ron Buckton
bdfb92aebe Fix crash in name resolution with custom transforms and emitDecoratorMetadata 2017-08-25 14:17:48 -07:00
Andy
3a0ab74ed6 Test for action description of code actions, and simplify description for extracting method to file (#18030)
* Test for action description of code actions, and simplify description for extracting method to file

* Add unit test file missing from tsconfig.json (only affects gulp) and update tests

* Use the actual number

* Use "module scope" or "global scope" instead of "this file"
2017-08-25 09:53:28 -07:00
Andy
e2141ad469 Mark some arrays as readonly (#17725)
* Mark some arrays as readonly

* Avoid unnecessary allocations and style changes

* Fix lint
2017-08-24 09:55:01 -07:00
Andrew Casey
49676c58f3 Merge pull request #17844 from amcasey/SymbolWalker
Resuscitate the SymbolWalker API
2017-08-23 13:32:21 -07:00
Wesley Wigham
8d44e48dd0 Fix instrumenter target + deprecation warning (#17973) 2017-08-22 15:39:10 -07:00
Ryan Cavanaugh
43b8ce664c Merge 2017-08-22 14:31:49 -07:00
Andrew Casey
8cbf42cff5 Fix lint errors 2017-08-22 11:33:34 -07:00
Andrew Casey
129ace5047 Update SymbolWalker tests
...to consume revised API.
2017-08-22 11:33:33 -07:00
Wesley Wigham
053b915061 Rebase SymbolWalker change onto master
From PR #9847.
2017-08-22 11:33:32 -07:00
Arthur Ozga
a3d113bed3 Merge pull request #16385 from aozgaa/isInMultiLineComment
multi-line comment formatting fix and handler
2017-08-18 12:43:37 -07:00
Wesley Wigham
ecd2ae8dac Deduplicate inputfiles before running RWC tests (#17877)
* Deduplicate inputfiles before running RWC tests

We deduplicate in the compiler, but we don't in the harness - this causes tests where the same file is listed multiple times in the arguments to not have the expected errors written, because we write out the same file multiple times when we should not.

* Don't completely omit both copied of duplicates

* Remove trailing whitespace

* Maintain list order while filtering duplicates

* Merge adjacent loops
2017-08-18 11:44:36 -07:00
Andy
ade3b565ae Revert public API changes to logger (#17899) 2017-08-18 11:20:07 -07:00
Daniel Rosenwasser
2729281a14 Merge pull request #17631 from Microsoft/synthesizedNamespaces
Always emit leading 'var' declarations for synthesized namespaces
2017-08-16 23:56:07 -07:00
Arthur Ozga
760ef44c36 test if onlyMultiLine flag changes answer 2017-08-16 18:48:27 -07:00
Arthur Ozga
19e2fa6fc5 Merge branch 'master' into isInMultiLineComment 2017-08-16 17:57:04 -07:00
Daniel Rosenwasser
281d821fe8 Fix lint errors. 2017-08-15 12:16:54 -07:00
Ron Buckton
360dc914c3 Merge pull request #17602 from Microsoft/multiInferredProjects
Adds support for inferred project isolation by projectRootPath
2017-08-11 16:06:49 -07:00
Daniel Rosenwasser
18cced9abd Added test. 2017-08-11 18:44:37 -04:00
Wesley Wigham
c92deef6ec Fix runtests-browser with latest node (#17735)
* Fixes for running tests in the browser with the latest node

* Make memoize safe

* Integrate PR feedback, require key func on memoize
2017-08-11 10:58:38 -07:00