Commit Graph

30124 Commits

Author SHA1 Message Date
Titian Cernicova-Dragomir
8ab0a25211 Improve error messages when indexing into a type (#31379)
* Improved error messages when indexing an object type with a literal string, a literal string union or a string.

* Added more specific message when using the indexing operator with an incompatible index argument.

* Fixed spelling and error message.
2019-05-23 15:27:50 -07:00
Dhruv Rajvanshi
ce23093a58 Merge branch 'master' of https://github.com/Microsoft/Typescript 2019-05-24 02:27:55 +05:30
Andrew Branch
a2b40292fe Merge pull request #31542 from andrewbranch/bug/31481
Error when writing to rest element range of readonly tuple
2019-05-23 13:38:09 -07:00
Andrew Branch
7359ff8158 Add test 2019-05-23 13:33:38 -07:00
Nathan Shively-Sanders
5d9d4b2553 Manually copy just postMessage changes (#31557)
* Manually copy just postMessage changes

* Update baselines
2019-05-23 13:26:41 -07:00
Andrew Branch
f97f57c155 Fix containsPrecedingToken for tokens whose preceding token is a missing node 2019-05-23 12:15:50 -07:00
Nathan Shively-Sanders
4d27361680 Allow JS with isolated modules (#31483)
* Allow JS with isolated modules

Previously legacy JS code was not allowed; it was required to use ES6
module syntax. Unfortunately, the check happens after parsing but before
binding, and the commonjs module indicator isn't set until binding
because it's not syntactically simple like the ES6 module indicator,
which is set during parsing.

So I decided that JS should be allowed during isolatedModules
unconditionally. We're not going to be transforming it anyway.

* Update baselines

* Switch test to outDir instead of noEmit
2019-05-23 11:09:28 -07:00
Sheetal Nandi
ae7a1b4f56 Merge pull request #31541 from microsoft/packageId
Always use resolved file to figure out subModule name in package id
2019-05-23 10:50:13 -07:00
Alexander T
6cd992132d Add string properties declaration to the completion list 2019-05-23 11:08:19 +03:00
Anders Hejlsberg
e6013335b9 Merge pull request #31537 from microsoft/fixIndexedAccessConstraint
Fix indexed access constraint
2019-05-22 18:35:15 -07:00
Andrew Branch
300cbef071 Don’t crash when creating a union signature from signatures that do and don’t have this types 2019-05-22 17:42:05 -07:00
Anders Hejlsberg
cd7a14ac21 Reuse getSimplifiedTypeOrConstraint function 2019-05-22 17:22:33 -07:00
Anders Hejlsberg
a95d18e7b4 Accept new baselines 2019-05-22 17:13:36 -07:00
Anders Hejlsberg
b688e25cd3 Implement inferrable index signatures for enum types 2019-05-22 17:12:37 -07:00
Andrew Branch
9f6791a5ab Error when writing to readonly tuple in rest element range 2019-05-22 15:03:17 -07:00
Sheetal Nandi
5d188a8c68 Always use resolved file to figure out subModule name in package id
Fixes #30429
2019-05-22 14:30:56 -07:00
Andrew Branch
eecb6d9049 Add failing test 2019-05-22 13:39:05 -07:00
Sheetal Nandi
85d3c5d7a1 Trace Package id at the module resolution site 2019-05-22 12:35:20 -07:00
Andrew Branch
60d0bb9b19 Don’t touch imports used for module augmentation in non-declaration files since it could change JS emit 2019-05-22 11:37:35 -07:00
Sheetal Nandi
431f0d6d8c Add test case for #30429 2019-05-22 11:22:07 -07:00
Ron Buckton
6a559e37ee Fix crash when checking invalid object rest (#31530) 2019-05-22 11:20:57 -07:00
Ron Buckton
3d2af9ff33 Relocate Debug namespace to reduce duplication (#31524) 2019-05-22 11:20:29 -07:00
Ron Buckton
c3055e585d Fix compiler crash with object rest in catch binding (#31522) 2019-05-22 11:20:07 -07:00
Ron Buckton
b3dc32fec7 Reset error record in downlevel for-of (#31519) 2019-05-22 11:18:07 -07:00
Ron Buckton
7611c5b931 Fix for computed properties in instance initializers (#31517) 2019-05-22 11:17:54 -07:00
Andrew Branch
ad9c36e0ec Expose ts.Diagnostics to fourslash 2019-05-22 10:00:09 -07:00
Nathan Shively-Sanders
b36c8a0690 Make anyArray.filter(Boolean) return any[], not unknown[] (#31515)
* Add this-parameter workaround to Array.filter

Allows anys.filter(Boolean) to once again return any[], not unknown[].

* Add any constraint to Boolean factory function

I want to test how well this works.

* Remove Boolean factory type guard

* Remove typeGuardBoolean test
2019-05-22 09:45:41 -07:00
Sheetal Nandi
1e7a77cf78 Merge pull request #31503 from microsoft/casing
Ignore drive letters when comparing casings of the files with forceConsistentCasingInFileNames
2019-05-22 09:25:34 -07:00
Anders Hejlsberg
b7012b577a Accept new baselines 2019-05-22 06:54:23 -07:00
Anders Hejlsberg
2fd4aaee92 Add regression test 2019-05-22 06:54:16 -07:00
Anders Hejlsberg
8120094c81 Simplify index and object types when obtaining indexed access constraint 2019-05-22 06:49:49 -07:00
Daniel Rosenwasser
de96b41272 Merge pull request #31521 from microsoft/relatedSpanSubsequentDeclarations
Related error spans on disagreeing declarations
2019-05-21 15:49:37 -07:00
Andrew Branch
52894cf850 Accept baselines, I guess 2019-05-21 15:39:07 -07:00
Andrew Branch
2856aabd70 Parse stray identifier-ish as JSXText instead of trivia 2019-05-21 15:28:16 -07:00
Daniel Rosenwasser
81d3595058 Accepted baselines. 2019-05-21 15:22:03 -07:00
Daniel Rosenwasser
3f5912995b Add related span to original declaration on disagreeing variable/property types. 2019-05-21 14:48:15 -07:00
Andrew Branch
feaef9c829 Improve error message for JSXExpressions that are comma expressions 2019-05-21 14:21:44 -07:00
TypeScript Bot
c71423edd6 Update user baselines (#31496) 2019-05-21 13:22:02 -07:00
Sheetal Nandi
38f689d19e Merge pull request #31484 from microsoft/completionsSorting
Add sortText depending scope of symbols
2019-05-21 12:59:01 -07:00
Sheetal Nandi
69711821a3 Merge pull request #31505 from microsoft/fileNotFound
Switch to using File not found message instead of trace message file does not exit
2019-05-21 12:56:00 -07:00
Andrew Branch
77a76c157b Revert "Allow synthetic identifiers to exist and give them escapedText"
This reverts commit 422b5414f1.
2019-05-21 09:45:08 -07:00
Sheetal Nandi
43c7eb77e1 Switch to using File not found message instead of trace message file does not exit
Fixes #30872
2019-05-21 09:43:40 -07:00
Sheetal Nandi
db150517d7 Ignore drive letters when comparing casings of the files with forceConsistentCasingInFileNames
Fixes #31327
2019-05-21 09:32:17 -07:00
Anders Hejlsberg
374569447c Merge pull request #31476 from microsoft/cacheUnnormalizedIntersections
Cache unnormalized intersection types
2019-05-21 06:42:51 -07:00
Wesley Wigham
07d850cf1c Prevent type parameter printing from recuring on the same symbol (#31453) 2019-05-20 16:43:55 -07:00
Sheetal Nandi
00cea41b65 Add sortText depending scope of symbols
Fixes #15024
2019-05-20 15:53:51 -07:00
Andrew Branch
897e10a81e Use range instead of two markers 2019-05-20 14:58:25 -07:00
Andrew Branch
6faeee449d Don’t remove imports that are used for module augmentation, just remove their import clauses 2019-05-20 14:49:28 -07:00
Andrew Branch
0f15bda45f Add failing test 2019-05-20 13:31:44 -07:00
Nathan Shively-Sanders
9052804576 Test docCommentTemplate for prototype methods (#31477)
This works in 3.5, but didn't in 3.2. Adding a test to make sure it
stays working.
2019-05-20 12:50:29 -07:00