Commit Graph

6585 Commits

Author SHA1 Message Date
Andrew Casey
568c8a3298 Allow extraction of variable decls used outside the extracted range
If there are only declarations, use the new function as the initializer
for a destructuring declaration.

If there are declarations and writes, changes all of the `const`
declarations to `let` and add `| undefined` onto any explicit types.
Use destructuring assignment to accomplish both "initialization" and
writes.

I don't believe there is a case where there are both declarations and a
return (since the declarations wouldn't be available after the return).

UNDONE: this could probably be generalized to handle binding patterns
but,
for now, only identifiers are supported.

Fixes #18242
Fixes #18855
2017-10-11 16:38:38 -07:00
Anders Hejlsberg
6cf41ae882 Merge pull request #19107 from Microsoft/fixRecursiveCallbacks
Fix checking of recursive callback types
2017-10-12 00:28:16 +01:00
Wesley Wigham
b949245336 Add ValueModule as a valid object literal type, as they are immutable (#19090)
* Add ValueModule as a valid object literal type, as they are immutable

* Rename method based on usage
2017-10-11 15:13:33 -07:00
Nathan Shively-Sanders
461e29bbd8 Merge pull request #18965 from Microsoft/set-symbol-on-union-of-spreads
Set symbol on union that is returned from `getSpreadType`
2017-10-11 13:25:45 -07:00
Ron Buckton
73d06f796d Merge pull request #19056 from Microsoft/fix16221
Fix recursive reference in type parameter default
2017-10-11 12:49:35 -07:00
Anders Hejlsberg
07e4819b8b Add regression test 2017-10-11 12:01:38 -07:00
Ron Buckton
d08770bdff Merge pull request #19046 from Microsoft/fix15395
Fix emit for classes with both fields and 'extends null'
2017-10-11 11:49:22 -07:00
Charles Pierce
576bd8c25f Ensure Async Modifier is maintained through ES6 Class Conversion (#19092) 2017-10-11 09:04:51 -07:00
Wesley Wigham
856961b84c Add regression test for #18668 (#19085) 2017-10-10 17:20:10 -07:00
Sheetal Nandi
61dd815ebc Merge pull request #19072 from Microsoft/completionInClassMember
Handle the case of completion of class member when member name is being edited
2017-10-10 15:45:11 -07:00
Charles Pierce
249c2cbaf7 Maintain Export Modifier when Refactoring to ES6 Class #18435 (#19070) 2017-10-10 15:39:59 -07:00
Andrew Casey
d33a9acbcc Merge pull request #18950 from amcasey/MissingMemberFormatting
Improve AddMissingMember formatting
2017-10-10 13:12:05 -07:00
Andy
927ffefcf4 Replace more 'verify.rangeAfterCodeFix' with 'verify.codeFix' (#18800) 2017-10-10 11:28:05 -07:00
Sheetal Nandi
3171d082a6 Handle the case of completion of class member when member name is being edited
Fixes #17977
2017-10-10 10:58:21 -07:00
Sheetal Nandi
67a6a9477f Merge pull request #16586 from Microsoft/projectRootAsCurrentDirectoryInEmit
Use the project root or the directory of current script info as the current directory to emit the file
2017-10-10 10:28:14 -07:00
Ron Buckton
dc607c29b4 Fix 'this' capturing for dynamic import 2017-10-09 17:15:13 -07:00
Ron Buckton
aaa06122b9 Fix recursive reference in type parameter default 2017-10-09 15:44:06 -07:00
Arthur Ozga
1db762356e Merge pull request #18706 from aozgaa/dev/aozgaa/JsDocExtendsSupport
support @extends in jsdoc
2017-10-09 15:08:58 -07:00
Joe Calzaretta
bb3467b8e1 Handle type guard predicates on Array<T>.find (#18160)
* Handle type guard predicates on `Array<T>.find`

If the `predicate` function passed to `Array<T>.find` or `ReadonlyArray<T>.find`
is a type guard narrowing `value` to type `S`, then any returned element should also
be narrowed to `S`.

Adding test case and associated baselines

* trailing whitespace after merge conflict
2017-10-09 14:58:41 -07:00
Nathan Shively-Sanders
9b51c33582 Merge pull request #19005 from charlespierce/abstract_property_in_constructor
Error when accessing abstract property in constructor #9230
2017-10-09 13:21:33 -07:00
Ron Buckton
264652c0ef Fix emit for classes with both fields and 'extends null' 2017-10-09 13:14:49 -07:00
Andy
2796ebfe35 In resolveNameHelper, use a lastNonBlockLocation (#18918) 2017-10-09 11:04:28 -07:00
Charles Pierce
79f5d968a1 Use ancestor walk to determine if property access is within constructor #9230 2017-10-09 10:57:08 -07:00
Andy
8a55baf9a3 In @typedef tag, handle property with no type (#19013) 2017-10-09 09:58:02 -07:00
Charles Pierce
9e00df590d Error when accessing abstract property in constructor #9230 2017-10-06 19:46:29 -07:00
Arthur Ozga
932b1b038c better error message 2017-10-06 16:16:37 -07:00
Arthur Ozga
0afaadba3b add error for multiple tags 2017-10-06 15:56:39 -07:00
Andy
71f8852124 Have getNameOfDeclaration return x for export default x. (#18616) 2017-10-06 14:29:45 -07:00
Arthur Ozga
5ea3ca4ef9 Merge branch 'master' into dev/aozgaa/JsDocExtendsSupport 2017-10-06 14:25:31 -07:00
Anders Hejlsberg
b7e744a0e5 Merge pull request #18976 from Microsoft/strictCallbackParameters
Strictly check callback parameters
2017-10-06 21:36:52 +01:00
Anders Hejlsberg
7fcf51960d Add tests 2017-10-06 09:22:10 -07:00
Nathan Shively-Sanders
e1bc916b91 Merge branch 'master' into excess-property-checks-for-discriminated-unions 2017-10-06 09:18:57 -07:00
Wesley Wigham
7a4c3314e8 Visit default export expressions (#18977) 2017-10-05 16:47:24 -07:00
Anders Hejlsberg
aae7572c48 Add test 2017-10-05 13:25:23 -07:00
Daniel Rosenwasser
e5eccf0a22 Added test. 2017-10-05 11:38:21 -07:00
Daniel Rosenwasser
924460406e Merge pull request #18811 from Microsoft/uncalledDecorator
Give a more helpful error message for certain decorators with too many arguments
2017-10-05 11:27:46 -07:00
Nathan Shively-Sanders
da6acba71e Merge branch 'master' into excess-property-checks-for-discriminated-unions 2017-10-05 09:07:23 -07:00
Nathan Shively-Sanders
0cb12b32a5 Test:{} in union from spread gets implicit index signature
Also tighten up the existing test code in the file.
2017-10-05 09:03:03 -07:00
Sheetal Nandi
03441fe120 Merge branch 'master' into projectRootAsCurrentDirectoryInEmit 2017-10-04 18:48:16 -07:00
Wesley Wigham
648bd6e9e0 Skip more lib checks, improve test execution time a bit more (#18952)
* Skip more lib checks, improve test execution time a bit more

* Change complexRecursiveCollections to still check

* Remove way more
2017-10-04 14:43:35 -07:00
Benjamin Lichtman
43084829bc Increase maximum depth of outlining span search (#18704)
* Increase max depth of outlining spans to 120

* Update tests

* Update tests to demonstrate limit

* Set limit to 40 and update tests
2017-10-04 13:48:08 -07:00
Wesley Wigham
25c3b99f29 Add skip lib check to many tests (#18935)
* Add skip lib check to many tests, do not include unit test duration in profiler duration

* Add a few more skipLibCheck flags

* A few more

* Add more skip lib check flags
2017-10-04 13:14:05 -07:00
Andrew Casey
4cf289e1a5 Fix whitespace around inserted property initializer
Fixes #18741
2017-10-04 11:26:41 -07:00
Andrew Casey
686fd1e62d Fix whitespace around inserted static property
Fixes #18743
2017-10-04 11:23:58 -07:00
Andy
6617819bf3 In getModifierOccurrences, support additional container kinds (#18947) 2017-10-04 09:52:51 -07:00
Andy
fe9129b1ab Support contextual type for property assignments in JS that are not declarations (#18820) 2017-10-04 09:32:09 -07:00
Andy
46e135b098 Fix parsing of qualified name in @augments (#18914) 2017-10-03 13:47:01 -07:00
Daniel Rosenwasser
301c90ccff Merge pull request #18300 from Microsoft/correctlyCacheTaggedTemplates
Correctly cache tagged template objects in modules
2017-10-03 12:06:57 -07:00
Nathan Shively-Sanders
4d8663c378 Merge pull request #18117 from Microsoft/jsdoc-dotdotdot-binds-tighter-than-postfix
Jsdoc ... binds tighter than postfix ?!
2017-10-03 08:45:26 -07:00
Daniel Rosenwasser
392cd6117b Added a test for an 'any'-type decorator. 2017-10-02 18:44:49 -07:00