Mohamed Hegazy
c47df3a8fd
Merge pull request #24438 from vpukhanov/issue-22674
...
addMethodDeclaration: add after quickfix location if possible
2018-05-30 10:30:01 -07:00
Anders Hejlsberg
a8a31ed508
Merge pull request #24439 from Microsoft/unknownType
...
New 'unknown' top type
2018-05-30 10:22:02 -07:00
Nathan Shively-Sanders
22cdff59e4
Better fix for bogus duplicate identifier in module exports ( #24491 )
2018-05-30 09:59:14 -07:00
Mohamed Hegazy
04dc76ec9c
Merge pull request #24442 from Kingwl/fix-implement-interface-with-extends-class
...
add lookup for extends class when implement interface
2018-05-30 09:20:50 -07:00
Andy
5e2c7ffce6
isValidMethodAccess: use getTypeOfPropertyOfType instead of getTypeOfFuncClassEnumModule ( #24488 )
2018-05-30 09:12:24 -07:00
Andy
011a4df4dd
Don't allow to rename string literal ( #24477 )
2018-05-30 07:50:48 -07:00
Anders Hejlsberg
e22a9d6fc1
Merge branch 'master' into unknownType
2018-05-30 07:45:10 -07:00
王文璐
2cb211305b
Merge branch 'master' into fix-implement-interface-with-extends-class
2018-05-30 09:05:56 +08:00
Anders Hejlsberg
577662de42
Update tests
2018-05-29 17:55:57 -07:00
Andy
e99be8c47d
Avoid duplicate import completions when a namespace is exported by two different modules ( #24473 )
2018-05-29 15:52:34 -07:00
Nathan Shively-Sanders
36c580378f
Fix duplicate identifier error with module.exports ( #24466 )
...
A bug in checkSpecialAssignment added bogus duplicate identifier errors
when using module.exports assignment to export a class. This commit
fixes that.
2018-05-29 14:29:48 -07:00
Nathan Shively-Sanders
15bfaf1cf6
Skip IntrinsicAttributes elaboration in JSX errors ( #24461 )
...
* Skip IntrinsicAttributes elaboration in JSX errors
Do not issue an error message for a source type that comes from JSX
attributes and a target type that is an intersection containing
IntrinsicAttributes or IntrinsicClassAttributes. This will make error
messages simpler and less confusing.
Note:
1. There will always be elaboration under the skipped message, so this
won't elide errors completely.
2. Rarely (once in the tests) the intersection type will have more that
one non-Intrinsic* member. However, these additional members don't
provide useful information either, so it's fine to skip them.
* Add test of IntrinsicAttributes error
* Fix indentation in test
2018-05-29 14:00:26 -07:00
Anders Hejlsberg
c694ffe7a5
Update tests
2018-05-29 12:54:12 -07:00
Andy
8bc1932ed5
moduleSpecifiers: Don't return a relative path to node_modules ( #24460 )
2018-05-29 12:40:06 -07:00
Andy
160b667846
fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback ( #24306 )
...
* fixUnusedIdentifier: Don't remove parameter in override or non-last parameter in callback
* Only allow removing last parameters; don't care about contextual type
2018-05-29 12:39:45 -07:00
Andy
816f1cee5a
Include '...' on doc comment for rest parameter ( #24462 )
2018-05-29 12:17:57 -07:00
王文璐
f9a55beec5
add lookup for extends class when implement interface
2018-05-28 18:38:07 +08:00
Anders Hejlsberg
31c73defa7
Update tests
2018-05-27 15:44:01 -07:00
Vyacheslav Pukhanov
1bc5977e3a
Update undeclared method quickfix tests
2018-05-28 00:09:47 +03:00
Anders Hejlsberg
73af0adcf0
Add tests
2018-05-27 10:37:59 -07:00
Mohamed Hegazy
a7a68d9591
Merge branch 'fix-es5-export-class-name-object' of https://github.com/Kingwl/TypeScript into Kingwl-fix-es5-export-class-name-object
2018-05-25 15:45:31 -07:00
Wesley Wigham
8f9c0861bc
Use external aliases in quickinfo and signature help return types ( #24391 )
...
* Dont include import types in quick info type names
* Add UseAliasDefinedOutsideCurrentScope flag to LS operations which were missing it
2018-05-24 15:19:57 -07:00
Nathan Shively-Sanders
e250942d6a
Disallow nested object param syntax in callback tag ( #24392 )
...
* Callback tag:Disallow nested-object-param syntax
Previously this caused a crash in parsing. If/when we want to support
this syntax, we will need to fix this crash.
* Update baselines
2018-05-24 15:11:33 -07:00
Elizabeth Dinella
b745ea059e
Fix to issue 23326 for completions on new.target ( #24342 )
...
* Fix to issue 23326 for completions on new.target
* Fixed linting issues - whitespace in if statements
* Removed debug statement in test case and consolidated and cleaned up code in switch statement for completions
* Added support for import.meta completion
2018-05-24 14:12:33 -07:00
Elizabeth Dinella
13734e7d68
Fix for issue #6154 - overriding methods with properties in the derived class ( #24343 )
...
* Fix to issue 6154 - Overriding a method with a property in the derived class should not cause a compiler error
* new baselines
* fixed deleted baselines
2018-05-24 14:12:13 -07:00
Andy
16af96b006
moveToNewFile: Format the new file ( #24379 )
2018-05-24 11:08:32 -07:00
Andy
bc570cd85f
moveToNewFile: Respect UserPreferences#quote ( #24365 )
2018-05-24 09:36:37 -07:00
kingwl
cb2be44d02
fix export class declare with name object targeting es5 ( #17494 )
2018-05-24 18:16:38 +08:00
Mohamed Hegazy
dd6dc5e27a
Merge pull request #24328 from Microsoft/getEditsForFileRename_oldFileStillPresent
...
getEditsForFileRename: Handle old file still being present
2018-05-23 16:16:00 -07:00
Mohamed Hegazy
10ac8b47e5
Merge pull request #22022 from Kingwl/enum-eval-div-zero
...
disallow nan and infinity in enum member
2018-05-23 15:32:35 -07:00
Wenlu Wang
4606709672
add code fix convert to mapped object type ( #24286 )
...
* add code fix convert to mapped object type
* add support for type literal and improve test
* fix typo
* add support for heritageClauses
* only determine declaration is not class
2018-05-23 14:09:49 -07:00
Andy
5983c45e24
Fix typo: seperate -> separate ( #24338 )
...
* Fix typo: seperate -> separate
* update tests
2018-05-23 09:36:17 -07:00
Andy
fb4caadaec
Support signature help for partially-filled-in type arguments f< ( #24138 )
...
* Support signature help for partially-filled-in type arguments `f<`
* Use `isPossiblyTypeArgumentPosition` and support new expressions
2018-05-23 08:28:09 -07:00
Sheetal Nandi
16d7f4c103
Merge pull request #24348 from Microsoft/findRefInJson
...
Fix getter of local symbol for export= when it is json module
2018-05-22 20:15:59 -07:00
Sheetal Nandi
a0d4e4f059
Fix getter of local symbol for export= when it is json module
...
Fixes #24341
2018-05-22 17:10:56 -07:00
Wesley Wigham
0102f8050c
Check for keyof constraint type instead of syntactic check ( #24098 )
...
* Check for keyof constraint type instead of syntactic check
* Readopt older candidateType check, even though it shouldnt really matter
* OK. Just use maybetypeOfKind
* Remove redundant boolean check
2018-05-22 16:58:31 -07:00
Wesley Wigham
8b8cd31784
Use unknown serialization kind when type symbol isnt resolved ( #24332 )
...
* Use unknown serialization kind when type symbol isnt resolved
* Add test for the isolated modules case
2018-05-22 16:56:12 -07:00
Andy
aed0eb6693
Improve verify.codeFixAvailable ( #24325 )
...
* Improve verify.codeFixAvailable
* Revert change to `verify.not.codeFixAvailable()`, and use `assertObjectsEqual` for better errors
2018-05-22 16:04:39 -07:00
Andy
ba63f49513
moveToNewFile: Don't provide refactor if selection is just imports ( #24336 )
2018-05-22 15:21:04 -07:00
Wesley Wigham
3fe946df78
Use symbolToTypeNode for class & interface references ( #24330 )
...
* Use merged symbols when calculating qualification, use symbolToTypeNode
* Accept baselines
2018-05-22 14:09:45 -07:00
Andy
5622bc2dd6
moveToNewFile: Support selecting the name of a declaration ( #24331 )
2018-05-22 14:00:29 -07:00
Andy
9cda2bdba0
Support recommended completion for union ( #24326 )
...
* Support recommended completion for union
* Fix for empty enum, which is not a union
2018-05-22 13:38:28 -07:00
Andy
694a985b49
For completions, treat a '// @ts-check' file like a TypeScript one ( #24321 )
2018-05-22 13:06:59 -07:00
Armando Aguirre
b5d882ebd6
Merge pull request #24262 from armanio123/FixObjectLiteralExpression
...
Fix issue with formatting object literal csharp style
2018-05-22 12:39:14 -07:00
Andy Hanson
46eaf62abb
getEditsForFileRename: Handle old file still being present
2018-05-22 12:20:34 -07:00
Mohamed Hegazy
9d57903630
Merge pull request #24312 from Kingwl/multiline-type-literal-formatter
...
fix wrong formatting with multiline type literals with IntersectionTy…
2018-05-22 10:06:24 -07:00
Andy
982c8d0af9
Add suggestion diagnostics for unused label and unreachable code ( #24261 )
...
* Add suggestion diagnostics for unused label and unreachable code
* Always error on unused left hand side of comma
2018-05-22 07:56:29 -07:00
Anders Hejlsberg
f52c4af448
Merge pull request #24310 from Microsoft/nonWideningLiteralInferences
...
Non-widening literal type inferences
2018-05-22 06:56:34 -07:00
王文璐
4b47c0cb82
fix wrong formatting with multiline type literals with IntersectionType and UnionType
2018-05-22 14:01:04 +08:00
Armando Aguirre
0b18bdf590
Added tests
2018-05-21 18:22:13 -07:00