1230 Commits

Author SHA1 Message Date
Sheetal Nandi
667751df2a When sending typings request use project's current directory as project root path
This ensures that we arent picking typings from folder different from the current directory for the project
2018-01-09 15:59:56 -08:00
Andy
89ceb4b9b5
Support completions that require changing from dot to bracket access (#20547)
* Support completions that require changing from dot to bracket access

* Use insertText and replacementSpan

* Rename includeBracketCompletions to includeInsertTextCompletions

* Don't add completions that start with space
2018-01-08 18:57:46 -08:00
Wenlu Wang
7154df10df add support for insertSpaceBeforeTypeAnnotation (#20466) 2018-01-08 13:25:02 -08:00
Andy
6f2ba15446
Start linting for double spaces (#20820)
* Start linting for double spaces

* Code review

* Fix cases that were excluded by countDoubleSpaces

* Remove extraneous closing parenthesis
2018-01-08 08:52:13 -08:00
Matt Bierner
8ed4e666e8 Log TS Server version and process args (#20847)
* Print TS Server version and args in logs

Fixes #18867

Adds basic logging of the version of tsserver being run and the full command line arguments used to run it

* Don't check log level for logging versions/args
2018-01-04 15:18:41 -08:00
Ryan Cavanaugh
dde7f03914
Merge pull request #20854 from mjbvz/global-plugins-for-inferred
Load global plugins for inferred projects
2018-01-03 12:39:49 -08:00
Benjamin Lichtman
b9ea3471a4 Simplify test and add explanatory assertion 2017-12-28 11:22:41 -08:00
uniqueiniquity
d4dd930f2e Allow dynamic files script info to be created when not opened by client 2017-12-27 11:12:56 -08:00
Matt Bierner
993a21e4e2 Load global plugins for inferred projects
Fixes #18322

Ensure that we also try to load global plugins for inferred projects. Moves global plugin loading logic to base `Project` class from `ConfigureProject` .
2017-12-21 17:04:27 -08:00
Andrew Casey
a3ab1ffcff
Merge pull request #20713 from amcasey/GH19165
Stop assuming code fix test changes are in the originating file
2017-12-15 14:21:57 -08:00
Andrew Casey
8b0988543b Stop assuming code fix test changes are in the originating file
Triggering a fix in one file can result in changes in another file.
Instead of passing around the originating file, retrieve an appropriate
`ScriptInfo` for each `FileTextChanges`.

Fixes #19165
2017-12-14 16:50:28 -08:00
Ryan Cavanaugh
bd3a27ed52 Clear the module resolution cache when new @types appear 2017-12-12 16:11:37 -08:00
Andy
19ea189b42
Support a "getCombinedCodeFix" service (#20338)
* Support a "getCombinedCodeFix" service

* Rename things

* Code review

* Rename things

* Update API baselines

* CodeActionAll -> CombinedCodeActions

* Take a `scope` parameter instead of `fileName` for flexibility

* Renames and bugfixes

* Make API changes internal

* Code review

* Update comment
2017-12-07 12:14:18 -08:00
Arthur Ozga
477c1f57a9
Merge pull request #20465 from Microsoft/dev/aozgaa/tsserverVersion
Add a status request-response for editors
2017-12-06 17:05:46 -08:00
Arthur Ozga
03e93d832e Merge branch 'master' into dev/aozgaa/tsserverVersion 2017-12-06 14:02:30 -08:00
Arthur Ozga
0e75c5cc2f update descriptions 2017-12-06 14:02:04 -08:00
Ryan Cavanaugh
ee283d1524
Merge pull request #20464 from RyanCavanaugh/fix20402
Don't add ambiently declared modules to ATA's unresolvedModules list
2017-12-06 13:55:54 -08:00
Ryan Cavanaugh
c15470595f Dedupe local types from ATA and reuse old programs correctly 2017-12-06 13:17:21 -08:00
Andy
3a3bb8e3f0
Immediately respond to applyCodeActionCommand requests (#20448) 2017-12-05 13:19:01 -08:00
Arthur Ozga
a714ece3da add status request 2017-12-04 18:11:23 -08:00
Andy
d8142339f9
Use 'filter' array helper (#20452) 2017-12-04 13:36:01 -08:00
Andy
fd4d8ab96e
Support a 'recommended' completion entry (#20020)
* Support a 'recommended' completion entry

* Code review

* Restore duplicate comments
2017-12-01 13:00:01 -08:00
Mine Starks
1fbe684834 compileOnSaveAffectedFileList shouldn't return any files for noEmit projects 2017-11-30 14:55:41 -08:00
Andrew Casey
e934c30513
Merge pull request #20173 from RyanCavanaugh/fixTypingsInstallerAgain_master
Always send a response to installTypings even if all types are cached
2017-11-27 10:47:05 -08:00
Andrew Casey
eb5797fd36
Merge pull request #20211 from amcasey/GH20084
Update project on PackageInstalledResponse
2017-11-22 10:21:33 -08:00
Andrew Casey
5ed31cff8c Use stricter types for event bodies 2017-11-21 16:38:58 -08:00
Andrew Casey
f483495408 Use {} instead of any to improve type checking 2017-11-21 16:24:05 -08:00
Andrew Casey
35545d4a0a Update project on PackageInstalledResponse
As with `SetTypings`, new typings have been installed so the project
should be updated and the client should be notified (via event).

Changed PackageInstalledResponse from "event" to "action" for the sake
of explicitness.

Fixes #20084.
2017-11-21 15:59:46 -08:00
Andrew Casey
39e6a00054 Unswap arguments 2017-11-21 15:59:45 -08:00
Andrew Casey
761c739824
Merge pull request #20181 from amcasey/TiRootPath
Correct project root path passed to Typings Installer
2017-11-21 10:39:28 -08:00
Ryan Cavanaugh
ee2d436999 Always send a response to installTypings even if all types are cached 2017-11-20 21:32:56 -08:00
Andrew Casey
1793652373 Correct project root path passed to Typings Installer
`createInstallTypingsRequest` has its own logic for extracting the
project root path from the project name and it disagrees with the
versions in the project flavors.  In particular, it only drops the last
component of the name if it exists.  For folder projects and JS-only
contexts, this will not be the case, but the last entry should still be
dropped.

TL;DR: stop creating filewatchers for
"c:/foo/foo.csproj*jscontent/node_modules"
2017-11-20 18:56:27 -08:00
Andrew Casey
71e07df817 Check hasOwnProperty before copying property 2017-11-20 18:43:14 -08:00
Andrew Casey
9cbe4eb614 Convert legacy safe list keys to lowercase on construction 2017-11-20 18:30:28 -08:00
Bill Ticehurst
6c4c10c7cf
Merge pull request #20115 from Microsoft/dev/billti/port20109toMaster
Port #20109 to master
2017-11-17 21:03:17 -08:00
Arthur Ozga
65908ef8ba
Merge pull request #19864 from Microsoft/dev/aozgaa/eventPortTelemetry
Send events through a single stream
2017-11-17 20:22:57 -08:00
Arthur Ozga
d2cc4f15be test overriding Session.event 2017-11-17 19:48:57 -08:00
Ryan Cavanaugh
574ceccf0a
Update editorServices.ts
Fix lint
2017-11-17 16:12:42 -08:00
Bill Ticehurst
805f191a57 Moved minified file exclusion 2017-11-17 14:39:33 -08:00
Bill Ticehurst
b244907074 Fixed internal safelist 2017-11-17 14:39:26 -08:00
Andy
e7adb1ce79
Bundle fileName with CodeActionCommand (#19881)
* Bundle fileName with CodeActionCommand

* Update test

* Fix API tests

* Add new overloads in services

* Fix overload

* Update API baselines
2017-11-17 14:16:38 -08:00
Arthur Ozga
890820b528 cleanup NodeTypingsInstaller 2017-11-16 19:19:05 -08:00
Arthur Ozga
8b0d3ab318 remove comments 2017-11-16 19:10:38 -08:00
Arthur Ozga
c098a5cf83 type event callback correctly 2017-11-16 19:06:08 -08:00
Arthur Ozga
49d92d844b defer callback and remove handler object 2017-11-16 18:15:39 -08:00
Armando Aguirre
464ae31776
Merge pull request #20082 from armanio123/KendoOptionalMin
Modified Kendo regex to include -ui folders and files without min
2017-11-16 17:37:24 -08:00
Armando Aguirre
49c169a523 Fixed unbalanced parenthesis 2017-11-16 16:16:10 -08:00
Armando Aguirre
48aa83e13a Modified Kendo regex to include -ui folders and files without min 2017-11-16 15:59:27 -08:00
Ryan Cavanaugh
a416826b64 Apply safelist exclusions even when include is not specified; recompute project contexts when installer reqs finish 2017-11-16 12:52:30 -08:00
Arthur Ozga
5c2fea4d4e make eventSender required for TypingsInstaller 2017-11-15 19:49:34 -08:00