microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-23 07:07:09 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity
29,841 Commits 372 Branches 237 Tags
b78ef30cb7fc15efcfc7bf1af9987653eeb12f80
Commit Graph

3385 Commits

Author SHA1 Message Date
Anders Hejlsberg
b78ef30cb7 No union subtype reduction during type inference (#37327) 
* No union type subtype reduction in getImplicitIndexTypeOfType

* Add regression test
 2020-03-11 10:27:51 -07:00
Anders Hejlsberg
c4da90368f Infer to erased signatures (#37261) 
* Use erased signatures as inference targets

* Add tests
 2020-03-10 08:42:36 -07:00
Nathan Shively-Sanders
061338e82b Don't inferFromIndexTypes() twice (#34501) 
* Don't inferFromIndexTypes() twice

* Add tests
 2020-03-04 13:19:35 -08:00
Eli Barzilay
5c8def9a06 Fix emitting ?. 
Use `emit()` for writing `questionDotToken`, leading to properly calling
the emit hooks (which `emitTokenWithComment` doesn't) and printing the
comments.  This fixes #35372 by calling its hooks to set the `.__pos`
and `.__end` fields.

Also, remove `getDotOrQuestionDotToken` which was used only here --
mainly because it seems likely to encourage misusing the
`questionDotToken` again.

Also, fix a bunch of `visitor` -> `tokenVisiton` calls in
`visitorPublic.ts`.
 2020-03-04 14:52:33 -05:00
Ryan Cavanaugh
67930fc163 Don't crash when there's no class type to derive a 'this' type from (#37164) 
Fixes #37161
 2020-03-04 09:34:28 -08:00
Wesley Wigham
b9c0999a2a Thread host.useCaseSensitiveFileNames through program and node builder into specifier generation (#37170) 2020-03-03 10:50:01 -08:00
Wesley Wigham
67c6cebfc8 Reinterpret a type parameter constrained to any as an upper bound constraint (#29571) 
* Reinterpret a type parameter constrained to any as an upper bound constraint

* Use real constraqint in alias in test

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-03-03 09:51:15 -08:00
Wesley Wigham
af4201ff51 Retain reexports in js emit even when they export nothing (#37124) 2020-03-02 14:33:53 -08:00
Anders Hejlsberg
a5796cf3b2 Remove ordering restrictions in control flow analysis (#37134) 
* Don't reset CFA type for x.y when x is narrowed

* Add tests

* Accept new baselines

* Remove unnecessary type assertion
 2020-02-29 12:03:09 -08:00
Pathurs
5c85febb0c Fix Get/Set being enumerable (#32264) 
* Fix Get/Set being enumerable

fixes #3610

* fix tests

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-02-27 14:08:20 -08:00
Wesley Wigham
e7c578a67d Reapply contextual type when recalculating array literals as tuples (#37071) 2020-02-27 14:02:28 -08:00
Eli Barzilay
e71614a185 Proper treatment of splicing tuples in array literals 
Fixes #32465.

After this was done, I continued to extend the implementation to handle
TupleLike types but it'ss broken since JS doesn't allow splicing
TupleLike values into array literals so pulled that out, and instead
keeping it for reference below.  (It Includes tests, which are broken
too.)

modified   src/compiler/checker.ts
@@ -22268,6 +22268,21 @@ namespace ts {
                         else hasNonEndingSpreadElement = true;
                     }
                 }
+                else if (spreadType && isTupleLikeType(spreadType)) {
+                    let i = 0, tupleEltType: Type | undefined;
+                    while (tupleEltType = getTypeOfPropertyOfType(spreadType, "" + i as __String)) {
+                        elementTypes.push(tupleEltType);
+                        i++;
+                    }
+                    const stringIndexInfo = getIndexInfoOfType(spreadType, IndexKind.String);
+                    const numberIndexInfo = getIndexInfoOfType(spreadType, IndexKind.Number);
+                    if (stringIndexInfo || numberIndexInfo) {
+                        if (stringIndexInfo) elementTypes.push(stringIndexInfo.type);
+                        if (numberIndexInfo) elementTypes.push(numberIndexInfo.type);
+                        if (i === elementCount - 1) hasEndingSpreadElement = true;
+                        else hasNonEndingSpreadElement = true;
+                    }
+                }
                 else {
                     if (inDestructuringPattern && spreadType) {
                         // Given the following situation:
new file   tests/cases/compiler/spliceTupleLikesWIntegers.ts
@@ -0,0 +1,23 @@
+declare const sb: { [0]: string, [1]: boolean };
+
+let k1: [number, string, boolean];
+k1 = [1, ...sb];
+
+let k2: [number, string, boolean, number];
+k2 = [1, ...sb, 1];
+
+// declare const sb_: [string, ...boolean[]];
+
+// let k3: [number, string, ...boolean[]];
+// k3 = [1, ...sb_];
+
+// declare const sbb_: [string, boolean, ...boolean[]];
+
+// let k4: [number, string, ...boolean[]];
+// k4 = [1, ...sbb_];
+
+// let k5: [number, string, boolean, ...boolean[]];
+// k5 = [1, ...sbb_];
+
+// let k6: [number, string, boolean, boolean, ...boolean[]];
+// k6 = [1, ...sbb_];
new file   tests/cases/compiler/spliceTupleLikesWStrings.ts
@@ -0,0 +1,23 @@
+declare const sb: { 0: string, 1: boolean };
+
+let k1: [number, string, boolean];
+k1 = [1, ...sb];
+
+let k2: [number, string, boolean, number];
+k2 = [1, ...sb, 1];
+
+declare const sb_: { 0: string, [s: string]: (boolean|string) };
+
+let k3: [number, string, ...(boolean|string)[]];
+k3 = [1, ...sb_];
+
+declare const sbb_: { 0: string, 1: boolean, [s: string]: (boolean|string) };
+
+let k4: [number, string, boolean, ...(boolean|string)[]];
+k4 = [1, ...sbb_];
+
+// let k5: [number, string, boolean, ...(boolean|string)[]];
+// k5 = [1, ...sbb_];
+
+// let k6: [number, string, boolean, boolean, ...(boolean|string)[]];
+// k6 = [1, ...sbb_];
 2020-02-27 16:43:29 -05:00
Alexander T
baff821594 fix(36989): 'async' modifier cannot be used in an ambient context.ts (#37010) 
* fix(36989): omit 'async' modifier for methods in declaration files.

* remove useless condition
 2020-02-27 00:11:29 -08:00
Ryan Cavanaugh
c4e96856ac Detect circularities when removing 'undefined' from defaulted params (#37023) 
Fixes #37008

Note that referencing a variable in its initializer is a TDZ error;
the OP report had OOB logic that prevented this in practice (?)
 2020-02-26 14:59:04 -08:00
Nathan Shively-Sanders
af901ba911 No error on this exprs in static property inits (#36781) 
No error on `this` expressions in static property declaration
initialisers when targetting ESNext and with useDefineForClassFields. In
this case the emit is correct and the types are correct, so the error
should not be issued.
 2020-02-26 09:07:45 -08:00
Wesley Wigham
15dd0002ef Unwrap substitutions both before _and_ after potential simplification (#32116) 
* Unwrap substitutions both before _and_ after potential simplification

* Repeatedly unwrap/simplify until no more can be performed

* Use seperate loops for source and target to reduce redundant calls

* Move loop into function

* Inline worker
 2020-02-25 17:36:56 -08:00
Wesley Wigham
4d5464e1f9 Revert "Support declaration emit for late bound element accesses assigned to functions in both TS and JS (#36593)" (#37034) 
This reverts commit 3e4ce4777d.
 2020-02-25 16:40:38 -08:00
Anders Hejlsberg
9ed73ebbbf Properly handle control flows from returns in try/catch within IIFE (#36901) 
* Properly handle control flows from returns in try/catch within IIFE

* Accept new baselines

* Add tests

* Accept new baselines

* When end of finally is unreachable, end of try statement is too

* Add additional test case
 2020-02-25 16:14:00 -08:00
Wesley Wigham
e99173a6f9 Ignore data- props when excess property checking (#36952) 2020-02-25 15:52:24 -08:00
Ryan Cavanaugh
43863cafe2 Check for undefined source.symbol (#37021) 
Fixes #37014
 2020-02-25 13:46:24 -08:00
Wesley Wigham
3e4ce4777d Support declaration emit for late bound element accesses assigned to functions in both TS and JS (#36593) 2020-02-25 13:45:27 -08:00
Wesley Wigham
7d8dc730b7 Baseline arity checks for jsx sfc tags (#36643) 
Finish comment

PR feedback
 2020-02-25 13:44:22 -08:00
Wesley Wigham
e536c89872 Add js-equivalent test for the binary expression stress and introduce trampoline into getJSSyntacticDiagnosticsForFile (#36724) 
* Add js-equivalent test for the binary expression stress and introduce trampiline into getJSSyntacticDiagnosticsForFile

* Update src/compiler/parser.ts

Comment text update

Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Fix lint

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
 2020-02-25 13:29:34 -08:00
Wesley Wigham
65e7acce58 Use getters to define live export bindings refresh (#35967) 
* use getters to define live export bindings

* fix scoping in export* helper

* Object.defineProperty cannot be used in ES3 target

* Accept changed baselines

* Use function expression, not arrow function

* Update importStarHelper to match export helper in binding-making

* Fix whitespace

* Adjust whitespace in edited helpers

* Use new helper for setting bindings, use unscoped __exportStar helper for exports so helpers get reused more

* Accept updated baselines

* Use __createBinding for individual reexports when target is es3

* Remove unneeded type assertion

* Singeline the helpers

* Add check for createBinding helper, accept updated baselines with shortened helper

Co-authored-by: Michael Rawlings <mirawlings@ebay.com>
 2020-02-24 15:36:14 -08:00
Ron Buckton
fd8000dd59 Fix class emit in converted loop body (#36795) 2020-02-24 10:55:13 -08:00
Alexander T
bf6be75131 feat(36048): handle uncalled function checks in ternaries (#36402) 2020-02-20 09:29:41 -08:00
Wesley Wigham
aece8c06b0 Allow intersections (and substitutions) to be checks against discriminable unions (#36663) 2020-02-10 15:26:46 -08:00
Andrew Branch
20471182fc Fix crash when trying to import a non-exported type (#36619) 
* Fix crash when trying to import a non-exported type

* Add related info on each declaration
 2020-02-05 08:27:49 -08:00
Ron Buckton
fcf28506aa Fix overzealous renaming of emit helpers in es module emit (#36541) 2020-01-31 10:41:47 -08:00
Ron Buckton
24d8f795b2 Fix crash in emitTokenWithComment (#36542) 2020-01-31 10:41:09 -08:00
Hye Sung Jung
8ed129771f fix spelling errors (#36523) 
* fix spelling errors

* remove changes in lib/*
 2020-01-30 13:39:54 -08:00
Anders Hejlsberg
8a0b8822b2 Fix contextually typed parameter issues (#36476) 
* Fix multiple issues with contextually typed parameters

* Accept new baselines

* Fix lint error

* Add tests

* Address CR feedback

* Add fourslash tests
 2020-01-30 10:50:39 -08:00
Nathan Shively-Sanders
8da3eff7b0 Subtypes of ErrorConstructor extend it (#35549) 
Previously subtypes of Error extended Error, but the matching subtypes
of ErrorConstructor did not extend ErrorConstructor. The members in
es5.d.ts are identical, so there's no need except for allowing interface
merging into ErrorConstructor to affect subtypes as well.
 2020-01-29 13:26:00 -08:00
Brandon Bloom
49282d9fba Nested this container (#36495) 
* Add nestedThisContainer test

* Fix #36492
 2020-01-29 09:35:23 -08:00
Sheetal Nandi
8eee8db192 NoEmit and incremental are allowed with listFilesOnly (#36488) 
Fixes #32882
 2020-01-28 15:59:09 -08:00
Sheetal Nandi
0e9416c7c8 Disallow incremental with noEmit (#36483) 
Fixes #32882
 2020-01-28 13:11:45 -08:00
Sheetal Nandi
f91f762ced Fix js declaration emit for exporting default which looks like namespace merge (#36482) 
Fixes #35074
 2020-01-28 12:21:36 -08:00
Wesley Wigham
18cd79e179 Allow infer type variables to have constraints inferred (#32093) 
* Allow `infer` type variables to have constraints infered and allow the breakdown of substitutes in simplifiable source inferences

* Still skip conditional inference when `extends infer Q` so such a pattern still acts as a constraint size breaker
 2020-01-24 16:59:20 -08:00
Wesley Wigham
08e6bc20bb Trampolines for large binary expressions (#36248) 
* WIP

* Test no longer crashes, but emit trampoline is incomplete and skips pipeline phases

* Fix lints, use non-generator trampoline in emit (still skips pipeline)

* Final version with emitBinaryExprssion work stack that is only used if possible

* Fix lints

* retarget to es2015 for testing

* Use bespoke state machine trampolines in binder and checker

* Remove now extraneous code in parser

* Adjust fixupParentReferences to use a depth first preorder traversal rather than breadth first

* Reintroduce incremental fast bail in fixupParentReferences

* Revert target to es5

* PR feedback

* Small edit for devops rebuild with updated definition

* Fix comment nits, add internally extraneous check back into transformer
 2020-01-24 16:29:55 -08:00
Klaus Meinhardt
8e0b091795 es2018: visit other binding elements when transforming object destructuring with rest (#35872) 
* es2018: visit other binding elements when transforming object destructuring with rest

fixes: #35771

* more tests
 2020-01-24 15:50:29 -08:00
Wesley Wigham
9ef9bb04f1 Fix crash on erroneous enum member merged with exported type alias (#36429) 2020-01-24 15:00:15 -08:00
Sheetal Nandi
677e45ccb8 Dont add "use strict" prologue in json emit (#36380) 
* Add test for strict with isolated modules and resolveJson
Test for #36372

* Dont add "use strict" prologue in json emit
Fixes #36372
 2020-01-23 13:01:11 -08:00
Wesley Wigham
75f88eee48 Do not short-circuit module visibility calculation when alias visibility is requested (#36339) 2020-01-22 14:49:29 -08:00
Alexander T
38eccbab2a feat(29624): better errors for non-exported types (#36187) 2020-01-21 13:03:22 -08:00
Anders Hejlsberg
1a10e712e6 Improve variance measurement (#36261) 
* No covariance default for recursive references in variance measurement

* Add tests

* Accept new baselines
 2020-01-17 11:50:38 -08:00
Orta
1dafd09a06 Revert "Add related diagnostic to "used before defined" if type is a function that returns a union with undefined (#33171)" (#35751) 
This reverts commit be960fa356.
 2020-01-15 12:50:52 -05:00
Alexander T
daf786ecd0 throw an error when no default export present (#35815) 2020-01-14 11:38:48 -08:00
Wesley Wigham
69ab1d5ecd Handle Identifier declarations in getDeclarationSpaces (#36136) 2020-01-13 10:29:37 -08:00
Sheetal Nandi
0c3019e3b3 Handle invalid package.json typings fields when generating specifiers (#36137) 
Fixes #35437
 2020-01-10 14:51:23 -08:00
Wesley Wigham
88677de380 Do not omit the anyFunctionType from intersections (#35658) 
* Do not omit the anyFunctionType from intersections

* Move check into isEmptyResolvedType
 2020-01-07 00:39:28 -08:00