Commit Graph

1336 Commits

Author SHA1 Message Date
Sheetal Nandi
a14396320b Resolve json modules only when --resolveJsonModule is specified 2018-04-05 15:37:13 -07:00
Andy
24842b4002 When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors (#22361)
* When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors

* Improve performance: do not add unused suggestion diagnostics unless asking for a suggestion

* Add "unused" flag to diagnostics

* Code review

* reportsUnused -> reportsUnnecessary

* Fix test
2018-04-05 12:33:00 -07:00
Andy
4f80fbddc2 Fix typo and use array helper (#23169)
* Fix typo and use array helper

* Update API baselines
2018-04-05 10:17:01 -07:00
Andrew Casey
855171bde5 Introduce a --syntaxOnly server mode
1. Disable the LS in all projects
 2. Don't create Program objects
 3. Ignore config files
2018-04-04 16:44:15 -07:00
uniqueiniquity
36cdb52b17 Handle double quotes for every argument 2018-04-02 16:41:29 -07:00
uniqueiniquity
8f503fb483 Close over getLogPath 2018-04-02 15:38:04 -07:00
uniqueiniquity
e625a6a9b4 Use object destructuring instead of tuple 2018-04-02 15:12:26 -07:00
uniqueiniquity
ffbb046cd4 Consume extra parts of file path 2018-04-02 13:58:31 -07:00
uniqueiniquity
361be11a04 Remove trailing whitespace 2018-04-02 12:32:15 -07:00
uniqueiniquity
0238991cd3 Ensure TSS_LOG handles paths with spaces 2018-04-02 11:04:52 -07:00
Andy
3e32e15895 Add 'fixAllDescription' property to CodeFixAction (#22616)
* Add 'fixAllDescription' property to CodeFixAction

* Code review

* Add to protocol

* Make fixAllDescription be just a string
2018-03-27 18:21:21 -07:00
Andrew Casey
517cf6aa89 Add support for suppressing project events
VS doesn't consume (e.g.) `syntaxDiag` events, so there's no reason to
do the work to compute their payloads.
2018-03-22 16:44:09 -07:00
Andy
67670d8726 Revert change to canUseEvents in IoSessionOptions (#22791) 2018-03-22 10:29:32 -07:00
Andrew Casey
564183f9ed Fix lint errors 2018-03-21 15:18:06 -07:00
Andrew Casey
9352a8bc11 Delete IoSessionOptions
Many of the operations were unused because the values were being
accessed directly from the enclosing scope.
2018-03-21 14:56:06 -07:00
Andy
cc3921323c Support services settings (#22236)
* Support services settings

* Code review

* More review

* Use different names for Options and GetCompletionsAtPositionOptions (todo: come up with better names)

* More renames

* More renaming

* Support quote style in importFixes

* Add `importModuleSpecifierPreference` option

* Support quote style for `throw new Error('Method not implemented.')` (#18169)

* options -> preferences
2018-03-20 13:07:59 -07:00
Sheetal Nandi
e48ed3f9c2 Do not close the file watches just to create new ones in the type installer
Fixes #22581
2018-03-15 10:45:09 -07:00
Mohamed Hegazy
c335c3803c Fix #22133: Expose getOutliningSpans on the server protocol (#22400)
* Fix #22133: Expose getOutliningSpans on the server protocol

* Remove debugger statement from test
2018-03-09 08:50:47 -08:00
Mohamed Hegazy
1fc3aebc20 Port changes from #22172, provide a callback to fs.close (#22405) 2018-03-09 08:30:09 -08:00
Sheetal Nandi
17b10dc2a9 Merge pull request #21243 from Microsoft/watchOptions
Different watchFile and watchDirectory options through environment variable
2018-03-08 12:44:53 -08:00
Nathan Shively-Sanders
a81f264d70 Call process.stdout._handle.setBlocking(true) (#22389)
* Call process.stdout._handle.setBlocking(true)

This prevents output from being truncated when the compiler can output
errors to stdout faster than it can receive them. This may slow down
performance for compilations for many errors, but those were already
quite slow.

* Disable tslint no-unnnecessary-type-assertion-2

It is wrong. It *is* necessary.
2018-03-08 12:38:30 -08:00
Josh Goldberg
7826b38426 Apply 'no-unnecessary-initializer' lint rule (#22014)
* Apply 'no-unnecessary-initializer' lint rule

Forbids `let`/`const` statements to be initialized to `undefined`, since that's the initial value by default anyway.
The auto-fixer also happened to remove two unnecessary `as number` casts in `src/harness/parallel/worker.ts`.

For historical data: to run with `--fix`, I modified the line in `Jakefile.js` that declared the `cmd` for running TSLint.

* Moved worker.ts type assertions to parameters
2018-03-06 07:30:40 -08:00
Sheetal Nandi
ae8637c99f Merge branch 'master' into watchOptions 2018-03-03 10:51:59 -08:00
Sheetal Nandi
cbef5c29b5 Merge pull request #22151 from Microsoft/svcOfPendingReloadFile
Reload the text from file if there is pending reload of the script info before determining to use SVC
2018-03-02 19:11:11 -08:00
Andy
a564912d9a Apply 'no-unnecessary-qualifier' lint rule (#22009) 2018-03-01 14:20:18 -08:00
Andy
03ba8a0852 mergeMapLikes: Improve type (#22237)
* mergeMapLikes: Improve type

* Make source Partial<T>

* T extends object

* Update api baseline
2018-03-01 07:35:42 -08:00
Sheetal Nandi
005a50f587 Merge pull request #22136 from Microsoft/moduleResolution
Use cache for the non-relative module resolution and enhance the watches for failed lookup locations
2018-02-28 14:39:22 -08:00
Andy
fa4619c5c1 Add 'info' diagnostics (#22204)
* Add 'info' diagnostics

* Code review
2018-02-28 11:16:32 -08:00
Sheetal Nandi
f1c879d090 Merge branch 'master' into watchOptions 2018-02-23 13:16:46 -08:00
Sheetal Nandi
08ab6eb42d Reload the text from file if there is pending reload of the script info before determining to use SVC
Fixes #20806
2018-02-23 12:10:24 -08:00
Sheetal Nandi
fdb5e95f0a Use the module cache to resolve non relative module name as well 2018-02-22 15:44:13 -08:00
Andy
b90a56dc7a Mark getOccurrences as deprecated in protocol.ts like it is in services/types.ts (#22067) 2018-02-22 13:21:40 -08:00
Sheetal Nandi
0b248d5e29 Trace should write messages to the logger 2018-02-22 10:47:19 -08:00
Sheetal Nandi
9a160f2079 Merge branch 'master' into watchOptions 2018-02-21 10:44:12 -08:00
Andy
b3edc8f9f4 Apply 'no-unnecessary-type-assertion' lint rule (#22005)
* Apply 'no-unnecessary-type-assertion' lint rule

* Fix type error

* Fix tsconfig.json

* Add --format back
2018-02-16 18:38:00 -08:00
Sheetal Nandi
ecddf8468f Fix the assert for undefined leaf in LineNode (#21924)
Fixes #21818
2018-02-16 16:37:32 -08:00
Nathan Shively-Sanders
7e8dab681a typingsInstaller:Remove triple-slash references (#21982)
Replace them with an explicit list of files in tsconfig. I got this list
by adding --listFiles to the jake-generated command.
2018-02-16 14:00:10 -08:00
Andrew Casey
5656f35b6a Introduce an organizeImports command
In phase 1, it coalesces imports from the same module and sorts the
results, but does not remove unused imports.

Some trivia is lost during coalescing, but none should be duplicated.
2018-02-16 10:51:38 -08:00
Sheetal Nandi
d9d98cf11a Handle the delayed updates due to user action correctly when ensuring the project structure is upto date
Fixes #20629
2018-02-12 16:53:47 -08:00
Sheetal Nandi
6ca65b71b4 Refactoring project updates in openFile 2018-02-12 13:12:55 -08:00
Benjamin Lichtman
f989ef7261 Merge pull request #21004 from uniqueiniquity/updateATA
Enable typings cache entries to expire and be updated
2018-02-09 14:17:26 -08:00
uniqueiniquity
4c89a813bf Handle case where package.json and package-lock.json don't agree 2018-02-09 10:36:49 -08:00
Sheetal Nandi
bf707ac265 Merge pull request #21743 from Microsoft/defaultProjectForFile
Fix getDefaultProjectForFile check
2018-02-08 09:58:43 -08:00
Wesley Wigham
871e71d4ef Move insertSorted from server to core, use for diagnostic collections (#21401)
* Move insertSorted from server to core, use for diagnostic collections

* All keep the overall list sorted, too

* Increase timeout for js verification

* Use knowledge of how diagnostics are sorted to make all diagnostic list creation lazy and more efficient

* Staunchly avoid array allocation in favor of resizing an existing array
2018-02-07 17:00:59 -08:00
Sheetal Nandi
b18f830216 Fix getDefaultProjectForFile check
Fixes #21738
2018-02-07 14:42:51 -08:00
Armando Aguirre
ece4eeec95 Removed internal on private property 2018-02-07 13:18:47 -08:00
Armando Aguirre
0aa72a7822 Added backward compatibility and PR comments 2018-02-06 17:11:59 -08:00
Armando Aguirre
cdff95f914 Refactored exceededTotalSizeLimitForNonTsFiles to return the last filename analyzed if the service language is going to be disabled 2018-02-05 19:25:07 -08:00
Sheetal Nandi
ca4af4f36c Merge branch 'master' into watchOptions 2018-02-05 13:07:12 -08:00
Andy
d11c7aeeaf class Project: implement log and error from LanguageServiceHost (#21635)
* class Project: implement `log` and `error` from `LanguageServiceHost`

* Update API baseline
2018-02-05 11:42:03 -08:00