10180 Commits

Author SHA1 Message Date
Sheetal Nandi
85285bcae1
Merge pull request #19688 from Microsoft/npmInstallAtTypes
Handle cases when npm install doesnt get triggered with actual failed lookup location but instead the trigger is some folder in the node_modules
2017-11-02 14:31:08 -07:00
Sheetal Nandi
2d5331edde Handle cases when npm install doesnt get triggered with the actual file added
Fixes #19597
2017-11-02 13:45:50 -07:00
Kris Zyp
c557131cac Ensure that we continue recursing into TS transforms (#19650)
* Ensure that we continue recursing into TS transforms when avoiding export elliding for transformed nodes, fix #19649

* Use more precise fix
2017-11-02 12:49:00 -07:00
Andy
ce25dc9807
reduceRight is never used (#19605) 2017-10-31 13:29:28 -07:00
Nathan Shively-Sanders
98e9a561af
Merge pull request #19219 from Microsoft/abstract-property-access-error-in-own-constructor-only
Abstract property access error in own constructor only
2017-10-31 13:27:24 -07:00
uniqueiniquity
3ebb2e8a34 Merge branch 'master' into jsxFragment 2017-10-31 10:53:57 -07:00
Andy
f4236ec5c8
Rename "isPartOfExpression" (#18469) 2017-10-31 08:05:39 -07:00
Wesley Wigham
c2aa13dac5
Parenthesize export assignments if needed (#19590)
* parenthesize export assignments if needed

* Add default-specific parenthesization to handle lookahead

* New parenthesization logic for export default

* Handle commalist and comma cases
2017-10-30 18:23:32 -07:00
Andrew Casey
a89c055a48
Merge pull request #19578 from amcasey/GH19395
Don't pass synthesized node to typeToTypeNode
2017-10-30 16:35:20 -07:00
Andy
5e0c71e6ba
The global "JSON" object should always exist (#19583) 2017-10-30 16:20:55 -07:00
Nathan Shively-Sanders
aea2ee5726 Fix the order of JSDocTag kinds
JSDocTypeLiteral should not be grouped with the JSDocTag kinds, so move
it just before they start, instead of just after. This updates the
LastJSDocNode and LastJSDocTagNode.
2017-10-30 15:00:34 -07:00
Mohamed Hegazy
6c71ca84e7
Add utility function to check for strict option flags (#19427)
* Add utility function to check for strict option flags
- Correctelly check for noImplicitAny in checker
- Correctelly check for noImplicitAny in installTypesForPackage refactor

* Respond to code review comments

* Accept baselines

* Revert "Accept baselines"

This reverts commit cf4ef62830b4ee5555125ce214d824e16c244488.

* Move type alias to core
2017-10-30 13:05:54 -07:00
Anders Hejlsberg
7f4a132af9
Merge pull request #19564 from Microsoft/fixGenericMappedTypeRelationships
Fix generic mapped type relationships
2017-10-30 12:42:24 -07:00
Matt
6de69df9c1 Fix #102: More accurate error message for module in type reference (#19324)
* Add: Logical OR of "SymbolFlags.ValueModule" into the "meaning" argument of the
"resolveName" call, in the "checkAndReportErrorForUsingNamespaceModuleAsValue"
function, when checking if a namespace is being used as a type.

* Fix: test "privacyImportParseErrors" error messages.

* Fix: test "typeofInternalModules" error message.

* Fix: test "moduleWithValuesAsType" error message.

* Fix: test "moduleAssignmentCompat2" error messages.

* Fix: test "moduleVisibilityTest3" error message.

* Fix: test "getAccessorWithImpliedReturnTypeAndFunctionClassMerge" error messages.

* Fix: test "staticInstanceResolution5" error messages.

* Fix: test "noCrashOnImportShadowing" error message.

* Fix: test "moduleAssignmentCompat3" error messages.

* Fix: test "primaryExpressionMods" error message.

* Fix: test "moduleInTypePosition1" error message.

* Fix: test "moduleAssignmentCompat1" error messages.

* Fix: test "moduleAssignmentCompat4" error messages.

* Fix: test "moduleCrashBug1" error message.
2017-10-30 12:38:18 -07:00
Andy
f0da3d7336
Fix declaration emit for typeof default export (#19471)
* Fix declaration emit for `typeof` default export

* Add comment
2017-10-30 11:40:32 -07:00
Andrew Casey
1f93526fd9 Assert that enclosing declaration is not synthesized 2017-10-30 11:22:07 -07:00
Mohamed Hegazy
5d469cf0e8
Merge pull request #19552 from ajafff/parse-negative-numbers
convertToObject: handle negative numbers in JSON
2017-10-30 09:58:30 -07:00
Anders Hejlsberg
b3a24322d3 Make generic mapped type relationship more inclusive 2017-10-29 16:49:28 -07:00
Anders Hejlsberg
fd0d40cc2b Undo unnecessary change 2017-10-28 15:31:39 -07:00
Anders Hejlsberg
90d20f260a Redo subtype reduction with correct --noImplicitAny error reporting 2017-10-28 15:28:11 -07:00
Klaus Meinhardt
4895d16645 convertToObject: handle negative numbers in JSON
Fixes: #19551
2017-10-28 20:06:33 +02:00
Anders Hejlsberg
73802be004 Undo extra subtype reduction in getWidenedType 2017-10-27 17:18:49 -07:00
Anders Hejlsberg
9c27c56779 Perform subtype reduction when widened union type contains {} 2017-10-27 10:05:44 -07:00
Anders Hejlsberg
fd0ac155b9 Add missing semicolon 2017-10-26 14:58:06 -07:00
Anders Hejlsberg
aa6b438eba Ensure void return in forEachType 2017-10-26 14:56:43 -07:00
Anders Hejlsberg
e483ea53d5 Use a single union type for all inferred object literal types 2017-10-26 12:48:20 -07:00
Anders Hejlsberg
1641f9bb0e Normalize nested object literals 2017-10-26 06:53:41 -07:00
Anders Hejlsberg
b435c90f86 Normalize object literals in widened union types 2017-10-25 11:46:51 -07:00
uniqueiniquity
5dd1a47c6b Error when using fragment with jsxFactory 2017-10-25 10:18:18 -07:00
uniqueiniquity
961495bb79 Remove unnecessary type annotation 2017-10-25 10:18:17 -07:00
Anders Hejlsberg
b17e75b52b Missing properties in fresh object literals are known to be undefined 2017-10-24 13:27:55 -07:00
uniqueiniquity
fb058868de Respond to CR 2017-10-24 13:24:11 -07:00
Sheetal Nandi
7828746cc9 Set the files found during node_modules search correctly when reusing existing program structure
This marks files reused correctly as from external library resulting in not using them for files to be emitted and computed for output structure
Fixes #19327
2017-10-23 19:05:38 -07:00
Wesley Wigham
fa3ce9fe6c Fix build break (#19431) 2017-10-23 14:28:20 -07:00
Andy
159a0a2197 Use NodeFlags to detect nodes inside with statements instead of climbing ancestors (#17721)
* Use NodeFlags to detect nodes inside with statements instead of climbing ancestors

* Add to ContextFlags
2017-10-23 13:38:50 -07:00
Anders Hejlsberg
b4b711ff5c Infer from base constraint signatures instead of erased signatures 2017-10-23 12:35:11 -07:00
Andy
74cbb827f9 Fix lint (#19387) 2017-10-20 14:12:24 -07:00
Andy
8b7d859fb3 Make it a noImplicitAny error to fail to provide type arguments to a superclass via @augments (#18778)
* Make it a noImplicitAny error to fail to provide type arguments to a superclass via @augments

* Don't recommend to add an @augments tag if it already exists

* Suggestions from code review

* Shorten error message
2017-10-20 09:41:19 -07:00
Andy
d7be61a569 Subsequent variable declarations must have same type: Mention location of other declaration (#19356)
* Subsequent variable declarations must have same type: Mention location of other declaration

* Fix naming, remove template literal
2017-10-20 08:33:16 -07:00
Nathan Shively-Sanders
1ea1254e8e Merge pull request #19355 from Microsoft/sandersn/fix-getParameterSymbolFromJSDoc
fix getParameterSymbolFromJSDoc
2017-10-19 19:35:10 -07:00
Anders Hejlsberg
8a227674ce Merge pull request #19319 from Microsoft/fixMappedTypeInferenceErrors
Fix mapped type inference errors
2017-10-19 18:13:04 -07:00
Mohamed Hegazy
8adbcefbbb Merge pull request #19149 from Kingwl/fix-incorrect-super-without-base-class
fix super call from class that has no basetype but with same symbol (#19068)
2017-10-19 17:32:42 -07:00
Mohamed Hegazy
8a292e3514 Update version (#19353)
* Update version

* Accept baselines after version change
2017-10-19 15:37:38 -07:00
Andy
c1b4d59752 Fixup line and offset of rename location of refactor (#19265)
* Fixup line and offset of rename location of refactor

* Fixes

* Handle "\r" only documents

* Update api baselines

* Fix error if an edit comes *after* the rename location

* Add bounds check

* Simpler implementation: get new text, then calculate line starts the usual way
2017-10-19 14:31:23 -07:00
Nathan Shively-Sanders
97a6f14ca2 Consolidate jsdoc node getters
They are now used both in getJSDocCommentsAndTagsWorker and in
geParameterSymbolFromJSDoc.
2017-10-19 14:12:56 -07:00
Nathan Shively-Sanders
c2bbfafcbe Fix getParameterSymbolFromJSDoc 2017-10-19 09:13:31 -07:00
Andy
1f282f19e0 Fix "noStringLiteral" lint errors (#19310) 2017-10-19 08:15:48 -07:00
Wesley Wigham
8212c962cd Workaround for nonnull operator on indexed accesses (#19275)
* Quick and dirty workaround

* Add third case to show current behavior

* Rename variable, replace elaboration from comment with links
2017-10-18 17:39:05 -07:00
Anders Hejlsberg
a885894baa Infer properties of type {} when argument of a mapped type is incorrect 2017-10-18 16:58:56 -07:00
Nathan Shively-Sanders
d8373c3dbb Merge pull request #19314 from Microsoft/fix-tsc-instrumented
Fix four tsc-instrumented bugs
2017-10-18 16:41:40 -07:00