Commit Graph

10307 Commits

Author SHA1 Message Date
Nathan Shively-Sanders
80d1a42179 Merge branch 'master' into instantiate-this-in-type-parameter-constraints 2017-11-13 13:13:38 -08:00
Andy
e7df83263d Break out of speculative parsing on bad parameter initializer (#19158)
* Break out of speculative parsing on bad parameter initializer

* Remove uses of 'finally'

* give up -> stop

* Do without exceptions

* Remove `resetAfterSpeculation`

* Use Fail and FailList objects

* Remove `inSpeculation` parameter to parseDelimitedList

* Don't use `createNodeArray`, it's not always in scope

* Move Fail and FailList inside initializeState

* More code review

* More code review
2017-11-13 09:18:36 -08:00
Anders Hejlsberg
b8fbf884d0 Merge pull request #19926 from Microsoft/improvePrimitiveComparable
Bidirectional comparable relation for primitive types
2017-11-11 09:15:24 -08:00
Ron Buckton
59fca7fc30 Fix crash when running tsc with -diagnostics 2017-11-10 16:26:16 -08:00
Ryan Cavanaugh
de7fbc041a Merge pull request #19542 from RyanCavanaugh/fix19533
Exclude legacy safelist files in external projects
2017-11-10 15:28:35 -08:00
Sheetal Nandi
8777962373 Merge pull request #19930 from Microsoft/constEnumWithWatch
Ensure that enum member value is computed before using it
2017-11-10 14:57:47 -08:00
Sheetal Nandi
c82c6f21cb Ensure that enum member value is computed before using it
Fixes #19898
2017-11-10 14:05:16 -08:00
Anders Hejlsberg
a79610a403 Merge pull request #19912 from Microsoft/fixEmptyArrayInference
Fix empty array inference
2017-11-10 13:48:38 -08:00
Anders Hejlsberg
7d5f5fd555 Make comparable relationship bidirectional for primitive types 2017-11-10 13:13:21 -08:00
Andy
5ffcc42169 Simplify setting constEnumOnlyModule (#19735) 2017-11-10 09:34:20 -08:00
Anders Hejlsberg
2010c4cda1 Give lowest priority to inferences made from empty array literals 2017-11-10 08:30:59 -08:00
Wesley Wigham
16efae2433 Consider the commonjs module indicator as a module indicator (#18490)
* Consider the commonjs module indicator as an indicator that something is effectively an external module

* Only use commonjs module indicator when targeting commonjs
2017-11-09 16:49:04 -08:00
Andy
65a191fa2b For import completion of default import, convert module name to identifier (#19875)
* For import completion of default import, convert module name to identifier

* Suggestions from code review
2017-11-09 13:13:23 -08:00
Ryan Cavanaugh
b043edd61c Merge 2017-11-09 12:42:37 -08:00
Ryan Cavanaugh
19cc42782b Format + new regex 2017-11-09 12:30:36 -08:00
Andy
90ae9ffe6e If there is an export default x; alias declaration, disallow other default exports (#19872) 2017-11-09 12:21:37 -08:00
Wesley Wigham
a1014b2b13 Mark all parameters as needed for metadata when one is decorated (#19849)
* Mark all properties as needed for metadata when one is decorated

* Add restarg test
2017-11-09 00:26:33 -08:00
Wesley Wigham
ceaeffa3ab Fix declaration emit for imported export alias specifiers (#19852)
* Badness

* Revert #3641, whose original bug has been fixed by other means

* Add another repro
2017-11-08 18:44:46 -08:00
Ron Buckton
c6fddbad27 Merge pull request #18348 from ubershmekel/no-space-after-comment
Remove trailing space from emitLeadingComment
2017-11-08 18:34:51 -08:00
Yuval Greenfield
bfe74de017 Only ignored params need underscores 2017-11-08 18:20:58 -08:00
Wesley Wigham
235356e6ff Handle synthetic nodes correctly as namespace identifiers in system transform (#19623)
* Handle synthetic nodes correctly as namespace identifiers in system transform

* Add ref to issue in comment

* Lock newline for ci
2017-11-08 18:15:23 -08:00
wenlu.wang
e9841f3899 fix completions protected members in recursive generic types (#19192) (#19242) 2017-11-08 17:44:12 -08:00
Nathan Shively-Sanders
90f87ef180 Merge pull request #17765 from tycho01/6229-known-length-tuples
add `strictTuples` flag giving tuples known length
2017-11-08 15:38:39 -08:00
Nathan Shively-Sanders
c1c7926735 Revert "Add TupleBase with unusable mutating Array methods"
This reverts commits
4385444c44,
2399d58,
es55de3,
888da3c
2017-11-08 15:18:35 -08:00
Nathan Shively-Sanders
76a3be7c4c Merge pull request #19838 from Microsoft/narrow-index-signature-property-access
Narrow property access of undeclared properties from string index signatures
2017-11-08 12:10:52 -08:00
Adrian Leonhard
a1da5bd5af Changed error for setter when emitting declaration with private param type (#18593)
so that error message refers to prop name instead of param name.

Changed getter errors for similar case so they also refer to prop name.

Fixed bug where static getters wouldn't output their specific error.

Fixes #1976
2017-11-08 10:02:39 -08:00
Nathan Shively-Sanders
d73fb3acdd Narrow property access from string index signatures
Previously these accesses did not use control flow to narrow property
accesses of undefined properties that are resolved from a string index
signature. Now the use control flow to narrow these just like normal
properties.
2017-11-08 09:48:36 -08:00
Andy
ef6f9351b5 Fix undefined error for diagnostic for instantiating an abstract class (#19809)
* Fix undefined error for diagnostic for instantiating an abstract class

* Only use the name-less diagnostic
2017-11-08 09:40:53 -08:00
Mohamed Hegazy
1de3bbac2e Merge branch 'update-types3' of https://github.com/ajafff/TypeScript into ajafff-update-types3 2017-11-07 15:23:38 -08:00
Nathan Shively-Sanders
9b36e1155a Merge pull request #19039 from Microsoft/guard-name-in-getSuggestionForNonexistentSymbol
In getSuggestionForNonexistentSymbol, guard name against undefined
2017-11-07 15:03:26 -08:00
Nathan Shively-Sanders
c6f343e266 Improve asserts in getSuggestionForNonexistentSymbol 2017-11-07 14:47:08 -08:00
Sheetal Nandi
fe40873664 Merge pull request #19786 from Microsoft/directoryRename
Handle the watch when folders are added/removed/renamed in wild card folder
2017-11-07 11:13:47 -08:00
Andy
bd2e97597d Enable 'no-empty' tslint rule (#19769)
* Enable 'no-empty' tslint rule

* Fix bug
2017-11-07 09:22:28 -08:00
Andy
9c8129eeac Enable 'no-invalid-template-strings' lint rule (#19790) 2017-11-07 06:51:35 -08:00
Aluan Haddad
70cabdda41 fix inconsistencies in import UMD code fixes adapting to module format (#19572)
* improve import code fixes for UMD modules
 - use default import under --allowSyntheticDefaultImports
 - import..require support
 - make make quick fix info match resulting import
 - make diagnostics

* Address PR feedback:
 - extract test for synethetic default imports into getAllowSyntheticDefaultImports in core.ts
 - use getAllowSyntheticDefaultImports in checker.ts and importFixes.ts
 - move compilerOptions to top level destructuring

* add tests

* remove `import =` quick fix and supporting code.

* update feature tests

* remove errant whitespace
2017-11-06 22:55:37 -08:00
Ron Buckton
3f248ecfe1 Merge pull request #19452 from Microsoft/compareStrings
Clean up outdated string comparison logic
2017-11-06 18:48:15 -08:00
Andy
77b24aec83 Apply 'unified-signatures' tslint rule (#19738)
* Apply 'unified-signatures' tslint rule

* Fix new failure
2017-11-06 18:38:03 -08:00
Andy
40efd1b3bd Apply 'object-literal-key-quotes' tslint rule (#19737)
* Apply 'object-literal-key-quotes' tslint rule

* Convert to "consistent-as-needed"
2017-11-06 18:13:20 -08:00
Wesley Wigham
d79c37cd19 Discriminate contextual types (#19733)
* Discriminate contextual types

* Invert conditional

* Update findMatchingDiscriminantType and baselines
2017-11-06 16:09:35 -08:00
Nathan Shively-Sanders
ea55de3e98 Eagerly fall back to TupleBase 2017-11-06 15:44:16 -08:00
Sheetal Nandi
3f34525c81 Handle the folder create/delete in the configured project 2017-11-06 15:22:48 -08:00
Andy
ed38889ca6 Enable 'no-unused-expression' tslint rule (#19734) 2017-11-06 13:01:07 -08:00
Eugene Timokhov
5b9905d5a4 Added empty constructors to TypedArrays from es2017 (#19680) 2017-11-06 13:00:05 -08:00
Wesley Wigham
0593ba27d8 Make getContextualTypeOfApparentType mapType over unions (#17668)
* Instantiate contextual types while in an inferrential context

* Limit scope of instantiation to only when likely needed

* Still get aparent type

* Expand test

* Fix nit

* Handle JSX and array

* Tests for the JSX and Array cases

* After much deliberation and inspection, much simpler fix

After much deliberation and inspection, much simpler fix

Undo

Redo
2017-11-06 12:52:33 -08:00
Wesley Wigham
4f48bf80fe Revised emit for computed property names, including with decorators (#19430)
* Revised emit for computed property names

* Fix downlevel name generation scopes

* Accept slightly more conservative baseline

* First feedback pass

* Reduce number of nonrequired variable declarations and assignments

* Remove side-effect-free identifier references

* skip partially emitted expressions

* Comments, move starsOnNewLine to emitNode

* Put expressions on newlines when inlined in class expressions for consistency

* Update new ref

* Fix typo in comment
2017-11-06 12:51:34 -08:00
Andy
c4bf21b9cb Improvements to checkUnusedIdentifiers (#19607) 2017-11-06 10:59:39 -08:00
Nathan Shively-Sanders
c2374c4ec3 Merge branch 'master' into 6229-known-length-tuples 2017-11-06 10:51:34 -08:00
Nathan Shively-Sanders
2399d58266 Improve TupleBase docs and backward compatibility 2017-11-06 10:50:57 -08:00
Anders Hejlsberg
b5f4a83365 Merge pull request #19745 from Microsoft/emptyArrayInference
No inference from empty array literals
2017-11-06 10:45:45 -08:00
Anders Hejlsberg
7a4808a89e Merge pull request #19774 from Microsoft/fixInvariantGenericErrors
Fix invariant generic error elaboration logic
2017-11-06 10:42:32 -08:00