Commit Graph

15960 Commits

Author SHA1 Message Date
uniqueiniquity
71ff6dd91e Allow characters in JsxText inside JsxFragment that would not normally scan 2018-02-22 15:56:34 -08:00
Andy
bb2c58b977 Simplify uses of getPossibleSymbolReferencePositions (#22099) 2018-02-22 13:22:52 -08:00
Andy
790f65d15b Simplify isJumpStatementTarget and isLabelOfLabeledStatement users using type predicates (#22100) 2018-02-22 13:22:34 -08:00
Andy
b90a56dc7a Mark getOccurrences as deprecated in protocol.ts like it is in services/types.ts (#22067) 2018-02-22 13:21:40 -08:00
Andy
8463b1e028 Fix bug: don't call addIndirectUser if we're not tracking indirect users (#22121) 2018-02-22 09:20:59 -08:00
csigs
13d57fdd47 LEGO: check in for master to temporary branch. 2018-02-22 17:10:13 +00:00
csigs
ce4bd134aa LEGO: check in for master to temporary branch. 2018-02-22 11:10:14 +00:00
csigs
a0b15e2b9a LEGO: check in for master to temporary branch. 2018-02-22 05:10:13 +00:00
csigs
4db45338f4 LEGO: check in for master to temporary branch. 2018-02-21 23:10:43 +00:00
Andrew Casey
72a7194b6c Merge pull request #22007 from amcasey/UnusedImports
Implement ts.OrganizeImports.removeUnusedImports
2018-02-21 13:35:43 -08:00
Andy
4f309702c1 Separate isGlobalCompletion from CompletionKind (#22074)
* Separate isGlobalCompletion from CompletionKind

* Fix comments
2018-02-21 13:12:13 -08:00
Wesley Wigham
66fa9f6cd7 Just map type variables to constraints at certain positions for narrowing so that we do not map primitives (#21384)
* Use a limited version of getApparentType that doesnt map primitives

* Reuse [most of]  getBaseConstraintOfType, since it does the needed behaviors

* Move new function next to the very similar function
2018-02-21 12:51:26 -08:00
Andy
8a52eade2e Make getTextOfIdentifierOrLiteral and getEscapedTextOfIdentifierOrLiteral only accept Identifier | StringLiteralLike | NumericLiteral (#22002) 2018-02-21 11:05:43 -08:00
Andy
dda4bd0d0b fixClassDoesnotImplementInheritedAbstractMember: Don't perform fix for same class twice (#22073) 2018-02-21 10:03:02 -08:00
Andy
dd47f2492b getSemanticDocumentHighlights: Use toMultiMap helper (#22059)
* getSemanticDocumentHighlights: Use `toMultiMap` helper

* Rename to arrayToMultiMap and follow pattern of arrayToMap and arrayToNumericMap
2018-02-21 10:02:34 -08:00
csigs
6523927716 LEGO: check in for master to temporary branch. 2018-02-21 17:10:30 +00:00
csigs
81e5cf70a9 LEGO: check in for master to temporary branch. 2018-02-21 11:10:14 +00:00
Andy
4833657c33 Use 'append' in chunkObjectLiteralElements (#22068) 2018-02-20 15:30:12 -08:00
Daniel Rosenwasser
0559151eb2 Merge pull request #21990 from Microsoft/documentExportAssignment
Document 'ExportAssignment' slightly.
2018-02-20 15:03:32 -08:00
Andrew Casey
cc386d25a4 Filter FAR results to initial SourceFile 2018-02-20 14:35:01 -08:00
Andy
b00c13b716 Fix bug: Handle QualifiedName in getMeaningFromRightHandSideOfImportEquals (#21779)
* Fix bug: Handle QualifiedName in getMeaningFromRightHandSideOfImportEquals

* Fix lint
2018-02-20 14:32:51 -08:00
Andrew Casey
fee1df34ce Implement ts.OrganizeImports.removeUnusedImports
TODO: Still need to add support for organizing imports in ambient
modules
2018-02-20 10:21:25 -08:00
csigs
64c24b61f1 LEGO: check in for master to temporary branch. 2018-02-20 17:10:32 +00:00
csigs
e305c5190e LEGO: check in for master to temporary branch. 2018-02-20 05:10:17 +00:00
Andy
b3edc8f9f4 Apply 'no-unnecessary-type-assertion' lint rule (#22005)
* Apply 'no-unnecessary-type-assertion' lint rule

* Fix type error

* Fix tsconfig.json

* Add --format back
2018-02-16 18:38:00 -08:00
Andy
8e078b9fde Add comment to isGlobalCompletion (#21973) 2018-02-16 16:48:42 -08:00
Andy
69abe49930 Supports more locations for completions contextual types (#21946) 2018-02-16 16:48:03 -08:00
Andy
9ee51fadd9 Have Symbol#isReferenced check the SymbolFlags of the reference (#21996) 2018-02-16 16:47:13 -08:00
Sheetal Nandi
ecddf8468f Fix the assert for undefined leaf in LineNode (#21924)
Fixes #21818
2018-02-16 16:37:32 -08:00
Sergii Bezliudnyi
b6f82adfed add template to jsdoc completion (#21978) 2018-02-16 16:27:57 -08:00
Andrew Casey
8341b1369d Merge pull request #22004 from amcasey/FARBadImport
Make FAR handle non-existent imported symbols
2018-02-16 16:17:04 -08:00
Mohamed Hegazy
f95b9bc65d Port generated lib files (#22003)
* Port generated lib files

* Port generated lib files
2018-02-16 15:53:44 -08:00
Andrew Casey
b64eefdb20 Remove redundant null check 2018-02-16 15:50:12 -08:00
Andrew Casey
d2cbd8de06 Merge pull request #22001 from amcasey/OrganizeImportsMissedCommits
Group imports before sorting and coalescing
2018-02-16 15:28:15 -08:00
Andrew Casey
9c2b95dae3 Make FAR handle non-existent imported symbols 2018-02-16 14:49:23 -08:00
Nathan Shively-Sanders
7e8dab681a typingsInstaller:Remove triple-slash references (#21982)
Replace them with an explicit list of files in tsconfig. I got this list
by adding --listFiles to the jake-generated command.
2018-02-16 14:00:10 -08:00
Andrew Casey
7a31394788 Group imports before sorting and coalescing 2018-02-16 13:15:07 -08:00
Andrew Casey
70e9a5e6dc Merge pull request #21909 from amcasey/OrganizeImports
Introduce an organizeImports command
2018-02-16 12:49:02 -08:00
Andrew Casey
5c278cee17 Address PR feedback
Eliminate cancellation token

Add organizeImports.ts to tsconfig.json

Simplify ts.OrganizeImports.organizeImports

Simplify sortImports

Semantic change: all invalid module specifiers are now considered to be
equal.

Simplify comparisons using ||

Pull out imports with invalid modules specifiers

...for separate processing.  They are tacked on to the end of the
organized imports in their original order.

Bonus: downstream functions can now assume imports have valid module
specifiers.

Rename baseline folder with leading lowercase

Simplify coalesceImports

Remove some unnecessary null checks

Simplify baseline generation
2018-02-16 10:56:16 -08:00
Andrew Casey
f4141ac6bf Separate OrganizeImports into its own namespace and file 2018-02-16 10:52:29 -08:00
Andrew Casey
979b14689e Fix lint errors 2018-02-16 10:52:21 -08:00
Andrew Casey
5656f35b6a Introduce an organizeImports command
In phase 1, it coalesces imports from the same module and sorts the
results, but does not remove unused imports.

Some trivia is lost during coalescing, but none should be duplicated.
2018-02-16 10:51:38 -08:00
Andy
b70aa229c6 getTextOfPropertyName: Assert input value is a PropertyName (#21981) 2018-02-16 10:48:57 -08:00
Daniel Rosenwasser
06286e760a Document 'ExportAssignment' slightly. 2018-02-16 01:17:45 -08:00
Andy
cfc234f959 Simplify getBraceMatchingAtPosition (#21979) 2018-02-15 16:29:42 -08:00
Andy
f8f4bb8fdd textChanges: Clean up handling of newLineCharacter (#21970) 2018-02-15 13:02:56 -08:00
Andy
347bff14a9 textChanges: Simplify getChanges (#21971)
* textChanges: Simplify getChanges

* Return ReadonlyArray
2018-02-15 13:02:45 -08:00
Andy
81df5313d7 Simplify getOccurrencesAtPosition (#21977) 2018-02-15 13:02:32 -08:00
Anders Hejlsberg
0f697c376b Merge pull request #21947 from Microsoft/fixKeyofWildcard
Fix issue with 'keyof T' and conditional types
2018-02-15 12:44:51 -08:00
Andy
a133cec246 Fix bug: Interface type parameter merged with property is not unused (#21966) 2018-02-15 09:30:58 -08:00