1094 Commits

Author SHA1 Message Date
Sheetal Nandi
6887dbc750 Assert if the script info that is attached to closed project is present
Adds assertion to investigate #19003 and #18928
2017-10-09 15:25:01 -07:00
Sheetal Nandi
07ba906594 Handle the case when finishCachingPerDirectoryResolution is not called because of exception
Fixes #18975
2017-10-09 14:32:33 -07:00
Sheetal Nandi
32d705dbb5 Fine tune logging so that only triggers in watch are logged in normal logging vs verbose 2017-10-05 11:35:18 -07:00
Sheetal Nandi
ee05d0eb1c Compile public api so that all the updates are ensured to be correct 2017-10-04 16:09:16 -07:00
Andy
efa274f722 When emitting all files, emit the changed file first (#18930)
* When emitting all files, emit the changed file first

* Export interface
2017-10-04 13:30:37 -07:00
Sheetal Nandi
c2427f22d0 Wrap the cancellation token in throttled cancellation token from server 2017-10-03 16:34:46 -07:00
Sheetal Nandi
4bb4711eff Merge branch 'master' into watchImprovements 2017-10-02 16:34:43 -07:00
Sheetal Nandi
7f969e8138 Making APIs as internal so that we can enable them after we have figured out final details 2017-10-02 16:27:26 -07:00
Andy
eefe5c9706 Fix acquiring format options for getEditsForRefactor (#18848)
* Fix acquiring format options for getEditsForRefactor

* Add test

* Fix test description

* Use `executeCommandSeq`
2017-10-02 13:26:35 -07:00
Sheetal Nandi
898559b4e5 Merge branch 'master' into watchImprovements 2017-10-02 12:34:34 -07:00
Ryan Cavanaugh
141cd574c7 Merge pull request #18603 from RyanCavanaugh/pluginWork
Report external files in initial case for project load
2017-10-02 10:32:04 -07:00
Sheetal Nandi
68d360585a PR feedback 2017-09-26 16:21:15 -07:00
Sheetal Nandi
38f3a2b700 Renamed PartialSystem as DirectoryStructureHost and CachedPartialSystem as CachedDirectoryStructureHost 2017-09-26 11:05:52 -07:00
Sheetal Nandi
23acff5bc8 Merge branch 'master' into watchImprovements 2017-09-25 16:18:26 -07:00
Andy
25ad0b5581 Apply "array-type" lint rule (#18699) 2017-09-22 16:14:41 -07:00
Ryan Cavanaugh
54070786e4 Report external files in initial case 2017-09-20 10:52:56 -07:00
Ryan Cavanaugh
b9b112738c Merge pull request #18456 from RyanCavanaugh/pluginWork
Properly report external filenames
2017-09-20 10:51:54 -07:00
Andrew Casey
0ac8406cd7 Merge pull request #18501 from Microsoft/formatOptions
Make formatOptions optional in GetEditsForRefactorRequestArgs
2017-09-15 17:11:08 -07:00
Andrew Casey
965a4d5aeb Restructure handling to TI messages to enforce exhaustiveness 2017-09-15 11:33:05 -07:00
Andy Hanson
0b76e43977 Make formatOptions optional in GetEditsForRefactorRequestArgs 2017-09-15 07:21:38 -07:00
Andrew Casey
f3411d4361 Only decrement activeRequestCount on SetTypings responses
InvalidateCache responses are triggered by file watchers, rather than by
requests.
2017-09-14 15:45:26 -07:00
Andy
0de1b2301e Cleanup getDiagnosticsForProject (#18151) 2017-09-14 12:38:48 -07:00
Andy
d96dfeb708 Don't normalize whitespace in fourslash tests (#18447)
* Don't normalize whitespace in fourslash tests

* Only render whitespace when the diff is text-only
2017-09-14 08:23:50 -07:00
Sheetal Nandi
cf72f2aaf0 Merge branch 'master' into watchImprovements 2017-09-13 17:35:21 -07:00
Ryan Cavanaugh
9046fcb658 Add files as one batch to preserve errors 2017-09-13 16:09:18 -07:00
Ryan Cavanaugh
3bd4c4f847 Properly report external filenames 2017-09-13 15:19:07 -07:00
Andy
2a70bf5158 Don't count a write-only reference as a use (#17752)
* Don't count a write-only reference as a use

* Split isWriteAccess to isWriteOnlyAccess and isReadOnlyAccess

* Update "unusedParameterUsedInTypeOf" to use "b"

* Update diagnostic messages: "is never used" -> "its value is never read"

* Use a WriteKind enum

* Rename enum and move documentation to enum members
2017-09-13 09:02:33 -07:00
Andy
c3199c7772 extractMethod: Support renameLocation (#18050)
* extractMethod: Support renameLocation

* Add tslint disable

* Properly analyze list of changes to always get a correct rename location

* Update test

* Ensure name is really unique

* Improvements to test code

* Respond to PR comments
2017-09-13 09:02:10 -07:00
Sheetal Nandi
4f7c0e5e1c Simplify event sent on background project update since its anyways just to update the error list 2017-09-12 18:16:31 -07:00
Sheetal Nandi
b536f9dade Should not remove the reused resolutions in the file when file contents have not changed. 2017-09-12 12:09:06 -07:00
Sheetal Nandi
aea8630ace Merge branch 'master' into watchImprovements 2017-09-12 10:33:58 -07:00
Sheetal Nandi
fdb104b242 Merge branch 'master' into watchImprovements 2017-09-11 13:49:36 -07:00
Ryan Cavanaugh
1f0e7b02ea Merge pull request #18093 from RyanCavanaugh/detectBadPlugins
Detect bad plugins and work around them
2017-09-11 12:49:10 -07:00
Sheetal Nandi
67f9533c67 Limit the resolution invalidation to max number of files as invalidation for larger cache might take more time than to just recalculate resolutions 2017-09-08 12:10:47 -07:00
Sheetal Nandi
b179cd1e1c Return configured project being closed by config file 2017-09-07 14:48:16 -07:00
Andrew Casey
097b094082 Don't get typings for projects with disabled language services 2017-09-07 11:10:12 -07:00
Andrew Casey
8d1eb29fb1 Merge pull request #18265 from amcasey/ThrottledOperations
Limit the number of unanswered Typings Installer requests
2017-09-07 11:01:27 -07:00
Adrian Leonhard
7b12b79558 ts.server.ProjectService.closeConfiguredProject returns true on success. (#18180)
Fixes #17892
The if condition around the return value of that method in closeExternalProject indicates that this was the expected behavior.
2017-09-07 09:17:47 -07:00
Andy
193f4be355 Enable interface-over-type-literal lint rule (#17733) 2017-09-07 09:14:59 -07:00
Sheetal Nandi
c8e711c3a3 Invalidate resolution of the failed lookup only if its one of the default extension or is one of the failed lookup location without that default extension 2017-09-06 20:03:41 -07:00
Sheetal Nandi
680994ea42 Better log for update graph and delay operations 2017-09-06 16:34:31 -07:00
Andrew Casey
9692ce86db Add explanatory comment 2017-09-06 15:46:59 -07:00
Andrew Casey
0b1bad8421 Fix lint issues 2017-09-06 15:44:00 -07:00
Sheetal Nandi
e6eede13ef Update how we get project/script info so that it doesnt start unnecessary update graph 2017-09-06 13:18:58 -07:00
Sheetal Nandi
0ff160f93f Add files to change set instead of delay reloading project on "change" command 2017-09-05 19:36:32 -07:00
Andrew Casey
482e802e83 Limit the number of unanswered typings installer requests
If we send them all at once, we (apparently) hit a buffer limit in the
node IPC channel and both TS Server and the typings installer become
unresponsive.
2017-09-05 18:08:50 -07:00
Andrew Casey
9c6765d5cf Document ThrottledOperations.schedule 2017-09-05 15:47:54 -07:00
Sheetal Nandi
7b2bab5b86 Revert to use refcount to keep track of directory watchers for failed lookup 2017-09-05 15:40:50 -07:00
Sheetal Nandi
9e5e20c80f Remove the configured project if on next open file if it has no open files instead of immediately when closing last open file 2017-08-31 17:58:09 -07:00
Sheetal Nandi
8d5d4c2a0e Reduce storage of maps/sets for failed lookups 2017-08-31 15:48:31 -07:00