Herrington Darkholme
67eabb98bc
fix #20449 , insert space between decorators ( #20491 )
2018-01-04 16:57:27 -08:00
Matt Bierner
12d5063e4c
Add kindModifier to mark if a completion item is for an optional field ( #20839 )
...
* Add kindModifier to mark if a completion item is for an optional field
For #12458
Adds a new KindModifier for completion items to mark when a property is optional. This can be used by editors to either change the item icon or add a `?` to the item text
* Add method test
* Baseline-accept
2018-01-04 16:36:31 -08:00
Benjamin Lichtman
96530719ac
Merge pull request #20912 from uniqueiniquity/jsxFragmentFormatting
...
Fix formatting for JSX fragment tags
2018-01-04 15:27:36 -08:00
Matt Bierner
3f577b8617
Fix quick info for require template string ( #20851 )
...
* Fix quick info for require template string
Fixes #20850
* Add path completions tests
2018-01-04 15:17:40 -08:00
Wenlu Wang
2ea5f58d60
quick fix of indexed access type ( #20956 )
2018-01-04 12:45:16 -08:00
Andy
db82a5604a
Improve find-all-references for redeclared property in a derived interface ( #21002 )
2018-01-04 10:58:14 -08:00
Andy
7de8c6bcaa
For export default foo, use 'foo' for the completion identifier name, not the module name ( #20987 )
2018-01-03 14:56:59 -08:00
Andy
a33f229d82
Support completions contextual types in more places ( #20768 )
...
* Support completions contextual types in more places
* Adjust formatting
2018-01-03 13:51:33 -08:00
Wesley Wigham
e0f20334d2
Use inference for filling JSX attributes in getJsxElementInstanceType ( #20973 )
...
* Add simple type inference for JSX elements
* Small cleanups from PR feedback
2018-01-03 11:30:41 -08:00
Nathan Shively-Sanders
5539e11b76
Merge pull request #20609 from Microsoft/getRootSymbols
...
Ensure getRootSymbols always works recursively
2018-01-03 09:44:27 -08:00
Andy
74b8160430
In import fixes, use a ".js" extension if other imports do ( #20624 )
...
* In import fixes, use a ".js" extension if other imports do
* Code review
2018-01-03 08:20:53 -08:00
Daniel Rosenwasser
0477f91dba
Merge pull request #20928 from Microsoft/initializerWithPropertyAccessUseBeforeDeclaration
...
Check whether we have a class before testing whether we have a super-class
2017-12-29 14:47:13 -08:00
Daniel Rosenwasser
0d56a0545c
Added tests.
2017-12-29 12:30:18 -08:00
Wesley Wigham
ae211983eb
Add method signature handler to getTypeOfVariableOrParameterOrProperty ( #20825 )
2017-12-28 19:00:54 -08:00
Anders Hejlsberg
ff4f03c51d
Merge pull request #20882 from Microsoft/fixNarrowTypeBySwitch
...
Fix narrowing of type variable in switch statement
2017-12-28 09:22:26 -08:00
Benjamin Lichtman
80b7983d2c
Add formatting tests
2017-12-27 16:56:03 -08:00
Anders Hejlsberg
319ad71b15
Add regression test
2017-12-23 19:28:13 -08:00
Nathan Shively-Sanders
2df7a89e61
Merge branch 'master' into limit-recursive-structured-type-resolution
2017-12-22 14:41:58 -08:00
Nathan Shively-Sanders
fb3042c3f7
Move recursion limiter to individual resolve* functions
2017-12-22 14:39:25 -08:00
Wesley Wigham
81fbe12c54
User runner submodule improvements ( #20868 )
...
* Add a reset and clean stage to submodule user tests, improve logging when errors occur
* Also force remove node_modules, update baselines
2017-12-22 11:41:48 -08:00
Wesley Wigham
cedcba9285
Reset partial memberlist on defered circularity to calculate the correct members ( #20179 )
...
* Reset partial memberlist on defered circularity to calculate the correct members
* Remove return type
2017-12-22 11:41:39 -08:00
Wesley Wigham
7ad0d7b9fd
Fix higher order inference on indexed access types ( #20165 )
2017-12-21 14:47:03 -08:00
Wesley Wigham
00450f029c
Not all extended types have symbols ( #20827 )
2017-12-21 13:07:29 -08:00
Andy
813864f021
For import completion, use an existing namespace import ( #20457 )
2017-12-21 11:16:09 -08:00
Anders Hejlsberg
2f4c8ebf13
Add regression test
2017-12-19 19:58:28 -08:00
Daniel Rosenwasser
69e091b40d
Merge pull request #19797 from charlespierce/implements_class_error_message
...
Add new error message when class implements class
2017-12-19 11:39:05 -08:00
Daniel Rosenwasser
89b5d8cb14
Merge pull request #19204 from Kingwl/fix-completions-with-template-literal-type
...
fix completions for string literal types with template string (#19162 )
2017-12-19 11:18:21 -08:00
Wesley Wigham
6c15fc6634
Fix devtools test ( #20731 )
...
* Fix devtools test
* Add small test case mimicing the issue from the user test
2017-12-18 14:47:45 -08:00
Andy
60bd262437
Don't treat class name as a completion list blocker if the position comes after it ( #20762 )
2017-12-18 12:41:05 -08:00
Andy
1562a278f8
Don't add completion for method if the this parameter doesn't match ( #20616 )
2017-12-18 11:28:04 -08:00
Andy
2efc92d1dc
Adjust formatting rule priority: Never delete space after case ( #20615 )
2017-12-18 10:54:54 -08:00
Andy
9a62454485
Include static 'this' accesses in references of class ( #20483 )
2017-12-18 10:54:22 -08:00
Andrew Casey
5e2dec7727
Merge pull request #20729 from amcasey/GH19839
...
Refine Extract Local
2017-12-15 16:51:25 -08:00
Andrew Casey
08a9c61640
Update fourslash baseline
2017-12-15 16:31:27 -08:00
Wesley Wigham
ae73a9141d
Allow JSXAttributes types to be shortcut-spread into the spread type like normal objects ( #19047 )
...
* Bring jsx type resolution inline with normal objects, move jsx attribute property ignorign into relationship check
* Improved errors and reordered members
* Always use inferrential mode for jsx pass
* Add some missing skipLibChecks
* New check mode instead of odd type mapper
* Do not enable object literal freshness checks on jsx spreads
* Fix minor style nits
* Update order of type for test
* Accept corrected baseline
2017-12-15 16:13:28 -08:00
Wesley Wigham
dd933f4413
Fix get symbol at location to behave correctly for parameter assignments and jsx attributes ( #20706 )
...
* Fix get symbol at location to behave correctly got parameter assignments and jsx attributes
* Handle all those edge cases that weren;t explicitly handled
* Fix part of bug WRT getTypeAtLocation and for loops
* Baseline corrections pursuant to #20710
* Restore jsdoc tag interpretation
* Clean up some code, revert fourslash tests
* Cleanup types used by PR feedback
2017-12-15 15:50:22 -08:00
Wesley Wigham
d89d68f426
make jsx attributes mutable locations ( #20710 )
2017-12-15 10:02:56 -08:00
Benjamin Lichtman
26c1a49d59
Merge pull request #20640 from uniqueiniquity/revertToJsDocInclusionList
...
Revert to inclusion list for JsDoc comment completion
2017-12-14 14:37:31 -05:00
Wesley Wigham
e1278f091c
Get resolved module exports in symbol chain and not raw exports ( #20661 )
...
* Actually get module exports and not module exports sans export stars
* style update
* Trim test a bit
2017-12-13 14:01:23 -08:00
Ryan Cavanaugh
f6603cd9f2
Merge pull request #20545 from RyanCavanaugh/codefixOmnibus
...
Omnibus fixes for telemetry-sourced crashes
2017-12-13 12:49:58 -08:00
Andy Hanson
9533c0093d
Merge branch 'master' into getRootSymbols
2017-12-13 12:26:57 -08:00
Andy
6fbeced025
Simplify test case ( #20675 )
2017-12-13 11:03:37 -08:00
Wesley Wigham
40029a0523
Use TypeFlags.UnionOrIntersection not TypeFlags.Union ( #20662 )
2017-12-12 16:32:55 -08:00
Andy
8ad4aeece1
Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter ( #20574 )
...
* Make ChangeTracker#newLineCharacter public, to avoid having to pass newLineCharacter around as a parameter
* Don't require newLineCharacter as input to ChangeTracker methods, and make it private again
2017-12-12 12:23:13 -08:00
Nathan Shively-Sanders
4bc0d85d29
Test:spread object retains lefthandside
...
1. Make sure that spreading `object` doesn't lose everything to the left.
2. Update baselines to show that `{ ...object }` is now `{}`.
2017-12-12 08:37:34 -08:00
Andy
d53af092c7
Always check a return expression in a generator ( #20621 )
2017-12-12 07:50:11 -08:00
Charles Pierce
c489dd96f6
Resolve merge conflicts in codeFix
2017-12-11 22:27:56 -08:00
uniqueiniquity
03b036b630
Revert "Loosen restrictions on jsdoc completion locations"
...
This reverts commit 612616a1058d7aa9fc181126f83041549bfbe295.
2017-12-11 15:56:31 -08:00
Wesley Wigham
eba15b5990
Preserve literal types in contextual unions ( #19966 )
...
* Cherrypick non-comparability related changes from prolific literals PR
* Renames and other style changes
* Accept changes to new tests
* Exclude the domain root from contextual typing literals except for type variables
* Readd simple preservation fix
* Add huge map test
* Revert changes to widening on destructuring initalizers
* Use tristate for subtype-reduction type
* Rename type and argument
* Move longer-running test to user suite
2017-12-11 18:03:38 -05:00
Wesley Wigham
d01f4d140a
Reimplement #20320 differently to handle multiple check orders better ( #20588 )
...
* Reimplement #20320 less elegantly but handle odd check orders better
* Consolidate 2 of 3 conditions
2017-12-11 13:32:16 -05:00
