20279 Commits

Author SHA1 Message Date
Anders Hejlsberg
5ad46b180b Fix minor issue 2019-06-05 16:53:42 -07:00
Anders Hejlsberg
2e99438edc Handle numeric enums in mapped types + fix obscure crash 2019-06-05 14:57:18 -07:00
csigs
30333e19e2 LEGO: check in for master to temporary branch. 2019-06-03 16:10:14 +00:00
Anders Hejlsberg
a5281ada54
Merge pull request #31687 from microsoft/enumImplicitIndexSignatures
Implicit index signatures for enum object types
2019-06-02 07:42:58 -07:00
Anders Hejlsberg
d6c323a21b
Merge pull request #31711 from microsoft/fixDestructuringWithFallback
Fix destructuring with fallback
2019-06-01 17:30:07 -07:00
Anders Hejlsberg
d548f6af70 Consider object literals in unions to have properties of type 'undefined' 2019-06-01 09:45:58 -07:00
Benjamin Lichtman
eb81feaf04
Merge pull request #31685 from uniqueiniquity/stopInvalidatingOnOpenFileSave
Stop invalidating module resolution cache when saving an open file
2019-05-31 20:36:33 -04:00
Anders Hejlsberg
4fc5f6a5ff When binding pattern contextually types x || y, x contextually types y 2019-05-31 16:40:22 -07:00
Wesley Wigham
41ce98b440
Propagate saved variance flags from cached comparisons (#31688)
* Propegate saved variance flags from cached comparisons

* Propegate variance a bit more selectively

* Add test

* Remove now-redundant code

* Fix misspelling and remove unneeded branch
2019-05-31 16:11:08 -07:00
Benjamin Lichtman
d3b6ba557a Change test instead of behavior 2019-05-31 14:46:15 -07:00
Benjamin Lichtman
7ac5fa783b Refactor and add wildcard scenario 2019-05-31 11:24:54 -07:00
Anders Hejlsberg
aaa55923e8 Permit assignment this.xxx when class has index signature 2019-05-31 11:03:49 -07:00
Anders Hejlsberg
bb15df3e43 Fix lint error 2019-05-30 21:06:51 -07:00
Benjamin Lichtman
6b92ccaffa Respond to CR 2019-05-30 17:22:12 -07:00
Benjamin Lichtman
a30cacb562 Add test 2019-05-30 16:56:27 -07:00
Anders Hejlsberg
0b53b8e7f8 Merge branch 'master' into enumImplicitIndexSignatures 2019-05-30 16:38:25 -07:00
Anders Hejlsberg
7dc1f40dc1
Merge pull request #31680 from microsoft/fixGenericReturnTypeInference
Fix generic return type inference
2019-05-30 16:33:22 -07:00
Anders Hejlsberg
08d8f97bb4 Add comment 2019-05-30 16:06:49 -07:00
Benjamin Lichtman
8c443b1481 Stop invalidating resolution when file stays open 2019-05-30 15:05:53 -07:00
Anders Hejlsberg
82ea88569e
Merge pull request #31662 from microsoft/fixTypeAliasInference
Fix contravariant type alias inference
2019-05-30 14:09:35 -07:00
Andrew Branch
b8dcf27c3e
Merge pull request #31482 from andrewbranch/bug/31338
Organize imports: don’t delete import declarations used for module augmentation
2019-05-30 14:01:55 -07:00
Anders Hejlsberg
08cd0b3700 Use proper variances when inferring between type alias instantiations 2019-05-29 12:42:43 -07:00
Daniel Rosenwasser
94f19c7edd Update version to 3.6.0. 2019-05-29 08:59:44 -07:00
Anders Hejlsberg
b75a90e95a Return type inference should not include parameter inferences 2019-05-28 16:32:10 -07:00
Wesley Wigham
cd09cbbd5e
Cache widened types (#31586)
* Cache widened types

* Fix lint
2019-05-28 13:13:46 -07:00
Wesley Wigham
e70f2af25d
Defer union or intersection property type normalization (#31486)
* Defer union or intersection property type normalization

* Accept moved span
2019-05-28 10:51:47 -07:00
Daniel Rosenwasser
38f3b05cb1
31304 - Autocomplete for enum values fails when typing "/" (#31362)
31304 - Autocomplete for enum values fails when typing "/"
2019-05-24 16:17:25 -07:00
Sheetal Nandi
57d9ecc39f Do not log errors when ts server plugin is not found in one folder but is eventually resolved.
Fixes #30106
2019-05-24 15:15:04 -07:00
Andrew Branch
a06ab8532c
Merge pull request #31560 from andrewbranch/bug/31485
Fix crash when creating a union signature from signatures that do and don’t have `this` types
2019-05-24 10:30:47 -07:00
Andrew Branch
9380b9f920
Merge pull request #31568 from andrewbranch/bug/31347
Fix containsPrecedingToken for tokens whose preceding token is a missing node
2019-05-24 10:29:21 -07:00
Anders Hejlsberg
7ff97d1393
Merge pull request #31572 from microsoft/normalizedIntersectionLimiter
Limit size of union types resulting from intersection type normalization
2019-05-23 17:57:33 -07:00
Ron Buckton
b460d8cd26
Expose getTypeOfArrayLiteralOrObjectLiteralDestructuringAssignment with better name (#31564) 2019-05-23 17:50:44 -07:00
Ron Buckton
dfd28d2751
Fix handling of empty 'types', 'typings', etc. fields in package.json (#31539) 2019-05-23 17:19:32 -07:00
Wesley Wigham
bb4080c175
Collect _all_ symlinks a file may have witnessed when attempting to generate specifiers (#31571) 2019-05-23 17:17:24 -07:00
Anders Hejlsberg
f20a4fdfc4 Limit size of union types resulting from intersection type normalization 2019-05-23 15:39:40 -07:00
Titian Cernicova-Dragomir
8ab0a25211 Improve error messages when indexing into a type (#31379)
* Improved error messages when indexing an object type with a literal string, a literal string union or a string.

* Added more specific message when using the indexing operator with an incompatible index argument.

* Fixed spelling and error message.
2019-05-23 15:27:50 -07:00
Andrew Branch
a2b40292fe
Merge pull request #31542 from andrewbranch/bug/31481
Error when writing to rest element range of readonly tuple
2019-05-23 13:38:09 -07:00
Nathan Shively-Sanders
5d9d4b2553
Manually copy just postMessage changes (#31557)
* Manually copy just postMessage changes

* Update baselines
2019-05-23 13:26:41 -07:00
Andrew Branch
f97f57c155
Fix containsPrecedingToken for tokens whose preceding token is a missing node 2019-05-23 12:15:50 -07:00
Nathan Shively-Sanders
4d27361680
Allow JS with isolated modules (#31483)
* Allow JS with isolated modules

Previously legacy JS code was not allowed; it was required to use ES6
module syntax. Unfortunately, the check happens after parsing but before
binding, and the commonjs module indicator isn't set until binding
because it's not syntactically simple like the ES6 module indicator,
which is set during parsing.

So I decided that JS should be allowed during isolatedModules
unconditionally. We're not going to be transforming it anyway.

* Update baselines

* Switch test to outDir instead of noEmit
2019-05-23 11:09:28 -07:00
Sheetal Nandi
ae7a1b4f56
Merge pull request #31541 from microsoft/packageId
Always use resolved file to figure out subModule name in package id
2019-05-23 10:50:13 -07:00
Anders Hejlsberg
e6013335b9
Merge pull request #31537 from microsoft/fixIndexedAccessConstraint
Fix indexed access constraint
2019-05-22 18:35:15 -07:00
Andrew Branch
300cbef071
Don’t crash when creating a union signature from signatures that do and don’t have this types 2019-05-22 17:42:05 -07:00
Anders Hejlsberg
cd7a14ac21 Reuse getSimplifiedTypeOrConstraint function 2019-05-22 17:22:33 -07:00
Anders Hejlsberg
b688e25cd3 Implement inferrable index signatures for enum types 2019-05-22 17:12:37 -07:00
Andrew Branch
9f6791a5ab
Error when writing to readonly tuple in rest element range 2019-05-22 15:03:17 -07:00
Sheetal Nandi
5d188a8c68 Always use resolved file to figure out subModule name in package id
Fixes #30429
2019-05-22 14:30:56 -07:00
Sheetal Nandi
85d3c5d7a1 Trace Package id at the module resolution site 2019-05-22 12:35:20 -07:00
Andrew Branch
60d0bb9b19
Don’t touch imports used for module augmentation in non-declaration files since it could change JS emit 2019-05-22 11:37:35 -07:00
Ron Buckton
6a559e37ee
Fix crash when checking invalid object rest (#31530) 2019-05-22 11:20:57 -07:00