18628 Commits

Author SHA1 Message Date
Ryan Cavanaugh
5666be682c
Merge pull request #27517 from brandonmbanks/typo-comments
fix typo in performance mark name
2018-10-03 09:41:11 -07:00
Nathan Shively-Sanders
9aeb6e2ac4
Also --init git submodules when running user tests (#27508) 2018-10-03 06:31:26 -07:00
Brandon Banks
804a2fd66a fix typo in performance mark name 2018-10-02 22:52:17 -04:00
Andy
16766b196c
textChanges: Reuse some methods (#27492) 2018-10-02 17:34:17 -07:00
Ryan Cavanaugh
5f96fb13b2
Merge pull request #27313 from spratmannc/spratmannc/fixing-extends-helper
adding missing semi-colon to extendsHelper
2018-10-02 12:06:04 -07:00
Ryan Cavanaugh
c04faa1e5b
Merge pull request #27485 from IllusionMH/fix-completionInfo-exception-27338
Use safe some function to handle undefined declarations (fixes #27338)
2018-10-02 11:28:38 -07:00
Wesley Wigham
1e55d650f3
Exclude the overlap between Type and Value when checking for parameter visibility (#27444) 2018-10-02 09:41:06 -07:00
Valera Rozuvan
b15d6a48cb Fix GH#18217 issue for FileLog. (#27430)
* Fix GH#18217 issue for FileLog.

* Refactor FileLog class to not use isEnabled property.
2018-10-02 09:09:51 -07:00
Alessandro Vergani
bbf77538c4
Remove unneeded check from getTransformationBody
Remove unneeded `argName` check, because it always evaluates to `true` (the `false` case is handled just before the modified line)
2018-10-02 16:02:04 +02:00
Benjamin Lichtman
f356cd6c89 Insert async keyword as last modifier (#27491) 2018-10-01 17:43:17 -07:00
Ryan Cavanaugh
70e26fc701
Merge pull request #27447 from mattmccutchen/issue-27117
Don't complain about `modules` and `outFile` options when `emitDeclarationOnly` is set.
2018-10-01 15:50:08 -07:00
Sheetal Nandi
29dd67ec40
Merge pull request #27443 from Microsoft/errorMessageLogger
Default logger for projectService has assert on exceptions being logged in tsserver
2018-10-01 15:04:03 -07:00
Sheetal Nandi
6e8027e95e
Merge pull request #27395 from Microsoft/noFilesError
Refactoring to unify updating no input files error
2018-10-01 15:03:44 -07:00
Ryan Cavanaugh
3331d073c4
Merge pull request #26070 from ajafff/tuple-rest
Infer array rest as tuple if possible
2018-10-01 13:56:28 -07:00
IllusionMH
d0abd399af Use safe some function to handle undefined declarations (fixes #27338) 2018-10-01 23:11:32 +03:00
Sheetal Nandi
d2647a1dda
Merge pull request #27483 from Microsoft/redirects
Fix issue of program not being reused when host implements getSourceFileByPath
2018-10-01 12:46:59 -07:00
Andy
8feddcd16d
Clean up amalgamatedDuplicates (#27285)
* Clean up amalgamatedDuplicates

* Code review
2018-10-01 12:16:49 -07:00
Andy
115636bb93
Minor cleanup in bindNamespaceExportDeclaration (#27367)
* Minor cleanup in bindNamespaceExportDeclaration

* Change formatting
2018-10-01 12:15:10 -07:00
Sheetal Nandi
dd3277c219 PR feedback 2018-10-01 12:12:22 -07:00
Sheetal Nandi
bc23037e14
Merge pull request #27438 from Microsoft/failedLookupNotMatchingPath
Handle the case of failed lookup location being not normalized in resolutionCache to watch the path
2018-10-01 11:57:34 -07:00
Sheetal Nandi
1c2f2555ec Add resolvedPath and originalFileName to redirected file
Fixes #27207
2018-10-01 11:51:45 -07:00
Sheetal Nandi
c197bae990 Add tests for failing redirect reuse of program when host implements getSourceFileByPath
Test for #27207
2018-10-01 11:51:30 -07:00
Matt McCutchen
32e75e7ae7 Don't complain about modules and outFile options when
`emitDeclarationOnly` is set.

Fixes #27117.
2018-09-28 21:07:48 -04:00
Sheetal Nandi
6549969d2c Default logger for projectService has assert on exceptions being logged in tsserver 2018-09-28 15:47:34 -07:00
Sheetal Nandi
552777d70e When there is parse error do not verify actual errors 2018-09-28 15:28:44 -07:00
Sheetal Nandi
ee04b8c7f3 Handle the case of failed lookup location being not normalized.
Also fixed issue where type defs with relative name didnt resolve when directoryExists is present on the host
Fixes #27405
2018-09-28 14:40:34 -07:00
Sheetal Nandi
0245c2d35e Only copy non error values in array when converting the json
Fixes #27432
2018-09-28 13:49:00 -07:00
Nathan Shively-Sanders
21148b3b0a
Fix typo in PseudoPragma* types (#27437) 2018-09-28 10:39:30 -07:00
Nathan Shively-Sanders
6d92a2942f
Fix parent points in unreachable code (#27400) (#27406)
In the binder, unreachable code mistakenly skips the `bindJSDoc` call in
`bindChildrenWorker`, which sets parent pointers. The fix is to call
`bindJSDoc` in the case of unreachable code as well.
2018-09-28 08:31:56 -07:00
Dhruv Rajvanshi
bde81deed2 Issue #27301: Fixed crash when converting function to async (#27396) 2018-09-27 18:56:37 -07:00
Andy
19af881f94
ExpressionWithTypeArguments parent may be a JSDocAugmentsTag (#27229) 2018-09-27 18:26:57 -07:00
Wesley Wigham
26eb6ab6f4
Primitives should not be instanceof... anything (#27402) 2018-09-27 15:49:51 -07:00
Ron Buckton
9cf201c512
Merge pull request #27204 from Microsoft/fixPerIteration
Fix per-iteration bindings in for-loop head
2018-09-27 13:23:03 -07:00
Wesley Wigham
7bf382e73f
Allow empty files lists in tsconfigs with an extends member (#27383) 2018-09-27 12:40:29 -07:00
Sheetal Nandi
aed876dfb4 Refactoring to unify updating no input files error 2018-09-27 11:58:15 -07:00
Andy
5f2741b2ba
Make RenameInfo a union (#27382) 2018-09-27 08:56:40 -07:00
Andy
0a97663843
Add 'prefixText' and 'suffixText' when renaming shorthand properties (#27356)
* Add 'prefixText' and 'suffixText' when renaming shorthand properties

* Make prefixText and suffixText missing instead of undefined

* Fix test
2018-09-26 16:58:01 -07:00
Wesley Wigham
bf3cea7f6d
Remove project tests from default compiler flag 2018-09-26 16:36:47 -07:00
Anders Hejlsberg
d7219b21c2
Merge pull request #27357 from Microsoft/fixBivariantInferences
Make contravariant inferences only from pure contravariant positions
2018-09-26 14:03:59 -07:00
Nathan Shively-Sanders
98ec1e8730
Fix commonjs export= merging (#27368) (#27371)
I'm surprised we haven't seen more of this; I suspect it's because the
mixed `module.exports=` + `export.foo=` pattern isn't that common.
However, it'll happen any time that the exported symbol is unknown;
getCommonJsExportEquals blithely clones unknownSymbol and proceeds to
stick the `exports.foo=` properties onto it.

This causes problems later, because the compiler checks for
unknownSymbol with `===`. The fix is to not stick properties onto a
clone of unknownSymbol. This makes the correct errors appear and removes
the crash.
2018-09-26 12:40:30 -07:00
Andy
c435d1c9a4
Log text of relevant file after an exception (#27006)
* Log text of relevant file after an exception

* Require LogLevel.verbose
2018-09-26 11:31:59 -07:00
Andy
4855920314
navigationBar/Tree: Better description for anonymous function (#27063) 2018-09-26 11:22:44 -07:00
Andy
b3dd471584
Support completions after 'async' in object literal (#27250) 2018-09-26 11:22:27 -07:00
Andy
d4d947e488
Fix bug: Allow completions after '@' with no contextToken (#27325) 2018-09-26 11:22:08 -07:00
Sheetal Nandi
1a63c67e8a
Merge pull request #27260 from valera-rozuvan/fix-27086
Fix 27086. Ignore directories starting with a dot.
2018-09-26 11:11:37 -07:00
Nathan Shively-Sanders
4fac5f26dc
Fix crash in use-before-def checking of enum tag (#27350) (#27354) 2018-09-26 09:05:18 -07:00
Anders Hejlsberg
f59229bf22 Only add unique inferences to candidate arrays 2018-09-26 06:54:37 -07:00
Anders Hejlsberg
5e55118076 Only make contravariant inferences from pure contravariant positions 2018-09-25 18:07:51 -07:00
Daniel Rosenwasser
e1fd0ea53e Bump version to 3.2. 2018-09-25 16:48:03 -04:00
Anders Hejlsberg
5510e0755e Merge branch 'master' into typedBindCallApply
# Conflicts:
#	tests/baselines/reference/tsxTypeArgumentPartialDefinitionStillErrors.errors.txt
#	tests/baselines/reference/wrappedAndRecursiveConstraints4.errors.txt
2018-09-24 16:38:39 -07:00