Commit Graph

3006 Commits

Author SHA1 Message Date
Wesley Wigham
4da9d8bc87 Include index signatures of the source in mapped type template target inferences (#29253) 2019-01-25 15:22:35 -08:00
Ron Buckton
469ab3fdd0 Merge branch 'master' into fix29006 2019-01-24 16:50:50 -08:00
Ryan Cavanaugh
d85c4e551e Merge pull request #27121 from xl1/26977-typedarray
Allow non-number source for TypedArray.from
2019-01-24 13:42:43 -08:00
Anders Hejlsberg
71d70ef161 Merge pull request #29563 from Microsoft/fixSwitchControlFlow
Fix switch statement control flow logic
2019-01-24 10:36:52 -08:00
Anders Hejlsberg
500c4729e9 Add additional repro 2019-01-24 10:12:35 -08:00
Anders Hejlsberg
83f7f4d190 Add regression test 2019-01-24 09:30:46 -08:00
xiaofa
d7601b755f fix trailing comma should not allowed in dynamic import argument 2019-01-24 18:16:34 +08:00
Ron Buckton
60639ce5a8 Replace most instances of getTextOfPropertyName in checker 2019-01-22 14:24:21 -08:00
kingwl
e8497096d8 Merge branch 'master' into improve_type_arguments_parser_1 2019-01-20 01:54:49 +08:00
Wesley Wigham
20285e66e9 Include all flow nodes made within try blocks as antecedents for catch or finally blocks (#29466)
* Include all flow nodes made within `try` blocks as antecedents for `catch` or `finally` blocks

* Fix typo
2019-01-18 14:43:31 -08:00
Wesley Wigham
addeff325b Make the relationship between partial mapped types and the empty object not apply for subtype relationship (#29384) 2019-01-17 15:42:58 -08:00
Wesley Wigham
b6ae492009 Add missing arity check on second inference pass (#29386) 2019-01-17 15:21:17 -08:00
Wesley Wigham
49689894d7 Elaborate jsx children elementwise (#29264)
* Heavy WIP, but has good contextual typing fix

* Add arity error, refine messages and spans

* Small error message change

* Better error messages, text-specific message
2019-01-15 11:32:36 -08:00
Ron Buckton
208148d05c Fix crash in getTextOfPropertyName 2019-01-14 17:47:52 -08:00
Wesley Wigham
dc0f4afe5e Save & recalculate declare flag modifier on late printed statements (#29412)
* Save & recalculate declre flag modifier on late printed statements

* Accept related baseline updates
2019-01-14 13:53:04 -08:00
Sheetal Nandi
d4055a3234 Merge pull request #26017 from ajafff/rest-param-destructuring
allow BindingPattern in FunctionRestParameter
2019-01-14 10:58:19 -08:00
Wesley Wigham
aba0b700b6 Allow circular umd-merged-with-augmentation refs to resolve to the module as intended (#29335) 2019-01-10 14:48:15 -08:00
Wesley Wigham
76f444e338 Allow nonnull assertions in references (#29351) 2019-01-10 14:45:19 -08:00
Wesley Wigham
d0aff9bdcd Fix crash (#29333) 2019-01-09 14:23:57 -08:00
Daniel Rosenwasser
6bfb935929 Merge pull request #25445 from a-tarasyuk/bug/24542-bad-error-message-for-import-ing-an-export
24542 - bad error message for `import *`-ing an `export=`
2019-01-09 11:02:14 -08:00
Klaus Meinhardt
b52a7fc3ea Exclude JSDoc @extends from 'super()' checks (#29308)
* Exclude JSDoc @extends from 'super()' checks

This fixes a similar problem as #29244 where JSDoc `@extends`

* fix check 'super can only be referenced in a derived class'
2019-01-09 10:35:22 -08:00
Wesley Wigham
19c72c758a Allow untyped calls on unions of untyped things (#29265) 2019-01-08 11:05:55 -08:00
Alexander T
52057ac4f6 Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/24542-bad-error-message-for-import-ing-an-export 2019-01-08 10:55:11 +02:00
Martin Probst
7a2b2cebbf Do not emit code for @extends tags in JS. (#29244)
When transpiling JavaScript, TS3.1+ emits `@extends` tags as code. E.g.

    /** @extends {SuperClass} */
    class SubClass {}

Causes an ES5 emit that references SuperClass:

    /**
    * @extends {SomeBase}
    */
    var SubClass = /** @class */ (function (_super) {
        __extends(SubClass, _super);
        function SubClass() {
            return _super !== null && _super.apply(this, arguments) || this;
        }
        return SubClass;
    }(SomeBase));

Note the literal references to `SomeBase`.

This appears to be an accidental effect of 0f55566cf4. It refactored
`getEffectiveBaseTypeNode` for type checking, but missed an instance
where it is also used for emit logic. This change fixes the problem by
specifically getting the heritage clauses directly off the AST.

Change-Id: I3128a757e5924e2528c61230a90ac13650852542
2019-01-04 08:13:14 -08:00
Klaus Meinhardt
66314e1f85 Merge branch 'master' of github.com:Microsoft/TypeScript into rest-param-destructuring 2019-01-03 17:45:17 +01:00
Anders Hejlsberg
beebda3574 Merge pull request #29110 from Microsoft/fixDiscriminantCheck
Fix discriminant property check
2018-12-30 17:46:01 -10:00
Anders Hejlsberg
fd3af78b8b Merge pull request #29179 from Microsoft/typeParameterDefaultForwardReference
No self or forward references in type parameter defaults
2018-12-30 17:43:57 -10:00
Anders Hejlsberg
7f4d1ac475 Add regression test 2018-12-28 09:38:19 -10:00
Anders Hejlsberg
a400a8afec Add regression test 2018-12-27 14:05:14 -10:00
Anders Hejlsberg
3e93461fc8 Add regression test 2018-12-20 07:21:49 -08:00
Wesley Wigham
08022d57c8 Allow calls on unions of dissimilar signatures (#29011)
* Add core of new union signature logic and test - needs intersection signature logic to fully work

* Add inversion of variance for class props lookup from union sig returns

* Fix lints

* Combine parameter names for nicer quick info

* PR feedback 1

* Fix miscopy

* PR feedback round 2

* Remove argument name combining because loc :(

* Nit cleanup round 3

* Reinline getTupleTypeForArgumentAtPos

* Remove a tad more

* No step on sneky off-by-one error
2018-12-19 16:35:01 -08:00
Daniel Rosenwasser
ab2a38ebef Merge pull request #29102 from Microsoft/declarationEmitForDefaultExportClassExtendingExpression
Declaration emit for default exported class extending expression
2018-12-19 16:19:36 -08:00
Daniel Rosenwasser
54352dc1c9 Added test case. 2018-12-19 15:51:31 -08:00
Wesley Wigham
d23effc200 Non-latebound computed property names should print as their underlying name type (#29084) 2018-12-18 17:02:34 -08:00
Wesley Wigham
4e3bc9e35a Reset constEnumOnlyModule flag on relevant symbol merges in binder (#29079) 2018-12-18 12:31:53 -08:00
Alexander T
78707b206a Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/24542-bad-error-message-for-import-ing-an-export 2018-12-18 10:41:31 +02:00
Anders Hejlsberg
c52e5985b7 Merge pull request #29068 from Microsoft/noGenericEmptyObject
Generic types should never be considered empty objects
2018-12-17 15:59:42 -08:00
Wesley Wigham
d2885eab4a Add regression test for #29047 (#29066) 2018-12-17 14:56:48 -08:00
Anders Hejlsberg
ab797df977 Add regression test 2018-12-17 14:14:54 -08:00
Daniel Rosenwasser
4d74f67325 Merge pull request #28888 from Microsoft/numericPropertyAccess
Avoid adding a dot when comment a property acccess's expression has trailing comments
2018-12-13 15:18:27 -08:00
Wesley Wigham
5788446aa1 Use contextual parameter types over binding pattern initializer types (#28967)
* Use contextual parameter types over binding pattern initializer types

* Remove unneeded check
2018-12-12 15:39:32 -08:00
Daniel Rosenwasser
2999a1eb47 Merge remote-tracking branch 'origin/master' into numericPropertyAccess 2018-12-11 16:52:23 -08:00
Philip Pesca
e6aa992095 Fix error message when type argument arity is wrong (#28366)
* Fix error message when type argument arity is wrong

* Parenthesize 's' in plurals

* Update baseline

* Update baseline

* Use old error message

* Revert parantheses
2018-12-11 09:54:38 -08:00
Daniel Rosenwasser
2e9be8c05b Added more tests, including some in 'removeComments' mode. 2018-12-10 22:21:15 -08:00
Daniel Rosenwasser
bc59582c7d Merge pull request #28627 from ajafff/arrow-arguments
ArrowFunction has no own 'arguments'
2018-12-10 11:42:43 -08:00
Daniel Rosenwasser
8150169762 Merge pull request #28857 from JoshuaKGoldberg/identifiers-after-numeric-literals
Added error for IdentifierStart immediately after a NumericLiteral
2018-12-06 11:49:56 -08:00
Josh Goldberg
a211184347 Clarified error message; extended error to identifier end
Lengthening the reported error length to include all of the identifier necessitates scanning for all of the identifier. I also reset the `pos` after so other identifier scanning still happens.
2018-12-06 11:17:06 -08:00
Daniel Rosenwasser
3fe72631ce Added test case for trivia preceding dot in numeric LHS in property accesses. 2018-12-05 15:02:00 -08:00
Anders Hejlsberg
07dbc56208 Merge pull request #28854 from Microsoft/fixExcessPropertyChecks
Improve excess property checks
2018-12-05 08:51:08 -08:00
Josh Goldberg
174816fc26 Added error for IdentifierStart immediately after a NumericLiteral
Fixes #4702.
2018-12-04 17:59:20 -08:00