Andy
dcd3b5e1f7
At <div x=/**/, completion insertText should be wrapped in braces ( #21372 )
2018-01-25 09:02:20 -08:00
Andy
0b7f6d5911
Fix bug: Support this. completions even when isGlobalCompletion is false ( #21330 )
2018-01-25 07:42:01 -08:00
Ron Buckton
5698a6ab52
Fix loop labels for for..await
2018-01-25 02:11:01 -08:00
Andy
d333d889c1
Test for (and fix) order of import fixes ( #21398 )
2018-01-24 15:06:52 -08:00
Wesley Wigham
ba797f2c50
Add flag to skip qualification check when symbol is already in the process of being qualified ( #21337 )
2018-01-24 12:37:45 -08:00
Andy
d4b3bd16c4
Add KeywordCompletionFilters.TypeKeywords ( #21364 )
2018-01-23 10:57:35 -08:00
Nathan Shively-Sanders
a3387cc41f
Merge pull request #21328 from Lazarus535/master
...
Fixes #17080
2018-01-22 14:08:21 -08:00
Nathan Shively-Sanders
ae652404cd
Fix JSX attribute checking when spreading unions
...
Previously, the code didn't account for the fact that spreading a union
creates a union. In fact, before Decemeber, spreading a union in JSX
didn't create a union.
Now the check for properties of the spread type uses
`getPropertiesOfType`, which works with unions, instead of accessing the
`properties` property directly.
2018-01-22 13:34:12 -08:00
Nathan Shively-Sanders
97fb0fd55f
Add semicolon to unused class member list
...
Turns out SemicolonClassElement is a specific kind for semicolons inside
a class. Having one of them with --noUnusedLocals on would crash the
compiler after the assert added in #21013 .
2018-01-22 12:59:53 -08:00
Stephan Ginthör
b9a2d7f0ef
Merge branch 'master' of https://github.com/Microsoft/TypeScript
2018-01-22 21:47:12 +01:00
Stephan Ginthör
d11341820e
Fixes #17080
...
Fixed the two requested changes.
1) Deleting the file "pull_request_template.md"
2) Declaring functions in tests, instead of defining
2018-01-22 21:45:37 +01:00
Andy
588716926d
Fix bug: result of createUnionOrIntersectionProperty may be undefined ( #21332 )
2018-01-22 10:15:57 -08:00
Stephan Ginthör
5a87a94c59
Fixes #17080
...
https://github.com/Microsoft/TypeScript/issues/17080
Added testcases from the Github bugreport (all working as intended now).
Signed CLA.
2018-01-22 13:40:57 +01:00
Stephan Ginthör
18e1ac0306
Fixes #17080
...
Changes are in src/compiler.checker.ts only
The second arguments to the function "removeOptionalityFromDeclaredType" has been changed from "getRootDeclaration(declaration)" to "declaration".
2018-01-22 09:52:58 +01:00
Esakki Raj
92bde084c1
Fix formatting between for and await ( #21254 )
...
* Fix issue 21084
* Removed unwanted rules.
2018-01-21 09:45:58 -08:00
Wenlu Wang
d1ff12e0a6
add completion filter for function like body ( #21257 )
2018-01-19 17:26:58 -08:00
Wesley Wigham
d4c36120cf
Make nonnull assertions and binding patterns apparent declared type locations ( #20995 )
...
* Use apparent type of original type to handle indexes
* Redo older fix causing new bug by extending getDeclaredOrApparentType instead of getTypeWithFacts
* Rename symbol
2018-01-19 16:06:42 -08:00
Andy
6224d51f84
For { type: "a" } | { type: "b" }, find references for the union property ( #21298 )
2018-01-19 16:04:30 -08:00
Nathan Shively-Sanders
eed85737b8
Merge pull request #21271 from Microsoft/infer-keyof-to-any-not-empty
...
Inference of string literals to keyof creates an object with props of type `any`, not `{}`
2018-01-19 13:35:22 -08:00
Nathan Shively-Sanders
4632ed6dda
Merge pull request #21242 from Microsoft/fix-indexed-access-relation
...
Fix indexed access relation
2018-01-19 13:13:14 -08:00
Andy
0a90c67c07
Support testing definition range of a reference gruop ( #21302 )
2018-01-19 12:15:41 -08:00
Anders Hejlsberg
f6c79a631c
Add regression test
2018-01-18 17:28:37 -08:00
Andrew Casey
ebbb3a4dc4
Merge pull request #21158 from amcasey/NewlineConsistency
...
Handle linebreaks consistently in code fixes and refactorings
2018-01-18 16:02:27 -08:00
Nathan Shively-Sanders
39fee67d8e
Merge pull request #21110 from jack-williams/strict-null-empty-destructuring
...
Fix #20873 : Enforce strictNullChecks for RHS of empty destructuring assignment
2018-01-18 14:24:50 -08:00
Wesley Wigham
5fcde240e3
External test runner updates ( #21276 )
...
* Increase user test timeout to 10m because npm can be slow, remove parse5 because they added their own types, accept updated error msg for rxjs, acccept current chrome baseline and pin chrmoe version
* Suppress lint
2018-01-18 13:48:23 -08:00
Andy
b5ae9de7ba
Add grammar error for const { ...a: b } = {}; ( #21267 )
...
* Add grammar error for `const { ...a: b } = {};`
* Fix bug: bring in forEachChild change from #21268
2018-01-18 10:57:35 -08:00
Andy
9436b1cc0b
Fix formatter crash for const { ...a: b } = {};: forEachChild and emitBindingElement should handle ... before the propertyName ( #21268 )
2018-01-18 10:36:41 -08:00
Nathan Shively-Sanders
f0b4018017
Infer:string literal->keyof creates any props not {}
2018-01-18 08:44:57 -08:00
Andy
73922301bc
In formatter, get lineAction directly from applyRuleEdits ( #21245 )
2018-01-17 16:02:42 -08:00
Andrew Casey
095aa771f5
Merge pull request #21144 from amcasey/GH18274
...
Special case arrow functions with only parameter unused
2018-01-17 15:45:17 -08:00
Andrew Casey
3ca1cc406a
Clean up TODOs for #18445
2018-01-17 15:29:41 -08:00
Wesley Wigham
99d6b0d308
Actually get the apparent type of intersection members when calculating intersection apparent types ( #21133 )
...
* Actually get the apparent type of intersection members when calculating intersection apparent types
* Add nonjsx variant
* Fix nit
2018-01-17 15:20:09 -08:00
Andrew Casey
db3f7c538e
Update test baselines
2018-01-17 15:18:54 -08:00
Andrew Casey
5de6ac1a2f
Simplify test cases
2018-01-17 15:06:54 -08:00
Andrew Casey
3b5689fa1f
Add more test coverage for unusedParameterInLambda
2018-01-17 15:06:54 -08:00
Andy
ec37651308
Use packageId for suggestion to install @types/packageName ( #21241 )
2018-01-17 14:22:58 -08:00
Mohamed Hegazy
b0d7d5a7ef
Fix #21089 : Do not infer from numeric index signature in Object.values and Object.entries ( #21129 )
...
* Fix https://github.com/Microsoft/TypeScript/issues/21089 : Do not infer from numeric index signature in Object.values and Object.entries
* Update test
2018-01-17 14:16:11 -08:00
Nathan Shively-Sanders
485ec34e8e
Test assignability of indexed access types
2018-01-17 13:22:31 -08:00
Ron Buckton
3c988e8f5a
Merge pull request #21215 from Microsoft/fix20461
...
Fixes var declaration shadowing in async functions
2018-01-17 13:08:18 -08:00
Benjamin Lichtman
8f6c516ef9
Merge pull request #21205 from uniqueiniquity/resolveTripleSlashReferencePaths
...
Fix Windows-style absolute paths in triple-slash directives
2018-01-17 12:31:46 -08:00
Andy
8ed885db3e
Add completions from the 'this' type ( #21231 )
...
* Add completions from the 'this' type
* Code review
2018-01-17 12:05:31 -08:00
Andy
c549bb5737
Fix bug: getNonNullableType before getting signatures of method ( #21212 )
2018-01-17 11:27:21 -08:00
Ron Buckton
e655446318
Add test for catch block without variable
2018-01-17 11:25:53 -08:00
Ron Buckton
2ba29d8d9d
Support labeled statement
2018-01-17 11:24:28 -08:00
Ron Buckton
004f18ff0c
Merge pull request #21219 from Microsoft/fix19020
...
Fix destructuring assignment when assignment target is RHS
2018-01-17 11:22:30 -08:00
Andy
61fb845b87
Get packageId for relative import within a package ( #21130 )
...
* Get packageId for relative import within a package
* Code review
* Rename things and add comments
* Improve documentation
* Test for scoped packages
2018-01-17 11:14:03 -08:00
Ron Buckton
7a89c963b0
Merge pull request #21217 from Microsoft/fix20146
...
Symbol-named properties do not need to align with string indexer type
2018-01-16 17:01:27 -08:00
Ron Buckton
dcc5c32abf
Merge pull request #21216 from Microsoft/fix19103
...
Fix incorrect parenthesization logic for conditional expression branches
2018-01-16 17:00:55 -08:00
Ron Buckton
4aca0c8121
Fix destructuring assignment when assignment target is RHS
2018-01-16 16:58:56 -08:00
Ron Buckton
cd525fb6de
Merge pull request #21206 from Microsoft/fix20744
...
Fix temp variable emit for names used in nested classes
2018-01-16 16:00:24 -08:00