17207 Commits

Author SHA1 Message Date
Andy
3f77e1eae1
Support import completion for merged declaration exports (#24539) (#24572) 2018-06-01 10:28:00 -07:00
Andy
8dc7d5aa88
getEditsForFileRename: Support directory rename (#24305) (#24568)
* getEditsForFileRename: Support directory rename

* Code review

* Handle imports inside the new file/directory

* Document path updaters

* Shorten relative paths where possible

* Reduce duplicate code

* Rewrite, use moduleSpecifiers.ts to get module specifiers from scratch instead of updating relative paths

* Update additional tsconfig.json fields

* Add test with '.js' extension

* Handle case-insensitive paths

* Better tsconfig handling

* Handle properties inside compilerOptions

* Use getOptionFromName
2018-06-01 09:48:48 -07:00
Mohamed Hegazy
19ef19489c Merge branch 'release-2.9' of https://github.com/Microsoft/TypeScript into release-2.9 2018-05-31 14:17:10 -07:00
Mohamed Hegazy
80233b2983 Update version 2018-05-31 14:17:03 -07:00
Sheetal Nandi
de1849faa5 Do not emit trailing comma in json module
Fixes #24530
2018-05-31 12:50:53 -07:00
Alexander T
6024ed29d3 Do not emit 'use strict' prologue in .json files with --alwaysStrict 2018-05-31 12:19:24 -07:00
Wesley Wigham
124e0a3c37
For type emit, walk non-parent containers when those containers have aliases leading to the target (#24507) (#24510) 2018-05-31 09:17:49 -07:00
Andy
ca8ee38157
moveToNewFile: Remove newlines after last moved statement (#24503) (#24505) 2018-05-31 09:11:26 -07:00
Wesley Wigham
71ea6c3f28
Lookup type arguments correcly for taged templates when checking generic arity (#24496) (#24504) 2018-05-30 15:41:48 -07:00
Nathan Shively-Sanders
7b1e32ecec Fix exported type resolution in commonjs (#24495)
* Fix resolution of exported types in commonjs

It is fine to resolve the types of exported classes in ES6:

```js
export class C {
}
var c = new C()
```

But not for commonjs exported classes:

```js
module.exports.C = class {
}
var c = new C() // should error
```

Fixes #24492

* All jsdoc type aliases are available locally in commonjs modules

* Check that location isSourceFile before commonJsModuleIndicator
2018-05-30 14:14:01 -07:00
Mohamed Hegazy
01fc3d58ee Revert "Check detected npm path is existing"
This reverts commit 1fda3a4165b83fb82b666bd15e601c73590b52ec.
2018-05-25 14:35:56 -07:00
Wesley Wigham
4369d54c6b
Use external aliases in quickinfo and signature help return types (#24391) (#24395)
* Dont include import types in quick info type names

* Add UseAliasDefinedOutsideCurrentScope flag to LS operations which were missing it
2018-05-24 18:35:15 -07:00
Nathan Shively-Sanders
a7b2983d12 Disallow nested object param syntax in callback tag (#24392)
* Callback tag:Disallow nested-object-param syntax

Previously this caused a crash in parsing. If/when we want to support
this syntax, we will need to fix this crash.

* Update baselines
2018-05-24 15:12:35 -07:00
Wesley Wigham
246465e251
Hoisted declarations should occur after prologue directives (#24386) 2018-05-24 12:50:47 -07:00
Andy
a7b7b3c2ad
moveToNewFile: Format the new file (#24379) (#24382) 2018-05-24 11:35:02 -07:00
Andy
68bc957cf6
moveToNewFile: Respect UserPreferences#quote (#24365) (#24378) 2018-05-24 10:06:38 -07:00
Andy Hanson
d9fbf96e55 Don't need to check failedLookupLocations if resolved successfully 2018-05-23 16:17:31 -07:00
Andy Hanson
0ef6937202 getEditsForFileRename: Handle old file still being present 2018-05-23 16:17:24 -07:00
Mohamed Hegazy
a4fd87eeb6
Merge pull request #24347 from weswigham/constraint-fix
Check for keyof constraint type instead of syntactic check (#24098)
2018-05-23 08:42:46 -07:00
Mohamed Hegazy
3546503d49
Merge pull request #24346 from weswigham/metadata-change
Use unknown serialization kind when type symbol isnt resolved (#24332)
2018-05-23 08:42:34 -07:00
Sheetal Nandi
c435179450 Fix getter of local symbol for export= when it is json module
Fixes #24341
2018-05-22 20:18:05 -07:00
Wesley Wigham
b60ad05eb5
Check for keyof constraint type instead of syntactic check (#24098)
* Check for keyof constraint type instead of syntactic check

* Readopt older candidateType check, even though it shouldnt really matter

* OK. Just use maybetypeOfKind

* Remove redundant boolean check
2018-05-22 17:00:10 -07:00
Wesley Wigham
ef6b961877
Use unknown serialization kind when type symbol isnt resolved (#24332)
* Use unknown serialization kind when type symbol isnt resolved

* Add test for the isolated modules case
2018-05-22 16:57:11 -07:00
Andy
14fcbc1830
moveToNewFile: Don't provide refactor if selection is just imports (#24336) (#24339) 2018-05-22 16:04:58 -07:00
Armando Aguirre
4e88e3c6eb
Merge pull request #24335 from armanio123/FixObjectLiteralExpression
Fix object literal expression
2018-05-22 15:33:01 -07:00
Wesley Wigham
3321537c99
Use symbolToTypeNode for class & interface references (#24330) (#24334)
* Use merged symbols when calculating qualification, use symbolToTypeNode

* Accept baselines
2018-05-22 15:22:36 -07:00
Andy
38a037058a
moveToNewFile: Support selecting the name of a declaration (#24331) (#24333) 2018-05-22 14:48:37 -07:00
Mohamed Hegazy
1318c933da Merge branch 'master' into MergeMaster5-22-2 2018-05-22 12:21:45 -07:00
Sheetal Nandi
f44dd6f53b
Merge pull request #24206 from Microsoft/documentRegistery
Cache the latest source file from document registery in script info so that we do not have to reparse orphan script info
2018-05-22 12:11:16 -07:00
Sheetal Nandi
e8a0e56e3e Add a test when orphan file changes before it gets added back to project 2018-05-22 11:45:52 -07:00
Andrew Casey
bedc110c74
Merge pull request #24311 from amcasey/GH23287
Preserve jsx imports even when the compiler option is not set
2018-05-22 11:23:15 -07:00
Sheetal Nandi
66590a9391 Verify ref counts are set correctly when reusing the source file from script info cache 2018-05-22 11:18:40 -07:00
Andy
7106a587cc
Add type for diagnostics where location is defined (#23686)
* Add type for diagnostics where location is defined

* getSemanticDiagnostics may return global diagnostics

* Reduce array creation
2018-05-22 11:01:18 -07:00
Mohamed Hegazy
7fb3123984
Merge pull request #24298 from Microsoft/noErrOnBackgroundUpdate
Add noGetErrOnBackgroundUpdate session option to not queue diagnostics check for open files
2018-05-22 10:56:18 -07:00
Andrew Casey
2e0cc63067 Check TransformFlags.ContainsJsx, rather than LanguageVariant.JSX 2018-05-22 10:51:19 -07:00
Anders Hejlsberg
a5029e3d4e
Merge pull request #23794 from Microsoft/fixDiscriminatedContextualType
Fix discriminant checking in contextual types
2018-05-22 10:35:29 -07:00
Mohamed Hegazy
9d57903630
Merge pull request #24312 from Kingwl/multiline-type-literal-formatter
fix wrong formatting with multiline type literals with IntersectionTy…
2018-05-22 10:06:24 -07:00
Mine Starks
5e5c5a761a
Merge pull request #24139 from minestarks/dynamicprojectassert
Normalize ProjectService.currentDirectory
2018-05-22 09:04:45 -07:00
Andy
982c8d0af9
Add suggestion diagnostics for unused label and unreachable code (#24261)
* Add suggestion diagnostics for unused label and unreachable code

* Always error on unused left hand side of comma
2018-05-22 07:56:29 -07:00
Anders Hejlsberg
f52c4af448
Merge pull request #24310 from Microsoft/nonWideningLiteralInferences
Non-widening literal type inferences
2018-05-22 06:56:34 -07:00
王文璐
4b47c0cb82 fix wrong formatting with multiline type literals with IntersectionType and UnionType 2018-05-22 14:01:04 +08:00
Mohamed Hegazy
a9e89ce3f1
Merge pull request #24180 from Microsoft/updateVersion
Update version
2018-05-21 17:18:39 -07:00
Andrew Casey
edd31a1505 Preserver jsx imports even when the compiler option is not set
...based on feedback from VS Code users.

Fixes #23287
2018-05-21 16:57:18 -07:00
Anders Hejlsberg
8528dbee76 Handle union types in getRegularTypeOfLiteralType 2018-05-21 16:17:56 -07:00
Mohamed Hegazy
b127090e31 Merge branch 'master' into release-2.9 2018-05-21 16:13:49 -07:00
Andy
802dc2bb9b
fixUnusedIdentifier: If every VariableDeclaration is unused, remove the VariableStatement (#24231) 2018-05-21 15:54:33 -07:00
Anders Hejlsberg
c8ac085498 Infer non-widening literal types when type parameter constraint includes primitive types 2018-05-21 15:28:51 -07:00
Sheetal Nandi
f1acbc93ef Add noGetErrOnBackgroundUpdate session option to not queue diagnostics check for open files
This will ensure that the getErr will be queued in by host and hence would make sure that it is cancellable.
Handles one of the scenario delaying completions in #19458
2018-05-21 12:53:31 -07:00
Mohamed Hegazy
c244e5a89e Merge branch 'master' into release-2.9 2018-05-21 12:40:47 -07:00
Mohamed Hegazy
d2f6f6a0a4
Merge pull request #24296 from Microsoft/npmPackageSize
Remove unneeded files from npm package
2018-05-21 12:35:00 -07:00