Commit Graph

571 Commits

Author SHA1 Message Date
Cyrus Najmabadi
3a6c328f00 Update tests. 2014-10-05 21:58:37 -07:00
Cyrus Najmabadi
7222963923 Tweak how we populate NavBarItems.
Now we will always place child items of a node in the right bar, even if we're
also placing it on the 'top level nodes' list on the left.  This makes things
clearer for users by making it clear that any time you have a node selected on
the left, you can always find its children on the right.  And, it still preserves
the behavior we want where the left list acts as a high level 'table of contents'
for the file.
2014-10-05 21:17:13 -07:00
Mohamed Hegazy
432fff1362 Merge pull request #823 from chrisbubernak/betterErrorsForBitwiseOperatorsOnBooleans
Fix for issue #712
2014-10-05 09:51:11 -07:00
Chris Bubernak
6044e3aea3 Made fixes based on CR feedback 2014-10-04 10:10:55 -07:00
Chris Bubernak
e6b5591ae9 Updated baselines 2014-10-03 18:50:48 -07:00
Daniel Rosenwasser
c1d15c792b Merge branch 'master' into navbar
Also fixed getSourceText and renamed it to getTextOfNode
2014-10-03 17:44:52 -07:00
CyrusNajmabadi
6b76a6d826 Merge pull request #816 from Microsoft/renameCommentsAndStrings
Support rename in comments and strings.
2014-10-03 16:29:18 -07:00
Cyrus Najmabadi
a39064457e Adding tests. 2014-10-03 15:59:20 -07:00
Cyrus Najmabadi
1f045e1227 Adding rename tests. 2014-10-03 15:33:29 -07:00
Cyrus Najmabadi
e751c34fcb Add some heuristics in the lexical classifier to make it play better with the syntactic classifier when classifying expressions involving generics. 2014-10-03 01:54:43 -07:00
Daniel Rosenwasser
ffef437320 Merge pull request #799 from Microsoft/stopBlindlyColoring
Values sharing names with interfaces no longer classified as interfaces
2014-10-01 17:42:15 -07:00
Yui T
5926a03363 Merge branch 'master' into flagAllDuplication 2014-10-01 14:27:41 -07:00
Mohamed Hegazy
1a7862c316 Merge pull request #786 from Microsoft/aliasCompletion
Show aliases in completion list
2014-10-01 13:54:40 -07:00
Mohamed Hegazy
a37106d4da Merge pull request #748 from chrisbubernak/selfReferencingFileError
Fix issue #568 (no error for file self reference)
2014-10-01 13:44:47 -07:00
Jason Freeman
64638804f8 Merge branch 'master' into sigHelp 2014-10-01 13:10:03 -07:00
Daniel Rosenwasser
a6e991a3db Fixed bug where value-space identifiers got classified as interfaces when sharing the same name as an interface. 2014-10-01 12:44:17 -07:00
Yui T
296e8e01b3 Update Baselines 2014-10-01 11:27:20 -07:00
Vladimir Matveev
13f13b804d Merge pull request #752 from Microsoft/getTokenAtPosition
make rename\gotoDef work at the end of token
2014-09-30 23:06:18 -07:00
Yui T
c2d86711e8 Update baselines 2014-09-30 18:09:55 -07:00
CyrusNajmabadi
dc10492e28 Merge pull request #787 from Microsoft/classifierTweaks
Tweak classification so it does not classify things as keywords that cou...
2014-09-30 17:16:53 -07:00
Jason Freeman
b2bca72bb6 Fix argumentCount and selectedItemIndex 2014-09-30 17:13:57 -07:00
Jason Freeman
a89710471d Add test for empty arguments and arity filtering 2014-09-30 17:13:53 -07:00
Jason Freeman
a79a1d2248 Record trailing comma even for incorrectly terminated lists 2014-09-30 17:13:49 -07:00
Jason Freeman
ab3326f7b7 Fix arity checking for partial overload resolution 2014-09-30 17:13:47 -07:00
Mohamed Hegazy
55621aae49 Get exported symbols off aliases in getCompletions 2014-09-30 14:56:46 -07:00
Daniel Rosenwasser
f2880ce5b7 Merge pull request #778 from Microsoft/getOccurrencesSetItAndForGetIt
getOccurrences for 'get' and 'set' keywords.
2014-09-30 14:54:18 -07:00
Cyrus Najmabadi
f09971f10b Tweak classification so it does not classify things as keywords that could not actually be keywords according to the grammar. 2014-09-30 14:35:07 -07:00
Daniel Rosenwasser
5851752e32 Merge branch 'master' into navbar
Conflicts:
	Jakefile
	src/services/getScriptLexicalStructureWalker.ts
	src/services/services.ts
2014-09-30 14:20:58 -07:00
Mohamed Hegazy
284c767e08 set the kind on alias completions 2014-09-30 14:17:32 -07:00
Daniel Rosenwasser
87146735a7 Merge pull request #776 from Microsoft/getOccurrencesThrow
Support getOccurrencesAtPosition for 'throw' keywords.
2014-09-30 14:06:14 -07:00
Mohamed Hegazy
11ca3dab01 Add aliases in completion list 2014-09-30 13:50:09 -07:00
Mohamed Hegazy
e49ff08922 Merge pull request #763 from Microsoft/protectedCompletion
Protected completion
2014-09-30 13:32:46 -07:00
Daniel Rosenwasser
379f6ce758 Minor cleanup, added getScriptLexicalStructureWalker.ts Jakefile. 2014-09-30 11:58:56 -07:00
Daniel Rosenwasser
c61be112d9 getOccurrences for 'get' and 'set' keywords.
'get'/'set' keywords are highlighted for analogous accessors.
2014-09-29 14:38:03 -07:00
Daniel Rosenwasser
2503e50a5d Changed "ownership" relation of try blocks on throw statements.
A try-block now only owns a throw statement if its try statement has a catch-clause.
2014-09-29 12:41:47 -07:00
Daniel Rosenwasser
3f56411e74 Merge branch 'master' into getOccurrencesThrow 2014-09-29 11:59:40 -07:00
Vladimir Matveev
222e1d8365 outlining support for switch blocks\array literals 2014-09-28 22:33:00 -07:00
Daniel Rosenwasser
16d969c9ca Support getOccurrencesAtPosition for 'throw' keywords.
Also revised behavior for 'return' keywords in that when the position
resides on a 'return' statement, 'throw' keywords in the same
function scope that are not within a try-block are also highlighted.
2014-09-28 20:39:09 -04:00
Mohamed Hegazy
8089673066 Filter protected members from the completion list 2014-09-26 14:37:17 -07:00
Daniel Rosenwasser
4ed6a80c9c Limited identifying identifiers after dots to keywords. 2014-09-26 09:46:14 -07:00
ChrisBubernak
1b3da908de fixing baseline 2014-09-26 09:33:06 -07:00
ChrisBubernak
93db897778 Fixed some of the baselines, made file comparisons handle different
casing, put diagnostic message in correct order
2014-09-26 07:47:44 -07:00
Daniel Rosenwasser
a3b59f88c1 Fix issue where trivia is incorrectly identified as an identifier following a dot.
Fixes #753
2014-09-25 22:28:02 -07:00
Vladimir Matveev
c456ef496d renamed getNodeAtPosition to getExactTokenAtPosition, added predicate parameter that will determine if token with end === position should be returned 2014-09-25 14:29:32 -07:00
Daniel Rosenwasser
a98cca7723 Properly support string-literal property names and escape external module names. 2014-09-25 13:10:04 -07:00
ChrisBubernak
e11ee0f6cf Fixed a few of the code review suggestions 2014-09-25 13:02:37 -07:00
ChrisBubernak
ae17c35728 Added error checking for references that reference the same file along
with 3 tests,
2014-09-25 09:12:31 -07:00
Yui T
f5b3409058 Merge branch 'master' into notShowModuleNames 2014-09-24 15:08:54 -07:00
Yui T
684de53143 Address code review : add test case for inside ambient module declaration and single quote 2014-09-24 14:51:23 -07:00
Vladimir Matveev
dae98be062 Merge pull request #737 from Microsoft/instanceof_cascading_errors
do not report cascading errors in instanceof operator
2014-09-24 11:09:21 -07:00