Commit Graph

20535 Commits

Author SHA1 Message Date
Andrew Branch
a4cddd4647 Merge pull request #32239 from andrewbranch/enhancement/missing-await-errors
Improve error messages for potentially missing 'await'
2019-07-09 16:28:54 -07:00
Nathan Shively-Sanders
949956b586 Improve multiple overloads error span (#32315)
* Improve multiple overloads error span

When all errors for a multiple-overload error refer to the same span,
use that span instead of the one for the entire call.

This situation is quite common for 2-overload sets in React.

* Update baselines

* Fix lint
2019-07-09 15:39:42 -07:00
Anders Hejlsberg
b0f050f4ee Merge pull request #32260 from microsoft/fix32169
Include conditional types in top-level type parameter check
2019-07-09 10:30:44 -07:00
Andrew Branch
bdd8a3e878 Only add "Did you forget await" for function args when the parameter type is not promise-like 2019-07-08 16:32:53 -07:00
Andrew Branch
64501996cc Update error code 2019-07-08 14:52:23 -07:00
Andrew Branch
6626a99f11 Fix bad rebase 2019-07-08 14:44:57 -07:00
Andrew Branch
eb6b87aa26 Refactor to use related info everywhere 2019-07-08 14:37:45 -07:00
Andrew Branch
094a001982 Did you forget to use await? on arguments of function calls 2019-07-08 14:33:25 -07:00
Andrew Branch
e89a2c4571 Update baselines 2019-07-08 14:03:59 -07:00
Andrew Branch
a3a076d79f Did you forget to use await? for call and construct signatures 2019-07-08 14:01:25 -07:00
Andrew Branch
48fc6b8b17 Did you forget to use await? on iterables 2019-07-08 13:59:59 -07:00
Andrew Branch
c48e34ef91 Did you forget to use await? for operators 2019-07-08 13:50:56 -07:00
Nathan Shively-Sanders
834a476a96 Merge branch 'master' into report-multiple-overload-errors 2019-07-08 09:33:24 -07:00
Anders Hejlsberg
d7f8f0072e Include conditional types in top-level type parameter check 2019-07-04 16:26:54 -10:00
Ron Buckton
e8bf9584aa Improve type checking and inference for Generators and Async Generators (#30790)
* Improve typing for Generators and Async Generators

* Add TReturn and TNext to Iterator, IterableIterator, etc.

* Update ts internal Iterator to be assignable from global Iterator

* Make 'done' optional in IteratorYieldResult

* Revert Iterable and IterableIterator to simpler versions plus other fixes

* Add additional inference tests

* Added additional tests

* PR cleanup and minor async iteration type fix

* Updated diagnostics message and added non-strict tests

* Fix expected arity of Iterator/AsyncIterator
2019-07-03 21:55:59 -07:00
Wesley Wigham
0bea4bd3c9 Widen object literal this types (#32240) 2019-07-03 15:58:21 -07:00
Nathan Shively-Sanders
19b593ee4e Merge branch 'master' into report-multiple-overload-errors 2019-07-03 14:55:06 -07:00
Nathan Shively-Sanders
6f0baa3ae1 Merge pull request #29717 from petersandor/jsdoc-tag-author-email-support
Support email in author JSDoc tag
2019-07-03 10:42:02 -07:00
Andrew Branch
16bbb4d002 Merge pull request #32077 from andrewbranch/bug/31114
Fix incorrect noImplicitAny error on contextual union function signature
2019-07-03 10:10:10 -07:00
Nathan Shively-Sanders
722917f04e Remove TODO 2019-07-03 09:50:03 -07:00
Nathan Shively-Sanders
e62d84cd88 Merge branch 'master' into report-multiple-overload-errors 2019-07-03 09:28:44 -07:00
Anders Hejlsberg
340f81035f Merge pull request #32178 from microsoft/improveTupleDestructuring
Simplify tuple destructuring logic
2019-07-02 17:25:12 -07:00
Anders Hejlsberg
440ed83f29 Merge pull request #32079 from microsoft/instantiationCountLimiter
Add type instantiation count limiter
2019-07-02 17:19:39 -07:00
Anders Hejlsberg
5b24ea80a7 Restore union-like behavior for inference to conditional types 2019-07-01 17:46:50 -10:00
Nathan Shively-Sanders
f139455229 Address PR comments 2019-07-01 15:06:16 -07:00
Wesley Wigham
3e6856137a Add support for sharding tests across multiple workers (#32173)
* Add support for sharding tests across multiple workers

* Disable unittests when runners are expressly provided (unless they contain the unittest runner)
2019-07-01 14:56:57 -07:00
Wesley Wigham
055a07ea4a Check for parse errors in emitted JS (#32009) 2019-07-01 14:15:30 -07:00
Wesley Wigham
3765651d82 Fix not emitted statement in then clauses producing syntactically invalid output (#32010)
* Fix not emitted statement in then clauses producing syntactically invalid output

* Refactor to common code, apply to all embedded statements
2019-07-01 13:39:18 -07:00
Andrew Branch
11a62cb0ab Merge pull request #31801 from andrewbranch/semicolons
Detect semicolons before writing from TextChanges
2019-07-01 13:23:31 -07:00
Andrew Branch
327bc3cb67 Merge pull request #32071 from andrewbranch/bug/31070
Allow assignability of non-empty object to generic mapped type
2019-07-01 13:18:44 -07:00
Wesley Wigham
ff81d5261e Elide the exact node version rush complains about from the docker output (#32204) 2019-07-01 13:13:44 -07:00
Andrew Branch
a890275463 Merge pull request #31912 from andrewbranch/bug/31657
Fix smartSelection returning extra span inside string quotes when cursor is outside them
2019-07-01 11:53:24 -07:00
Sheetal Nandi
af20e791fd Merge pull request #32167 from microsoft/tryReuseProgram
When checking sourceFile is from external library, use sourceFile.resolvedPath since thats how the source files are queried and thats the real path
2019-07-01 11:16:17 -07:00
Andrew Branch
23f1d5ccb7 Merge pull request #32117 from andrewbranch/bug/31460
Fix declaration emit for negative number properties, allow negative numbers as computed type property names
2019-07-01 10:56:56 -07:00
Sheetal Nandi
f6d7261288 Merge pull request #32147 from microsoft/noDtsWhenNotUsingProjectReferences
Watch generated file if it doesnt exist when trying to translate it to to source generated position
2019-07-01 10:22:16 -07:00
Nathan Shively-Sanders
cce2b9316e Merge branch 'master' into report-multiple-overload-errors 2019-07-01 10:17:03 -07:00
Nathan Shively-Sanders
b46c44d70d Merge pull request #32181 from microsoft/use-only-immediately-preceding-jsdoc
Use only immediately preceding JSDoc
2019-07-01 10:12:05 -07:00
Sheetal Nandi
ebf323ea19 Merge pull request #32124 from austincummings/affectsEmitToModuleAndEsModuleInterop
Add affectsEmit to module and esModuleInterop options
2019-07-01 09:59:41 -07:00
Sheetal Nandi
1bd631e593 Merge pull request #32076 from stristr/master
Make close() in interface Watch<T> public
2019-07-01 09:46:09 -07:00
Anders Hejlsberg
f89165d072 Merge pull request #32049 from microsoft/noDuplicateIntersectionSignatures
Remove duplicate signatures in intersections
2019-06-30 19:38:37 -07:00
Anders Hejlsberg
17153a6e5f Fix linting error 2019-06-30 08:54:48 -10:00
Austin Cummings
c30054de63 Fix esModuleInterop affectsEmit change test 2019-06-30 11:06:00 -07:00
Anders Hejlsberg
eb1b2251b8 Pad tuple type initializers of parameter array binding elements 2019-06-30 08:02:18 -10:00
Nathan Shively-Sanders
fefb857847 Use only immediately preceding JSDoc
Now only the immediately preceding jsdoc of a node is retrieved by
getJSDoc, although it still does the correct non-local lookup for nodes
like ParameterDeclaration.

This doesn't change parsing or binding, which use the per-node Node.jsdoc
property directly. But it does change everything that relies on getJSDoc,
which includes the checker and language service.

Fixes #32062, which contains the analysis that justifies the change.
2019-06-29 08:05:10 -07:00
Anders Hejlsberg
2e5249835d Remove logic that pads array literals contextually typed by tuple types 2019-06-28 16:54:42 -10:00
Austin Cummings
5b694f8302 Add tests for module and esModuleInterop affectsEmit change 2019-06-28 18:34:59 -07:00
Austin Cummings
4195f1a409 Add affectsEmit to module and esModuleInterop options 2019-06-28 17:51:05 -07:00
Nathan Shively-Sanders
71276a21af Merge branch 'master' into report-multiple-overload-errors 2019-06-28 16:24:38 -07:00
Nathan Shively-Sanders
97784749b5 Fix lint 2019-06-28 16:09:54 -07:00
Daniel Rosenwasser
410b71751e Merge pull request #32034 from dragomirtitian/GH-32013-improve-error-messages-for-calling-types
Improved error message for calling/constructing types
2019-06-28 16:08:18 -07:00