Wesley Wigham
7ad72d2440
Rework symbol visibility checking to allow for multiple potential containers ( #24971 )
...
* Rework symbol visibility checking to allow for multiple potential containers
* Express a preference for the local symbol if accessible from the enclosing declaration
2018-07-05 16:00:07 -07:00
Wesley Wigham
b8b34a38ec
Actually cache intermediate results in getBaseConstraint ( #25417 )
...
* Have getBaseConstraint push resolutions for the types it actually recurs on
* Cache base constraints correctly
2018-07-05 15:54:43 -07:00
Andy
64555aa6a9
navigateTo: Collect results from all referenced projects. ( #25283 )
...
* navigateTo: Collect results from all referenced projects.
* Don't use project references, just source maps
* Move more code to session
* Test when implementation file is deleted
* Use tsserver tests instead of fourslash tests to ensure session is used
* Support find-all-references
* Restore fourslash tests
* Update emit baselines (added missing newline)
* Support rename
* @weswigham code review
* Don't open/close files
* Avoid growing `toDo` too eagerly
* @sheetalkamat code review
* Also get symlinked projects for originalLocation
* Update API (#24966 )
* More @sheetalkamat code review
* Remove unnecessary test
* Update API (#24966 )
2018-07-05 15:39:03 -07:00
Nathan Shively-Sanders
065e695a28
No merge for redirected source files in initializeTypeChecker ( #25463 )
...
Previously, redirected source files merged the same way as other source
files, effectively causing the target of the redirection to be merged
twice. mergeSymbol now has an assert (`source===target`) that catches
this condition, so this change makes sure to skip redirected source
files.
This change doesn't apply to the preceding binding loop, since the
binder handles already-bound source files correctly.
2018-07-05 13:49:34 -07:00
Mohamed Hegazy
383319ded6
Merge pull request #25423 from Microsoft/defaultExportName
...
Handle getting name of default export that's an alias
2018-07-05 12:21:53 -07:00
Mohamed Hegazy
2059c36afa
Merge pull request #25457 from Microsoft/resolveJsonModuleInterop
...
Do not report esModuleInterop needed error for json imports
2018-07-05 12:16:28 -07:00
Mohamed Hegazy
8911c19f4f
Merge pull request #25313 from github-john-doe/typo
...
Typo
2018-07-05 11:43:12 -07:00
Mohamed Hegazy
320db5ccfe
Merge pull request #25433 from a-tarasyuk/bug/24839-give-a-better-error-message-for-using-import-as-a-type
...
24839 - Give a better error message for using import as a type
2018-07-05 11:11:35 -07:00
Sheetal Nandi
cb622b413b
Do not report esModuleInterop needed error for json imports
...
Fixes #25400
2018-07-05 10:39:39 -07:00
Nathan Shively-Sanders
50ef631b59
Support prototype assignment with a function declaration ( #25300 )
...
Previously variable declaration+function expression worked.
Note that class expression/class declaration do not work, due to the way
they are specified. I added a test for future reference.
2018-07-05 09:04:28 -07:00
Andy Hanson
b1e916cae6
Handle getting name of default export that's an alias
2018-07-05 09:03:22 -07:00
Alexander T
f851ab8f3e
Add a suggestion - Did you mean 'typeof import()?. Add tests to handle undated error message
2018-07-04 16:04:29 +03:00
Wesley Wigham
84f5aa540e
Put error spans deep on nested object literals ( #25140 )
...
* Add ncie deep elaborations
* Nice stuff
* Modify tuple error to use length error mroe often
* Accept good baselines
* Accept meh baselines
* Fix literal types
* Calculate elaborations like it was the very first time again~
* Use tristate for enum relationship to ensure elaborations are printed at least once
* Update message text, nits
* move some functions back to where they were
* Add test of deep JSX elaboration
* Add elaboration test with parenthesized expressions, comma expressions, and assignments
* Move check to allow elaborations on more anonymous types
* Fix nits
* Add specialized error to elaborations of nonliteral computed named-members
* Update error message
2018-07-03 19:40:58 -07:00
Andy
204b70d7af
Don't add completions from a discriminated union type when the discriminant doesn't match ( #24770 )
...
* Don't add completions from a discriminated union type when the discriminant doesn't match
* Move code to checker
* Update API (#24966 )
* Use isTypeIdenticalTo
2018-07-03 17:05:51 -07:00
Anders Hejlsberg
eb7ff43f95
Merge pull request #25408 from Microsoft/contextualTupleTypes
...
Infer tuple types for contextually typed rest parameters
2018-07-03 14:02:48 -10:00
Andy
064ecd449e
Support code-fix-all for importFixes ( #25137 )
...
* Support code-fix-all for importFixes
* Change description
* Update API (#25283 )
2018-07-03 15:19:15 -07:00
Mohamed Hegazy
17b10e8293
Merge pull request #25397 from a-tarasyuk/bug/25356-instance-property-is-not-a-block-scoped-variable
...
25356 - Instance property is not a block scoped variable
2018-07-03 14:11:28 -07:00
Andy
e1a7f8497e
Restore NewFileContent type ( #25406 )
2018-07-03 13:36:45 -07:00
Sheetal Nandi
75369cd887
Merge pull request #25414 from Microsoft/classMembersInSuperClassFromUnknownNamespace
...
Fix the completion when base type is class from unknown namespace
2018-07-03 13:21:11 -07:00
Andy
76a4694bd4
parser: Fix testing for missing list ( #25411 )
...
* parser: Fix testing for missing list
* Fix return type
2018-07-03 12:37:20 -07:00
Sheetal Nandi
95ad71864b
Fix the completion when base type is unknown type from unknown namespace
...
Fixes #25387
2018-07-03 12:35:25 -07:00
Wesley Wigham
cb4cb7a75f
Check if module reference requires type reference before path reference ( #25385 )
2018-07-03 11:41:07 -07:00
Andy
304d45d833
Canonicalize path before calling startsWith ( #25364 )
...
* Canonicalize path before calling `startsWith`
* More specific type for sourceDirectory, and add fourslash test
* Update API (#24966 )
2018-07-03 11:23:19 -07:00
Anders Hejlsberg
e8d64a9c7c
Merge pull request #25336 from Microsoft/fixResolveTypeMembers
...
Fix runaway recursion in object type member resolution
2018-07-03 07:53:02 -10:00
Alexander T
689793209f
Update tests baseline. Change tests
2018-07-03 14:41:09 +03:00
Daniel Rosenwasser
e13fd0c568
Merge pull request #24915 from Microsoft/triggerSignatureHelpIArdlyKnowSignatureHelp
...
Trigger characters in signature help
2018-07-02 23:36:57 -07:00
Anders Hejlsberg
17e959407c
Fix fourslash tests
2018-07-02 18:14:32 -10:00
Anders Hejlsberg
e5d520e463
Add tests
2018-07-02 17:50:42 -10:00
Andy
efc1b7df08
More thoroughly test navigateTo ( #25239 )
...
* More thoroughly test navigateTo
* Fix #25233 and #25237
* Update API (#24966 )
2018-07-02 19:25:27 -07:00
Wesley Wigham
65655f2c6b
Change import type determination to not use a RE on the symbol name ( #25381 )
2018-07-02 17:43:39 -07:00
Andy
5c57e14000
goToDefinition: Don't go to jsx constructor signature ( #25382 )
2018-07-02 17:18:07 -07:00
Andy Hanson
271bbb027c
Merge branch 'master' into fixAddMissingMember_all_dedup
2018-07-02 16:06:57 -07:00
Daniel Rosenwasser
159b3dcec0
Accepted baselines and updated fourslash test.
2018-07-02 16:05:07 -07:00
Daniel Rosenwasser
9651c4231e
Account for trigger reasons, as implemented by Roslyn.
2018-07-02 16:04:48 -07:00
Daniel Rosenwasser
c046958752
Merge remote-tracking branch 'origin/master' into triggerSignatureHelpIArdlyKnowSignatureHelp
2018-07-02 15:36:41 -07:00
Mohamed Hegazy
837df49a66
Merge pull request #25374 from Microsoft/SetMapConstructor
...
Consolidate overloads in constructors for Map, Set, WeakMap, and WeakSet
2018-07-02 15:32:42 -07:00
Mohamed Hegazy
956f9d0be2
Merge pull request #25335 from Microsoft/codeFixAddMissingEnumMember_all
...
Combine code-fix-all for missing class member and missing enum member
2018-07-02 15:14:19 -07:00
Mohamed Hegazy
4dd1f9fc7c
Consolidate overloads in constructors for Map, Set, WeakMap, and WeakSet
...
Fixes https://github.com/Microsoft/TypeScript/issues/23551
Fixes https://github.com/Microsoft/TypeScript/issues/25362
2018-07-02 11:58:48 -07:00
Andy Hanson
f3bc891ae9
fixAddMissingMember: Improve deduplication in code-fix-all
2018-07-02 11:26:50 -07:00
Andy
7dc66e916a
moduleSpecifiers: specifier from "rootDirs" should be treated as relative ( #25369 )
2018-07-02 11:14:49 -07:00
Wesley Wigham
7084e6cf47
Adds related spans and error grouping for duplicate identifier errors ( #25328 )
...
* Adds related spans and error grouping for duplicate identifier errors
* Trim trailing whitespace
* Record related info in error baselines
* Make error more whimsical
2018-07-02 10:47:52 -07:00
Anders Hejlsberg
92f5f1dd9d
Add regression test
2018-06-29 17:16:23 -10:00
Andy
ded446573a
ChangeTracker: Combine deleteDeclaration, deleteNode, and deleteNodeInList ( #25276 )
...
* ChangeTracker: Combine deleteDeclaration, deleteNode, and deleteNodeInList
* Change name
* Update API (#24966 )
2018-06-29 19:53:32 -07:00
Andy Hanson
2fa27ffdf7
Combine code-fix-all for missing class member and missing enum member
2018-06-29 19:39:19 -07:00
Wesley Wigham
18e3f487a4
Support LibraryManagedAttributes<TComponent, TAttributes> JSX namespace type ( #24422 )
...
* WIP
* Allow type alias for managed type
* Add a large test
* Accept updatedbaselines
* Fix typo in test, add one more example
2018-06-29 18:45:29 -07:00
Benjamin Lichtman
f0e5056063
Add test
2018-06-29 11:34:58 -07:00
Wesley Wigham
30db30055f
Fix module specifier case handling for declaration emit ( #25110 )
2018-06-29 11:02:43 -07:00
Mohamed Hegazy
c27dace3df
Merge pull request #25182 from Kingwl/fix-missing-enum-member
...
add quick fix for add missing enum member
2018-06-29 10:19:23 -07:00
Daniel Rosenwasser
d46b54b639
Actually make the test file use '--strict'.
2018-06-28 22:36:59 -07:00
Daniel Rosenwasser
f23c180a38
Merge pull request #25287 from Microsoft/skipToNonNullTargets
...
Skip to non null targets in error messages
2018-06-28 22:26:36 -07:00