1361 Commits

Author SHA1 Message Date
Sheetal Nandi
b0d6896235
Merge pull request #23438 from Microsoft/typingsFiles
Better handling of typing installer events and consuming typing files in tsserver
2018-04-18 11:34:46 -07:00
Sheetal Nandi
7c5f5249ae Renames as per PR feedback 2018-04-18 11:05:56 -07:00
Andrew Casey
26c836b12a Propagage reportsUnnecessary in convertToDiagnosticsWithLinePosition 2018-04-17 19:44:52 -07:00
Sheetal Nandi
d64f2483e4 Update to respond to PR feedback 2018-04-17 14:17:15 -07:00
Andy
cae464058a
Delete "delete me" files (#23446) 2018-04-16 15:29:02 -07:00
Sheetal Nandi
82e9a7595b Invoked should be property on watchers map instead of local variable since watchers arent closed if they need to be reopened 2018-04-13 15:17:13 -07:00
Sheetal Nandi
60b19f5782 Invalidate the unresolved import resolutions when typing files are set
This has 3 changes:
1. In updateGraph when enqueue the typing installation request (depending on unresolved imports)
2. When ActionSet event is received, invalidate only files with unresolved imports and resolve those.
3. When ActionInvalidate event is received, typing installer has detected some change in global typing cache location, so just enqueue a new typing installation request. This will repeat the cycle of setting correct typings and pickiing unresolved imports
2018-04-13 15:17:13 -07:00
Sheetal Nandi
35abe26824 Force new typings resolution only if there are more or less script infos in the project.
This helps in reducing number of forced typing installation requests
We anyways use changes in unresolved import array to determine if we need to enqueue new typing request
Hence there is no need to soley rely on hasChanges from updateGraph which just indicates that we didnt reused the program (that does not mean new files were added to the program or changes in unresolved imports)
2018-04-13 15:17:13 -07:00
Sheetal Nandi
c9479f7263 Remove the specialized type UnresolvedImportsMap which is just a redirection and helps only in test only 2018-04-13 15:17:13 -07:00
Sheetal Nandi
b0fb73c47c Typings cache is internal data structure 2018-04-13 15:17:12 -07:00
Sheetal Nandi
a9ffabbe51
Merge pull request #23374 from Microsoft/npmInstallCommandTooLong
Handle command too long failure in typings installer
2018-04-12 14:17:47 -07:00
Ryan Cavanaugh
ff60520460 Merge branch 'master' into referencesDogfood_1 2018-04-12 12:26:10 -07:00
Sheetal Nandi
b3d83c81cc Handle command too long failure in typings installer 2018-04-12 11:43:18 -07:00
Andy
ff7ef4a25a
Add fixName property to CodeFixAction (#23350) 2018-04-12 09:05:30 -07:00
Ryan Cavanaugh
0e07d775a1 You have to do this everywhere now! 2018-04-11 16:59:53 -07:00
Ryan Cavanaugh
df95de3231 Merge branch 'master' into referencesDogfood_1 2018-04-11 16:17:38 -07:00
Ryan Cavanaugh
501d7be7ba Add explicit file lists to server tsconfig files 2018-04-11 15:39:12 -07:00
Ryan Cavanaugh
21d16693da Explicitly list server source files in their current emitted order 2018-04-11 15:38:27 -07:00
Ryan Cavanaugh
3ca1d2d7e3 Remove all reference comments from server/ 2018-04-11 15:38:26 -07:00
Andy
4b706fc479
Add 'disableSuggestions' to UserPreferences (#23283)
* Add 'disableSuggestions' to UserPreferences

* Make mergeMapLikes return a new object

* Avoid additional clone

* mergeMapLikes -> object spread
2018-04-10 11:53:24 -07:00
Andy
556a8010b9
Fix bug: ensure 'reportsUnnecessary' is actually sent by tsserver (#23293) 2018-04-10 10:15:15 -07:00
Andy
542184a05a
Rename infoCheck to suggestionCheck (#23286) 2018-04-09 14:09:07 -07:00
Sheetal Nandi
7a0a1f6a28 Do not watch script infos that are part of global typings location 2018-04-06 15:52:39 -07:00
Sheetal Nandi
c9f39951b6 Do not send project update in background if there was no ensureUpdate pending on the project structure 2018-04-06 14:58:13 -07:00
Sheetal Nandi
62c6fe2ccc There is no need to ensure project structure when tryiong to get inferred project
The project operations will validate if its valid anyways
2018-04-06 14:22:08 -07:00
Sheetal Nandi
e304178c65 Add time stamp into the ti log. 2018-04-06 14:22:04 -07:00
Andy
24842b4002
When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors (#22361)
* When --noUnusedLocals/--noUnusedParameters is disabled, add suggestions instead of errors

* Improve performance: do not add unused suggestion diagnostics unless asking for a suggestion

* Add "unused" flag to diagnostics

* Code review

* reportsUnused -> reportsUnnecessary

* Fix test
2018-04-05 12:33:00 -07:00
Andy
4f80fbddc2
Fix typo and use array helper (#23169)
* Fix typo and use array helper

* Update API baselines
2018-04-05 10:17:01 -07:00
Andrew Casey
855171bde5 Introduce a --syntaxOnly server mode
1. Disable the LS in all projects
 2. Don't create Program objects
 3. Ignore config files
2018-04-04 16:44:15 -07:00
uniqueiniquity
36cdb52b17 Handle double quotes for every argument 2018-04-02 16:41:29 -07:00
uniqueiniquity
8f503fb483 Close over getLogPath 2018-04-02 15:38:04 -07:00
uniqueiniquity
e625a6a9b4 Use object destructuring instead of tuple 2018-04-02 15:12:26 -07:00
uniqueiniquity
ffbb046cd4 Consume extra parts of file path 2018-04-02 13:58:31 -07:00
uniqueiniquity
361be11a04 Remove trailing whitespace 2018-04-02 12:32:15 -07:00
uniqueiniquity
0238991cd3 Ensure TSS_LOG handles paths with spaces 2018-04-02 11:04:52 -07:00
Andy
3e32e15895
Add 'fixAllDescription' property to CodeFixAction (#22616)
* Add 'fixAllDescription' property to CodeFixAction

* Code review

* Add to protocol

* Make fixAllDescription be just a string
2018-03-27 18:21:21 -07:00
Andrew Casey
517cf6aa89 Add support for suppressing project events
VS doesn't consume (e.g.) `syntaxDiag` events, so there's no reason to
do the work to compute their payloads.
2018-03-22 16:44:09 -07:00
Andy
67670d8726
Revert change to canUseEvents in IoSessionOptions (#22791) 2018-03-22 10:29:32 -07:00
Andrew Casey
564183f9ed Fix lint errors 2018-03-21 15:18:06 -07:00
Andrew Casey
9352a8bc11 Delete IoSessionOptions
Many of the operations were unused because the values were being
accessed directly from the enclosing scope.
2018-03-21 14:56:06 -07:00
Andy
cc3921323c
Support services settings (#22236)
* Support services settings

* Code review

* More review

* Use different names for Options and GetCompletionsAtPositionOptions (todo: come up with better names)

* More renames

* More renaming

* Support quote style in importFixes

* Add `importModuleSpecifierPreference` option

* Support quote style for `throw new Error('Method not implemented.')` (#18169)

* options -> preferences
2018-03-20 13:07:59 -07:00
Sheetal Nandi
e48ed3f9c2 Do not close the file watches just to create new ones in the type installer
Fixes #22581
2018-03-15 10:45:09 -07:00
Mohamed Hegazy
c335c3803c
Fix #22133: Expose getOutliningSpans on the server protocol (#22400)
* Fix #22133: Expose getOutliningSpans on the server protocol

* Remove debugger statement from test
2018-03-09 08:50:47 -08:00
Mohamed Hegazy
1fc3aebc20
Port changes from #22172, provide a callback to fs.close (#22405) 2018-03-09 08:30:09 -08:00
Sheetal Nandi
17b10dc2a9
Merge pull request #21243 from Microsoft/watchOptions
Different watchFile and watchDirectory options through environment variable
2018-03-08 12:44:53 -08:00
Nathan Shively-Sanders
a81f264d70
Call process.stdout._handle.setBlocking(true) (#22389)
* Call process.stdout._handle.setBlocking(true)

This prevents output from being truncated when the compiler can output
errors to stdout faster than it can receive them. This may slow down
performance for compilations for many errors, but those were already
quite slow.

* Disable tslint no-unnnecessary-type-assertion-2

It is wrong. It *is* necessary.
2018-03-08 12:38:30 -08:00
Josh Goldberg
7826b38426 Apply 'no-unnecessary-initializer' lint rule (#22014)
* Apply 'no-unnecessary-initializer' lint rule

Forbids `let`/`const` statements to be initialized to `undefined`, since that's the initial value by default anyway.
The auto-fixer also happened to remove two unnecessary `as number` casts in `src/harness/parallel/worker.ts`.

For historical data: to run with `--fix`, I modified the line in `Jakefile.js` that declared the `cmd` for running TSLint.

* Moved worker.ts type assertions to parameters
2018-03-06 07:30:40 -08:00
Sheetal Nandi
ae8637c99f Merge branch 'master' into watchOptions 2018-03-03 10:51:59 -08:00
Sheetal Nandi
cbef5c29b5
Merge pull request #22151 from Microsoft/svcOfPendingReloadFile
Reload the text from file if there is pending reload of the script info before determining to use SVC
2018-03-02 19:11:11 -08:00
Andy
a564912d9a
Apply 'no-unnecessary-qualifier' lint rule (#22009) 2018-03-01 14:20:18 -08:00