16623 Commits

Author SHA1 Message Date
Andy
2f6b59eab9
Misc. improvements to addImplementationReferences (#23507)
* Misc. improvements to addImplementationReferences

* Test typeHavingNode.type === typeNode

* Fix bug: refNode.parent -> refNode
2018-04-18 15:24:19 -07:00
Andy
8f1bdc7e18
findAllReferences: Reduce node.getSourceFile() calls (#23524)
* findAllReferences: Reduce node.getSourceFile() calls

* Don't create extra object
2018-04-18 15:24:02 -07:00
Andy
b271df1639
Simplify getParentSymbolsOfPropertyAccess (#23513) 2018-04-18 12:58:40 -07:00
Andy
0e9b815956
Improve performance of duplicate check (#23516) 2018-04-18 12:58:16 -07:00
Sheetal Nandi
b0d6896235
Merge pull request #23438 from Microsoft/typingsFiles
Better handling of typing installer events and consuming typing files in tsserver
2018-04-18 11:34:46 -07:00
Sheetal Nandi
7c5f5249ae Renames as per PR feedback 2018-04-18 11:05:56 -07:00
Andrew Casey
a2f494ab57
Merge pull request #23494 from amcasey/PropagateUnnecessary
Propagage reportsUnnecessary in convertToDiagnosticsWithLinePosition
2018-04-18 09:55:45 -07:00
Andy
afde2b5bf3
MissingDeclaration is only ever a Statement (#23485) 2018-04-18 07:55:57 -07:00
csigs
81b347d61d LEGO: check in for master to temporary branch. 2018-04-18 04:10:18 +00:00
Andrew Casey
26c836b12a Propagage reportsUnnecessary in convertToDiagnosticsWithLinePosition 2018-04-17 19:44:52 -07:00
Mohamed Hegazy
52192006cf
Merge pull request #20671 from Kingwl/fix-import-not-existed-module
error if import empty object form module not existed
2018-04-17 17:29:07 -07:00
Andy
f5101e21c3
Find-all-references: Don't crash on 'typeof import' (#23448)
* Find-all-references: Don't crash on 'typeof import'

* Move `| ImportTypeNode` out of `AnyImportOrReExport`
2018-04-17 15:01:36 -07:00
Sheetal Nandi
d64f2483e4 Update to respond to PR feedback 2018-04-17 14:17:15 -07:00
Andy
d1fde3786c
Symbol kind for a method on a mapped type should still be 'method' (#23478) 2018-04-17 14:07:59 -07:00
Andy
b00e370605
Add '?' in quick info for optional properties/methods (#23480) 2018-04-17 12:42:23 -07:00
Andy
56d83f9572
Rename pushTypePart to pushSymbolKind (#23481) 2018-04-17 12:41:39 -07:00
Benjamin Lichtman
48f98bdd4d
Merge pull request #23452 from uniqueiniquity/normalizeDocumentHighlightsPaths
Normalize document highlights paths
2018-04-17 12:31:00 -07:00
Andy
f6510bd6b9
goToDefinition: Remove isSignatureDeclaration, use isFunctionLike (#23475) 2018-04-17 11:53:41 -07:00
Andy
0c17a2b2a8
goToDefinition: Reduce duplicate code around createDefinitionInfo (#23473)
* goToDefinition: Reduce duplicate code around createDefinitionInfo

* Use '[]' instead of 'emptyArray'

* Remove comment
2018-04-17 11:28:12 -07:00
Nathan Shively-Sanders
db68075b67
Add create-react-app and puppeteer user tests (#23471)
* Add create-react-app

* Add puppeteer

Everything is broken now. I am going back to master to see if that fixes
things.

* Add puppeteer baseline

* Add chalk override (gitignore was ignoring it)
2018-04-17 11:21:11 -07:00
Andy
d009d8efcf
Fix bug: IfStatement#elseStatement can be undefined (#23467) 2018-04-17 10:41:53 -07:00
Mohamed Hegazy
ca53993e41
Merge pull request #23462 from JoshuaKGoldberg/combined-pretty-summaries
Combined "Found X error(s)" and "Compilation complete" --watch messages
2018-04-17 10:37:07 -07:00
uniqueiniquity
12f6e5232b Remove unnecessary allocation 2018-04-17 09:41:26 -07:00
uniqueiniquity
160356317b Treat expectedRanges as readonly 2018-04-17 09:20:52 -07:00
uniqueiniquity
3a8d66ba29 Only normalize for purposes of assert 2018-04-17 09:20:34 -07:00
Andy
e50b24a83b
convertFunctionToEs6Class: Copy comment from variable declaration (#23445) 2018-04-17 09:15:05 -07:00
Andy
55f9a6ffc2
Fix bug: VariableDeclaration initiazer may be undefined (#23439) 2018-04-17 08:59:07 -07:00
Andy
bc285aa9a1
findAllReferences: Mark *every* search symbol as seen, not just search.symbol (#23451) 2018-04-17 07:53:43 -07:00
csigs
e35336c118 LEGO: check in for master to temporary branch. 2018-04-17 10:10:39 +00:00
Josh Goldberg
9dff614bd2 Combined the "Found X error(s)" and "Compilation" complete --watch messages 2018-04-17 01:47:43 -07:00
csigs
1e6e679a53 LEGO: check in for master to temporary branch. 2018-04-17 04:10:48 +00:00
Andy
40fd6aebdc
Shrink span for convert-to-es6-module suggestion (#23441) 2018-04-16 16:46:27 -07:00
Benjamin Lichtman
221ac50c4c
Merge pull request #23437 from Microsoft/getOutliningSpansDepthElseIf
In outliningElementsCollector, treat 'else if' as having same depth as the 'if'
2018-04-16 16:25:57 -07:00
uniqueiniquity
606492b677 Fix lint error and normalization issue 2018-04-16 16:20:12 -07:00
uniqueiniquity
e9d6f788ca Add test 2018-04-16 15:59:22 -07:00
uniqueiniquity
003c0a6743 Move normalization into services 2018-04-16 15:59:22 -07:00
uniqueiniquity
676983cb3e Normalize paths to search for highlights 2018-04-16 15:59:22 -07:00
Andy
cae464058a
Delete "delete me" files (#23446) 2018-04-16 15:29:02 -07:00
csigs
1bafc49da0 LEGO: check in for master to temporary branch. 2018-04-16 22:11:09 +00:00
Andy
aac9ef5e51
convertToEs6Module: Avoid replacing entire function (#22507)
* convertToEs6Module: Avoid replacing entire function

* Code review

* Fix typo
2018-04-16 13:16:04 -07:00
Mohamed Hegazy
a8618a79e1
Merge pull request #23358 from joscha/joscha/fix-non-imports-matching
fix: do not match MySymbol.import("mod")
2018-04-16 12:37:53 -07:00
Mohamed Hegazy
f0057f9a33
Remove condition 2018-04-16 11:48:04 -07:00
Andy Hanson
a60caba467 In outliningElementsCollector, treat 'else if' as having same depth as the 'if' 2018-04-16 11:33:30 -07:00
Andy
cc6bc763bc
Simplify getConvertibleFieldAtPosition (#23315) 2018-04-16 09:30:10 -07:00
csigs
f5b7826c1f LEGO: check in for master to temporary branch. 2018-04-16 16:10:41 +00:00
Andy
a297a28fd5
Use getPossibleSymbolReferenceNodes in one more place (#23378) 2018-04-16 08:27:25 -07:00
Joscha Feth
a3311edb4a revert change 2018-04-15 11:30:37 +10:00
Joscha Feth
4dc9db1e70 detect nested non-imports 2018-04-15 11:27:51 +10:00
Joscha Feth
c64c1c9395 fix up 2018-04-15 03:30:47 +10:00
Joscha Feth
f4fa2eb28e
undefined instead of null 2018-04-15 01:51:01 +10:00