15869 Commits

Author SHA1 Message Date
Anders Hejlsberg
9189354713 Wildcard instantiation of indexed access should be wildcard 2018-02-10 17:10:32 -08:00
csigs
9b65a7dfe1 LEGO: check in for master to temporary branch. 2018-02-10 11:10:20 +00:00
Andrew Casey
025418fdb0 Handle class declarations without names in Extract Symbol
Fixes #21816
2018-02-09 19:09:25 -08:00
Andrew Casey
22c4862d9e
Merge pull request #21835 from amcasey/GH21786
Handle variable declaration without initializer in Convert to ES6 Module
2018-02-09 18:21:50 -08:00
Andrew Casey
1baae42149 Handle variable declaration without initializer in Convert to ES6 Module
Fixes #21786
2018-02-09 18:08:47 -08:00
Andrew Casey
ab5596e785 Call replaceNode rather than replaceRange
...where convenient.  Same for deleteNode/Range.
2018-02-09 17:51:28 -08:00
Andrew Casey
8d1f316414 Eliminate ChangeMultipleNodesOptions in favor of smart separators 2018-02-09 16:06:14 -08:00
Anders Hejlsberg
f1d7afe760
Merge pull request #21847 from Microsoft/predefinedConditionalTypes
Predefined conditional types
2018-02-09 15:39:58 -08:00
Andy
49e78f68d2
findAllRefs: Fix bug for export not at top-level of a module/namespace (#21846) 2018-02-09 15:10:34 -08:00
Andy
425a4182a3
Handle empty declaration list in Convert to ES6 Module (#21843)
* Handle empty declaration list in Convert to ES6 Module

* Fix test
2018-02-09 14:46:57 -08:00
Anders Hejlsberg
2aba29fc32 Add Exclude, Extract, NonNullable, ReturnType, and InstanceType types 2018-02-09 14:22:46 -08:00
Benjamin Lichtman
f989ef7261
Merge pull request #21004 from uniqueiniquity/updateATA
Enable typings cache entries to expire and be updated
2018-02-09 14:17:26 -08:00
Andy
171b68c9e7
Add assertions for bad symbol declaration (#21837)
* Add assertions for bad symbol declaration

* Fix lint
2018-02-09 14:08:56 -08:00
Andy
31ec5e7390
findAllReferences: Don't fail on broken re-export (#21841) 2018-02-09 13:56:04 -08:00
Andy
aa1ebda6a6
Fix bug: handle missing symbol.parent for non-accessible symbol (#21834) 2018-02-09 13:48:40 -08:00
uniqueiniquity
4c89a813bf Handle case where package.json and package-lock.json don't agree 2018-02-09 10:36:49 -08:00
Andrew Casey
6dd88b39d5
Merge pull request #21781 from amcasey/TextChangesReplace
Tidy up textChanges.replace*
2018-02-09 10:35:20 -08:00
Andy
1b620886a9
Assert getExportEqualsLocalSymbol returns a defined result (#21831) 2018-02-09 10:28:31 -08:00
Anders Hejlsberg
868a9ee117
Merge pull request #21782 from Microsoft/fixIdenticalConditionalTypes
Compatibility of identical conditional types
2018-02-08 17:38:31 -08:00
Anders Hejlsberg
a9251723c7 Properly detect identical conditional types in caching logic 2018-02-08 17:10:25 -08:00
Andrew Casey
f77cefee88 Introduce *WithNodes paralleling textChanges.Replace*
1) Take options
2) Return `this`
3) Use adjusted positions
2018-02-08 15:52:12 -08:00
Andrew Casey
80b2c58c51 Eliminate replaceWithSingle in favor of replaceRange 2018-02-08 15:43:46 -08:00
Andrew Casey
8d6e48a2ec Change the meaning of useNonAdjustedStartPosition
Old: getFullStart
New: getStart
Impact: only used in tests
Reason: symmetry with useNonAdjustedEndPosition - both now effectively
mean "exclude trivia from range"
2018-02-08 15:43:41 -08:00
Andy
e2178ecfab
In getSymbolAtLocation, return undefined instead of unknownSymbol (#21774)
* In getSymbolAtLocation, return undefined instead of unknownSymbol

* Update check in completions to look for undefined instead of unknownSymbol
2018-02-08 14:35:21 -08:00
Andy
16f3b93ffd
Simplify TextSpan creation (#21306)
* Simplify TextSpan creation

* Rename 'start' to 'pos' where possible
2018-02-08 13:51:10 -08:00
Nathan Shively-Sanders
37f15ccb41
Print deferred mapped symbols 1 level deep (#21311)
* Print deferred mapped symbols 1 level deep

Previously, deferred mapped symbols would not print their type at all;
it would always print as `any`. This differed from the older behaviour
that printed it forever if necessary. As a compromise, we now print
deferred mapped symbosl 1 level deep before giving up and printing
`any`. This should cover the most common uses of mapped types.

* Use context flags instead of a global
2018-02-08 13:35:00 -08:00
Alan Agius
7b9ceb85fa refactor: use union type in DateConstructor (#21757)
* refactor: use union type in `DateConstructor`

Add support for union types in `DateConstructor`

This will add support for something like the below;
`
let date; string | number;
const date = new Date(x);
`

Closes: #21758

* fix: date constructor can't be passed `string | Date`, but takes either individually

Closes: #20900
2018-02-08 12:22:37 -08:00
Sheetal Nandi
a0b8be0198 Merge branch 'master' into symbolAndTypesOfString 2018-02-08 11:09:26 -08:00
Mohamed Hegazy
4150a463e2
Fix #20805 (#21755)
* Add `-dev` to version patch number in master

* Refactor to handel non-identifier tokens for UMD modules

* Be more graceful handeling non-identifier tokens in import fixes

* Fix bad merge

* Remove check for isIdentifier
2018-02-08 10:32:08 -08:00
Andy
2a17825428
completions: Add assertions that symbols are defined (#21764)
* completions: Add assertions that symbols are defined

* Add assertion messages
2018-02-08 10:20:01 -08:00
Sheetal Nandi
353cfbddc6
Merge pull request #21750 from Microsoft/memberCompletionOfUnknownRightSideOfImport
Fix the member completion returned on right side of the import when it does not resolve to any symbol
2018-02-08 10:07:12 -08:00
Sheetal Nandi
bf707ac265
Merge pull request #21743 from Microsoft/defaultProjectForFile
Fix getDefaultProjectForFile check
2018-02-08 09:58:43 -08:00
Andy
05510a8612
Don't use export function for a function whose name differs from its exported name (#21739)
* Don't use `export function` for a function whose name differs from its exported name

* Fix lint
2018-02-08 09:53:53 -08:00
Andy
28c4871c99
hasSameKeys: Simplify and optimize for identical maps (#21763) 2018-02-08 09:45:43 -08:00
Priyantha Lankapura
79dde93068 Fix formatting of conditional types (#21762)
* Add test for formatting of conditional types

* Fix formatting of conditional types
2018-02-08 09:28:38 -08:00
Mohamed Hegazy
384527aa09
Add -dev to version patch number in master (#21741) 2018-02-07 23:45:37 -08:00
Wesley Wigham
871e71d4ef
Move insertSorted from server to core, use for diagnostic collections (#21401)
* Move insertSorted from server to core, use for diagnostic collections

* All keep the overall list sorted, too

* Increase timeout for js verification

* Use knowledge of how diagnostics are sorted to make all diagnostic list creation lazy and more efficient

* Staunchly avoid array allocation in favor of resizing an existing array
2018-02-07 17:00:59 -08:00
Anders Hejlsberg
22fbb8edce
Merge pull request #21744 from Microsoft/fixGetConstrainedTypeParameter
Fix getConstrainedTypeParameter function
2018-02-07 16:37:10 -08:00
Sheetal Nandi
5b1f29c722 Fix the member completion returned on right side of the import when it does not resolve to any symbol
Fixes #20794
2018-02-07 15:44:22 -08:00
Armando Aguirre
c9ccf72219
Merge pull request #21665 from armanio123/AddFileToLanguageServiceDisabled
Refactored exceededTotalSizeLimitForNonTsFiles to return the last fil…
2018-02-07 15:43:27 -08:00
csigs
c382e46f7d LEGO: check in for master to temporary branch. 2018-02-07 23:10:27 +00:00
Wesley Wigham
65149063ed
Fix #21641, Add indirect location for default imports for synthetic defaults (#21703) 2018-02-07 15:04:37 -08:00
Anders Hejlsberg
7ad8182af2
Merge pull request #21737 from Microsoft/fixDeferredConditional
Fix definitely false check in conditional types
2018-02-07 14:59:40 -08:00
Anders Hejlsberg
22cbfe3b1b Fix getConstrainedTypeParameter function 2018-02-07 14:48:13 -08:00
Sheetal Nandi
b18f830216 Fix getDefaultProjectForFile check
Fixes #21738
2018-02-07 14:42:51 -08:00
Andy
ed941c27b8
Don't check modifier legality, highlight anyway (#21335) 2018-02-07 13:51:08 -08:00
Sheetal Nandi
01d160e3b6
Merge pull request #21740 from Microsoft/gotoDefinition
Fix assert when goToDefinition, from location that is new expression target but not a class symbol
2018-02-07 13:50:02 -08:00
Sheetal Nandi
dab0dbe6f0 Avoid the class declaration not found assert when the new expression doesnt contain construct signature 2018-02-07 13:30:58 -08:00
Sheetal Nandi
35450d3451 Construct signature is valid signature declaration
Fixes #21501
2018-02-07 13:29:47 -08:00
Andy
c4362ac4ba
Simplify use of FindAllReferences in inferFromUsage (#20551) 2018-02-07 13:25:36 -08:00