17594 Commits

Author SHA1 Message Date
Andy
2b9166b2f9
Don't recommend to install '@types/foo' if that already exists (#24815)
* Don't recommend to install '@types/foo' if that already exists

* Add different extra diagnostic text if the @types package exists

* Update API (#24966)
2018-06-21 10:19:14 -07:00
Andy
e7b338e943
Don't treat a declaration as a type argument position (#25046) 2018-06-21 10:18:37 -07:00
Nathan Shively-Sanders
43d0794ba3
Fix crash when binding jsdoc-style inner namepaths (#25106)
* getDeclarationIdentifier handles undefined name

getNameOfDeclaration actually doesn't handle all declarations, only
those that produce names that could be reasonably used as an identifier.
Until now, getDeclarationIdentifier assumed that getNameOfDeclaration
always returned a name. This caused crashes whenever we tried to get the
name of something like a Constructor.

* Add test and baselines

* getNameOfDeclaration can return undefined

This requires all callers to handle it, which turns out now to be too
disruptive.

* Fix lint
2018-06-21 10:01:39 -07:00
Andy
40899eaf5b
Error on 'const' in class expression (#25125) 2018-06-21 09:57:52 -07:00
Andy
3e50f502bb
Mark some Type[] and Signature[] as ReadonlyArray (#25099) 2018-06-21 09:57:14 -07:00
csigs
4bb3f645b5 LEGO: check in for master to temporary branch. 2018-06-21 10:10:39 +00:00
Nathan Shively-Sanders
0f55566cf4
In JS, always check the extends tag of a class before its heritage clause (#25111)
* Check extends tag first in getClassExtendsHeritageClauseElement

Previously getBaseTypeNodeOfClass checked, but this is only used in a
few places.

* Fix names and add test

* Update API baseline

* Move jsdocAugments tests to conformance/jsdoc

* Better naming in checkClassLikeDeclaration
2018-06-20 16:28:30 -07:00
Sheetal Nandi
3eeb36bd22
Merge pull request #25102 from Microsoft/declarationEmitWithNoEmitAndWatch
Mark the declarations visible correctly when emit is disabled but asked to emit declarations for watch mode
2018-06-20 16:04:57 -07:00
Andy
f3e2e891da
navigationBar: Avoid double recursion on special property assignment (#25077) 2018-06-20 12:57:34 -07:00
Sheetal Nandi
f506b28e95 Mark the declarations visible correctly when emit is disabled but asked to emit declarations for watch mode
Fixes #25068
2018-06-20 12:28:50 -07:00
Andy
1c3259d29b
Add CompletionInfo command to protocol (#25080)
* Add CompletionInfo command to protocol

* Add comments to protocol
2018-06-20 09:13:04 -07:00
Andy
b3f9ec3796
Fix bug: Still implement a method even if the return type is defined in another file (#24978) 2018-06-19 16:36:18 -07:00
Mohamed Hegazy
9706f1729e
Merge pull request #25075 from Dangoo/feat/add_intl-number-format_format-to-parts_types
Add Intl.NumberFormat.formatToParts types
2018-06-19 14:20:26 -07:00
dangoo
2ef73ab4fa Fix test messages to mention esnext.intl 2018-06-19 22:58:26 +02:00
Andy
7f553f4f93
refactorConvertToGetAccessAndSetAccess: Don't trigger on leading trivia (#25054)
* refactorConvertToGetAccessAndSetAccess: Don't trigger on leading trivia

* Update API (#24966)
2018-06-19 13:46:03 -07:00
Andy
db85f37669
fixUnusedIdentifier: Don't needlessly exclude jsdoc (#25014) 2018-06-19 13:44:00 -07:00
dangoo
b7f5f2a92b Add missing references in clparser and libs.json 2018-06-19 22:24:32 +02:00
dangoo
48e1a891a6 Add Intl.NumberFormat.formatToParts types 2018-06-19 21:28:49 +02:00
Nathan Shively-Sanders
03fff50fa4
Simplify getJSDocCommentAndTags (#24997)
Previously, getJSDocCommentAndTags could recur up to four times if any
of four predicates matched. However, to avoid duplicates, the predicates
have been tuned to be mutually exclusive, which means that the recursion
can be turned into a while loop. The while loop is much simpler and
safer, since it is guaranteed to only walk up the tree one time. In
addition, the extra check that adds jsdoc from initializers only runs
once, before the loop, further reducing the opportunity for duplicate
jsdocs.

I thought about further simplifying the code that gets the next node to
check, but to know when to stop the loop, I'd need a predicate that is
as complicated as the code in `getNextJSDocCommentLocation`, so I kept
the existing code, just reordering it for compactness.
2018-06-19 10:14:47 -07:00
Markus Johnsson
aa87cc5b73 Merge branch 'master' of github.com:Microsoft/TypeScript 2018-06-19 11:18:20 +02:00
Ryan Cavanaugh
4fafe0b502
Merge pull request #25049 from RyanCavanaugh/tsbuild-fixes
Fixes downstream prepend projects not being built correctly on upstream changes
2018-06-19 12:01:42 +12:00
Ryan Cavanaugh
a72fe5dd8e Add a testcase 2018-06-18 16:44:25 -07:00
Ryan Cavanaugh
43d1ae42a9 Do fewer calls to getRelativePathToDirectoryOrUrl when writing sourcemaps 2018-06-18 11:12:19 -07:00
Ryan Cavanaugh
bb29a1087e Fixes downstream prepend projects not being built correctly on upstream changes 2018-06-18 11:11:03 -07:00
Ron Buckton
aa26a59835
Merge pull request #24244 from Andarist/redefining-helpers
Use redefining helper pattern for better tree-shakeability
2018-06-18 01:11:23 -07:00
Andy
f597589e54
Fix protocol: Field is 'body', not 'edits' (#25005) 2018-06-15 14:59:47 -07:00
Ron Buckton
23c7571e27 Merge branch 'master' into parallelAsyncTests 2018-06-15 13:26:27 -07:00
Andy
e7e69ad4a2
Fix bug in importTracker: default and namespace imports are not exclusive (#24965) 2018-06-15 12:15:39 -07:00
Ryan Cavanaugh
73844ac565 Accept baseline 2018-06-15 11:10:54 -07:00
Wesley Wigham
640af3f75e
Introduce related spans into tsserver protocol (#24548)
* Introduce related spans into tsserver protocol

* Incorporate pretty output, implement esModuleInterop related span
2018-06-15 10:54:36 -07:00
Ryan Cavanaugh
e1e2882edf PR fixups 2018-06-15 10:48:46 -07:00
Ryan Cavanaugh
d02fe4ac44 Merge branch 'master' into esau-squash
# Conflicts:
#	tests/baselines/reference/api/typescript.d.ts
2018-06-15 10:40:46 -07:00
Ron Buckton
575ab61c6b Fix sources array case sensitivity 2018-06-14 23:27:04 -07:00
Ron Buckton
e62a5edc94 Fix off-by-one error with sourcemaps 2018-06-14 22:54:31 -07:00
Andy
7a1d75cc11
getEditsForFileRename: Don't update unrelated import (#24961)
* getEditsForFileRename: Don't update unrelated import

* Importing source file moved if it's the old path *or* new path
2018-06-14 15:42:16 -07:00
Andy
4a7a550502
moveToNewFile: Reuse code from importFixes for inserting import (#24957)
* moveToNewFile: Reuse code from importFixes for inserting import

* Fix test failures

* Update API baselines (#24966)
2018-06-14 15:41:47 -07:00
Nathan Shively-Sanders
4db1c132b7
No dupe jsdoc for assignment inside an initializer (#24973) 2018-06-14 15:32:10 -07:00
Ryan Cavanaugh
03c3c9dda1 Merge branch 'master' into esau-squash 2018-06-14 13:23:15 -07:00
Nathan Shively-Sanders
57e652dd02
Js/check type tags (#24967)
* Check the type expression of `@type` tags

* Update existing tests and baselines
2018-06-14 13:11:52 -07:00
Sheetal Nandi
34b9c4dbad
Merge pull request #24959 from Microsoft/moduleResolutionWithoutExtensionWithJson
Handle the json extension when ResolvedModule result is json file
2018-06-14 13:09:29 -07:00
Sheetal Nandi
1cd604ac69
Merge pull request #24933 from Microsoft/failedLookupWatchesWithClassicResolver
Do not watch parent folders recursively if not needed
2018-06-14 13:09:16 -07:00
Andy
345012e29d
Don't add diagnostic on unused import starting with underscore (#24958)
* Don't add diagnostic on unused import starting with underscore

* Fix lint
2018-06-14 12:55:12 -07:00
Sheetal Nandi
fe260588fa Handle package.json, jsconfig.json, tsconfig.json in the getDiagnostics of fourslash tests 2018-06-14 11:51:18 -07:00
Ryan Cavanaugh
8491f70379 Merge branch 'master' into esau-squash
# Conflicts:
#	tests/baselines/reference/api/typescript.d.ts
2018-06-14 11:25:00 -07:00
Nathan Shively-Sanders
a56b272d38
In JS, fix crash with in a file with conflicting ES2015/commonjs exports (#24960)
* fix crash with conflicting ES2015/commonjs modules

* Refactor based on PR comments
2018-06-14 11:18:23 -07:00
Ryan Cavanaugh
2428220015 Turn on SLC 2018-06-14 11:17:37 -07:00
Wesley Wigham
a77068827d
Handle combinations of rootdir and outdir when calculating paths (#24941) 2018-06-14 11:07:46 -07:00
Sheetal Nandi
8e16bfffc2 Handle the json extension when ResolvedModule result is json file
Fixes #24932
2018-06-14 09:53:06 -07:00
Andy
3261473a9b
Avoid huge inferred type (#24953) 2018-06-14 09:23:40 -07:00
csigs
260f5f80df LEGO: check in for master to temporary branch. 2018-06-14 16:10:53 +00:00