* Use a single ShimMap class, and indicate that iteration always yields string keys (which it did before too)
* Remove emacs-added newline at end of baseline
* Remove space at end of line in baseline
* Add numeric indexer to strings and remove lint
* Update baselines with spread string's numeric indexers
* Reset baseline line number to the locally incorrect value
* Remove trailing newline from baseline again
* Respond to PR comments
* Refactor getTypeFromTypeLiteral, from PR comments
* Fix lint
* Use same literal comparison rules for switch/===
switch was missing the rule for converting literal types to the literal
base type if needed.
* Add switch comparability test and update baselines
* Push eitherIsNotLiteral check into isTypeEqualityComparableTo
Since all callers need this check -- it's how equality is supposed to
work everywhere.
* Update baselines
There are more literal types in error messages because error reporting
no longer has the advantage of calls to getBaseLiteralType
* Adds ES5 to ES3 transformer for reserved words
* Minor cleanup
* Cleaned up emit of enum declaration
* Return both ts and js results from module resolution, and don't have moduleNameResolver responsible for omitting files based on compiler options
* Instead of getResolutionOrDiagnostic, use getResolutionDiagnostic and avoid using resolution.resolvedFileName if the diagnostic is defined.
* Remove "ResolvedModuleFromHost" type and just make `resolvedTsFileName` and `resolvedJsFileName` optional properties
(but still automatically infer one of them to supply if the host supplied neither)
* Remove type inference for spread types
* Update inference test for spread types
* Make spread assignability and apparent type stricter
Assignability now does not allow properties to the left of a type
parameter.
Apparent type now only returns the apparent type of the right-most
spread member.
* Update tests w/spread assignability+apparent type
* Moved AMD/CJS/UMD transform to end
* Spread no longer distributes intersections
* Update spread w/intersection tests
* Move System module transform to end.
* Update baseline
* Revert baseline change due to stale output
* Resolve all-object intersections inside spreads
This means that getSpreadType will return an object type, even when
spreading two intersections, as long as those intersections contain
nothing but object types themselves.
* Update and improve spread intersection tests
* Simplify expression in resolveObjectIntersection
* Update baselines with new index signature rules
* Move n-ary spread handling into separate function.
To be moved to callers in the next step.
* Move multiple-spread handling out of getSpreadType
* Clean up and reorder getSpreadType body
* Respond to PR comments
* Error for call/construct signatures in spread type
1. Simplify the error reporting code to handle all kinds of signatures.
2. Remove index signature handling code when creating a spread type
since it's an error anyway.
* Update baselines with new spread type index errors
* Explain writeSpreadType a little better
* Add more commentary to getSpreadType
* Initial implementation of 'keyof T' type operator
* Introduce PropertyNameType
* Move most of resolveModuleNameForLsHost to lsHost
* Simplify isImplicitGlob test
* Initial implementation of 'T[K]' property access types
* add a fallback logic for older versions of node that don't support 'homedir' (#11845)
* add a fallback logic for older versions of node that don't support 'homedir'
* try os.homedir first
* For JavaScript files, we report semantic errors for using TypeScript-only constructs
from within a JavaScript file as syntactic errors.
* Don't require `resolvedTsFileName` and `resolvedJsFileName`, just `resolvedFileName` and `extension`. Also, change search order to do all TS searching before searching for JS.
* Fix#10108 (Completion suggestion for object literal with getter) (#11808)
* Fix#10108 (Completion suggestion for object literal with getter)
* completions for setter
* Move helper functions to core (fix build)
* Support parametric property access expressions + some renaming
* rewrite void-returning statements in constructors that capture result of super call (#11868)
* rewrite void-returning statements in constructors that capture result of super call
* linter
* only emit /// types reference for a symbol in d.ts file if all declarations of a symbol come from type reference directives (#11872)
* only emit /// types reference for a symbol in d.ts file if all declarations of a symbol come from type reference directives
* pass proper value for current directory when compiling .d.ts files
* Fix bug: Return a resolution diagnostic for a `.jsx` import if `--allowJs` is turned off
* Remove a comment about a parameter that no longer exists
* Fix bug: We want to test for existence of the enum value, not whether it's non-zero
* Fix: test for presence, not absence
* Allow untyped imports
* Simplify for loops in fourslash.ts
* Rename to zipWith
* Change diagnostic message
* Make `extension` property of `ResolvedModule` optional; introduce `ResolvedModuleFull` interface for when the extension is provided.
* Consider index signatures in type produced by 'keyof T'
* Respond to PR comments
* Refactor getIndexedAccessType to be reusable from checkIndexedAccess
* Skip overloads with too-short function parameters
If the parameter of an overload is a function and the argument is also a
function, skip the overload if the parameter has fewer arguments than
the argument does. That overload cannot possibly apply, and should not
participate in, for example, contextual typing.
Example:
```ts
interface I {
(a: number): void;
(b: string, c): void;
}
declare function f(i: I): void;
f((x, y) => {});
```
This code now skips the first overload instead of considering.
This was a longstanding bug but was only uncovered now that more
functions expressions are context sensitive.
* Test skip overloads w/too-short function params
1. Update changed baseline.
2. Add a new test with baseline.
* Minor style improvements
* Ignore optionality when skipping overloads
* Revert "Merge pull request #11354 from Microsoft/map4"
This reverts commit adfdae0dc47db5ad8248d26929a7b31cb895a539, reversing
changes made to aad663cebf6a89f7029af57d8cb6a0a011854978.
* Rename Experimental transform to ESNext
1. Spread/rest are no longer experimental.
2. We need a place to put stage 3 ES features.
* Changes from CR feedback
* disable CoS for inferred projects (#11909)
* Updating test due to CR changes. The order of the diagnostic messages has changed due to concatenation changes
* Do not use contextual signatures with too few parameters
* isAritySmaller runs later: getNonGenericSignature
* Rename TransformFlags.Experimental -> ESNext
* enable non-ts extensions in inferred projects by default
* update CFG to properly handle do statements
* do not inline async IIFEs in control flow graph
* Minor fixes
* cache type for empty type literal (#11934)
cache type for empty type literal
* Improved error messages for invalid assignments to identifiers
* Accept new baselines
* Improved error messages for invalid assignments to properties
* Accept new baselines
* Improve more error messages
* Accept new baselines
* Fix realPathMap in test harness: Must be used in `directoryExists`
* Add helper function
* Update generated files (#11963)
* Move eitherIsNotLiteral check into switch and === checks
This improves error messages
* Forbid augmentation of untyped module (#11962)
* Forbid augmentation of untyped module
* Just use `undefined` for untyped modules
* Unify checking of indexed access expressions and indexed access types
* Accept new baselines
* Accept additional baselines
* Make `cachingInServerLSHost` tests work with `runtests-browser`
* Get literal type only once
* Update baselines
* Add missed test update
* Improve unification by moving more logic to getIndexedAccessType
* Add test cases to report errors for decorators in js file
* Report all the js file errors and skip only the nodes that are not allowed in js
Fixes#11800
* Fix 'keyof any' to produce 'string | number'
* Fix#11396: Make error message referene `Promise` explicitly (#11982)
* Simplify the checking for async function return type
* Fix https://github.com/Microsoft/TypeScript/issues/11396: Make error message referene `Promise` explicitly
* Minor fixes
* Adding tests
* Test case for property used in destructuring variable declaration
* Mark property referenced in the destructuring as referenced
Fixes#11324
* Spread types handle nested index [access] types
Nested index [access] types are treated as assignable to themselves only,
just like type parameters.
* Test index [access] types inside spread types
* module resolution: prefer locally defined ambient modules, reuse resolutions to ambient modules from the old program (#11999)
module resolution: prefer locally defined ambient modules, reuse resolutions to ambient modules from the old program
* Parse, bind and check rest elements
* Downlevel emit of rest elements
* Add rest tests
* Update baselines
* Remove spread types, leaving spread syntax/emit
Spreads are still typed, but cannot be created from a non-object type.
Tests still need to be updated.
* Fix lint
* Lock tslint version to 4.0.0-dev.0, because 4.0.0-dev.1 complains about unnecessary semicolons following properties
* Remove spread type tests from spread tests
* Spread handles index signatures from singleton spreads
I broke it when simplifying the logic earlier.
* Correct assignability for keyof types and type parameters
* Update tests
* Accept new baselines
* Update objectRestAssignment test and baselines
* Fix linting errors
* Update objectRestAssignment test
Missed previously, just got the baselines
* Improve readability of ES next destructuring emit
* Ensure transformFlags are correct before visiting a node.
* Port #12027, #11980 and #11932 to master (#12037)
* add test for the fix for overwrite emitting error
* cr feedback
* Address PR comments
1. Remove extra line in __rest shim.
2. Improve __rest vs __assign check for destructuring assignment.
* Move convertForOf to factory for esnext and es2015
Saves a lot of duplicated code
* Update improved baselines
* Move transformFunctionBody to factory
It is shared by es2015 and esNext transformers.
This commit just adds a convertObjectRest flag to be passed on to
flattenDestructuring functions, as well as adding necessary parameters
to use the code outside a transformer.
* Spread any types to any
* add missing bind calls to properly set parent on token nodes (#12057)
* Cache generic signature instantiations
* Accept new baselines
* Properly instantiate aliasTypeArguments
* Add regression test
* Revert incorrect logic from #11392
* Accept new baselines
* Rename SpreadElementExpression -> SpreadAssignment
and SpreadExpression (formerly SpreadElementExpression) -> SpreadElement
* Add SpreadAssignment to visitors
1. visitNode
2. reduceNode
3. emit
This fixes an emit bug for setters.
* Add --target esnext
Currently, this disables the rest and spread transforms. This will
change as proposals enter and leave stage 3.
* Add --target esnext tests and update baselines
* Revert unneeded change and comments per PR
* Rename variable in checkSwitchStatement per PR
* Do not emit __rest for --target esnext
* Add `realpath` implementation for lshost
* Create spread property types eagerly
This avoids the need for a synthetic symbol and later code called from
getTypeOfSymbol.
* Set spread type symbols in checkObjectLiteral
Instead of getSpreadType.
Also clean up special-case handling inside getSpreadType to be more
readable.
* Ports #12051 and #12032 into master (#12090)
* use local registry to check if typings package exist (#12014)
use local registry to check if typings package exist
* enable sending telemetry events to tsserver client (#12035)
enable sending telemetry events
* Address more PR comments
* return empty file watcher in case if target directory does not exist (#12091)
* return empty file watcher in case if target directory does not exist
* linter
* property handle missing config files in external projects (#12094)
* Reuse subtree transform flags for incrementally parsed nodes (#12088)
* Port fix for https://github.com/Microsoft/TypeScript/issues/12069 (#12095)
* reduce set of files being watched, increase polling interval (#12054) (#12092)
* Update authors for release-2.1
* Include declaration file emit
* use createHash from ServerHost instead of explicit require (#12043)
* use createHash from ServerHost instead of explicit require
* added missing method in ServerHost stub
* (signature help) type parameter lists are never variadic (#12112)
* Handle abstract and const modifiers
* Downlevel array destructuring to ES6 in object rest
Previously array destructuring inside an object destructuring with an
object rest would downlevel the array destructuring to ES5. This breaks
if the code that targets ES2015 is using iterators instead of arrays
since iterators don't support [0] or .slice that the ES5 emit uses.
* Improve nested destructuring test for ESNext emit
Now with object destructuring inside array destructuring inside object
destructuring! Each with their own array/object rest!
Also updates baselines.
* Add support for taking in jsxFactory option and report errors for invalid combinations
* Treat `| undefined` like optionality in spread type
* Add strictNullChecks test for object spread
* Verify that jsxFactory is either identifier or qualified name
* Resolve first identifier of the jsxFactory as part of type check
* When emitting use jsx factory entity expression if provided
* Transpile unit test case
* Enabled test case for source map
* Add test cases for when jsxFactory cannot be resolved
* Parse the jsxFactory again in the checker instead of using cached value in the program
* Adds error message for incompatible assignment of identically named type
Fixes issue #12050
* Updated condition for more readability
* Report errors for import helpers missing __rest
* Correctly check spread assignments in strict mode
Previously it crashed in the binder.
* Test error for import helpers with no __rest
* synthesize complete import declaration for tslib (#12151)
* Add ES2017 string padding (#12152)
* add es2017.string.d.ts for String.prototype.{padStart,padEnd}
* append es2017.string.d.ts into es2017.d.ts
* add es2017.string into commandLineParser
* append es2017.string into error message for unit tests of commandLineParser
* append es2017.string into Gulpfile
* append es2017.string into Jakefile
* Exclude js files in non-configured projects compile-on-save emitting (#12118)
* Exclude js files in non-configured projects CoS emitting
* remove unnecessary method
* Merge release-2.1 into master (#12157)
* Update LKG
* Update version
* Update LKG
* Skip overloads with too-short function parameters
If the parameter of an overload is a function and the argument is also a
function, skip the overload if the parameter has fewer arguments than
the argument does. That overload cannot possibly apply, and should not
participate in, for example, contextual typing.
Example:
```ts
interface I {
(a: number): void;
(b: string, c): void;
}
declare function f(i: I): void;
f((x, y) => {});
```
This code now skips the first overload instead of considering.
This was a longstanding bug but was only uncovered now that more
functions expressions are context sensitive.
* Test skip overloads w/too-short function params
1. Update changed baseline.
2. Add a new test with baseline.
* Minor style improvements
* Ignore optionality when skipping overloads
* Do not use contextual signatures with too few parameters
* isAritySmaller runs later: getNonGenericSignature
* rewrite void-returning statements in constructors that capture result of super call (#11868)
* rewrite void-returning statements in constructors that capture result of super call
* linter
* Update LKG
* Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters
* Add tests and baselines
* Skip trying to use alias if there is target type
* Update baselines
* Add diagnostics to remind adding tsconfig file for certain external project (#11932)
* Add diagnostics for certain external project
* Show tsconfig suggestion
* fix lint error
* Address pr
* fix comment
* Update error message
* Flag for not overwrite js files by default without generating errors (#11980)
* WIP
* Properly naming things
* refactor
* apply the option to all files and check out options
* Fix typo
* Update LKG
* lockLinter
* use local registry to check if typings package exist (#12014) (#12032)
use local registry to check if typings package exist
* Add test for https://github.com/Microsoft/TypeScript/pull/11980 (#12027)
* add test for the fix for overwrite emitting error
* cr feedback
* enable sending telemetry events to tsserver client (#12034) (#12051)
enable sending telemetry events
* Update LKG
* Reuse subtree transform flags for incrementally parsed nodes (#12088)
* Update LKG
* Update version
* Update LKG
* Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module
* Add tests and baselines
* [Release 2.1] fix11754 global augmentation (#12133)
* Exclude global augmentation from module resolution logic
* Address PR: check using string literal instead of NodeFlags.globalAugmentation
* Remove comment
* Improve error message
* Remove `SupportedExpressionWithTypeArguments` type; just check that the expression of each `ExpressionWithTypeArguments` is an `EntityNameExpression`.
* Fix bug
* Fix#10083 - allowSyntheticDefaultImports alters getExternalModuleMember (#10096)
* Use recursion, and fix error for undefined node
* Rename function
* Fix lint error
* Narrowing type parameter intersects w/narrowed types
This makes sure that a union type that includes a type parameter is
still usable as the actual type that the type guard narrows to.
* Don't allow ".d.ts" extension in an import either.
* Add a helper function `getOrUpdateProperty` to prevent unprotected access to Maps.
* Limit type guards as assertions to incomplete types in loops
* Accept new baselines
* Fix linting error
* Allow JS multiple declarations of ctor properties
When a property is declared in the constructor and on the prototype of
an ES6 class, the property's symbol is discarded in favour of the
method's symbol. That because the usual use for this pattern is to bind
an instance function: `this.m = this.m.bind(this)`. In this case the
type you want really is the method's type.
* Use {} type facts for unconstrained type params
Previously it was using TypeFacts.All. But the constraint of an
unconstrained type parameter is actually {}.
* Fix newline lint
* Test that declares conflicting method first
* [Release-2.0] Fix 9662: Visual Studio 2015 with TS2.0 gives incorrect @types path resolution errors (#9867)
* Change the shape of the shim layer to support getAutomaticTypeDirectives
* Change the key for looking up automatic type-directives
* Update baselines from change look-up name of type-directives
* Add @currentDirectory into the test
* Update baselines
* Fix linting error
* Address PR: fix spelling mistake
* Instead of return path of the type directive names just return type directive names
* Remove unused reference files: these tests produce erros so they will not produce these files (#9233)
* Add string-literal completion test for jsdoc
* Support other (new) literal types in jsdoc
* Don't allow properties inherited from Object to be automatically included in TSX attributes
* Add new test baseline and delete else in binder
The extra `else` caused a ton of test failures!
* Fix lint
* Port PR #10016 to Master (#10100)
* Treat namespaceExportDeclaration as declaration
* Update baselines
* wip - add tests
* Add tests
* Show "export namespace" for quick-info
* Fix more lint
* Try using runtests-parallel for CI (#9970)
* Try using runtests-parallel for CI
* Put worker count setting into .travis.yml
* Reduce worker count to 4 - 8 wasnt much different from 4-6 but had contention issues causing timeouts
* Fix lssl task (#9967)
* Surface noErrorTruncation option
* Stricter check for discriminant properties in type guards
* Add tests
* Emit more efficient/concise "empty" ES6 ctor
When there are property assignments in a the class body of an inheriting
class, tsc current emit the following compilation:
```ts
class Foo extends Bar {
public foo = 1;
}
```
```js
class Foo extends Bar {
constructor(…args) {
super(…args);
this.foo = 1;
}
}
```
This introduces an unneeded local variable and might force a reification
of the `arguments` object (or otherwise reify the arguments into an
array).
This is particularly bad when that output is fed into another transpiler
like Babel. In Babel, you get something like this today:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
_Bar.call.apply(_Bar, [this].concat(args));
this.foo = 1;
}
return Foo;
})(Bar);
```
This causes a lot of needless work/allocations and some very strange
code (`.call.apply` o_0).
Admittedly, this is not strictly tsc’s problem; it could have done a
deeper analysis of the code and optimized out the extra dance. However,
tsc could also have emitted this simpler, more concise and semantically
equivalent code in the first place:
```js
class Foo extends Bar {
constructor() {
super(…arguments);
this.foo = 1;
}
}
```
Which compiles into the following in Babel:
```js
var Foo = (function (_Bar) {
_inherits(Foo, _Bar);
function Foo() {
_classCallCheck(this, Foo);
_Bar.apply(this, arguments);
this.foo = 1;
}
return Foo;
})(Bar);
```
Which is well-optimized (today) in most engines and much less confusing
to read.
As far as I can tell, the proposed compilation has exactly the same
semantics as before.
Fixes#10175
* Fix instanceof operator narrowing issues
* Accept new baselines
* Add regression test
* Improve naming and documentation from PR
* Update comment
* Add more tests
* Accept new baselines
* Reduce worker count to 3 (#10210)
Since we saw a starvation issue on one of @sandersn's PRs.
* Speed up fourslash tests
* Duh
* Make baselines faster by not writing out unneeded files
* Fix non-strict-compliant test
* Fix 10076: Fix Tuple Destructing with "this" (#10208)
* Call checkExpression eventhough there is no appropriate type from destructuring of array
* Add tests and baselines
* use transpileModule
* Remove use strict
* Improve instanceof for structurally identical types
* Introduce isTypeInstanceOf function
* Add test
* Accept new baselines
* Fix loop over array to use for-of instead of for-in
* Use correct this in tuple type parameter constraints
Instantiate this in tuple types used as type parameter constraints
* Add explanatory comment to resolveTupleTypeMembers
* Ignore null, undefined, void when checking for discriminant property
* Add regression test
* Delay tuple type constraint resolution
Create a new tuple that stores the this-type.
* Always use thisType when generating tuple id
* Optimize format of type list id strings used in maps
* wip - fix error
* Make ReadonlyArray iterable.
* Allow OSX to fail while we investigate (#10255)
The random test timeouts are an issue.
* Fix error from using merging master
* avoid using the global name
* Fix single-quote lint
* Update baselines
* Fix linting
* Optimize performance of maps
* Update API sample
* Fix processDiagnosticMessages script
* Have travis take shallow clones of the repo (#10275)
Just cloning TS on travis takes 23 seconds on linux (68 seconds on mac), hopefully having it do a shallow clone will help.
We don't rely on any tagging/artifacts from the travis servers which clone depth could impact, so this shouldn't impact anything other than build speed.
* Add folds to travis log (#10269)
* Optimize filterType to only call getUnionType if necessary
* Add shorthand types declaration for travis-fold (#10293)
* Optimize getTypeWithFacts
* Filter out nullable and primitive types in isDiscriminantProperty
* Fix typo
* Add regression tests
* Optimize core filter function to only allocate when necessary
* Address CR comments + more optimizations
* Faster path for creating union types from filterType
* Allow an @types direcotry to have a package.json which specifies `"typings": null` to disclude it from automatically included typings.
* Lint
* Collect timing information for commands running on travis (#10308)
* Simplifies performance API
* Use 'MapLike' instead of 'Map' in 'preferConstRule.ts'.
* narrow from 'any' in most situations
instanceof and user-defined typeguards narrow from 'any' unless the narrowed-to type is exactly 'Object' or 'Function'. This is a breaking change.
* Update instanceof conformance tests
* accept new baselines
* add tests
* accept new baselines
* Use lowercase names for type reference directives
* Use proper response codes in web tests
* Treat ambient shorthand declarations as explicit uses of the `any` type
* Rename 'find' functions
* Parallel linting (#10313)
* A perilous thing, a parallel lint
* Use work queue rather than scheduling work
* Dont read files for lint on main thread
* Fix style
* Fix the style fix (#10344)
* Aligned mark names with values used by ts-perf.
* Use an enum in checkClassForDuplicateDeclarations to aid readability
* Rename to Accessor
* Migrated more MapLikes to Maps
* Add ES2015 Date constructor signature that accepts another Date (#10353)
* Parameters with no assignments implicitly considered const
* Add tests
* Migrate additional MapLikes to Maps.
* Fix 10625: JSX Not validating when index signature is present (#10352)
* Check for type of property declaration before using index signature
* Add tests and baselines
* fix linting error
* Adding more comments
* Clean up/move some Map helper functions.
* Revert some formatting changes.
* Improve ReadonlyArray<T>.concat to match Array<T>
The Array-based signature was incorrect and also out-of-date.
* Fix link to blog
* Remove old assertion about when we're allowed to use fileExists
* Set isNewIdentifierLocation to true for JavaScript files
* Update error message for conflicting type definitions
Fixes#10370
* Explain why we lower-case type reference directives
* Correctly merge bindThisPropertyAssignment
Also simply it considerably after noticing that it's *only* called for
Javascript files, so there was a lot of dead code for TS cases that
never happened.
* Fix comment
* Property handle imcomplete control flow types in nested loops
* Update due to CR suggestion
* Add regression test
* Assign and instantiate contextual this type if not present
* Fix 10289: correctly generate tsconfig.json with --lib (#10355)
* Separate generate tsconfig into its own function and implement init with --lib
# Conflicts:
# src/compiler/tsc.ts
* Add tests and baselines; Update function name
Add unittests and baselines
Add unittests and baselines for generating tsconfig
Move unittest into harness folder
Update harness tsconfig.json
USe correct function name
* Use new MapLike interstead. Update unittest
# Conflicts:
# src/compiler/commandLineParser.ts
* Update JakeFile
* Add tests for incorrect cases
* Address PR : remove explicity write node_modules
* JSDoc supports null, undefined and never types
* Update baselines in jsDocParsing unit tests
* Restored comments to explain spreading 'arguments' into calls to 'super'.
* Added test.
* Use the non-nullable type of the contextual type for object completions.
* Return non-JsDocComment children
... to make syntactic classification work
* Add more tests for `export = foo.bar`.
* Output test baselines to tests/baselines/local instead of root
* Move supportedTypescriptExtensionsWithDtsFirst next to supportedTypeScriptExtensions and rename
* Fix comment
* Fix RWC Runner (#10420)
* Use /// <reference types
* Don't report an errors if it comes from lib.d.ts
* Treat special property access symbol differently
... when retriving documentation
* Fix tests
* Update shim version to be 2.1 (#10424)
* Check return code paths on getters (#10102)
* Check return paths on getters
* Remove TODO comment
* Remove extraneous arguments from harness's runBaseline (#10419)
* Remove extraneous arguments from runBaseline
* Address comments from @yuit
* Remove needless call to basename
* Refactor baseliners out of compiler runner (#10440)
* CR feedback
* fix broken tests
* Pass in baselineOpts into types baselines so that RWC baselines can be written to internal folder (#10443)
* Add error message
Add error message when trying to relate primitives to the boxed/apparent
backing types.
* fix linting error
* follow advise
* remove extra code
* Add more test for 10426
* fix some errors
* routine update of dom libs
* Add test for jsdoc syntactic classification for function declaration
* Simplify implementation
* Tolerate certain errors in tsconfig.json
* Add test for configFile error tolerance
* Use TS parser to tolerate more errors in tsconfig.json
* Implement tuple types as type references to synthesized generic types
* Add comments + minor changes
* Accept new baselines
* Add .types extension
* Properly guard for undefined in getTypeReferenceArity
* Add jsdoc nullable union test case to fourslash
* Fix class/interface merging issue + lint error
* Allow "typings" in a package.json to be missing its extension (but also allow it to have an extension)
* Contextually type this in getDeclFromSig, not checkThisExpr
* Update parser comment with es7 grammar (#10459)
* Use ES7 term of ExponentiationExpression
* Update timeout for mac OS
* Address PR: add space
* allowSyntheticDefaultImports resolves to modules instead of variables
Fixes#10429 by improving the fix in #10096
* Rename getContextuallyTypedThisParameter to getContextualThisParameter
* Fix 10472: Invalid emitted code for await expression (#10483)
* Properly emit await expression with yield expression
* Add tests and update baselines
* Move parsing await expression into parse unary-expression
* Update incorrect comment
* change error message
* Fix broken build from merging with master
* Fix linting error
* Use merge2, gulp-if, gulp-newer, and more projects
* Add watch task
* Working non-inline sourcemaps for runtests
* browser tests now also loads sourcemaps from disk
* Lazypipes and better services stream management
* export interface used by other exported functions
* Make goto-definition work for `this` parameter
* Add new error for rest parameters
* Add error message for rest parameter properties
* Fix case when a document contains multiple script blocks with different base indentations.
Use the base indent size if it is greater that the indentation of the inherited predecessor
* Fix rwc-runner from breaking change in compiler (#9284)
* Signatures use JSDoc to determine optionality
* Changed implementation to use closure
* Updated tests
* Fixed linting error
* Adding Code of Conduct notice
* Don't crash when JS class property is self-referential.
Fixes#9293
* Remove stale baselines
* For optionality, check question token before JSDoc
* Accept rest parameter properties error baselines
* Change binding pattern parameter property error
* Accept binding pattern properties error baselines
* Lint
* Port the sync version diagnostics API from tsserverVS-WIP branch to 2.0
* Do copyright without gulp-if and lazypipe
* Change test comment and accept baseline
* Remove tsd scripts task from gulpfile
* Make use of module compiler option explicit, add strip internal to tsconfigs
* Remove Signature#thisType and use Signature#thisParameter everywhere
* Add Gulpfile lint to jake, fix lints
* Change reference tests to verify actual ranges referenced and not just their count
* Respond to PR comments
* Add new lint rule
* Fix object whitespace lints
* Fix case of gulpfile dependencies
* 1. pass subshell args 2. fix build order in services
1. /bin/sh requires its arguments joined into a single string unlike
cmd.
2. services/ depends on a couple of files from server/ but the order was
implicit, and changed from jakefile. Now the order is explicit in the
tsconfig.
* Fix single-quote lint
* Check for exactly one space
* Fix excess whitespace issues
* Add matchFiles test to Gulpfile
This was merged while the gulpfile was still in-progress
* Fix LKG useDebug task and newLine flag
* Update LKG
* Clean before LKG in Gulpfile
* Fix lint
* Correct the api string name
* Allow space in exec cmds
* Fix typo
* Add new APIs to protocol
* Fix bug where `exports.` was prepended to namespace export accesses
* Remove unnecessary parameter
* extract expression into function
* Add fourslash tests & address CR comments
* Fix 8549: Using variable as Jsx tagname (#9337)
* Parse JSXElement's name as property access instead of just entity name. So when one accesses property of the class through this, checker will check correctly
* wip - just resolve to any type for now
* Resolve string type to anytype and look up property in intrinsicElementsType of Jsx
* Add tests and update baselines
* Remove unneccessary comment
* wip-address PR
* Address PR
* Add tets and update baselines
* Fix linting error
* Unused identifiers compiler code (#9200)
* Code changes to update references of the Identifiers
* Added code for handling function, method and coonstructor level local variables and parameters
* Rebased with origin master
* Code changes to handle unused private variables, private methods and typed parameters
* Code changes to handle namespace level elements
* Code changes to handle unimplemented interfaces
* Code to optimize the d.ts check
* Correct Code change to handle the parameters for methods inside interfaces
* Fix for lint error
* Remove Trailing whitespace
* Code changes to handle interface implementations
* Changes to display the error position correctly
* Compiler Test Cases
* Adding condition to ignore constructor parameters
* Removing unnecessary tests
* Additional changes for compiler code
* Additional changes to handle constructor scenario
* Fixing the consolidated case
* Changed logic to search for private instead of public
* Response to PR Comments
* Changed the error code in test cases as result of merge with master
* Adding the missing file
* Adding the missing file II
* Response to PR comments
* Code changes for checking unused imports
* Test Cases for Unused Imports
* Response to PR comments
* Code change specific to position of Import Declaration
* Code change for handling the position for unused import
* New scenarios for handling parameters in lambda function, type parameters in methods, etc.
* Additional scenarios based on PR comments
* Removing a redundant check
* Added ambient check to imports and typeparatmeter reporting
* Added one more scenario to handle type parameters
* Added new scenario for TypeParameter on Interface
* Refactoring the code
* Added scenario to handle private class elements declared in constructor.
* Minor change to erro reporting
* Fix 8355: Fix emit metadata different between transpile and tsc --isolatedModule (#9232)
* Instead of returning undefined for unknownSymbol return itself
* Add Transpile unittest
* Wip - Add project tests
* Add project tests and baselines
* Update existed tests
* Add tests for emitting metadata with module targetting system
* Fix 8467: Fix incorrect emit for accessing static property in static propertyDeclaration (#8551)
* Fix incorrect emit for accessing static property in static propertyDeclaration
* Update tests and baselines
* Update function name
* Fix when accessing static property inside arrow function
* Add tests and baselines
* do not format comma/closeparen in jsxelement
* format jsx expression
* Remove extra baselines
* Fixed bugs and linting
* Added project tests for node_modules JavaScript searches
* Removed old TODO comment
* make rules optional
* Fixed the regexp for removing full paths
* Fix type of the disableSizeLimit option
* Update version to 2.0.0
* Remove upper boilerplate from issue template
Our issue stats did not improve appreciably when we added the issue template. Reduce upper boilerplate text and try to make it more action-oriented
* Remove unused compiler option (#9381)
* Update LKG
* Added emitHost method to return source from node modules
* Marked new method internal
* Update issue_template.md
* new options should be optional for compatibility
* Add getCurrentDirectory to ServerHost
* Add nullchecks for typeRoots, remove getCurrentDirectory from ServerHost as it is always the installation location
* VarDate interface and relevant Date.prototype members
* Port 9396 to release 2.0
* Fix 9363: Object destructuring broken-variables are bound to the wrong object (#9383)
* Fix emit incorrect destructuring mapping in var declaration
* Add tests and baselines
* Add additional tests and baselines
* Fix crash in async functions when targetting ES5.
When targetting ES5 and with --noImplicitReturns,
an async function whose return type could not be determined would cause
a compiler crash.
* Add This type to lib
* Merge master into release-2.0 (#9400)
* do not format comma/closeparen in jsxelement
* format jsx expression
* make rules optional
* Remove upper boilerplate from issue template
Our issue stats did not improve appreciably when we added the issue template. Reduce upper boilerplate text and try to make it more action-oriented
* Update issue_template.md
* new options should be optional for compatibility
* Add getCurrentDirectory to ServerHost
* Add nullchecks for typeRoots, remove getCurrentDirectory from ServerHost as it is always the installation location
* VarDate interface and relevant Date.prototype members
* Fix 9363: Object destructuring broken-variables are bound to the wrong object (#9383)
* Fix emit incorrect destructuring mapping in var declaration
* Add tests and baselines
* Add additional tests and baselines
* Fix#9402: Do not report unused identifier errors for catch variables
* getVarDate should be on the Date interface
* Defere checking unsed identifier checks
* Do not scan nodes preceding formatted region, just skip over them
* Don't emit source files found under node_modules
* Destructuring assignment removes undefined from type when default value is given
* Add nullcheck when calculating indentations for implort clause
* Use a deferred list to check for unused identifiers
* push checks to checkUnusedIdentifiersDeferred
* use isParameterPropertyDeclaration to test for paramter propoerties
* runtests-parallel skips empty buckets
Previously, it would enter them as buckets with no tests, which would
make our test runners run *every* test.
This was very obvious on machines with lots of cores.
* Report unused identifiers in for statements
* Do not check ambients, and overloads
* Add tests
* Consolidate type reference marking in getTypeFromTypeReference
* Handel type aliases
* Add tests
* Add test
* Dont load JavaScript if types packages are present
* Renamed API
* Use checkExpression, not checkExpressionCached
* Do not report unused errors for module augmentations
* Consolidate refernce marking in resolveName to allow marking aliases correctelly
* add tests
* Code review comments
* Only mark symbols found in a local symbol table
* Show "<unknown>" if the name of a declaration is unavailable
* Parse `export default async function` as a declaration
* Respond to PR comments
* Better name for test
* handel private properties correctelly
* Port 9426 to release 2.0
* Handel Swtich statements
check for locals on for statments
only mark private properties
* Removed one error to avoid full path issues
* Don't emit source files found under node_modules
(cherry picked from commit 5f8cf1af3e4be61037cbafd698535d32d292941f)
* Dont load JavaScript if types packages are present
(cherry picked from commit 5a45c44eb789f52ceb1aa0e23a230ecb599bfb08)
* Renamed API
(cherry picked from commit d8047b607f11cdf319284bb344282582c7c0aea0)
* Removed one error to avoid full path issues
(cherry picked from commit 5e4f13f342a75ec8f7cf65cb669bec9d6e6c5581)
* Fix incorrectly-saved quote symbols in ThirdPartyNoticeText.txt
* Fix#9458: exclude parameters starting with underscore from unusedParamter checks
* change variable name for strict mode
* Increase timeout from running RWC. As UWDWeb takes slightly longer now (#9454)
* Handle relative paths in tsconfig exclude and include globs
* Merge master into release branch 06/30 (#9447)
* do not format comma/closeparen in jsxelement
* format jsx expression
* make rules optional
* Remove upper boilerplate from issue template
Our issue stats did not improve appreciably when we added the issue template. Reduce upper boilerplate text and try to make it more action-oriented
* Update issue_template.md
* new options should be optional for compatibility
* Add getCurrentDirectory to ServerHost
* Add nullchecks for typeRoots, remove getCurrentDirectory from ServerHost as it is always the installation location
* VarDate interface and relevant Date.prototype members
* Fix 9363: Object destructuring broken-variables are bound to the wrong object (#9383)
* Fix emit incorrect destructuring mapping in var declaration
* Add tests and baselines
* Add additional tests and baselines
* Fix crash in async functions when targetting ES5.
When targetting ES5 and with --noImplicitReturns,
an async function whose return type could not be determined would cause
a compiler crash.
* Add This type to lib
* getVarDate should be on the Date interface
* Don't emit source files found under node_modules
* Destructuring assignment removes undefined from type when default value is given
* Add nullcheck when calculating indentations for implort clause
* Add test
* Dont load JavaScript if types packages are present
* Renamed API
* Use checkExpression, not checkExpressionCached
* Show "<unknown>" if the name of a declaration is unavailable
* Parse `export default async function` as a declaration
* Removed one error to avoid full path issues
* Fix incorrectly-saved quote symbols in ThirdPartyNoticeText.txt
* Improve names of whitespace functions
* Handle relative paths in tsconfig exclude and include globs
Port 9475 to release 2.0
* add new method getEmitOutputObject to return result of the emit as object with properties instead of json string
* fix linter
* Fix PromiseLike to be compatible with es6-promise (#9484)
* Fix reading files from IOLog because previous our API captures (#9483)
* Fix reading files from IOLog because previous our API captures
* Refactoring the ioLog
* Exclude FlowSwitchClause from flow graph for case expressions
* Add regression test
* Update LKG
* Update language in comment
* Add .mailmap file
* Add authors script to generate authors from repo
* Update AUTHORS.md for release-2.0
* Update script to pass more than one argument
* Remove the unused text buffer from ScriptInfo
* Fix#9531: account for async as an contextual keyword when parsing export assignments
* Update LKG
* Swap q from a reference to an import
* Fix#9550: exclude 'this' type parameters from unusedParameters checks.
* Update comment to reflect new dependency
* Avoid putting children tags in jsdoccomment
* Parse the result of getDirectories call
* Update harness getDirectories implementation for shims
* Fix multiple Salsa assignment-declarations
Previously, all assignment-declarations needed to be of the same kind:
either all `this.p = ...` assignments or `C.prototype.p = ...`
assignments.
* Test for multiple salsa assignment-declarations
* Add test for parsed @typedef tag node shape
* Provide a symbol for salsa-inferred class types
* Update .mailmap
* Fix module tracking
* Updated test with relative import
* Fixed the node tracking and a harness bug
* fixed lint error
* Fixed implicit any
* Added missing test files
* Removed duplicate logic
* Update conflicting baseline.
PR #9574 added a baseline that #9578 caused to be changed. The two PRs
went in so close to each other that the CI build didn't catch the change
to the new test's baseline.
* Fix type of JSXTagName
* Update baselines to use double-quote
* Update baselines when emitting metadata decorator
* Update baselines for async-await function
* Update baselines for comment in capturing down-level for...of and for...in
* Add missing Transpile tests
* Remove old JS transpile baselines
* Passing program as argument in emitWorker
* Port PR#9607 transforms
* Port new JSDOC tests to use baseline
* substitute alias for class expression in statics
* Address new lint warnings
* Change name for substitution function.
* Use sorcery to merge sourcemaps between browserify and gulp-typescript
* Use shorthand
* Fix nit
* move comments, change loop into map
* Ahahaha, we should run code before pushing it
* Move conditional into call
