Commit Graph

100 Commits

Author SHA1 Message Date
Andy
d8142339f9 Use 'filter' array helper (#20452) 2017-12-04 13:36:01 -08:00
Andrew Casey
e934c30513 Merge pull request #20173 from RyanCavanaugh/fixTypingsInstallerAgain_master
Always send a response to installTypings even if all types are cached
2017-11-27 10:47:05 -08:00
Andrew Casey
35545d4a0a Update project on PackageInstalledResponse
As with `SetTypings`, new typings have been installed so the project
should be updated and the client should be notified (via event).

Changed PackageInstalledResponse from "event" to "action" for the sake
of explicitness.

Fixes #20084.
2017-11-21 15:59:46 -08:00
Ryan Cavanaugh
ee2d436999 Always send a response to installTypings even if all types are cached 2017-11-20 21:32:56 -08:00
Ryan Cavanaugh
a416826b64 Apply safelist exclusions even when include is not specified; recompute project contexts when installer reqs finish 2017-11-16 12:52:30 -08:00
micbou
d97335e4e7 Silence NPM warnings when installing typings (#19749) 2017-11-06 09:45:52 -08:00
Andy
0a7b7e07ee Apply 'variable-name' tslint rule (#19743) 2017-11-06 09:23:47 -08:00
Andy
6a382f1436 In typings installer, provide mandatory 'package.json' fields (#19663) 2017-11-01 14:20:26 -07:00
Andy
d05443bb1d Add quickfix and refactoring to install @types packages (#19130)
* Add quickfix and refactoring to install @types packages

* Move `validatePackageName` to `jsTyping.ts`

* Remove combinePaths overloads

* Respond to code review

* Update api baselines

* Use native PromiseConstructor

* Return false instead of undefined

* Remove getProjectRootPath

* Update api
2017-10-17 15:04:09 -07:00
Andy
d0c4d13fe2 In tsserver, indent logged JSON (#19080) 2017-10-17 11:34:59 -07:00
Andy
917ae32937 Always log output of execSync (#19110)
* Always log output of execSync

* Fix lint
2017-10-11 14:50:45 -07:00
Sheetal Nandi
e30a66d22f Add utitlity for stringContains 2017-10-10 17:16:39 -07:00
Andy
193f4be355 Enable interface-over-type-literal lint rule (#17733) 2017-09-07 09:14:59 -07:00
Mohamed Hegazy
deaddb5595 Ports #17983 (#17986)
* Bind logger function before using

* Use lambda isntead of bind
2017-08-23 13:01:14 -07:00
Ryan Cavanaugh
43b8ce664c Merge 2017-08-22 14:31:49 -07:00
Ryan Cavanaugh
af68a61ba7 Ignore scripts for types packages 2017-08-16 11:53:44 -07:00
Andy
08fbcd8b80 Fix many no-object-literal-type-assertion lint errors (#17278)
* Fix many no-object-literal-type-assertion lint errors

* Simple fixes

* Use a union for FlowNode

* PR feedback and remove remaining `id()` uses

* Use a union for CodeBlock

* Discriminate CodeBlock by CodeBlockKind
2017-08-10 12:52:15 -07:00
Ryan Cavanaugh
5272ec6309 Types Map WIP 2017-07-27 16:07:50 -07:00
Andy
3330f2a33b JsTyping: Remove "safeList" global variable (#17304) 2017-07-27 10:54:47 -07:00
Andy Hanson
96d537bc54 readFile may return undefined 2017-07-14 15:57:23 -07:00
Andy
efc861c76d Add logging to discoverTypings (#16652) 2017-07-13 07:10:35 -07:00
Andy
e7dc2a67ca Enable "object-literal-shorthand" lint rule (#16987) 2017-07-07 07:26:58 -07:00
Andy
179a3e10b5 Handle depth in all readDirectory implementations (#16646) 2017-06-29 11:04:33 -07:00
Bill Ticehurst
2e0eb26543 Fix equals 2017-05-30 10:39:03 -07:00
Bill Ticehurst
05d3ff1823 Wrap npmLocation if needed 2017-05-30 10:38:55 -07:00
Andy
2412f8c6cf Allow configurable npmLocation for typingsInstaller (#16084)
* Allow configurable npmLocation for typingsInstaller

* Undo "export class" changes

* Add log for npmLocation

* Log whether '--npmLocation' was provided
2017-05-26 07:06:11 -07:00
Matt Bierner
e44d419c90 Add Log for When Typings Installer Finishes Updating the Types Registry
**Bug**
While investigating #15301, I was confused by the typing installer's log `Updating types-registry npm package...`. This was often the last line of the log file, leading me to believe that the types-registry update was still ongoing

**Fix**
Add an extra log for when the type-registry update completes successfully
2017-05-04 20:04:46 -07:00
Arthur Ozga
7e03429a8e enforce triple-equals 2017-04-04 15:51:13 -07:00
Mine Starks
0c1642a8b7 Allow specifying location of typingSafeList.json 2017-03-20 16:16:38 -07:00
Andy Hanson
2305c10a65 Fix lint errors 2017-03-17 13:54:18 -07:00
Vladimir Matveev
17cb68cbbf send error if obtaining of types-registry package failed (#14573) 2017-03-10 10:34:01 -08:00
Vladimir Matveev
77c2a1d20d allow passing --logFile and --logVerbosity parameter to tsserver (#14566) 2017-03-09 15:25:44 -08:00
Mohamed Hegazy
81c0bd50ab Add --lib es6 to @types/node dependent targets 2017-03-08 23:03:30 -08:00
Andy Hanson
d58cfa238b Merge branch 'master' into lint_better 2017-03-06 06:20:48 -08:00
Andy Hanson
8371eb6401 Update tslint to latest (next is still on 4.3) and lint for BOM 2017-03-01 10:37:13 -08:00
Andy Hanson
91421c8dbc Fix "semicolon" lint rule options (was not enabled) 2017-02-10 12:24:10 -08:00
Andy Hanson
58cb9a7f08 Use "ts2.2" (or "ts2.3", etc.) NPM tag in typingsInstaller 2017-01-31 06:57:47 -08:00
Andy Hanson
113338c791 Merge branch 'master' into map5 2017-01-12 12:35:00 -08:00
Andy Hanson
b98e82e5c4 Fix one more use of createMapFromTemplate 2017-01-12 12:25:00 -08:00
Andy Hanson
733111a931 Use tsconfig inheritance 2017-01-12 07:46:55 -08:00
Andy Hanson
8c5afd7f54 Merge branch 'master' into map5 2017-01-06 13:03:34 -08:00
Joel Day
8b44ce2fd7 Emitting tsserverlibrary as an external module. 2016-12-31 17:37:51 -08:00
Andy Hanson
6b1cc8972d Use native maps when they're available 2016-12-08 06:40:31 -08:00
Vladimir Matveev
1418fd170d send begin/end notifications when installing types packages (#12551) 2016-11-29 10:14:22 -08:00
jramsay
855431a943 Merge pull request #12373 from Microsoft/RenameTypingOptions
Rename typingOptions.enableAutoDiscovery to typeAcquisition.enable
2016-11-22 17:22:30 -08:00
Vladimir Matveev
680fb2ea1b add typings installer user agent for npm requests (#12446)
* add typings installer user agent for npm requests

* address PR feedback: change name of user agent
2016-11-22 14:56:18 -08:00
Jason Ramsay
5a9451ae23 Rename typingOptions.enableAutoDiscovery to typeAcquisition.enable 2016-11-18 18:14:32 -08:00
Vladimir Matveev
4c2474463c ports #12237, #12258 and #12259 into master (#12274)
* treat failures to resolve module name as missing packages (#12237)

* added extra check to prevent multiple installation of the same typing, added version field to telemetry event (#12258)

* added extra check to prevent multiple installation of the same typing, added version field to telemetry event

* use ts.version

* switch to execSync to ensure that no install orders are interleaved (#12259)

* Make sure version is public

* Update file with version string for nightly release
2016-11-15 12:53:46 -08:00
Vladimir Matveev
f11e8a3c69 add 'installSuccess' flag to telemetry, cache misses if npm install fails (#12163)
* add 'installSuccess' flag to telemetry, cache misses if npm install fails

* fix typo
2016-11-14 14:10:22 -08:00
Mohamed Hegazy
d537b79c61 Merge release-2.1 into master (#12157)
* Update LKG

* Update version

* Update LKG

* Skip overloads with too-short function parameters

If the parameter of an overload is a function and the argument is also a
function, skip the overload if the parameter has fewer arguments than
the argument does. That overload cannot possibly apply, and should not
participate in, for example, contextual typing.

Example:

```ts
interface I {
  (a: number): void;
  (b: string, c): void;
}
declare function f(i: I): void;
f((x, y) => {});
```

This code now skips the first overload instead of considering.

This was a longstanding bug but was only uncovered now that more
functions expressions are context sensitive.

* Test skip overloads w/too-short function params

1. Update changed baseline.
2. Add a new test with baseline.

* Minor style improvements

* Ignore optionality when skipping overloads

* Do not use contextual signatures with too few parameters

* isAritySmaller runs later: getNonGenericSignature

* rewrite void-returning statements in constructors that capture result of super call (#11868)

* rewrite void-returning statements in constructors that capture result of super call

* linter

* Update LKG

* Fix emit inferred type which is a generic type-alias both fully and partially fill type parameters

* Add tests and baselines

* Skip trying to use alias if there is target type

* Update baselines

* Add diagnostics to remind adding tsconfig file for certain external project (#11932)

* Add diagnostics for certain external project

* Show tsconfig suggestion

* fix lint error

* Address pr

* fix comment

* Update error message

* Flag for not overwrite js files by default without generating errors (#11980)

* WIP

* Properly naming things

* refactor

* apply the option to all files and check out options

* Fix typo

* Update LKG

* lockLinter

* use local registry to check if typings package exist (#12014) (#12032)

use local registry to check if typings package exist

* Add test for https://github.com/Microsoft/TypeScript/pull/11980 (#12027)

* add test for the fix for overwrite emitting error

* cr feedback

* enable sending telemetry events to tsserver client (#12034) (#12051)

enable sending telemetry events

* Update LKG

* Reuse subtree transform flags for incrementally parsed nodes (#12088)

* Update LKG

* Update version

* Update LKG

* Do not emit "use strict" when targeting es6 or higher or module kind is es2015 and the file is external module

* Add tests and baselines

* [Release 2.1] fix11754 global augmentation (#12133)

* Exclude global augmentation from module resolution logic

* Address PR: check using string literal instead of NodeFlags.globalAugmentation

* Remove comment
2016-11-10 14:28:34 -08:00