20220 Commits

Author SHA1 Message Date
Sheetal Nandi
1e7a77cf78
Merge pull request #31503 from microsoft/casing
Ignore drive letters when comparing casings of the files with forceConsistentCasingInFileNames
2019-05-22 09:25:34 -07:00
Daniel Rosenwasser
3f5912995b Add related span to original declaration on disagreeing variable/property types. 2019-05-21 14:48:15 -07:00
Sheetal Nandi
38f689d19e
Merge pull request #31484 from microsoft/completionsSorting
Add sortText depending scope of symbols
2019-05-21 12:59:01 -07:00
Sheetal Nandi
43c7eb77e1 Switch to using File not found message instead of trace message file does not exit
Fixes #30872
2019-05-21 09:43:40 -07:00
Sheetal Nandi
db150517d7 Ignore drive letters when comparing casings of the files with forceConsistentCasingInFileNames
Fixes #31327
2019-05-21 09:32:17 -07:00
Anders Hejlsberg
374569447c
Merge pull request #31476 from microsoft/cacheUnnormalizedIntersections
Cache unnormalized intersection types
2019-05-21 06:42:51 -07:00
Wesley Wigham
07d850cf1c
Prevent type parameter printing from recuring on the same symbol (#31453) 2019-05-20 16:43:55 -07:00
Sheetal Nandi
00cea41b65 Add sortText depending scope of symbols
Fixes #15024
2019-05-20 15:53:51 -07:00
Anders Hejlsberg
2c34672fe3 Merge branch 'master' into cacheUnnormalizedIntersections 2019-05-20 07:04:33 -07:00
Anders Hejlsberg
907664c31c
Merge pull request #31454 from microsoft/fixThisTypeIndexSignature
Permit assignment through index signature of 'this' type
2019-05-20 07:02:52 -07:00
Anders Hejlsberg
309ae224f0 Cache unnormalized intersection types 2019-05-20 06:23:30 -07:00
Anders Hejlsberg
d67fe13e30 Don't ignore index signatures in this type constraints 2019-05-17 13:10:09 -07:00
Nathan Shively-Sanders
eeba30afc8
Fix infinite loop: module.exports alias detection (#31436)
* Fix infinite loop: module.exports alias detection

Previously, module.exports alias detection in the binder could enter an
infinite recursion. Now it does not.

Notably, there are *two* safeguards: a counter limiter that I set at
100, and an already-seen set. I actually prefer the counter limiter code
because it's foolproof and uses less memory. But it takes 100
iterations to escape from loops.

* fix space lint

* Remove already-seen map
2019-05-17 12:50:39 -07:00
Ron Buckton
f4b83ef8d3
Fix newlines in smartSelection baselines to not be platform dependent (#31437) 2019-05-16 20:39:47 -07:00
Andrew Branch
15daf42b2c
Merge pull request #31028 from andrewbranch/feature/smart-select
Smart Select language service API
2019-05-16 09:45:05 -07:00
Daniel Rosenwasser
d484163d0f
Merge pull request #31262 from rpgeeganage/new_keyword_consistent_resolve
Quick info on 'new' keyword should be the same as that of resolved expression
2019-05-15 00:36:38 -07:00
Anders Hejlsberg
922186834f
Merge pull request #31400 from microsoft/undoSubsitutionSimplification
Revert substitution type simplification
2019-05-14 22:58:14 -07:00
Wesley Wigham
3885e3fcda
Fix error message regressed by #30916 (#31276) 2019-05-14 16:58:06 -07:00
Anders Hejlsberg
4b5968eb6d Revert change to substitution type simplification 2019-05-14 07:45:29 -07:00
Anders Hejlsberg
fb6ae38ddf
Merge pull request #31354 from microsoft/deferConditionalTypes
Defer resolution of true and false branches in conditional types
2019-05-13 17:17:26 -07:00
Anders Hejlsberg
70950cb934
Merge pull request #31377 from microsoft/noThisParameterFiltering
Revert this-parameter filtering in completions
2019-05-13 17:07:05 -07:00
Anders Hejlsberg
d2923460e9 Add comment providing context on the change 2019-05-13 16:34:09 -07:00
Anders Hejlsberg
1b3589ba27 Remove simplification logic from getConditionalType + simplify substitution types 2019-05-13 16:23:51 -07:00
Wesley Wigham
f140dfc30b
Chain RHS narrowing and truthiness narrowing in assignment expression narrowing (#31348) 2019-05-13 14:41:33 -07:00
Anders Hejlsberg
90667e104d Remove this-parameter filtering in statement completion 2019-05-13 12:42:33 -07:00
Wesley Wigham
8ba53b6fd5
Simplify conditionals upon comparison, rather than instantiation 2019-05-13 11:18:28 -07:00
Wesley Wigham
b7fe99a88c
Instantiate constraint with default upon comparison (#31240) 2019-05-11 16:40:23 -07:00
Anders Hejlsberg
bb9c5c96c8 Reuse existing type instantiations 2019-05-11 11:15:37 -07:00
Anders Hejlsberg
71fe8e824e Defer resolution of the true and false branches of conditional types 2019-05-11 09:39:06 -07:00
Anders Hejlsberg
ae3d1d45c1
Merge pull request #31221 from microsoft/improveReverseMappedTypes
Improve reverse mapped types
2019-05-10 13:42:22 -07:00
Anders Hejlsberg
bca2808049
Merge pull request #31337 from microsoft/fixConditionalTypeParameterReference
Fix type parameter leakage in conditional types
2019-05-10 13:11:45 -07:00
Wesley Wigham
d8f2702a5d
Cache control flow results across invocations (#31003)
* Modify flow loop cache key to include all inputs

* Add test case, cache similarly to loop cache, reuse loop cache key (now corrected)

* Use simpler singleton key and type cache for FlowAssignment nodes
2019-05-10 11:48:44 -07:00
Daniel Rosenwasser
39e9a2bb4f
Maintain modifiers on Omit (#31205)
Maintain modifiers on `Omit`
2019-05-10 10:03:48 -07:00
Anders Hejlsberg
46a278d449 Consistently check conditional extends type for type parameter references 2019-05-10 09:48:33 -07:00
Anders Hejlsberg
4af3a3b541 Lower priority for inferences made from partial reverse mapped types 2019-05-08 14:11:51 -07:00
Klaus Meinhardt
0c9db717ad fix parsing of leading union/intersection operator (#31265)
* fix parsing of leading union/intersection operator

Fixes: #30995

* test declaration emit
2019-05-08 14:09:11 -07:00
Ron Buckton
15e9c4ce33
Merge pull request #31301 from microsoft/fixCustomTransformers
Add opt-in behavior for custom transforms to support bundles
2019-05-07 17:31:28 -07:00
Ron Buckton
0c1a283bf9 Add opt-in behavior for custom transforms to support bundles 2019-05-07 17:29:02 -07:00
Ron Buckton
b40b542654
Merge pull request #29676 from NicholasLYang/fixObjectRestEnumeration
Fix object rest enumeration
2019-05-07 15:55:33 -07:00
Andrew Branch
8c07b40cb6
Merge pull request #31098 from andrewbranch/bug/30804
Fix crash checking spread element in loop
2019-05-07 13:02:22 -07:00
Titian Cernicova-Dragomir
4b77f34243 Fixed several typos, mostly in comments and parameter names. (#31287) 2019-05-07 11:00:56 -07:00
Wenlu Wang
714821fc97 add refactor of extract type (#30562)
* add basically implement

* add rename location and add testcase

* collection type arguments

* disallow infer type

* add support for typedef convert

* refactor info to make type safe

* disallow type pred

* avoid unnecessary branch

* disallow type query

* haha😂

Co-Authored-By: Kingwl <kingwenlu@gmail.com>

* Update src/services/refactors/extractType.ts

Co-Authored-By: Kingwl <kingwenlu@gmail.com>

* Update src/services/refactors/extractType.ts

Co-Authored-By: Kingwl <kingwenlu@gmail.com>

* add more tests

* add template tag support in jsdoc

* add support of type parameters constraint

* add more tests

* merge branch

* add more tests

* refactor and update function name
2019-05-07 08:26:53 -07:00
Klaus Meinhardt
3c2f368908 add assert 2019-05-06 21:31:20 +02:00
rpgeeganage
8f209be149 fixed the comments 2019-05-06 21:21:37 +02:00
Klaus Meinhardt
676ed3ead7 parseProjectReferenceConfigFile: always set SourceFile.path 2019-05-06 17:17:24 +02:00
rpgeeganage
578013b65c modified the service file 2019-05-05 19:01:14 +02:00
Klaus Meinhardt
4ee0084fa1 avoid more useless type assertions (#31239) 2019-05-03 14:51:54 -07:00
Wesley Wigham
b365e657d4
Add unmeasurable variance kind for marking types whose variance result is unreliable (#30416)
* Add unmeasurable variance kind for marking types whose variance result is unreliable

* Remove now-unneeded nongeneric checks

* Add rule allowing `Readonly<any>` to be `any` instead of `{readonly [index: string]: any}`

* All Unmeasurable variances to still shortcut structural comparisons in some cases

* Separate unmeasurable from unreliable to reduce the impact of this change, for now

* Fix lint

* Remove Readonly<any> -> any callout

* Add fix for circularity error triggered by deep signature return type comparisons with `this` types
2019-05-03 14:42:17 -07:00
Daniel Rosenwasser
fc88a1c51a
Don't use any[] in arrayFrom (#31201)
Don't use `any[]` in `arrayFrom`
2019-05-03 13:04:46 -07:00
Anders Hejlsberg
8891d4f375 Permit reverse mapped types to be created from partially inferable types 2019-05-02 15:15:03 -07:00