6549 Commits

Author SHA1 Message Date
Ron Buckton
1745e170bd Merge branch 'master' into dynamicNames 2017-10-03 12:44:17 -07:00
Daniel Rosenwasser
301c90ccff Merge pull request #18300 from Microsoft/correctlyCacheTaggedTemplates
Correctly cache tagged template objects in modules
2017-10-03 12:06:57 -07:00
Ron Buckton
7ab451bfe7 Merge branch 'master' into dynamicNames 2017-10-03 11:00:30 -07:00
Nathan Shively-Sanders
4d8663c378 Merge pull request #18117 from Microsoft/jsdoc-dotdotdot-binds-tighter-than-postfix
Jsdoc ... binds tighter than postfix ?!
2017-10-03 08:45:26 -07:00
Ron Buckton
6f05e43b55 Merge branch 'master' into dynamicNames 2017-10-02 19:08:09 -07:00
Andy
3a2c723a69 Allow parsing a qualified type name containing a reserved word (#18888) 2017-10-02 17:04:28 -07:00
Anders Hejlsberg
884c72efb4 Merge pull request #18654 from Microsoft/strictFunctionTypes
Strict function types
2017-10-02 23:09:17 +01:00
Anders Hejlsberg
c2344e07a4 Add error elaboration test 2017-10-02 13:40:26 -07:00
Andy
eefe5c9706 Fix acquiring format options for getEditsForRefactor (#18848)
* Fix acquiring format options for getEditsForRefactor

* Add test

* Fix test description

* Use `executeCommandSeq`
2017-10-02 13:26:35 -07:00
Anders Hejlsberg
bf75a3f4ac Emit .d.ts file in test 2017-10-02 12:54:04 -07:00
Ron Buckton
fb3168d46f Merge branch 'master' into dynamicNames 2017-10-02 11:40:28 -07:00
Andy
637ed57451 Fix crash when extending non-EntityNameExpression (#18853) 2017-10-02 10:39:03 -07:00
Andy
e6980722a6 Fix bug: Report errors on extends expression in JS even if an @augments tag is present (#18854) 2017-10-02 10:33:53 -07:00
Daniel Rosenwasser
f94bdedc79 Added test for module & global examples. 2017-09-29 23:01:33 -07:00
Daniel Rosenwasser
5da45fb6de Addressed code review feedback. 2017-09-29 17:16:50 -07:00
Anders Hejlsberg
0756aa1753 Merge branch 'master' into strictFunctionTypes 2017-09-28 15:39:57 -07:00
Andy
7959bd0a3d Check JSDoc @param tag names (#18777) 2017-09-28 13:44:38 -07:00
Andy
4bba6ee02e Support accessing enum types from JSDoc (#18703) 2017-09-28 13:43:39 -07:00
Armando Aguirre
a39110add9 Merge pull request #18806 from armanio123/FixScriptBlockFormatting
Fixed formatting on script blocks
2017-09-28 12:35:32 -07:00
Andy
1a2de721b5 Fixes to @augments handling (#18775)
* Fixes to @augments handling

* Renames and diagnostic changes

* Add test for < > characters

* Use more specific return type
2017-09-28 12:34:54 -07:00
Daniel Rosenwasser
b406d5453e git Merge branch 'master' into correctlyCacheTaggedTemplates 2017-09-27 17:32:38 -07:00
Daniel Rosenwasser
886a29b512 Added tests for import helpers with & without a declared template object creator. 2017-09-27 17:07:42 -07:00
Armando Aguirre
8683ac92c8 Fixed formatting on script blocks, added regrestion tests, fixed minor bugs 2017-09-27 15:18:25 -07:00
Andrew Casey
3eea1a9e9a Generalize extract method to handle constants as well
Major changes:

1) Instead of skipping undesirable scopes, include them and mark them
with errors.  Constants can be extracted into more scopes.

2) Update the tests to call through the "public" API.  This caused some
baseline changes.

3) Rename refactoring to "Extract Symbol" for generality.

4) Return a second ApplicableRefactorInfo for constants.  Distinguish
the two by splitting the action name.
2017-09-26 17:29:34 -07:00
Andy
ecef2dc970 Improve testing of code fixes, and improve diagnostic messages (#18742)
* Improve testing of code fixes, and improve diagnostic messages

* Disambiguate `newFileContent` from `newRangeContent`
2017-09-26 15:16:29 -07:00
Anders Hejlsberg
6a481e8ddc Update tests 2017-09-25 16:59:39 -07:00
Wesley Wigham
8f9724811d Add fix for crash in #18712 (#18751) 2017-09-25 13:07:44 -07:00
Andy
b4018a2ef1 Handle @typedef tag with missing type (#18662)
* Handle @typedef tag with missing type

* Add single quotes to diagnostic

* Remove redundant jsdoc checking (now done on every source element)

* Update baselines
2017-09-25 12:11:33 -07:00
Andy
17f10c032e Fix crash when @augments tag has no type (#18739) 2017-09-25 09:58:46 -07:00
Mohamed Hegazy
4221fb6a39 Check for initializer before using it (#18708) 2017-09-22 17:14:22 -07:00
Ron Buckton
891e71d44f Remove freshness, more comprehensive grammar checks and diagnostic messages 2017-09-22 15:08:55 -07:00
Ron Buckton
e81c83cdc7 Merge branch 'master' into dynamicNames 2017-09-22 14:45:22 -07:00
Andy
72c8b804da Use JSDoc @type tag type cast as a contextual type (#18690)
* Use JSDoc `@type` tag type cast as a contextual type

* Suggested changes
2017-09-22 10:42:02 -07:00
Anders Hejlsberg
70e8f7364e Add tests 2017-09-21 21:40:31 -07:00
Ron Buckton
d7ef99523d Merge branch 'master' into dynamicNames 2017-09-21 12:48:51 -07:00
Nathan Shively-Sanders
36cdbb2857 Merge pull request #18625 from Microsoft/fix-getAdjustedStartPosition-on-first-line
Fix get adjusted start position on first line
2017-09-21 10:08:30 -07:00
Nathan Shively-Sanders
3cc0aeb6be PR comments
I plan to fix the missing comment issue when I add the
convert-jsdoc-types-to-typescript-types refactoring. Or at least work
around it.
2017-09-21 09:44:51 -07:00
Daniel Rosenwasser
6a34dc953a Added test and accepted baselines. 2017-09-21 02:07:33 -07:00
Ron Buckton
d9951cbb8e Merge pull request #17919 from henrymercer/fix-empty-object-property-access
Fix property access on an object literal
2017-09-20 19:06:04 -07:00
Andrew Casey
f00c78c9b5 Merge pull request #18622 from amcasey/NoModifiers
JavaScript: handle lack of modifiers on extracted method
2017-09-20 17:10:42 -07:00
Nathan Shively-Sanders
410f84656d Update baselines temporarily
The loss of comments is not good, but should be fixed when
(1) trivia-handling issues are fixed or (2) the reafactorings themselves
add a workaround.
2017-09-20 16:31:28 -07:00
Andrew Casey
a1dee452fa JavaScript: handle lack of modifiers on extracted method
The emitter expects undefined, rather than empty.  This only affects JS,
because TS applies `private` to all extracted methods.

(cherry picked from commit 9630c46ea7174f78d9a2661cbcc204bdce1a7781)
2017-09-20 16:25:15 -07:00
Andy
4d2aa9bf2c Fix formatting when keyword is parsed as part of a JSX identifier (e.g. module-layout) (#18598) 2017-09-20 15:01:04 -07:00
Andy
d5e7227dbb Look at correct 'package.json' location for a scoped package (#18580)
* Look at correct 'package.json' location for a scoped package

* Update baseline
2017-09-20 08:15:24 -07:00
Magnus Kulke
b549e26665 Consider underscore for type parameters in unused-local checks (#18539)
* Consider underscore for type parameters in unused-local errors.

* Addressed review comments.
2017-09-19 16:57:26 -07:00
Henry Mercer
a8810925ac Merge branch 'master' into fix-empty-object-property-access 2017-09-20 00:29:18 +01:00
Andy
12649516cf navigation tree / bar: Set span of anonymous function to span of VariableDeclaration containing it (#18575)
* navigation tree / bar: Set span of anonymous function to span of VariableDeclaration containing it

* Add back `isFunctionOrClassExpression`
2017-09-19 14:39:29 -07:00
Henry Mercer
76ef97449c Expand test to ensure property access on object literal has correct behaviour 2017-09-19 22:18:15 +01:00
Andy
0ae42ea3de Allow relative imports of '.js' files when --noImplicitAny is disabled (#18489)
* Allow relative imports of '.js' files when `--noImplicitAny` is disabled

* Update baselines, and don't ignore a diagnostic about missing JSX
2017-09-19 12:42:29 -07:00
Nathan Shively-Sanders
339a7e5f63 Merge branch 'master' into make-jsdoc-getters-public 2017-09-19 11:20:06 -07:00