9279 Commits

Author SHA1 Message Date
Andrew Branch
16bbb4d002
Merge pull request #32077 from andrewbranch/bug/31114
Fix incorrect noImplicitAny error on contextual union function signature
2019-07-03 10:10:10 -07:00
Anders Hejlsberg
340f81035f
Merge pull request #32178 from microsoft/improveTupleDestructuring
Simplify tuple destructuring logic
2019-07-02 17:25:12 -07:00
Anders Hejlsberg
440ed83f29
Merge pull request #32079 from microsoft/instantiationCountLimiter
Add type instantiation count limiter
2019-07-02 17:19:39 -07:00
Anders Hejlsberg
8e75382ce3 Add regression test 2019-07-01 17:49:36 -10:00
Wesley Wigham
3765651d82
Fix not emitted statement in then clauses producing syntactically invalid output (#32010)
* Fix not emitted statement in then clauses producing syntactically invalid output

* Refactor to common code, apply to all embedded statements
2019-07-01 13:39:18 -07:00
Andrew Branch
11a62cb0ab
Merge pull request #31801 from andrewbranch/semicolons
Detect semicolons before writing from TextChanges
2019-07-01 13:23:31 -07:00
Andrew Branch
327bc3cb67
Merge pull request #32071 from andrewbranch/bug/31070
Allow assignability of non-empty object to generic mapped type
2019-07-01 13:18:44 -07:00
Andrew Branch
a890275463
Merge pull request #31912 from andrewbranch/bug/31657
Fix smartSelection returning extra span inside string quotes when cursor is outside them
2019-07-01 11:53:24 -07:00
Andrew Branch
23f1d5ccb7
Merge pull request #32117 from andrewbranch/bug/31460
Fix declaration emit for negative number properties, allow negative numbers as computed type property names
2019-07-01 10:56:56 -07:00
Nathan Shively-Sanders
b46c44d70d
Merge pull request #32181 from microsoft/use-only-immediately-preceding-jsdoc
Use only immediately preceding JSDoc
2019-07-01 10:12:05 -07:00
Anders Hejlsberg
f89165d072
Merge pull request #32049 from microsoft/noDuplicateIntersectionSignatures
Remove duplicate signatures in intersections
2019-06-30 19:38:37 -07:00
Anders Hejlsberg
5ad3d1bf08 Add more tests 2019-06-30 08:18:01 -10:00
Nathan Shively-Sanders
fefb857847 Use only immediately preceding JSDoc
Now only the immediately preceding jsdoc of a node is retrieved by
getJSDoc, although it still does the correct non-local lookup for nodes
like ParameterDeclaration.

This doesn't change parsing or binding, which use the per-node Node.jsdoc
property directly. But it does change everything that relies on getJSDoc,
which includes the checker and language service.

Fixes #32062, which contains the analysis that justifies the change.
2019-06-29 08:05:10 -07:00
Anders Hejlsberg
b7b7a6626c Add regression tests 2019-06-28 17:09:22 -10:00
Daniel Rosenwasser
410b71751e
Merge pull request #32034 from dragomirtitian/GH-32013-improve-error-messages-for-calling-types
Improved error message for calling/constructing types
2019-06-28 16:08:18 -07:00
Titian Cernicova-Dragomir
e4bca9649a Improved error spans for call errors:
1. When calling a non-callable expression the error span is on the call target not on the whole call
2. When calling a method, the error for overload resolution now includes the arguments (this was previously regressed by #31414)
2019-06-28 23:53:47 +03:00
Titian Cernicova-Dragomir
bc07eec015 Added tests for new error messages on calls to unions. 2019-06-28 23:23:17 +03:00
Titian Cernicova-Dragomir
768318b30c Improved error message for calling/constructing types 2019-06-28 23:23:16 +03:00
Wesley Wigham
b4a1a5996f
Rework declaration emit visibility calculation for namespaces (#32156)
* Rework declaration visibility for namespaces

* Accept skipped baselines
2019-06-28 13:23:15 -07:00
Wesley Wigham
6760a03cec
Add vscode docker test (#32152)
* Add vscode docker test

* Remove PID-log line

* Update user baselines (#18)
2019-06-28 13:22:25 -07:00
Anders Hejlsberg
5c6c1a3efe Add regression test 2019-06-27 16:48:00 -10:00
Wesley Wigham
2af8ac73ff
Add xterm test to docker suite (#32149) 2019-06-27 15:29:22 -07:00
Nathan Shively-Sanders
2362dd4fac Add fourslash test of jsdoc backtick parsing 2019-06-27 08:49:56 -07:00
Nathan Shively-Sanders
8454ef114d JSDoc:Treat tokens between backticks as comments
even `@`, which would otherwise start a new tag.
2019-06-26 16:04:46 -07:00
Klaus Meinhardt
392d775095 allow const-assertion on aliased enum symbol (#32110)
Fixes: #32087
2019-06-26 14:42:06 -07:00
Orta
a50a5d309c
Merge pull request #32088 from orta/fix-32068
Handle making sure that two less thans are never converted into >>
2019-06-26 14:10:02 -07:00
Andrew Branch
5ff3cda078
Add some negative test cases and accept baselines 2019-06-26 14:01:50 -07:00
Andrew Branch
17f6f77de5
Fix declaration emit for negative number property declarations 2019-06-26 11:49:45 -07:00
Andrew Branch
871bdeeec4
Merge pull request #31480 from andrewbranch/bug/25487
Fix invalid JSXExpressions having identifier-ish things in their trivia, improve error messages for comma expressions in JSX
2019-06-26 10:13:42 -07:00
Wesley Wigham
34eb5ddf75
Fix tuple and array comparisons during identity checking (#32089) 2019-06-25 20:56:41 -07:00
Orta Therox
897fb3a2a6 Handle making sure that two less thans are never converted into >> 2019-06-25 15:16:15 -07:00
Andrew Branch
252840ad40
Fix incorrect noImplicitAny error on contextual union function signature 2019-06-24 17:37:14 -07:00
Wesley Wigham
a150d55592
Explicitly error when an exclude is provided by a test as it will be unused (#32014) 2019-06-24 15:29:02 -07:00
Andrew Branch
7bbd299226
Look at properties of constraint-instantiated optional mapped types when deciding assignability 2019-06-24 15:19:43 -07:00
Andrew Branch
6717d8d928
Merge pull request #31942 from andrewbranch/bug/30882
Improve error message on indexed access to private members of type parameters
2019-06-24 09:22:21 -07:00
Anders Hejlsberg
076d9ad2ab Add regression test 2019-06-23 09:19:56 -10:00
Anders Hejlsberg
9223f39f53 Add regression test 2019-06-21 18:07:15 -10:00
Daniel Rosenwasser
2c458c0d1c
Merge pull request #31414 from dhruvrajvanshi/master
Report error on method name for chained method calls
2019-06-21 17:51:04 -07:00
Wesley Wigham
a97c18f227
Ignore identifier declarations when calculating symbol visibility (#31974) 2019-06-20 17:20:12 -07:00
Wesley Wigham
f2735b5a06
Fake up a namespace enclosing declaration when generating expando namespace members (#31971)
* Fake up a namespace enclosing declaration when generating expando namespace members

* Fix #31676
2019-06-20 12:58:16 -07:00
Wesley Wigham
c39a877a92
Add dockerfile based tests for azure-sdk-for-js and office-ui-fabric-react (#31948)
* Add dockerfile based tests

* Update tests/cases/docker/README.md

Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

* Combine sanitize functions

* Add some debugging instructions to README

* Fix listed command order
2019-06-20 12:47:57 -07:00
Anders Hejlsberg
6def72b3a4
Merge pull request #31950 from microsoft/unionObjectAndArrayLiterals
Union inferences from object and array literals
2019-06-20 09:36:20 -07:00
Sheetal Nandi
7ed3896a0a
Merge pull request #31587 from microsoft/definitionSpan
Include declarationSpan as relevant declaration span when defintion or other places are declaration name
2019-06-18 14:07:15 -07:00
Anders Hejlsberg
51712fb1ae Add tests 2019-06-17 16:18:13 -10:00
Josh Goldberg
ca00b3248b Added --noImplicitThis code fix for functions used as object properties (#31138)
* Added --noImplicitThis code fix for functions used as object properties

Before trying out all the various possibilities for where these functions could be used, I figured I'd start out with a relatively simple use case to verify this is the right approach. Is it? 😄

Starts on #28964.

* Fixed function expression names; included new baselines

* Got JSDocs to work, hooray!

* Added test for 'any' case of no function uses

* Refactored for inferFunctionReferencesFromUsage

* Fixed inference bug: undefined references cause parameters to default

* Removed dead code comments
2019-06-17 19:00:15 -07:00
Andrew Branch
04fbd93bf8
Revert previous fix and improve error message instead 2019-06-17 15:21:21 -07:00
Ron Buckton
179381301e
Move class property transform (#31848)
* Revert "Revert "Move class property transformation into new transformer. (#30467)""

This reverts commit 53467ae4a4edb37c259b0b4e61972a90cd6c5587.

* Fix emit issues
2019-06-17 14:26:42 -07:00
Andrew Branch
1ad3285701
Add test cases for union and intersection constraints 2019-06-17 09:45:09 -07:00
Andrew Branch
48f74fdf80
Consider non-public literal members in index type of constrained type parameters 2019-06-14 17:29:39 -07:00
Andrew Branch
b6c415485a
Add failing test for smartSelect string literals 2019-06-14 15:42:29 -07:00