2963 Commits

Author SHA1 Message Date
Wesley Wigham
08022d57c8
Allow calls on unions of dissimilar signatures (#29011)
* Add core of new union signature logic and test - needs intersection signature logic to fully work

* Add inversion of variance for class props lookup from union sig returns

* Fix lints

* Combine parameter names for nicer quick info

* PR feedback 1

* Fix miscopy

* PR feedback round 2

* Remove argument name combining because loc :(

* Nit cleanup round 3

* Reinline getTupleTypeForArgumentAtPos

* Remove a tad more

* No step on sneky off-by-one error
2018-12-19 16:35:01 -08:00
Daniel Rosenwasser
ab2a38ebef
Merge pull request #29102 from Microsoft/declarationEmitForDefaultExportClassExtendingExpression
Declaration emit for default exported class extending expression
2018-12-19 16:19:36 -08:00
Daniel Rosenwasser
54352dc1c9 Added test case. 2018-12-19 15:51:31 -08:00
Wesley Wigham
d23effc200
Non-latebound computed property names should print as their underlying name type (#29084) 2018-12-18 17:02:34 -08:00
Wesley Wigham
4e3bc9e35a
Reset constEnumOnlyModule flag on relevant symbol merges in binder (#29079) 2018-12-18 12:31:53 -08:00
Anders Hejlsberg
c52e5985b7
Merge pull request #29068 from Microsoft/noGenericEmptyObject
Generic types should never be considered empty objects
2018-12-17 15:59:42 -08:00
Wesley Wigham
d2885eab4a
Add regression test for #29047 (#29066) 2018-12-17 14:56:48 -08:00
Anders Hejlsberg
ab797df977 Add regression test 2018-12-17 14:14:54 -08:00
Daniel Rosenwasser
4d74f67325
Merge pull request #28888 from Microsoft/numericPropertyAccess
Avoid adding a dot when comment a property acccess's expression has trailing comments
2018-12-13 15:18:27 -08:00
Wesley Wigham
5788446aa1
Use contextual parameter types over binding pattern initializer types (#28967)
* Use contextual parameter types over binding pattern initializer types

* Remove unneeded check
2018-12-12 15:39:32 -08:00
Daniel Rosenwasser
2999a1eb47 Merge remote-tracking branch 'origin/master' into numericPropertyAccess 2018-12-11 16:52:23 -08:00
Philip Pesca
e6aa992095 Fix error message when type argument arity is wrong (#28366)
* Fix error message when type argument arity is wrong

* Parenthesize 's' in plurals

* Update baseline

* Update baseline

* Use old error message

* Revert parantheses
2018-12-11 09:54:38 -08:00
Daniel Rosenwasser
2e9be8c05b Added more tests, including some in 'removeComments' mode. 2018-12-10 22:21:15 -08:00
Daniel Rosenwasser
bc59582c7d
Merge pull request #28627 from ajafff/arrow-arguments
ArrowFunction has no own 'arguments'
2018-12-10 11:42:43 -08:00
Daniel Rosenwasser
8150169762
Merge pull request #28857 from JoshuaKGoldberg/identifiers-after-numeric-literals
Added error for IdentifierStart immediately after a NumericLiteral
2018-12-06 11:49:56 -08:00
Josh Goldberg
a211184347 Clarified error message; extended error to identifier end
Lengthening the reported error length to include all of the identifier necessitates scanning for all of the identifier. I also reset the `pos` after so other identifier scanning still happens.
2018-12-06 11:17:06 -08:00
Daniel Rosenwasser
3fe72631ce Added test case for trivia preceding dot in numeric LHS in property accesses. 2018-12-05 15:02:00 -08:00
Anders Hejlsberg
07dbc56208
Merge pull request #28854 from Microsoft/fixExcessPropertyChecks
Improve excess property checks
2018-12-05 08:51:08 -08:00
Josh Goldberg
174816fc26 Added error for IdentifierStart immediately after a NumericLiteral
Fixes #4702.
2018-12-04 17:59:20 -08:00
Anders Hejlsberg
e7bb5625c0 Add additional tests 2018-12-04 14:51:59 -08:00
Wesley Wigham
2103ed69e6
Merge pull request #28782 from weswigham/global-merge-no-crash
Fix crash on umd and module merge, allow umds to be accessed when merged with a non-UMD symbol
2018-12-03 09:43:04 -08:00
Wesley Wigham
03a98a2840
Merge pull request #28783 from weswigham/fix-typeparam-parent
Add missing case to declaration diagnostic handler
2018-12-03 09:15:38 -08:00
Anders Hejlsberg
28f8fdaccd
Merge pull request #28784 from Microsoft/controlFlowDestructuringLoop
Fix control flow analysis of destructuring in loops
2018-12-01 07:01:43 -08:00
Wesley Wigham
cd6fdb11d6 Add constructor case 2018-11-30 17:44:25 -08:00
Anders Hejlsberg
290eff9722 Add regression test 2018-11-30 16:28:21 -08:00
Wesley Wigham
fa8df0d32c Add missing case to declaration diagnostic handler 2018-11-30 16:25:07 -08:00
Wesley Wigham
d92771d61a Fix crash on umd and module merge, allow umds to be accessed when merged with a non-UMD symbol 2018-11-30 15:55:20 -08:00
Daniel Rosenwasser
b44ee8ef4b Added tests for types with overlap across a single property name. 2018-11-30 14:59:43 -08:00
Wesley Wigham
54bbf74f62
Do not lookup name of default property symbols from the symbols value declaration (#28711) 2018-11-28 13:58:43 -08:00
Nathan Shively-Sanders
f915420c80 Revert "Don't consider 'typeof a' as using 'a' (#28528)"
This reverts commit 0c4ceeec24f16f87e75386355c86ac38612a1175.
2018-11-26 14:45:19 -08:00
Daniel Rosenwasser
6627d33540
Merge pull request #27087 from Microsoft/overlappyTypes
Elaborate on types in unions with the most overlap in properties
2018-11-26 14:58:15 -05:00
Klaus Meinhardt
635780db07 ArrowFunction has no own 'arguments'
Fixes: #28621
2018-11-20 23:07:01 +01:00
Klaus Meinhardt
94d7e30393 MethodSignature doesn't have 'arguments' (#28625)
Fixes: #28622
2018-11-20 13:01:34 -08:00
Wesley Wigham
96937fd592
Allow union signatures to merge when they have differing argument counts (#28604)
* Allow union signatures to merge when they have differing argument counts

* Accept updated baselines

* Adjust comments io changed tests
2018-11-19 17:05:28 -08:00
Andy
79b9fa51b6 Avoid infinite loop checking yield expression (#21728)
* Avoid infinite loop checking yield expression

* Revert now-unneeded change

* Revert test filename changes
2018-11-19 11:18:32 -08:00
Andy
ca7f78b8df Fix typo (#28526) 2018-11-19 10:54:54 -08:00
Andy
b8a8ceae86 Handle merging unknownSymbol (#28453)
* Handle merging unknownSymbol

* mergeSymbol of unknown target returns source, not unknown
2018-11-19 10:51:58 -08:00
Wesley Wigham
608a8307ac
Dont emit module resolution errors when looking up specifiers for container symbols (#28558) 2018-11-16 17:15:40 -08:00
Daniel Rosenwasser
6ae288fbb3 Merge remote-tracking branch 'origin/master' into overlappyTypes 2018-11-16 15:02:13 -08:00
Andy
0c4ceeec24
Don't consider 'typeof a' as using 'a' (#28528)
* Don't consider 'typeof a' as using 'a'

* Also handle markPropertyAsReferenced

* Use isInTypeQuery
2018-11-16 08:35:36 -08:00
Wesley Wigham
b90d2910fb
Strongly typecheck unions of intrinsic tag names (#28557) 2018-11-15 13:46:32 -08:00
Nathan Shively-Sanders
6cee7c3080
Better nameless parameter implicit any error (#28554)
* Initial version, doesn't work for primitives yet.

Need to find out why.

* Primitives now work, plus improve error message

null and void don't even parse without parameter names so they are not
tested.

* Codefix: Add names to nameless parameters

* Improve error wording

* Add detail to error message
2018-11-15 12:45:39 -08:00
Aziz Khambati
24759b81e6 Fix comments after sread expression, spread assignment (#28482) 2018-11-14 14:20:07 -08:00
Wesley Wigham
7a71887c23
Build better import paths for declaration emit/typeToString from reexports if possible (#27340)
* Build better import paths from reexports if possible, issue error on node_modules import generation

* Small refactorings

* Add file-by-file cacheing

* Minor cleanups

* Adjust error message
2018-11-13 14:07:54 -08:00
Daniel Rosenwasser
25462beeb7
Merge pull request #28456 from Microsoft/nonExperimentalBigInt
BigInt shouldn't be considered experimental
2018-11-12 15:59:15 -08:00
Daniel Rosenwasser
9e92597ae7 More general test case name. 2018-11-12 14:52:44 -08:00
Daniel Rosenwasser
e4bb1973ed Fixed up flags on test cases and stray newline. 2018-11-12 14:52:44 -08:00
Daniel Rosenwasser
830be0651c
Merge pull request #27669 from Microsoft/betterErrorForAccidentalCall
Always emit diagnostic when a call expression can be fixed by adding a semicolon
2018-11-12 14:50:23 -08:00
Wesley Wigham
13234b62f5
Force inner indexed access simplification during inference, if possible (#28420)
* Force inner indexed access simplification during inference, if possible

* rename

* Refactor to used shared implementation of distribution
2018-11-12 14:39:43 -08:00
Wesley Wigham
eb21eb8e11
Ensure all default type params are mapped to some default even in circular scenarios (#28423)
* Ensure all default type params are mapped to some default even in circular scenarios

* Add js example, fix typo
2018-11-12 13:52:47 -08:00